EventGrid - Add api-version 2020-10-01-preview #11531
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swagger Validation Report
|
| Rule | Message |
|---|---|
|
"role":"Model Validation", "url":"https://github.com/Azure/azure-rest-api-specs/blob/ccc109b064f6f899b32d80d2cd0af092e462c533/specification/eventgrid/resource-manager/Microsoft.EventGrid/preview/2020-10-01-preview/EventGrid.json" |
️❌~[Staging] SemanticValidation: 1 Errors, 0 Warnings failed [Detail] [Expand]
| Rule | Message |
|---|---|
|
unexpected end of file, token: }, line: 1, column: 1 |
️️✔️~[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]
| Rule | Message |
|---|---|
|
"new":"https://github.com/Azure/azure-rest-api-specs/blob/ccc109b064f6f899b32d80d2cd0af092e462c533/specification/eventgrid/resource-manager/Microsoft.EventGrid/preview/2020-10-01-preview/EventGrid.json", "old":"https://github.com/Azure/azure-rest-api-specs/blob/master/specification/eventgrid/resource-manager/Microsoft.EventGrid/preview/2020-04-01-preview/EventGrid.json", "details":"Error: Command failed: node /home/vsts/work/1/s/azure-rest-api-specs/node_modules/autorest/dist/app.js --input-file=specification/eventgrid/resource-manager/Microsoft.EventGrid/preview/2020-10-01-preview/EventGrid.json --output-artifact=swagger-document.json --output-artifact=swagger-document.map --output-file=new --output-folder=/tmp\nERROR: Syntax error: unexpected end of the stream within a flow collection\n - file:///home/vsts/work/1/s/azure-rest-api-specs/specification/eventgrid/resource-manager/Microsoft.EventGrid/preview/2020-10-01-preview/examples/KubernetesBrokers_Update.json:64:0\nFATAL: swagger-document/loader - FAILED\nFATAL: Error: Syntax errors encountered.\n Error: Syntax errors encountered. |
at ChildProcess.exithandler (child_process.js:308:12)\n at ChildProcess.emit (events.js:314:20)\n at maybeClose (internal/child_process.js:1021:16)\n at Process.ChildProcess._handle.onexit (internal/child_process.js:286:5)"|
️️✔️~[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]
| Rule | Message |
|---|---|
|
"new":"https://github.com/Azure/azure-rest-api-specs/blob/ccc109b064f6f899b32d80d2cd0af092e462c533/specification/eventgrid/resource-manager/Microsoft.EventGrid/preview/2020-10-01-preview/EventGrid.json", "old":"https://github.com/Azure/azure-rest-api-specs/blob/master/specification/eventgrid/resource-manager/Microsoft.EventGrid/stable/2020-06-01/EventGrid.json", "details":"Error: Command failed: node /home/vsts/work/1/s/azure-rest-api-specs/node_modules/autorest/dist/app.js --input-file=specification/eventgrid/resource-manager/Microsoft.EventGrid/preview/2020-10-01-preview/EventGrid.json --output-artifact=swagger-document.json --output-artifact=swagger-document.map --output-file=new --output-folder=/tmp\nERROR: Syntax error: unexpected end of the stream within a flow collection\n - file:///home/vsts/work/1/s/azure-rest-api-specs/specification/eventgrid/resource-manager/Microsoft.EventGrid/preview/2020-10-01-preview/examples/KubernetesBrokers_Update.json:64:0\nFATAL: swagger-document/loader - FAILED\nFATAL: Error: Syntax errors encountered.\n Error: Syntax errors encountered. |
at ChildProcess.exithandler (child_process.js:308:12)\n at ChildProcess.emit (events.js:314:20)\n at maybeClose (internal/child_process.js:1021:16)\n at Process.ChildProcess._handle.onexit (internal/child_process.js:286:5)"|
Swagger Generation Artifacts
|
| Rule | Message |
|---|---|
|
"logUrl":"https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=172313&view=logs&j=fd490c07-0b22-5182-fac9-6d67fe1e939b", "detail":"ERROR: Syntax error: unexpected end of the stream within a flow collection" |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Azure CLI Extension Generation
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-java
|
azure-sdk-for-go
|
azure-sdk-for-js
|
azure-sdk-for-net
|
Trenton Generation
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
|
Please go through the contribution checklist added as part of the review and mark them completed. Also Please go through the ARM API Review Checklist. These steps are required before review can be continued. |
|
While adding new version the recommendation is to copy the existing version into new directory structure for first commit and then push new changes for easy review. Please create new branch with this recommendation for faster review. |
This was referenced Nov 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Please follow the link to find more details on PR review process.