[Hub Generated] Review request for Microsoft.Web to add version stable/2020-10-01 #11636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swagger Validation Report
|
| Rule | Message |
|---|---|
| Since operation 'Provider_GetFunctionAppStacks' response has model definition 'x-ms-pageable', it should be of the form '_list'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Web/stable/2020-10-01/Provider.json#L68 |
|
| Since operation 'Provider_GetFunctionAppStacksForLocation' response has model definition 'x-ms-pageable', it should be of the form '_list'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Web/stable/2020-10-01/Provider.json#L115 |
|
| Since operation 'Provider_GetWebAppStacksForLocation' response has model definition 'x-ms-pageable', it should be of the form '_list'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Web/stable/2020-10-01/Provider.json#L168 |
|
| Since operation 'Provider_GetWebAppStacks' response has model definition 'x-ms-pageable', it should be of the form '_list'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Web/stable/2020-10-01/Provider.json#L258 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isSupported Location: Microsoft.Web/stable/2020-10-01/Provider.json#L350 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isDefaultOff Location: Microsoft.Web/stable/2020-10-01/Provider.json#L355 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: remoteDebuggingSupported Location: Microsoft.Web/stable/2020-10-01/Provider.json#L485 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isPreview Location: Microsoft.Web/stable/2020-10-01/Provider.json#L521 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isDeprecated Location: Microsoft.Web/stable/2020-10-01/Provider.json#L526 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isHidden Location: Microsoft.Web/stable/2020-10-01/Provider.json#L531 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]
There are no breaking changes.
- Compared Swaggers (Based on Oad v0.8.6)
- original: stable/2020-09-01/AppServiceCertificateOrders.json <---> new: stable/2020-10-01/AppServiceCertificateOrders.json
- original: stable/2020-09-01/CertificateRegistrationProvider.json <---> new: stable/2020-10-01/CertificateRegistrationProvider.json
- original: stable/2020-09-01/DomainRegistrationProvider.json <---> new: stable/2020-10-01/DomainRegistrationProvider.json
- original: stable/2020-09-01/Domains.json <---> new: stable/2020-10-01/Domains.json
- original: stable/2020-09-01/TopLevelDomains.json <---> new: stable/2020-10-01/TopLevelDomains.json
- original: stable/2020-09-01/AppServiceEnvironments.json <---> new: stable/2020-10-01/AppServiceEnvironments.json
- original: stable/2020-09-01/AppServicePlans.json <---> new: stable/2020-10-01/AppServicePlans.json
- original: stable/2020-09-01/Certificates.json <---> new: stable/2020-10-01/Certificates.json
- original: stable/2020-09-01/CommonDefinitions.json <---> new: stable/2020-10-01/CommonDefinitions.json
- original: stable/2020-09-01/DeletedWebApps.json <---> new: stable/2020-10-01/DeletedWebApps.json
- original: stable/2020-09-01/Diagnostics.json <---> new: stable/2020-10-01/Diagnostics.json
- original: stable/2020-09-01/Provider.json <---> new: stable/2020-10-01/Provider.json
- original: stable/2020-09-01/Recommendations.json <---> new: stable/2020-10-01/Recommendations.json
- original: stable/2020-09-01/ResourceHealthMetadata.json <---> new: stable/2020-10-01/ResourceHealthMetadata.json
- original: stable/2020-09-01/ResourceProvider.json <---> new: stable/2020-10-01/ResourceProvider.json
- original: stable/2020-09-01/StaticSites.json <---> new: stable/2020-10-01/StaticSites.json
- original: stable/2020-09-01/WebApps.json <---> new: stable/2020-10-01/WebApps.json
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️[Staging] SDK Track2 Validation: 134 Warnings warning [Detail]
Only 10 items are listed, please refer to log for more details.
- The following tags are being changed in this PR
| Rule | Message |
|---|---|
| "readme":"web/resource-manager/readme.md", "tag":"package-2020-10", "details":"The schema 'AppServiceCertificateOrder-properties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"web/resource-manager/readme.md", "tag":"package-2020-10", "details":"The schema 'AppServiceCertificateOrderPatchResource-properties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"web/resource-manager/readme.md", "tag":"package-2020-10", "details":"The schema 'CertificateEmail-properties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"web/resource-manager/readme.md", "tag":"package-2020-10", "details":"The schema 'CertificateOrderAction-properties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"web/resource-manager/readme.md", "tag":"package-2020-10", "details":"The schema 'ReissueCertificateOrderRequest-properties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"web/resource-manager/readme.md", "tag":"package-2020-10", "details":"The schema 'RenewCertificateOrderRequest-properties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"web/resource-manager/readme.md", "tag":"package-2020-10", "details":"The schema 'Domain-properties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"web/resource-manager/readme.md", "tag":"package-2020-10", "details":"The schema 'DomainOwnershipIdentifier-properties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"web/resource-manager/readme.md", "tag":"package-2020-10", "details":"The schema 'DomainPatchResource-properties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"web/resource-manager/readme.md", "tag":"package-2020-10", "details":"The schema 'TopLevelDomain-properties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
Swagger Generation Artifacts
|
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Hi, @andimarc your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board([email protected]). cc @${PRAssignee} |
openapi-workflow-bot
bot
added
the
WaitForARMFeedback
|
Hi, @andimarc Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run unifiedPipeline |
|
No pipelines are associated with this pull request. |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Nov 11, 2020
|
Azure Pipelines successfully started running 1 pipeline(s). |
3 similar comments
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
andimarc
changed the title
andimarc
force-pushed
the
dev-web-Microsoft.Web-2020-06-01
branch
from
732cb79 to
87ea44e
Compare
andimarc
force-pushed
the
dev-web-Microsoft.Web-2020-06-01
branch
from
87ea44e to
fff45c3
Compare
… updating readme.md This reverts commit 948dfb4b1cd1d85e81e86035bf37c368a7baa763.
…ations/functionAppStacks, Microsoft.Web/webAppStacks and Microsoft.Web/locations/webAppStacks
andimarc
force-pushed
the
dev-web-Microsoft.Web-2020-06-01
branch
from
610f97f to
72e28e8
Compare
jorgecotillo
added
ARMSignedOff
weidongxu-microsoft
added
the
Approved-OkToMerge
|
If CI passes, this PR is good to merge. Let me know when (better be around the time that it onboards). |
This was referenced Feb 10, 2021
Closed
iscai-msft
added a commit
to iscai-msft/azure-rest-api-specs
that referenced
this pull request
Feb 10, 2021
…into fix_resource_multiapi_submodule * 'master' of https://github.com/Azure/azure-rest-api-specs: (452 commits) Dev cost management microsoft.cost management 2020 12 01 preview new (Azure#12259) Edit securityContact swagger for 2020-01-01 (Azure#12265) [Hub Generated] Review request for Microsoft.Insights to add version stable/2020-10-01 (Azure#11579) [Hub Generated] Review request for Microsoft.Media to add version stable/2020-05-01 (Azure#12681) Fix TimeSeriesInsights swagger issues (Azure#12204) Fixing error in lastModifiedAt description (Azure#12854) Update comment.yml (Azure#12910) Fixing RI s360 Flagged corrections in 2019-10-01 version (Azure#12777) [Hub Generated] Review request for Microsoft.Web to add version stable/2020-10-01 (Azure#11636) [Ready For Review] New version 20210101 (Azure#12111) Update scheduledQueryRule_API.json (Azure#12895) Remove UserAssigned MSI (Azure#12900) Update library.json (Azure#12922) KeyVault: Feature/update security domain spec (Azure#12863) Fixes ExampleId type and incorrect ArmTokenParameter name (Azure#12896) Update contract for anomaly detector (Azure#12487) [NetAppFiles] Urgent bug fix, backup response, remove systemData(not in response yet) (Azure#12852) [AML] Add PipelineEndpoint with version and DataPathAssignments fields in AzureMLExecutePipeline (Azure#12744) remove duplicated schema (Azure#12779) [Web] Add Swagger for Service Principal (Azure#12780) ...
mkarmark
pushed a commit
to mkarmark/azure-rest-api-specs
that referenced
this pull request
Jul 21, 2021
…e/2020-10-01 (Azure#11636) * Add 2020-10-01: Duplicating 2020-09-01 files first * Updating all '2020-09-01' strings to '2020-10-01' in copied files and updating readme.md This reverts commit 948dfb4b1cd1d85e81e86035bf37c368a7baa763. * Adding swagger for Microsoft.Web/functionAppStacks, Microsoft.Web/locations/functionAppStacks, Microsoft.Web/webAppStacks and Microsoft.Web/locations/webAppStacks * fixing incomplete descriptions * adding readOnly * removing query string from type * removing null id property * adding id property populated with resource ID * Adding "date-time" format * fixing typo in description * adding new property "storageAccountRequired" in CommonDefinitions.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
Changes introduced in API version 2020-10-01 are limited to the spec following spec: specification/web/resource-manager/Microsoft.Web/stable/2020-10-01/Provider.json
The changes begin in the second commit of this PR. (The first commit is just copying from the previous API version).
Changes:
ARM Manifest change PR: https://msazure.visualstudio.com/One/_git/AAPT-Antares-Websites/pullrequest/4025236
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Please follow the link to find more details on PR review process.