[Hub Generated] Review request for Microsoft.AzureStack to add version preview/2020-06-01-preview #12657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @ionuttulai Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
Swagger Validation Report
|
| Rule | Message |
|---|---|
| 'systemData' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. New: Microsoft.AzureStack/preview/2020-06-01-preview/AzureStack.json#L186 |
|
| 'systemData' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. New: Microsoft.AzureStack/preview/2020-06-01-preview/CustomerSubscription.json#L208 |
|
| 'systemData' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. New: Microsoft.AzureStack/preview/2020-06-01-preview/Product.json#L479 |
|
| Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: Returns a list of all linked subscriptions. New: Microsoft.AzureStack/preview/2020-06-01-preview/LinkedSubscription.json#L62 |
|
| Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: Returns a list of products. New: Microsoft.AzureStack/preview/2020-06-01-preview/Product.json#L20 |
|
| Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: Returns the specified product. New: Microsoft.AzureStack/preview/2020-06-01-preview/Product.json#L65 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]
There are no breaking changes.
️⚠️[Staging] Cross Version BreakingChange (Base on stable version): 23 Warnings warning [Detail]
Only 10 items are listed, please refer to log for more details.
- Compared Swaggers (Based on Oad v0.8.6)
- original: stable/2017-06-01/AzureStack.json <---> new: preview/2020-06-01-preview/AzureStack.json
- original: stable/2017-06-01/CustomerSubscription.json <---> new: preview/2020-06-01-preview/CustomerSubscription.json
- original: stable/2017-06-01/Product.json <---> new: preview/2020-06-01-preview/Product.json
- original: stable/2017-06-01/Registration.json <---> new: preview/2020-06-01-preview/Registration.json
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
Swagger Generation Artifacts
|
| Rule | Message |
|---|---|
|
"logUrl":"https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=191309&view=logs&j=fd490c07-0b22-5182-fac9-6d67fe1e939b", "detail":"Run.ps1 failed with exit code 128 " |
️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
️✔️Succeeded [Logs] Generate from a2685b233a076f25ff8efe7b65d93f2921fa54ca. SDK Automation 14.0.0command sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json command go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
️✔️azurestack/mgmt/2017-06-01/azurestack [View full logs] [Preview SDK Changes] Breaking Change Detectedinfo [Changelog] ### Breaking Changes info [Changelog] info [Changelog] - Function `ProductsClient.GetProductsPreparer` parameter(s) have been changed from `(context.Context, string, string, *DeviceConfiguration)` to `(context.Context, string, string, string, *DeviceConfiguration)` info [Changelog] - Function `ProductsClient.GetProducts` parameter(s) have been changed from `(context.Context, string, string, *DeviceConfiguration)` to `(context.Context, string, string, string, *DeviceConfiguration)` info [Changelog] info [Changelog] ### New Content info [Changelog] info [Changelog] - New function `RegistrationsClient.EnableRemoteManagementPreparer(context.Context, string, string) (*http.Request, error)` info [Changelog] - New function `RegistrationsClient.EnableRemoteManagementResponder(*http.Response) (autorest.Response, error)` info [Changelog] - New function `RegistrationsClient.EnableRemoteManagement(context.Context, string, string) (autorest.Response, error)` info [Changelog] - New function `RegistrationsClient.EnableRemoteManagementSender(*http.Request) (*http.Response, error)` info [Changelog] info [Changelog] Total 2 breaking change(s), 4 additive change(s). info [Changelog]
️⚠️ azure-resource-manager-schemas warning [Detail]
⚠️Warning [Logs] Generate from a2685b233a076f25ff8efe7b65d93f2921fa54ca. Schema Automation 14.0.0warn Skip initScript due to not configured command npx n 12 command autorest --use=@autorest/[email protected] --version=3.0.6351 --azureresourceschema --multiapi --title=none --pass-thru:subset-reducer --azureresourceschema-folder=/home/vsts/work/1/s/azure-resource-manager-schemas/azure-resource-manager-schemas ../../azure-rest-api-specs/specification/azurestack/resource-manager/readme.md warn No file changes detected after generation warn No package detected after generation
️⚠️ azure-sdk-for-python warning [Detail]
⚠️Warning [Logs] Generate from a2685b233a076f25ff8efe7b65d93f2921fa54ca. SDK Automation 14.0.0command sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json cmderr [automation_init.sh] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment cmderr [automation_init.sh] Failed building wheel for ConfigArgParse cmderr [automation_init.sh] Failed building wheel for wrapt cmderr [automation_init.sh] Failed building wheel for yarl cmderr [automation_init.sh] Failed building wheel for multidict cmderr [automation_init.sh] Cannot uninstall requirement azure-nspkg, not installed cmderr [automation_init.sh] Command '['/home/vsts/work/1/s/azure-sdk-for-python_tmp/venv-sdk/bin/python', '-m', 'pip', 'uninstall', '-y', 'azure-nspkg']' returned non-zero exit status 1. command sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
️✔️azure-mgmt-azurestack [View full logs] [Preview SDK Changes] Breaking Change Detectedinfo [Changelog] **Features** info [Changelog] info [Changelog] - Model Registration has a new parameter kind info [Changelog] - Model Registration has a new parameter system_data info [Changelog] - Model TrackedResource has a new parameter kind info [Changelog] - Model TrackedResource has a new parameter system_data info [Changelog] - Model Product has a new parameter system_data info [Changelog] - Model CustomerSubscription has a new parameter system_data info [Changelog] - Added operation RegistrationsOperations.enable_remote_management info [Changelog] - Added operation group LinkedSubscriptionsOperations info [Changelog] - Added operation group CloudManifestFileOperations info [Changelog] info [Changelog] **Breaking changes** info [Changelog] info [Changelog] - Parameter location of model RegistrationParameter is now required info [Changelog] - Operation CustomerSubscriptionsOperations.create has a new signature info [Changelog] - Operation ProductsOperations.get_products has a new signature info [Changelog] - Operation RegistrationsOperations.update has a new signature info [Changelog] - Operation RegistrationsOperations.create_or_update has a new signature info [Changelog] - Operation CustomerSubscriptionsOperations.create has a new signature
️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
️✔️Succeeded [Logs] Generate from a2685b233a076f25ff8efe7b65d93f2921fa54ca. SDK Automation 14.0.0warn Skip initScript due to not configured command autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/azurestack/resource-manager/readme.md
️✔️@azure/arm-azurestack [View full logs] [Preview SDK Changes]cmderr [npmPack] loaded rollup.config.js with warnings cmderr [npmPack] (!) Unused external imports cmderr [npmPack] default imported from external module 'rollup' but never used cmderr [npmPack] ./esm/azureStackManagementClient.js → ./dist/arm-azurestack.js... cmderr [npmPack] created ./dist/arm-azurestack.js in 385ms
️⚠️ azure-sdk-for-java warning [Detail]
⚠️Warning [Logs] Generate from a2685b233a076f25ff8efe7b65d93f2921fa54ca. SDK Automation 14.0.0command ./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json command ./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json cmderr [generate.py] 2021-01-28 18:09:34 INFO [VERSION][Not Found] cannot find version for "com.azure.resourcemanager:azure-resourcemanager-azurestack" cmderr [generate.py] 2021-01-28 18:09:34 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.1" cmderr [generate.py] 2021-01-28 18:09:34 INFO autorest --version=3.0.6350 --use=@autorest/[email protected] --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/azurestack/azure-resourcemanager-azurestack --java.namespace=com.azure.resourcemanager.azurestack --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL ../azure-rest-api-specs/specification/azurestack/resource-manager/readme.md cmderr [generate.py] 2021-01-28 18:10:18 INFO [CI][Success] Write to ci.yml cmderr [generate.py] 2021-01-28 18:10:18 INFO [POM][Process] dealing with pom.xml cmderr [generate.py] 2021-01-28 18:10:18 INFO [POM][Skip] pom already has module azure-resourcemanager-azurestack cmderr [generate.py] 2021-01-28 18:10:18 INFO [POM][Success] Write to pom.xml cmderr [generate.py] 2021-01-28 18:10:18 INFO [POM][Process] dealing with root pom cmderr [generate.py] 2021-01-28 18:10:18 INFO [POM][Success] Write to root pom cmderr [generate.py] WARNING: An illegal reflective access operation has occurred cmderr [generate.py] WARNING: Illegal reflective access by org.codehaus.groovy.reflection.ReflectionUtils (file:/home/vsts/.m2/repository/org/codehaus/groovy/groovy/3.0.0-beta-2/groovy-3.0.0-beta-2-indy.jar) to method java.util.Collections$UnmodifiableCollection.toString() cmderr [generate.py] WARNING: Please consider reporting this to the maintainers of org.codehaus.groovy.reflection.ReflectionUtils cmderr [generate.py] WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations cmderr [generate.py] WARNING: All illegal access operations will be denied in a future release
️✔️azure-resourcemanager-azurestack [View full logs] [Preview SDK Changes]- pom.xml
- azure-resourcemanager-azurestack-1.0.0-beta.1.jar
- azure-resourcemanager-azurestack-1.0.0-beta.1-javadoc.jar
- azure-resourcemanager-azurestack-1.0.0-beta.1-sources.jar
cmderr [Inst] 2021-01-28 18:13:21 DEBUG Got artifact_id: azure-resourcemanager-azurestack cmderr [Inst] 2021-01-28 18:13:21 DEBUG Got artifact: pom.xml cmderr [Inst] 2021-01-28 18:13:21 DEBUG Got artifact: azure-resourcemanager-azurestack-1.0.0-beta.1.jar cmderr [Inst] 2021-01-28 18:13:21 DEBUG Match jar package: azure-resourcemanager-azurestack-1.0.0-beta.1.jar cmderr [Inst] 2021-01-28 18:13:21 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/12657/azure-sdk-for-java/azure-resourcemanager-azurestack/azure-resourcemanager-azurestack-1.0.0-beta.1.jar\" -o azure-resourcemanager-azurestack-1.0.0-beta.1.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-azurestack -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-azurestack-1.0.0-beta.1.jar -Dpackaging=jar -DgeneratePom=true ```"}
|
Hi @ionuttulai, Your PR has some issues. Please fix the CI sequentially by following the order of
|
openapi-pipeline-app
bot
added
CI-BreakingChange-Go
and removed
CI-FixRequiredOnFailure
labels
openapi-pipeline-app
bot
added
CI-FixRequiredOnFailure
and removed
CI-BreakingChange-Python
labels
ionuttulai
force-pushed
the
dev-azurestack-Microsoft.AzureStack-2020-06-01-preview-clean
branch
from
0a6abe7 to
aecb44c
Compare
openapi-pipeline-app
bot
added
CI-FixRequiredOnFailure
and removed
CI-FixRequiredOnFailure
labels
ionuttulai
force-pushed
the
dev-azurestack-Microsoft.AzureStack-2020-06-01-preview-clean
branch
from
0be1afb to
3b39238
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
Changelog
Please ensure to add changelog with this PR by answering the following questions.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.