Microsoft.data protection

[mayankagg9722]

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

1. What's the purpose of the update?
   • new service onboarding
   • new API version
   • update existing version for new feature
   • update existing version to fix swagger quality issue in s360
   • Other, please clarify
2. When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
3. When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
4. If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
   • SDK of .NET (need service team to ensure code readiness)
   • SDK of Python
   • SDK of Java
   • SDK of Js
   • SDK of Go
   • PowerShell
   • CLI
   • Terraform
   • No, no need to refresh for updates in this PR

Contribution checklist:

• I commit to follow the Breaking Change Policy of "no breaking changes"
• I have reviewed the documentation for the workflow.
• Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

• Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

  • Adding new API(s)
  • Adding a new API version
  • Adding a new service

• Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

• If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

• Removing API(s) in stable version
• Removing properties in stable version
• Removing API version(s) in stable version
• Updating API in stable version with Breaking Change Validation errors
• Updating API(s) in preview over 1 year

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

[openapi-workflow-bot]

Hi, @mayankagg9722 Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

[openapi-pipeline-app]

Swagger Validation Report

️⌛BreakingChange pending [Detail]

️⌛LintDiff pending [Detail]

️⌛Avocado pending [Detail]

️⌛ModelValidation pending [Detail]

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️⌛[Staging] Cross Version BreakingChange (Base on preview version) pending [Detail]

️⌛[Staging] Cross Version BreakingChange (Base on stable version) pending [Detail]

️⌛[Staging] SDK Track2 Validation pending [Detail]

️⌛[Staging] PrettierCheck pending [Detail]

️⌛[Staging] SpellCheck pending [Detail]

_{Posted by Swagger Pipeline | How to fix these errors?}

[openapi-pipeline-app]

Swagger Generation Artifacts

️⌛[Staging] ApiDocPreview pending [Detail]

️🔄 azure-sdk-for-net inProgress [Detail]

_{Posted by Swagger Pipeline | How to fix these errors?}

[openapi-workflow-bot]

Hi @mayankagg9722, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff.

Task	How to fix	Priority	Support (Microsoft alias)
Avocado	Fix-Avocado	High	ruowan
Semantic validation	Fix-SemanticValidation-Error	High	raychen, jianyxi
Model validation	Fix-ModelValidation-Error	High	raychen,jianyxi
LintDiff	Fix-LintDiff	high	jianyxi, ruoxuan

If you need further help, please feedback via swagger feedback."

[mayankagg9722]

"/subscriptions/{subscriptionId}/providers/Microsoft.DataProtection/locations/{location}/operationStatus/{operationId}": {

why do you need operationStatus and operationResults?

Refers to: specification/dataprotection/resource-manager/Microsoft.DataProtection/preview/2020-01-01-alpha/dataprotection.json:115 in abcd60d. [](commit_id = abcd60d, deletion_comment = False)

Operationresult is used for old clients and operationstatus is used portal and this was already reviewed in private repo and may break existing clients

[mayankagg9722]

I have made all other changes for other comments you put, please review it once.

[varunkumta]

can you please specify which apis/models have not been reviewed before or have changed since the last review - so I can focus on those

[mayankagg9722]

can you please specify which apis/models have not been reviewed before or have changed since the last review - so I can focus on those

I have only made the changes for API version and to fix the comments you mentioned above. So, please take a look for the fixes of the APIs mentioned in the comments as those are the only ones which got changed.
Commit links:

• 3402544
• ba3cda3
• f2a6c91

[leniatgh]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 2 pipeline(s).

[akning-ms]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 2 pipeline(s).

[akning-ms]

Based on talk with Sumit as below, I will force merge this PR in branch first to unblock

[1:05 PM] Sumit Malhotra (BACKUP)
GO SDK is an issue we were tracking....
since this is in our branch
we will raise a seperate PR when all our changes are merged here
and ready to ship SDK to master branch
before that we will get that fixed
we are not planning to ship any sdk out of this ... we need to get the .net sdk and powershell ready and hence wanted to merge these
so we can have a baseline and other developers can get their apis reviewed on top of baseline
after all changes are done, we will go to master branch and will fix the GO sdk issues

@allenjzhang for awareness