Azure Data Share: Modify Proxy & Default DTOs for systemdata (2020-09-01)

[ahermas]

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

1. What's the purpose of the update?
   • new service onboarding
   • new API version
   • update existing version for new feature
   • update existing version to fix swagger quality issue in s360
   • Other, please clarify
2. When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
3. When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
4. If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
   • SDK of .NET (need service team to ensure code readiness)
   • SDK of Python
   • SDK of Java
   • SDK of Js
   • SDK of Go
   • PowerShell
   • CLI
   • Terraform
   • No, no need to refresh for updates in this PR

Contribution checklist:

• I commit to follow the Breaking Change Policy of "no breaking changes"
• I have reviewed the documentation for the workflow.
• Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

• Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

  • Adding new API(s)
  • Adding a new API version
  • Adding a new service

• Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

• If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.

• Removing API(s) in stable version
• Removing properties in stable version
• Removing API version(s) in stable version
• Updating API in stable or public preview version with Breaking Change Validation errors
• Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

[openapi-workflow-bot]

Hi, @ahermas Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

[openapi-pipeline-app]

Swagger Validation Report

️❌BreakingChange: 78 Errors, 40 Warnings failed [Detail]

Only 10 items are listed, please refer to log for more details.

• Compared Swaggers (Based on Oad v0.8.6)
  • original: stable/2020-09-01/DataShare.json <---> new: stable/2020-09-01/DataShare.json

Rule	Message
❌ 1026 - TypeChanged	The new version has a different type 'object' than the previous one ''. New: Microsoft.DataShare/stable/2020-09-01/DataShare.json#L5399:9 Old: Microsoft.DataShare/stable/2020-09-01/DataShare.json#L4646:9
❌ 1026 - TypeChanged	The new version has a different type 'object' than the previous one ''. New: Microsoft.DataShare/stable/2020-09-01/DataShare.json#L5399:9 Old: Microsoft.DataShare/stable/2020-09-01/DataShare.json#L5419:9
❌ 1026 - TypeChanged	The new version has a different type 'object' than the previous one ''. New: Microsoft.DataShare/stable/2020-09-01/DataShare.json#L5399:9 Old: Microsoft.DataShare/stable/2020-09-01/DataShare.json#L5419:9
❌ 1026 - TypeChanged	The new version has a different type 'object' than the previous one ''. New: Microsoft.DataShare/stable/2020-09-01/DataShare.json#L5399:9 Old: Microsoft.DataShare/stable/2020-09-01/DataShare.json#L5419:9
❌ 1026 - TypeChanged	The new version has a different type 'object' than the previous one ''. New: Microsoft.DataShare/stable/2020-09-01/DataShare.json#L5399:9 Old: Microsoft.DataShare/stable/2020-09-01/DataShare.json#L5419:9
❌ 1026 - TypeChanged	The new version has a different type 'object' than the previous one ''. New: Microsoft.DataShare/stable/2020-09-01/DataShare.json#L5399:9 Old: Microsoft.DataShare/stable/2020-09-01/DataShare.json#L5419:9
❌ 1026 - TypeChanged	The new version has a different type 'object' than the previous one ''. New: Microsoft.DataShare/stable/2020-09-01/DataShare.json#L5399:9 Old: Microsoft.DataShare/stable/2020-09-01/DataShare.json#L5419:9
❌ 1026 - TypeChanged	The new version has a different type 'object' than the previous one ''. New: Microsoft.DataShare/stable/2020-09-01/DataShare.json#L5399:9 Old: Microsoft.DataShare/stable/2020-09-01/DataShare.json#L5419:9
❌ 1026 - TypeChanged	The new version has a different type 'object' than the previous one ''. New: Microsoft.DataShare/stable/2020-09-01/DataShare.json#L5399:9 Old: Microsoft.DataShare/stable/2020-09-01/DataShare.json#L5419:9
❌ 1026 - TypeChanged	The new version has a different type 'object' than the previous one ''. New: Microsoft.DataShare/stable/2020-09-01/DataShare.json#L5399:9 Old: Microsoft.DataShare/stable/2020-09-01/DataShare.json#L5419:9

️️✔️LintDiff succeeded [Detail] [Expand]

Validation passes for LintDiff.

• Linted configuring files (Based on source branch, openapi-validator v1.7.0 , classic-openapi-validator v1.1.5 )
  • datashare/resource-manager/readme.md tag:package-2020-09-01
• Linted configuring files (Based on target branch, openapi-validator v1.7.0 , classic-openapi-validator v1.1.5 )
  • datashare/resource-manager/readme.md tag:package-2020-09-01

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️⚠️[Staging] SDK Track2 Validation: 1 Warnings warning [Detail]

• The following tags are being changed in this PR
• datashare/resource-manager/readme.md#package-2020-09-01

Rule	Message
⚠️ PreCheck/CheckDuplicateSchemas	"readme":"datashare/resource-manager/readme.md", "tag":"package-2020-09-01", "details":"Checking for duplicate schemas, this could take a (long) while. Run with --verbose for more detail."

️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

_{Posted by Swagger Pipeline | How to fix these errors?}

[openapi-pipeline-app]

Swagger Generation Artifacts

️🔄 azure-sdk-for-python inProgress [Detail]

️🔄[Staging] ApiDocPreview inProgress [Detail]

_{Posted by Swagger Pipeline | How to fix these errors?}

[openapi-workflow-bot]

In the Window Period to fix mismatches between swagger and service, when PR is labelled with “FixS360”, breaking change can be approved by PR assignee; the Azure Breaking Change Board is no longer required to approve the PR. Please ensure to clarify what s360 action items to be solved, and @ mention PR assignee for awareness. Please check this wiki Window to Fix Broken for more details.

[openapi-workflow-bot]

Hi @ahermas, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
If you want to know the production traffic statistic, please see ARM Traffic statistic.
If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.

[ahermas]

@markcowl
This PR isn't really a breaking change. It's just a slight modification of the azure resource (proxy and default DTOs) structure since adding a new systemData property was requested. This is the PR that introduced systemData for Azure Data Share for version 2020-09-01 which was merged some time last week.

Please let me know if you have any questions.