Peering api 2021-06-01 #14703

renuka-raju · 2021-06-07T21:27:21Z

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
When you expect to publish swagger? Please provide date, or month to public if date is not available yet. Upcoming Release
If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
- SDK of .NET (need service team to ensure code readiness)
- SDK of Python
- SDK of Java
- SDK of Js
- SDK of Go
- PowerShell
- CLI
- Terraform
- No, no need to refresh for updates in this PR

Contribution checklist:

I commit to follow the Breaking Change Policy of "no breaking changes"
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
- Adding new API(s)
- Adding a new API version
- Ensure to copy the existing version into new directory structure for first commit (including refactoring) and then push new changes including version updates in separate commits. This is required to review the changes efficiently.
- Adding a new service
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.

Removing API(s) in stable version
Removing properties in stable version
Removing API version(s) in stable version
Updating API in stable or public preview version with Breaking Change Validation errors
Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

openapi-workflow-bot · 2021-06-07T21:27:23Z

Hi, @renuka-raju Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

openapi-workflow-bot · 2021-06-07T21:27:24Z

[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

openapi-pipeline-app · 2021-06-07T21:27:24Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

️❌LintDiff: 2 Errors, 2 Warnings failed [Detail]

Linted configuring files (Based on source branch, openapi-validator v1.10.0 , classic-openapi-validator v1.1.8 )
- peering/resource-manager/readme.md tag:package-2021-06-01
Linted configuring files (Based on target branch, openapi-validator v1.10.0 , classic-openapi-validator v1.1.8 )
- peering/resource-manager/readme.md tag:default

The following errors/warnings are introduced by current PR:

Rule	Message
`❌` R4009 - RequiredReadOnlySystemData	The response of operation:'ConnectionMonitorTests_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Peering/stable/2021-06-01/peering.json#L1404
`❌` R4009 - RequiredReadOnlySystemData	The response of operation:'ConnectionMonitorTests_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Peering/stable/2021-06-01/peering.json#L1459
⚠️ R2066 - PostOperationIdContainsUrlVerb	OperationId should contain the verb: 'lookingglass' in:'LookingGlass_Invoke'. Consider updating the operationId Location: Microsoft.Peering/stable/2021-06-01/peering.json#L185
⚠️ R3018 - EnumInsteadOfBoolean	Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isTestSuccessful Location: Microsoft.Peering/stable/2021-06-01/peering.json#L3591

The following errors/warnings exist before current PR submission:

Only 10 items are listed, please refer to log for more details.

Rule	Message
`❌` R4009 - RequiredReadOnlySystemData	The response of operation:'PeerAsns_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Peering/stable/2021-06-01/peering.json#L289
`❌` R4009 - RequiredReadOnlySystemData	The response of operation:'RegisteredAsns_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Peering/stable/2021-06-01/peering.json#L537
`❌` R4009 - RequiredReadOnlySystemData	The response of operation:'RegisteredPrefixes_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Peering/stable/2021-06-01/peering.json#L772
`❌` R4009 - RequiredReadOnlySystemData	The response of operation:'Peerings_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Peering/stable/2021-06-01/peering.json#L1007
`❌` R4009 - RequiredReadOnlySystemData	The response of operation:'Prefixes_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Peering/stable/2021-06-01/peering.json#L1724
`❌` R4009 - RequiredReadOnlySystemData	The response of operation:'PeeringServices_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Peering/stable/2021-06-01/peering.json#L2012
`❌` R4009 - RequiredReadOnlySystemData	The response of operation:'PeerAsns_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Peering/stable/2021-06-01/peering.json#L330
`❌` R4009 - RequiredReadOnlySystemData	The response of operation:'RegisteredAsns_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Peering/stable/2021-06-01/peering.json#L592
`❌` R4009 - RequiredReadOnlySystemData	The response of operation:'RegisteredPrefixes_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Peering/stable/2021-06-01/peering.json#L827
`❌` R4009 - RequiredReadOnlySystemData	The response of operation:'Peerings_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Peering/stable/2021-06-01/peering.json#L1055

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️❌Cross-Version Breaking Changes: 12 Errors, 0 Warnings failed [Detail]

Compared Swaggers (Based on Oad v0.8.11)
- current:stable/2021-06-01/peering.json compared with base:stable/2021-01-01/peering.json
- current:stable/2021-06-01/peering.json compared with base:preview/2020-01-01-preview/peering.json

The following breaking changes are detected by comparison with the latest stable version:

Rule	Message
`❌` 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.Peering/CheckServiceProviderAvailability' removed or restructured? Old: Microsoft.Peering/stable/2021-01-01/peering.json#L65:5
`❌` 1029 - ReadonlyPropertyChanged	The read only property has changed from 'false' to 'true'. New: Microsoft.Peering/stable/2021-06-01/peering.json#L2504:9 Old: Microsoft.Peering/stable/2021-01-01/peering.json#L2163:9
`❌` 1029 - ReadonlyPropertyChanged	The read only property has changed from 'false' to 'true'. New: Microsoft.Peering/stable/2021-06-01/peering.json#L2517:9 Old: Microsoft.Peering/stable/2021-01-01/peering.json#L2175:9
`❌` 1029 - ReadonlyPropertyChanged	The read only property has changed from 'false' to 'true'. New: Microsoft.Peering/stable/2021-06-01/peering.json#L2530:9 Old: Microsoft.Peering/stable/2021-01-01/peering.json#L2187:9
`❌` 1029 - ReadonlyPropertyChanged	The read only property has changed from 'false' to 'true'. New: Microsoft.Peering/stable/2021-06-01/peering.json#L3068:9 Old: Microsoft.Peering/stable/2021-01-01/peering.json#L2607:9

The following breaking changes are detected by comparison with latest preview version:

Rule	Message
`❌` 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.Peering/CheckServiceProviderAvailability' removed or restructured? Old: Microsoft.Peering/preview/2020-01-01-preview/peering.json#L19:5
`❌` 1029 - ReadonlyPropertyChanged	The read only property has changed from 'false' to 'true'. New: Microsoft.Peering/stable/2021-06-01/peering.json#L2504:9 Old: Microsoft.Peering/preview/2020-01-01-preview/peering.json#L1964:9
`❌` 1029 - ReadonlyPropertyChanged	The read only property has changed from 'false' to 'true'. New: Microsoft.Peering/stable/2021-06-01/peering.json#L2517:9 Old: Microsoft.Peering/preview/2020-01-01-preview/peering.json#L1976:9
`❌` 1029 - ReadonlyPropertyChanged	The read only property has changed from 'false' to 'true'. New: Microsoft.Peering/stable/2021-06-01/peering.json#L2530:9 Old: Microsoft.Peering/preview/2020-01-01-preview/peering.json#L1988:9
`❌` 1029 - ReadonlyPropertyChanged	The read only property has changed from 'false' to 'true'. New: Microsoft.Peering/stable/2021-06-01/peering.json#L3068:9 Old: Microsoft.Peering/preview/2020-01-01-preview/peering.json#L2402:9
`❌` 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'code' renamed or removed? New: Microsoft.Peering/stable/2021-06-01/peering.json#L4038:7 Old: Microsoft.Peering/preview/2020-01-01-preview/peering.json#L3183:7
`❌` 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'message' renamed or removed? New: Microsoft.Peering/stable/2021-06-01/peering.json#L4038:7 Old: Microsoft.Peering/preview/2020-01-01-preview/peering.json#L3183:7

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️️✔️[Staging] SDK Track2 Validation succeeded [Detail] [Expand]

Validation passes for SDKTrack2Validation

The following tags are being changed in this PR

peering/resource-manager/readme.md#package-2021-06-01

The following errors/warnings are introduced by current PR:

|:speech_balloon: AutorestCore/Exception|"readme":"peering/resource-manager/readme.md",
"tag":"package-2021-06-01",
"details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0)"|
|:speech_balloon: AutorestCore/Exception|"readme":"peering/resource-manager/readme.md",
"tag":"package-2021-06-01",
"details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
|:speech_balloon: AutorestCore/Exception|"readme":"peering/resource-manager/readme.md",
"tag":"package-2021-06-01",
"details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|

️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️[Staging] Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2021-06-07T21:27:25Z

Swagger Generation Artifacts

️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️️✔️[Staging] SDK Breaking Change Tracking succeeded [Detail] [Expand]

Breaking Changes Tracking

️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-peering - 1.0.0
️✔️azure-sdk-for-go - peering/mgmt/2021-06-01/peering - v55.4.0
️✔️azure-sdk-for-go - peering/mgmt/2021-01-01/peering - v55.4.0
️✔️azure-sdk-for-go - peering/mgmt/2020-10-01/peering - v55.4.0
️✔️azure-sdk-for-go - peering/mgmt/2020-04-01/peering - v55.4.0
️✔️azure-sdk-for-go - preview/peering/mgmt/2020-01-01-preview/peering - v55.4.0
️✔️azure-sdk-for-go - preview/peering/mgmt/2019-09-01-preview/peering - v55.4.0
️✔️azure-sdk-for-go - preview/peering/mgmt/2019-08-01-preview/peering - v55.4.0

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs]Release - Generate from c51580c. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json

️✔️track2_azure-mgmt-peering [View full logs] [Release SDK Changes]
- azure-mgmt-peering-1.0.0b1.zip
- azure_mgmt_peering-1.0.0b1-py2.py3-none-any.whl
```
info	[Changelog]
```

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs]Release - Generate from c51580c. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
cmderr	[generate.py] 2021-06-30 00:34:23 INFO [VERSION][Found] current version "com.azure.resourcemanager:azure-resourcemanager-peering;1.0.0-beta.1;1.0.0-beta.2"
cmderr	[generate.py] 2021-06-30 00:34:23 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.2"
cmderr	[generate.py] 2021-06-30 00:34:23 INFO autorest --version=3.1.3 --use=@autorest/[email protected] --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/peering/azure-resourcemanager-peering --java.namespace=com.azure.resourcemanager.peering   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL ../azure-rest-api-specs/specification/peering/resource-manager/readme.md
cmderr	[generate.py] 2021-06-30 00:34:57 INFO [CI][Skip] ci.yml already has module azure-resourcemanager-peering
cmderr	[generate.py] 2021-06-30 00:34:57 INFO [POM][Process] dealing with pom.xml
cmderr	[generate.py] 2021-06-30 00:34:57 INFO [POM][Skip] pom already has module azure-resourcemanager-peering
cmderr	[generate.py] 2021-06-30 00:34:57 INFO [POM][Success] Write to pom.xml
cmderr	[generate.py] 2021-06-30 00:34:57 INFO [POM][Process] dealing with root pom
cmderr	[generate.py] 2021-06-30 00:34:57 INFO [POM][Skip] pom already has module sdk/peering
cmderr	[generate.py] 2021-06-30 00:34:57 INFO [POM][Success] Write to root pom

️✔️azure-resourcemanager-peering [View full logs] [Release SDK Changes]

cmderr	[Inst] 2021-06-30 00:36:34 DEBUG Got artifact_id: azure-resourcemanager-peering
cmderr	[Inst] 2021-06-30 00:36:34 DEBUG Got artifact: pom.xml
cmderr	[Inst] 2021-06-30 00:36:34 DEBUG Got artifact: azure-resourcemanager-peering-1.0.0-beta.2-sources.jar
cmderr	[Inst] 2021-06-30 00:36:34 DEBUG Got artifact: azure-resourcemanager-peering-1.0.0-beta.2.jar
cmderr	[Inst] 2021-06-30 00:36:34 DEBUG Match jar package: azure-resourcemanager-peering-1.0.0-beta.2.jar
cmderr	[Inst] 2021-06-30 00:36:34 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/14703/azure-sdk-for-java/azure-resourcemanager-peering/azure-resourcemanager-peering-1.0.0-beta.2.jar\" -o azure-resourcemanager-peering-1.0.0-beta.2.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-peering -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-peering-1.0.0-beta.2.jar -Dpackaging=jar -DgeneratePom=true
```"}

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from c51580c. SDK Automation 14.0.0

command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️peering/mgmt/2021-06-01/peering [View full logs] [Release SDK Changes]
```
info	[Changelog] This is a new package
```
️✔️peering/mgmt/2021-01-01/peering [View full logs]
```
info	[Changelog] This is a new package
```
️✔️peering/mgmt/2020-10-01/peering [View full logs]
```
info	[Changelog] No exported changes
```
️✔️peering/mgmt/2020-04-01/peering [View full logs]
```
info	[Changelog] No exported changes
```
️✔️preview/peering/mgmt/2020-01-01-preview/peering [View full logs]
```
info	[Changelog] No exported changes
```
️✔️preview/peering/mgmt/2019-09-01-preview/peering [View full logs]
```
info	[Changelog] No exported changes
```
️✔️preview/peering/mgmt/2019-08-01-preview/peering [View full logs]
```
info	[Changelog] No exported changes
```

️❌ azure-sdk-for-net failed [Detail]

❌Failed [Logs]Release - Generate from c51580c. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-5.0
command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/peering/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied

❌Microsoft.Azure.Management.Peering [View full logs] [Release SDK Changes]

cmdout	[msbuild]      3>/home/vsts/work/1/s/azure-sdk-for-net/sdk/peering/Microsoft.Azure.Management.Peering/tests/PeeringTests.cs(827,17): error CS0200: Property or indexer 'PeerAsn.ValidationState' cannot be assigned to -- it is read only [/home/vsts/work/1/s/azure-sdk-for-net/sdk/peering/Microsoft.Azure.Management.Peering/tests/Microsoft.Azure.Management.Peering.Tests.csproj]
cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/peering/Microsoft.Azure.Management.Peering/tests/PeeringTests.cs(827,17): error CS0200: Property or indexer 'PeerAsn.ValidationState' cannot be assigned to -- it is read only [/home/vsts/work/1/s/azure-sdk-for-net/sdk/peering/Microsoft.Azure.Management.Peering/tests/Microsoft.Azure.Management.Peering.Tests.csproj]
error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-net]: dotnet

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from c51580c. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/peering/resource-manager/readme.md

️✔️@azure/arm-peering [View full logs] [Release SDK Changes]

azure-arm-peering-1.0.0.tgz

cmderr	[npmPack] loaded rollup.config.js with warnings
cmderr	[npmPack] (!) Unused external imports
cmderr	[npmPack] default imported from external module 'rollup' but never used
cmderr	[npmPack] ./esm/peeringManagementClient.js → ./dist/arm-peering.js...
cmderr	[npmPack] created ./dist/arm-peering.js in 505ms

️⚠️ azure-resource-manager-schemas warning [Detail]

⚠️Warning [Logs]Release - Generate from c51580c. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh] WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
cmderr	[generateScript.sh] (node:2376) UnhandledPromiseRejectionWarning: Error: ENOENT: no such file or directory, unlink '/home/vsts/work/1/s/azure-resource-manager-schemas/schemas/2019-09-01-preview/Microsoft.Peering.json'
cmderr	[generateScript.sh] (Use `node --trace-warnings ...` to show where the warning was created)
cmderr	[generateScript.sh] (node:2376) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 1)
cmderr	[generateScript.sh] (node:2376) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

️✔️peering [View full logs] [Release Schema Changes]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-workflow-bot · 2021-06-07T21:41:23Z

Hi, @renuka-raju your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board([email protected]). cc @

…into peeringAPI-2021-06-01

chiragg4u · 2021-06-14T18:40:34Z

Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

chiragg4u · 2021-06-14T18:42:14Z

Thanks for copying older version in the first commit, It helped me review the changes efficiently. I reviewed the changes. Changes looks good, marking ARM_Signedoff.

uslava77 · 2021-06-18T17:49:15Z

Open API Hub comparison with 2021-01-01 peering.json

…ation

ArcturusZhang · 2021-06-23T00:37:36Z

Approving for changes in readme.go.md

akning-ms · 2021-06-23T08:19:42Z

There is few Linter error about system data. do you have plan to support system data? and removing a path(CheckServiceProviderAvailability) from previous stable version is a breaking change which need breaking change review board approval, it is on purpose?

openapi-workflow-bot · 2021-06-23T09:14:14Z

Hi @renuka-raju, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
If you want to know the production traffic statistic, please see ARM Traffic statistic.
If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.

uslava77 · 2021-06-28T18:24:46Z

Hi @akning-ms , thanks for your review, the CheckServiceProviderAvailability was changed back so it is not a breaking change. We do not plan to support systemData for this API version, but we will plan for future API. @renuka-raju will reply with justification for the other breaking changes.

uslava77 · 2021-06-28T18:51:13Z

Correction: path CheckServiceProviderAvailability rename to checkServiceProviderAvailability is required, as it is s360 linting violation

uslava77 · 2021-06-29T19:49:45Z

Hi @akning-ms , for each breaking change here are the relevant s360 items:
Linter Error R3021
ROUNDTRIP_ADDITIONAL_PROPERTY
ROUNDTRIP_INCONSISTENT_PROPERTY
Expected impact is minimal on end-user experience (ReadOnly changes with no impact, and camel-case change for checkServiceProviderAvailability used mostly by internal code on Portal side).

* Existing version in new directory * 2021-06-01 swagger correctness changes * Resolved conflict * [feat] Add looking glass documentation to 2021-06-01 * [fix] Change LookingGlasses to LookingGlass * Add connection monitor models and examples * Remove LookingGlass response status codes and fix parameter capitalization * Fix ReadOnly properties in request * Remove last readOnly property Co-authored-by: Renuka Raju <[email protected]> Co-authored-by: Jimmy Xu <[email protected]> Co-authored-by: Slava Uryumtsev <[email protected]>

Existing version in new directory

ef6d7d4

openapi-pipeline-app bot added the CI-BreakingChange-Python label Jun 7, 2021

This was referenced Jun 7, 2021

[AutoPR Microsoft.Azure.Management.Peering] Peering api 2021-06-01 AzureSDKAutomation/azure-sdk-for-net#4355

Closed

[AutoPR azure-resourcemanager-peering] Peering api 2021-06-01 AzureSDKAutomation/azure-sdk-for-java#8750

Closed

2021-06-01 swagger correctness changes

3f273fd

openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jun 7, 2021

Renuka Raju and others added 3 commits June 9, 2021 23:10

Merge branch 'master' of https://github.com/Azure/azure-rest-api-specs …

871b63f

…into peeringAPI-2021-06-01

Resolved conflict

a892281

[feat] Add looking glass documentation to 2021-06-01

5226c35

chiragg4u added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jun 14, 2021

Jimmy Xu and others added 2 commits June 15, 2021 14:59

[fix] Change LookingGlasses to LookingGlass

d523ed1

Add connection monitor models and examples

2320d9b

This was referenced Jun 18, 2021

[AutoPR @azure/arm-peering] Peering api 2021-06-01 AzureSDKAutomation/azure-sdk-for-js#5109

Closed

[AutoPR track2_azure-mgmt-peering] Peering api 2021-06-01 AzureSDKAutomation/azure-sdk-for-python#6076

Closed

This was referenced Jun 18, 2021

[AutoPR azure-resourcemanager-peering] Peering api 2021-06-01 AzureSDKAutomation/azure-sdk-for-java#8856

Closed

[AutoPR Microsoft.Azure.Management.Peering] Peering api 2021-06-01 AzureSDKAutomation/azure-sdk-for-net#4480

Closed

Remove LookingGlass response status codes and fix parameter capitaliz…

3123c75

…ation

Slava Uryumtsev added 2 commits June 18, 2021 14:20

Fix ReadOnly properties in request

9205e95

Remove last readOnly property

1f145a5

renuka-raju marked this pull request as ready for review June 18, 2021 23:14

renuka-raju requested a review from ArcturusZhang as a code owner June 18, 2021 23:14

openapi-assignment-bot bot assigned akning-ms Jun 18, 2021

ArcturusZhang approved these changes Jun 23, 2021

View reviewed changes

akning-ms added the BreakingChangeReviewRequired label Jun 23, 2021

uslava77 force-pushed the peeringAPI-2021-06-01 branch from 6223d11 to 1f145a5 Compare June 28, 2021 18:49

akning-ms removed the BreakingChangeReviewRequired label Jun 30, 2021

akning-ms merged commit c51580c into Azure:master Jun 30, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Peering api 2021-06-01 #14703

Peering api 2021-06-01 #14703

renuka-raju commented Jun 7, 2021 •

edited

Loading

openapi-workflow-bot bot commented Jun 7, 2021

openapi-workflow-bot bot commented Jun 7, 2021

openapi-pipeline-app bot commented Jun 7, 2021 •

edited

Loading

openapi-pipeline-app bot commented Jun 7, 2021 •

edited

Loading

Breaking Changes Tracking

openapi-workflow-bot bot commented Jun 7, 2021

chiragg4u commented Jun 14, 2021

chiragg4u commented Jun 14, 2021

uslava77 commented Jun 18, 2021

ArcturusZhang commented Jun 23, 2021

akning-ms commented Jun 23, 2021 •

edited

Loading

openapi-workflow-bot bot commented Jun 23, 2021

uslava77 commented Jun 28, 2021

uslava77 commented Jun 28, 2021

uslava77 commented Jun 29, 2021

Peering api 2021-06-01 #14703

Peering api 2021-06-01 #14703

Conversation

renuka-raju commented Jun 7, 2021 • edited Loading

Changelog

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

openapi-workflow-bot bot commented Jun 7, 2021

openapi-workflow-bot bot commented Jun 7, 2021

openapi-pipeline-app bot commented Jun 7, 2021 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Jun 7, 2021 • edited Loading

Swagger Generation Artifacts

Breaking Changes Tracking

openapi-workflow-bot bot commented Jun 7, 2021

chiragg4u commented Jun 14, 2021

chiragg4u commented Jun 14, 2021

uslava77 commented Jun 18, 2021

ArcturusZhang commented Jun 23, 2021

akning-ms commented Jun 23, 2021 • edited Loading

openapi-workflow-bot bot commented Jun 23, 2021

uslava77 commented Jun 28, 2021

uslava77 commented Jun 28, 2021

uslava77 commented Jun 29, 2021

renuka-raju commented Jun 7, 2021 •

edited

Loading

openapi-pipeline-app bot commented Jun 7, 2021 •

edited

Loading

openapi-pipeline-app bot commented Jun 7, 2021 •

edited

Loading

akning-ms commented Jun 23, 2021 •

edited

Loading