Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding iperf APIs #14714

Merged
merged 6 commits into from
Jun 21, 2021
Merged

Adding iperf APIs #14714

merged 6 commits into from
Jun 21, 2021

Conversation

dsgouda
Copy link
Contributor

@dsgouda dsgouda commented Jun 8, 2021

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
      New API version but no sdk/ARM Manifest was released for the previous version
  2. When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet. June 2021
  3. When you expect to publish swagger? Please provide date, or month to public if date is not available yet. June 2021
  4. If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No, no need to refresh for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Ensure to copy the existing version into new directory structure for first commit (including refactoring) and then push new changes including version updates in separate commits. This is required to review the changes efficiently.
    • Adding a new service
  • Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @dsgouda Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    @openapi-workflow-bot
    Copy link

    [Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jun 8, 2021

    Swagger Validation Report

    ️❌BreakingChange: 8 Errors, 0 Warnings failed [Detail]
    Rule Message
    1038 - AddedPath The new version is adding a path that was not found in the old version.
    New: Microsoft.DBforPostgreSQL/preview/2021-06-01-preview/IntelligentPerformance.json#L37:5
    1038 - AddedPath The new version is adding a path that was not found in the old version.
    New: Microsoft.DBforPostgreSQL/preview/2021-06-01-preview/IntelligentPerformance.json#L82:5
    1038 - AddedPath The new version is adding a path that was not found in the old version.
    New: Microsoft.DBforPostgreSQL/preview/2021-06-01-preview/IntelligentPerformance.json#L127:5
    1038 - AddedPath The new version is adding a path that was not found in the old version.
    New: Microsoft.DBforPostgreSQL/preview/2021-06-01-preview/QueryPerformanceInsights.json#L37:5
    1038 - AddedPath The new version is adding a path that was not found in the old version.
    New: Microsoft.DBforPostgreSQL/preview/2021-06-01-preview/QueryPerformanceInsights.json#L79:5
    1038 - AddedPath The new version is adding a path that was not found in the old version.
    New: Microsoft.DBforPostgreSQL/preview/2021-06-01-preview/QueryPerformanceInsights.json#L124:5
    1038 - AddedPath The new version is adding a path that was not found in the old version.
    New: Microsoft.DBforPostgreSQL/preview/2021-06-01-preview/QueryPerformanceInsights.json#L180:5
    1038 - AddedPath The new version is adding a path that was not found in the old version.
    New: Microsoft.DBforPostgreSQL/preview/2021-06-01-preview/QueryPerformanceInsights.json#L225:5
    ️⚠️LintDiff: 5 Warnings warning [Detail]
    The following errors/warnings are introduced by current PR:
    Rule Message
    ⚠️ R2066 - PostOperationIdContainsUrlVerb OperationId should contain the verb: 'resetqueryperformanceinsightdata' in:'QueryPerformanceInsightData_Reset'. Consider updating the operationId
    Location: Microsoft.DBforPostgreSQL/preview/2021-06-01-preview/QueryPerformanceInsights.json#L42
    ⚠️ R4014 - AllResourcesMustHaveGetOperation The resource 'RecommendationAction' does not have get operation, please add it.
    Location: Microsoft.DBforPostgreSQL/preview/2021-06-01-preview/IntelligentPerformance.json#L269
    ⚠️ R4014 - AllResourcesMustHaveGetOperation The resource 'QueryStatistic' does not have get operation, please add it.
    Location: Microsoft.DBforPostgreSQL/preview/2021-06-01-preview/QueryPerformanceInsights.json#L469
    ⚠️ R4014 - AllResourcesMustHaveGetOperation The resource 'WaitStatistic' does not have get operation, please add it.
    Location: Microsoft.DBforPostgreSQL/preview/2021-06-01-preview/QueryPerformanceInsights.json#L591
    ⚠️ R4021 - DescriptionAndTitleMissing 'error' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
    Location: Microsoft.DBforPostgreSQL/preview/2021-06-01-preview/QueryPerformanceInsights.json#L306


    The following errors/warnings exist before current PR submission:

    Only 10 items are listed, please refer to log for more details.

    Rule Message
    R4037 - MissingTypeObject The schema 'StorageEditionCapability' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.DBforPostgreSQL/preview/2021-06-01-preview/postgresql.json#L1161
    R4037 - MissingTypeObject The schema 'CapabilityProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.DBforPostgreSQL/preview/2021-06-01-preview/postgresql.json#L1276
    R4037 - MissingTypeObject The schema 'ServerProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.DBforPostgreSQL/preview/2021-06-01-preview/postgresql.json#L1352
    R4037 - MissingTypeObject The schema 'Server' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.DBforPostgreSQL/preview/2021-06-01-preview/postgresql.json#L1483
    R4037 - MissingTypeObject The schema 'ServerPropertiesForUpdate' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.DBforPostgreSQL/preview/2021-06-01-preview/postgresql.json#L1511
    R4037 - MissingTypeObject The schema 'ServerForUpdate' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.DBforPostgreSQL/preview/2021-06-01-preview/postgresql.json#L1551
    R4037 - MissingTypeObject The schema 'Sku' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.DBforPostgreSQL/preview/2021-06-01-preview/postgresql.json#L1593
    R4037 - MissingTypeObject The schema 'Storage' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.DBforPostgreSQL/preview/2021-06-01-preview/postgresql.json#L1619
    R4037 - MissingTypeObject The schema 'Backup' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.DBforPostgreSQL/preview/2021-06-01-preview/postgresql.json#L1629
    R4037 - MissingTypeObject The schema 'Network' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.DBforPostgreSQL/preview/2021-06-01-preview/postgresql.json#L1661
    ️⚠️Avocado: 1 Warnings warning [Detail]
    Rule Message
    ⚠️ MULTIPLE_API_VERSION The default tag contains multiple API versions swaggers.
    readme: specification/postgresql/resource-manager/readme.md
    tag: specification/postgresql/resource-manager/readme.md#tag-package-2020-01-01
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️⚠️[Staging] SDK Track2 Validation: 1 Warnings warning [Detail]
    The following errors/warnings are introduced by current PR:
    Rule Message
    ⚠️ ? "readme":"postgresql/resource-manager/readme.md",
    "tag":"package-2021-06-01-preview",
    "details":"Operation 'WaitStatistics/ListByServer' really should not have a media type (because there should be no body)"
    💬 AutorestCore/Exception "readme":"postgresql/resource-manager/readme.md",
    "tag":"package-2021-06-01-preview",
    "details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0)"
    💬 AutorestCore/Exception "readme":"postgresql/resource-manager/readme.md",
    "tag":"package-2021-06-01-preview",
    "details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"


    The following errors/warnings exist before current PR submission:

    |:speech_balloon: AutorestCore/Exception|"readme":"postgresql/resource-manager/readme.md",
    "tag":"package-2021-06-01-preview",
    "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|

    ️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️[Staging] Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jun 8, 2021

    Swagger Generation Artifacts

    ️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️️✔️[Staging] SDK Breaking Change Tracking succeeded [Detail] [Expand]

    Breaking Changes Tracking

    ️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-rdbms - 8.1.0
    ️✔️azure-sdk-for-go - postgresql/mgmt/2021-06-01/postgresqlflexibleservers - v55.3.0
    ️✔️azure-sdk-for-go - postgresql/mgmt/2020-01-01/postgresql - v55.3.0
    ️✔️azure-sdk-for-go - postgresql/mgmt/2017-12-01/postgresql - v55.3.0
    ️✔️azure-sdk-for-go - preview/postgresql/mgmt/2021-06-01-preview/postgresqlflexibleservers - v55.3.0
    ️✔️azure-sdk-for-go - preview/postgresql/mgmt/2020-11-05-preview/postgresqlflexibleservers - v55.3.0
    ️✔️azure-sdk-for-go - preview/postgresql/mgmt/2020-02-14-preview/postgresqlflexibleservers - v55.3.0
    ️✔️azure-sdk-for-go - preview/postgresql/mgmt/2017-12-01-preview/postgresql - v55.3.0
    ️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 269d6e2. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    • ️✔️track2_azure-mgmt-rdbms [View full logs]  [Release SDK Changes]
      info	[Changelog]
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 269d6e2. SDK Automation 14.0.0
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
      command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
      cmderr	[generate.py] 2021-06-21 04:23:40 INFO [VERSION][Found] current version "com.azure.resourcemanager:azure-resourcemanager-postgresql;1.0.0;1.1.0-beta.1"
      cmderr	[generate.py] 2021-06-21 04:23:40 WARNING [VERSION][Not Implement] set to current version "1.1.0-beta.1" by default
      cmderr	[generate.py] 2021-06-21 04:23:40 INFO autorest --version=3.1.3 --use=@autorest/[email protected] --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/postgresql/azure-resourcemanager-postgresql --java.namespace=com.azure.resourcemanager.postgresql   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL ../azure-rest-api-specs/specification/postgresql/resource-manager/readme.md
      cmderr	[generate.py] 2021-06-21 04:24:23 INFO [CI][Skip] ci.yml already has module azure-resourcemanager-postgresql
      cmderr	[generate.py] 2021-06-21 04:24:23 INFO [POM][Process] dealing with pom.xml
      cmderr	[generate.py] 2021-06-21 04:24:23 INFO [POM][Skip] pom already has module azure-resourcemanager-postgresql
      cmderr	[generate.py] 2021-06-21 04:24:23 INFO [POM][Success] Write to pom.xml
      cmderr	[generate.py] 2021-06-21 04:24:23 INFO [POM][Process] dealing with root pom
      cmderr	[generate.py] 2021-06-21 04:24:23 INFO [POM][Skip] pom already has module sdk/postgresql
      cmderr	[generate.py] 2021-06-21 04:24:23 INFO [POM][Success] Write to root pom
    • ️✔️azure-resourcemanager-postgresql [View full logs]  [Release SDK Changes]
      cmderr	[Inst] 2021-06-21 04:27:47 DEBUG Got artifact_id: azure-resourcemanager-postgresql
      cmderr	[Inst] 2021-06-21 04:27:47 DEBUG Got artifact: pom.xml
      cmderr	[Inst] 2021-06-21 04:27:47 DEBUG Got artifact: azure-resourcemanager-postgresql-1.1.0-beta.1.jar
      cmderr	[Inst] 2021-06-21 04:27:47 DEBUG Match jar package: azure-resourcemanager-postgresql-1.1.0-beta.1.jar
      cmderr	[Inst] 2021-06-21 04:27:47 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/14714/azure-sdk-for-java/azure-resourcemanager-postgresql/azure-resourcemanager-postgresql-1.1.0-beta.1.jar\" -o azure-resourcemanager-postgresql-1.1.0-beta.1.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-postgresql -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-postgresql-1.1.0-beta.1.jar -Dpackaging=jar -DgeneratePom=true
      ```"}
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 269d6e2. SDK Automation 14.0.0
      command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️postgresql/mgmt/2021-06-01/postgresqlflexibleservers [View full logs]  [Release SDK Changes]
      info	[Changelog] This is a new package
    • ️✔️postgresql/mgmt/2020-01-01/postgresql [View full logs]  [Release SDK Changes]
      Only show 18 items here, please refer to log for details.
      info	[Changelog] - New struct `RecoverableServerProperties`
      info	[Changelog] - New struct `RecoverableServerResource`
      info	[Changelog] - New struct `RecoverableServersClient`
      info	[Changelog] - New struct `ServerBasedPerformanceTierClient`
      info	[Changelog] - New struct `ServerParametersClient`
      info	[Changelog] - New struct `ServerParametersListUpdateConfigurationsFuture`
      info	[Changelog] - New struct `ServerSecurityAlertPolicyListResult`
      info	[Changelog] - New struct `ServerSecurityAlertPolicyListResultIterator`
      info	[Changelog] - New struct `ServerSecurityAlertPolicyListResultPage`
      info	[Changelog] - New field `MinStorageMB` in struct `PerformanceTierProperties`
      info	[Changelog] - New field `MaxBackupRetentionDays` in struct `PerformanceTierProperties`
      info	[Changelog] - New field `MinBackupRetentionDays` in struct `PerformanceTierProperties`
      info	[Changelog] - New field `MaxStorageMB` in struct `PerformanceTierProperties`
      info	[Changelog] - New field `MinLargeStorageMB` in struct `PerformanceTierProperties`
      info	[Changelog] - New field `MaxLargeStorageMB` in struct `PerformanceTierProperties`
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 60 additive change(s).
      info	[Changelog]
    • ️✔️postgresql/mgmt/2017-12-01/postgresql [View full logs]  [Release SDK Changes]
      Only show 18 items here, please refer to log for details.
      info	[Changelog] - New struct `RecoverableServerProperties`
      info	[Changelog] - New struct `RecoverableServerResource`
      info	[Changelog] - New struct `RecoverableServersClient`
      info	[Changelog] - New struct `ServerBasedPerformanceTierClient`
      info	[Changelog] - New struct `ServerParametersClient`
      info	[Changelog] - New struct `ServerParametersListUpdateConfigurationsFuture`
      info	[Changelog] - New struct `ServerSecurityAlertPolicyListResult`
      info	[Changelog] - New struct `ServerSecurityAlertPolicyListResultIterator`
      info	[Changelog] - New struct `ServerSecurityAlertPolicyListResultPage`
      info	[Changelog] - New field `MinStorageMB` in struct `PerformanceTierProperties`
      info	[Changelog] - New field `MaxBackupRetentionDays` in struct `PerformanceTierProperties`
      info	[Changelog] - New field `MinBackupRetentionDays` in struct `PerformanceTierProperties`
      info	[Changelog] - New field `MaxStorageMB` in struct `PerformanceTierProperties`
      info	[Changelog] - New field `MinLargeStorageMB` in struct `PerformanceTierProperties`
      info	[Changelog] - New field `MaxLargeStorageMB` in struct `PerformanceTierProperties`
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 60 additive change(s).
      info	[Changelog]
    • ️✔️preview/postgresql/mgmt/2021-06-01-preview/postgresqlflexibleservers [View full logs]  [Release SDK Changes]
      info	[Changelog] This is a new package
    • ️✔️preview/postgresql/mgmt/2020-11-05-preview/postgresqlflexibleservers [View full logs]  [Release SDK Changes]
      info	[Changelog] ### Breaking Changes
      info	[Changelog]
      info	[Changelog] ### New Content
      info	[Changelog]
      info	[Changelog] - New struct `ServerPropertiesPrivateDNSZoneArguments`
      info	[Changelog] - New field `SourceResourceGroupName` in struct `ServerProperties`
      info	[Changelog] - New field `PrivateDNSZoneArguments` in struct `ServerProperties`
      info	[Changelog] - New field `SourceSubscriptionID` in struct `ServerProperties`
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 3 additive change(s).
      info	[Changelog]
    • ️✔️preview/postgresql/mgmt/2020-02-14-preview/postgresqlflexibleservers [View full logs]  [Release SDK Changes]
      info	[Changelog] No exported changes
    • ️✔️preview/postgresql/mgmt/2017-12-01-preview/postgresql [View full logs]  [Release SDK Changes]
      Only show 18 items here, please refer to log for details.
      info	[Changelog] - New struct `RecoverableServerProperties`
      info	[Changelog] - New struct `RecoverableServerResource`
      info	[Changelog] - New struct `RecoverableServersClient`
      info	[Changelog] - New struct `ServerBasedPerformanceTierClient`
      info	[Changelog] - New struct `ServerParametersClient`
      info	[Changelog] - New struct `ServerParametersListUpdateConfigurationsFuture`
      info	[Changelog] - New struct `ServerSecurityAlertPolicyListResult`
      info	[Changelog] - New struct `ServerSecurityAlertPolicyListResultIterator`
      info	[Changelog] - New struct `ServerSecurityAlertPolicyListResultPage`
      info	[Changelog] - New field `MaxStorageMB` in struct `PerformanceTierProperties`
      info	[Changelog] - New field `MinLargeStorageMB` in struct `PerformanceTierProperties`
      info	[Changelog] - New field `MaxLargeStorageMB` in struct `PerformanceTierProperties`
      info	[Changelog] - New field `MinStorageMB` in struct `PerformanceTierProperties`
      info	[Changelog] - New field `MaxBackupRetentionDays` in struct `PerformanceTierProperties`
      info	[Changelog] - New field `MinBackupRetentionDays` in struct `PerformanceTierProperties`
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 60 additive change(s).
      info	[Changelog]
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 269d6e2. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/postgresql/resource-manager/readme.md
    • ️✔️@azure/arm-postgresql [View full logs]  [Release SDK Changes]
      cmderr	[npmPack] loaded rollup.config.js with warnings
      cmderr	[npmPack] (!) Unused external imports
      cmderr	[npmPack] default imported from external module 'rollup' but never used
      cmderr	[npmPack] ./esm/postgreSQLManagementClient.js → ./dist/arm-postgresql.js...
      cmderr	[npmPack] created ./dist/arm-postgresql.js in 511ms
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 269d6e2. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh] WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh] npm WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] npm WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    • ️✔️postgresql [View full logs]  [Release Schema Changes]
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot
    Copy link

    NewApiVersionRequired reason:

    A service’s API is a contract with customers and is represented by using the api-version query parameter. Changes such as adding an optional property to a request/response or introducing a new operation is a change to the service’s contract and therefore requires a new api-version value. This is critically important for documentation, client libraries, and customer support.

    EXAMPLE: if a customer calls a service in the public cloud using api-version=2020-07-27, the new property or operation may exist but if they call the service in a government cloud, air-gapped cloud, or Azure Stack Hub cloud using the same api-version, the property or operation may not exist. Because there is no clear relationship between the service api-version and the new property/operation, customers can’t trust the documentation and Azure customer have difficulty helping customers diagnose issues. In addition, each client library version documents the service version it supports. When an optional property or new operation is added to a service and its Swagger, new client libraries must be produced to expose this functionality to customers. Without updating the api-version, it is unclear to customers which version of a client library supports these new features.

    @openapi-workflow-bot
    Copy link

    Hi, @dsgouda your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board([email protected]). cc @PhoenixHe-msft

    @openapi-workflow-bot openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jun 10, 2021
    @j5lim j5lim added ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jun 10, 2021
    Copy link
    Contributor Author

    @dsgouda dsgouda left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Tagging @ssen-msft for some feedback

    @dsgouda
    Copy link
    Contributor Author

    dsgouda commented Jun 16, 2021

    /azp

    @azure-pipelines
    Copy link

    Supported commands
    • help:
      • Get descriptions, examples and documentation about supported commands
      • Example: help "command_name"
    • list:
      • List all pipelines for this repository using a comment.
      • Example: "list"
    • run:
      • Run all pipelines or specific pipelines for this repository using a comment. Use this command by itself to trigger all related pipelines, or specify specific pipelines to run.
      • Example: "run" or "run pipeline_name, pipeline_name, pipeline_name"
    • where:
      • Report back the Azure DevOps orgs that are related to this repository and org
      • Example: "where"

    See additional documentation.

    @dsgouda
    Copy link
    Contributor Author

    dsgouda commented Jun 16, 2021

    /azp run

    @azure-pipelines
    Copy link

    Commenter does not have sufficient privileges for PR 14714 in repo Azure/azure-rest-api-specs

    @dsgouda
    Copy link
    Contributor Author

    dsgouda commented Jun 17, 2021

    @PhoenixHe-msft PTAL I have addressed all the comments

    @PhoenixHe-NV
    Copy link
    Contributor

    /azp run

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @PhoenixHe-NV
    Copy link
    Contributor

    @dsgouda Please address the lint issue.

    @PhoenixHe-NV PhoenixHe-NV merged commit 269d6e2 into Azure:master Jun 21, 2021
    This was referenced Jun 21, 2021
    asager pushed a commit to asager/azure-rest-api-specs that referenced this pull request Jun 24, 2021
    * Adding iperf APIs
    
    * Addressing review comments
    
    * Addressing PR comments
    
    * Removing APIs unimplemented in Sterling
    
    * Fixing resource schemas
    
    * Fixing linting errors
    mkarmark pushed a commit to mkarmark/azure-rest-api-specs that referenced this pull request Jul 21, 2021
    * Adding iperf APIs
    
    * Addressing review comments
    
    * Addressing PR comments
    
    * Removing APIs unimplemented in Sterling
    
    * Fixing resource schemas
    
    * Fixing linting errors
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    5 participants