Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync sql 2021 05 01 with main branch #16236

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
7a1bad6
Update comment.yml for publish pr (#16166)
JackTn Sep 27, 2021
2862eb6
Bump dependencies (#16170)
zhenglaizhang Sep 27, 2021
06a8e3f
remove submodule (#16171)
leniatgh Sep 27, 2021
5dbc2b6
add azure-resource-manager-schema to servicelinker (#16176)
najian Sep 27, 2021
2b586b9
Update pr assignment config (#16175)
raych1 Sep 27, 2021
bee7248
[Synapse] - fix scheme for Artifacts and update readme to include KQL…
idear1203 Sep 27, 2021
b9aa587
fix (#16164)
msyyc Sep 27, 2021
4c8162b
Remove requirement of identity field in the request for TURN. (#15966)
AriZavala2 Sep 27, 2021
a8e6d89
change api version in readme for sdk release (#16187)
PingZhu2232 Sep 28, 2021
a5f8ef6
[Search] Rename types for better SDK code (#16039)
Mohit-Chakraborty Sep 28, 2021
0e16aa6
fix validStreamingUnits (#16143)
roslynlu Sep 29, 2021
9f70268
Fix schemas readme files (#16207)
leniatgh Sep 29, 2021
7919a86
add resourcemanager in module-name (#16206)
Alancere Sep 29, 2021
98e17cd
Minor description update for createorupdate & update slot (#15457)
edwin-msft Sep 29, 2021
9dcd83c
[Hub Generated] Review request for Microsoft.Security to add version …
dochollidayxx Sep 29, 2021
d23ad89
Yifanzhou/api version change (#16191)
yifan-zhou922 Sep 29, 2021
9c56101
change read-only property (#16209)
parvsaxena Sep 29, 2021
0ce98d9
Update account.json - make CollectionReferece type writable (#16208)
hvermis Sep 29, 2021
b6f4a61
Fixed an event name typo in its description. (#16227)
xuepingd Sep 29, 2021
5567317
Introduce new API version for Microsoft.ProviderHub 2021-09-01-previe…
laxmankumar12 Sep 30, 2021
c985283
fluidrelay_readme_config (#16192)
RAY-316 Sep 30, 2021
0685b1b
Add community gallery proxy resource (#16043)
kangsun-ctrl Sep 30, 2021
21ebd57
[Hub Generated] Public private branch 'dev-storagecache-Microsoft.Sto…
brpanask Sep 30, 2021
350d1c0
Fix S360 bugs for swagger FSPG 2020-02-14-preview, 2021-06-01-preview…
xunsun-commits Sep 30, 2021
fdf061b
Add email reminder when PR makes changes in Synapse (#16116)
wanyang7 Sep 30, 2021
af463c3
ServiceBus add batch tag (#16229)
Alancere Sep 30, 2021
03c6ecc
add code owner to synapse (#16230)
wanyang7 Sep 30, 2021
2ce9153
[Datafactory] Power Query model changes for multiple queries (#16158)
soma-ms Sep 30, 2021
8117acc
[Synapse] Add release tag for management SDK Oct. release (#16213)
wanyang7 Sep 30, 2021
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .github/comment.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
- Azure/azure-rest-api-specs-pr
variables:
openapiHub: https://portal.azure-devex-tools.com
to: Azure/azure-rest-api-specs/master
to: Azure/azure-rest-api-specs/main
label: Approved-OkToMerge
onLabeledComments: "Hi @${PRAuthor},Your PR is approved. Congratulations. </br> <li> Since your PR is in private repo (azure-rest-api-specs-pr), there won’t be PR merge. If you want to publish the PR to public repo (Azure/azure-rest-api-specs) and get it merged, pls use [OpenAPIHub Publish PR](${openapiHub}/tools/publishpullrequest?pr=${owner}/${repo}/${PRNumber}&to=${to}).</li> <li> For further guidance on how to proceed. Please refer to this [wiki](https://dev.azure.com/azure-sdk/internal/_wiki/wikis/internal.wiki/205/RP-Scenarios-to-Contribute-to-Swagger?anchor=**public-repository-vs.-private-repository**)</li>"

Expand All @@ -37,9 +37,9 @@
Hi @${PRAuthor}, Your PR has some issues. Please fix the CI sequentially by following the order of `Avocado, semantic validation, model validation, breaking change, lintDiff`.
<table><tr><th>Task</th><th>How to fix</th><th>Priority</th><th>Support (Microsoft alias)</th></tr>
<tr><td>Avocado</td><td>[Fix-Avocado](https://github.com/Azure/avocado)</td><td>High</td><td>ruowan</td></tr>
<tr><td>Semantic validation</td><td>[Fix-SemanticValidation-Error](https://github.com/Azure/azure-rest-api-specs/blob/master/documentation/ci-fix.md#semantic-validation)</td><td>High</td><td>raychen, jianyxi</td></tr>
<tr><td>Model validation</td><td>[Fix-ModelValidation-Error](https://github.com/Azure/azure-rest-api-specs/blob/master/documentation/ci-fix.md#model-validation)</td><td>High</td><td>raychen,jianyxi</td></tr>
<tr><td>LintDiff</td><td>[Fix-LintDiff](https://github.com/Azure/azure-rest-api-specs/blob/master/documentation/ci-fix.md#linter-validation)</td><td>high</td><td>jianyxi, ruoxuan</td></tr></table>
<tr><td>Semantic validation</td><td>[Fix-SemanticValidation-Error](https://github.com/Azure/azure-rest-api-specs/blob/main/documentation/ci-fix.md#semantic-validation)</td><td>High</td><td>raychen, jianyxi</td></tr>
<tr><td>Model validation</td><td>[Fix-ModelValidation-Error](https://github.com/Azure/azure-rest-api-specs/blob/main/documentation/ci-fix.md#model-validation)</td><td>High</td><td>raychen,jianyxi</td></tr>
<tr><td>LintDiff</td><td>[Fix-LintDiff](https://github.com/Azure/azure-rest-api-specs/blob/main/documentation/ci-fix.md#linter-validation)</td><td>high</td><td>jianyxi, ruoxuan</td></tr></table>
If you need further help, please feedback via [swagger feedback](https://aka.ms/swaggerfeedback)."

- rule:
Expand All @@ -48,7 +48,7 @@
openapiHub: https://portal.azure-devex-tools.com
keywords:
- "I have reviewed the [documentation](https://aka.ms/ameonboard) for the workflow."
onOpenedComments: "Hi, @${PRAuthor} Thanks for your PR. I am workflow bot for review process. Here are some small tips. </br> <li> Please ensure to do self-check against checklists in first PR comment.</li> <li> PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging. </li> <li> For specs comparison cross API versions, Use [API Specs Comparison Report Generator](${openapiHub}/tools/diff?pr=${owner}/${repo}/${PRNumber})</li> <li> If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. [How to fix?](https://github.com/Azure/azure-rest-api-specs/blob/master/documentation/ci-fix.md)</li></br> Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]"
onOpenedComments: "Hi, @${PRAuthor} Thanks for your PR. I am workflow bot for review process. Here are some small tips. </br> <li> Please ensure to do self-check against checklists in first PR comment.</li> <li> PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging. </li> <li> For specs comparison cross API versions, Use [API Specs Comparison Report Generator](${openapiHub}/tools/diff?pr=${owner}/${repo}/${PRNumber})</li> <li> If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. [How to fix?](https://github.com/Azure/azure-rest-api-specs/blob/main/documentation/ci-fix.md)</li></br> Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]"

- rule:
type: PROpen
Expand Down
9 changes: 2 additions & 7 deletions .github/pull_request_assignment.yml
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@
- "specification/network/**"
reviewers:
- lirenhe
- raych1


- rule:
Expand All @@ -68,7 +69,7 @@


- rule:
paths: "specification/@(resources|powerplatform|appplatform|deviceupdate)/**"
paths: "specification/@(resources|powerplatform|appplatform|deviceupdate|servicelinker)/**"
reviewers:
- raych1

Expand Down Expand Up @@ -145,12 +146,6 @@
reviewers:
- weidongxu-microsoft

- rule:
paths:
- "specification/servicelinker/**"
reviewers:
- raych1

- rule:
paths:
- "specification/keyvault/**"
Expand Down
15 changes: 15 additions & 0 deletions .github/sla.yml
Original file line number Diff line number Diff line change
Expand Up @@ -84,3 +84,18 @@
to: ${AUTHOR}
cc:
- [email protected]

- scheduleTask:
action: sendEmail
scope: pull_request
name: "send email for synapse PR"
trigger:
- path
args:
message: '<p>Dear Synapse Swagger reviewers,</p><p>Please check the PR ${URL} . You receive the email because the PR is making changes in the Synapse&#39;s path of the Azure REST Api Specs repository.</p><p>This PR need to be reviewed, please feel free to leave comments.</p><p>DO NOT REPLY: This email was automatically sent. Please send an email to&nbsp;<a href="mailto:[email protected]">[email protected]</a>&nbsp;if you have any questions.</p>'
targetPaths:
- "specification/synapse/**"
subject: "[Action Required] Please review the PR ${URL}"
to: [email protected]
cc:
- ${AUTHOR}
2 changes: 1 addition & 1 deletion CODEOWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@
/specification/storsimple8000series/ @manaas-microsoft
/specification/streamanalytics/ @atpham256
/specification/subscriptions/ @navysingla
/specification/synapse/ @idear1203
/specification/synapse/ @idear1203 @wonner
/specification/timeseriesinsights/ @sandshadow
/specification/trafficmanager/ @allencal @hrkulkarmsft
/specification/web/ @naveedaz @Azure/azure-app-service-control-plane
Expand Down
1 change: 0 additions & 1 deletion azure-rest-api-specs
Submodule azure-rest-api-specs deleted from c6c46a
Loading