Databoxedge march release #18374
Merged
Databoxedge march release #18374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 23, 2022 22:51
|
Hi, @amishra31 Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
|
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Validation Report
|
| Rule | Message |
|---|---|
| Per the Noun_Verb convention for Operation Ids, the noun 'DeviceCapacityInfo' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.DataBoxEdge/stable/2022-03-01/databoxedge.json#L789 |
|
| OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'DeviceCapacityInfoModel'. Consider using the plural form of 'DeviceCapacityInfo' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.DataBoxEdge/stable/2022-03-01/databoxedge.json#L789 |
|
| OperationId should contain the verb: 'devicecapacitycheck' in:'DeviceCapacityCheck_CheckResourceCreationFeasibility'. Consider updating the operationId Location: Microsoft.DataBoxEdge/stable/2022-03-01/databoxedge.json#L723 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isFeasible Location: Microsoft.DataBoxEdge/stable/2022-03-01/databoxedge.json#L9730 |
The following errors/warnings exist before current PR submission:
Only 30 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
|
The delete operation is defined without a 200 or 204 error response implementation,please add it.' Location: Microsoft.DataBoxEdge/stable/2022-03-01/databoxedge.json#L3161 |
|
The delete operation is defined without a 200 or 204 error response implementation,please add it.' Location: Microsoft.DataBoxEdge/stable/2022-03-01/databoxedge.json#L3407 |
|
The parameters:deviceName,resourceGroupName should be kept in the same order as they present in the path. Location: Microsoft.DataBoxEdge/stable/2022-03-01/databoxedge.json#L189 |
|
The parameters:deviceName,resourceGroupName should be kept in the same order as they present in the path. Location: Microsoft.DataBoxEdge/stable/2022-03-01/databoxedge.json#L236 |
|
The parameters:deviceName,resourceGroupName should be kept in the same order as they present in the path. Location: Microsoft.DataBoxEdge/stable/2022-03-01/databoxedge.json#L292 |
|
The parameters:deviceName,resourceGroupName should be kept in the same order as they present in the path. Location: Microsoft.DataBoxEdge/stable/2022-03-01/databoxedge.json#L340 |
|
The parameters:deviceName,resourceGroupName should be kept in the same order as they present in the path. Location: Microsoft.DataBoxEdge/stable/2022-03-01/databoxedge.json#L395 |
|
The parameters:deviceName,name,resourceGroupName should be kept in the same order as they present in the path. Location: Microsoft.DataBoxEdge/stable/2022-03-01/databoxedge.json#L444 |
|
The parameters:deviceName,resourceGroupName should be kept in the same order as they present in the path. Location: Microsoft.DataBoxEdge/stable/2022-03-01/databoxedge.json#L497 |
|
The parameters:deviceName,name,resourceGroupName should be kept in the same order as they present in the path. Location: Microsoft.DataBoxEdge/stable/2022-03-01/databoxedge.json#L546 |
|
The parameters:deviceName,name,resourceGroupName should be kept in the same order as they present in the path. Location: Microsoft.DataBoxEdge/stable/2022-03-01/databoxedge.json#L597 |
|
The parameters:deviceName,name,resourceGroupName should be kept in the same order as they present in the path. Location: Microsoft.DataBoxEdge/stable/2022-03-01/databoxedge.json#L661 |
|
The parameters:deviceName,resourceGroupName should be kept in the same order as they present in the path. Location: Microsoft.DataBoxEdge/stable/2022-03-01/databoxedge.json#L830 |
|
The parameters:deviceName,resourceGroupName should be kept in the same order as they present in the path. Location: Microsoft.DataBoxEdge/stable/2022-03-01/databoxedge.json#L874 |
|
The parameters:deviceName,resourceGroupName should be kept in the same order as they present in the path. Location: Microsoft.DataBoxEdge/stable/2022-03-01/databoxedge.json#L933 |
|
The parameters:deviceName,resourceGroupName should be kept in the same order as they present in the path. Location: Microsoft.DataBoxEdge/stable/2022-03-01/databoxedge.json#L977 |
|
The parameters:deviceName,resourceGroupName should be kept in the same order as they present in the path. Location: Microsoft.DataBoxEdge/stable/2022-03-01/databoxedge.json#L1036 |
|
The parameters:deviceName,resourceGroupName should be kept in the same order as they present in the path. Location: Microsoft.DataBoxEdge/stable/2022-03-01/databoxedge.json#L1083 |
|
The parameters:deviceName,resourceGroupName should be kept in the same order as they present in the path. Location: Microsoft.DataBoxEdge/stable/2022-03-01/databoxedge.json#L1129 |
|
The parameters:deviceName,resourceGroupName should be kept in the same order as they present in the path. Location: Microsoft.DataBoxEdge/stable/2022-03-01/databoxedge.json#L1175 |
|
The parameters:deviceName,name,resourceGroupName should be kept in the same order as they present in the path. Location: Microsoft.DataBoxEdge/stable/2022-03-01/databoxedge.json#L1222 |
|
The parameters:deviceName,resourceGroupName should be kept in the same order as they present in the path. Location: Microsoft.DataBoxEdge/stable/2022-03-01/databoxedge.json#L1275 |
|
The parameters:deviceName,resourceGroupName should be kept in the same order as they present in the path. Location: Microsoft.DataBoxEdge/stable/2022-03-01/databoxedge.json#L1321 |
|
The parameters:deviceName,name,resourceGroupName should be kept in the same order as they present in the path. Location: Microsoft.DataBoxEdge/stable/2022-03-01/databoxedge.json#L1370 |
|
The parameters:deviceName,resourceGroupName should be kept in the same order as they present in the path. Location: Microsoft.DataBoxEdge/stable/2022-03-01/databoxedge.json#L1423 |
|
The parameters:deviceName,resourceGroupName should be kept in the same order as they present in the path. Location: Microsoft.DataBoxEdge/stable/2022-03-01/databoxedge.json#L1472 |
|
The parameters:deviceName,resourceGroupName should be kept in the same order as they present in the path. Location: Microsoft.DataBoxEdge/stable/2022-03-01/databoxedge.json#L1516 |
|
The parameters:deviceName,resourceGroupName should be kept in the same order as they present in the path. Location: Microsoft.DataBoxEdge/stable/2022-03-01/databoxedge.json#L1573 |
|
The parameters:deviceName,resourceGroupName should be kept in the same order as they present in the path. Location: Microsoft.DataBoxEdge/stable/2022-03-01/databoxedge.json#L1623 |
|
The parameters:deviceName,resourceGroupName should be kept in the same order as they present in the path. Location: Microsoft.DataBoxEdge/stable/2022-03-01/databoxedge.json#L1669 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️❌~[Staging] ApiReadinessCheck: 1 Errors, 0 Warnings failed [Detail]
| Rule | Message |
|---|---|
|
"code: InvalidResourceType, message: The resource type 'operations' could not be found in the namespace 'Microsoft.DataBoxEdge' for api version '2022-03-01'. The supported api-versions are '2017-09-01, 2018-07-01, 2019-03-01, 2019-07-01, 2019-08-01, 2020-01-01, 2020-05-01-preview, 2020-06-01, 2020-07-01, 2020-07-01-preview, 2020-09-01, 2020-09-01-preview, 2020-12-01, 2021-02-01-preview, 2021-02-01, 2021-06-01, 2021-06-01-preview'." |
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️⚠️Cross-Version Breaking Changes: 2 Warnings warning [Detail]
- Compared Swaggers (Based on Oad v0.9.3)
- current:stable/2022-03-01/databoxedge.json compared with base:stable/2021-06-01/databoxedge.json
- current:stable/2022-03-01/databoxedge.json compared with base:preview/2021-06-01-preview/databoxedge.json
| Rule | Message |
|---|---|
| The new version has new required property 'contactInformation' that was not found in the old version. New: Microsoft.DataBoxEdge/stable/2022-03-01/databoxedge.json#L7884:9 Old: Microsoft.DataBoxEdge/preview/2021-06-01-preview/databoxedge.json#L7331:9 |
|
| The new version has new required property 'contactInformation' that was not found in the old version. New: Microsoft.DataBoxEdge/stable/2022-03-01/databoxedge.json#L7912:5 Old: Microsoft.DataBoxEdge/preview/2021-06-01-preview/databoxedge.json#L7358:5 |
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️SDK Track2 Validation succeeded [Detail] [Expand]
Validation passes for SDKTrack2Validation
- The following tags are being changed in this PR
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
Swagger Generation Artifacts
|
This was referenced Mar 23, 2022
added 2 commits
March 24, 2022 10:17
openapi-workflow-bot
bot
added
the
WaitForARMFeedback
|
Hi, @amishra31 your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board([email protected]). |
added 2 commits
March 24, 2022 12:30
|
Hey, my changes for adding new API version are done. Could the team please review? @lirenhe tagging you here as unable to reach you on teams. |
pilor
reviewed
Mar 24, 2022
...cation/databoxedge/resource-manager/Microsoft.DataBoxEdge/stable/2022-03-01/databoxedge.json
Outdated
Show resolved
Hide resolved
...cation/databoxedge/resource-manager/Microsoft.DataBoxEdge/stable/2022-03-01/databoxedge.json
Outdated
Show resolved
Hide resolved
...cation/databoxedge/resource-manager/Microsoft.DataBoxEdge/stable/2022-03-01/databoxedge.json
Show resolved
Hide resolved
pilor
added
ARMChangesRequested
pilor
added
ARMSignedOff
|
Hi @lirenhe, seems like SDK for Js looks like an infra problem. In swagger pipeline I can see a memory issue error. Could you please check? I can see the same error when I check the swagger for previous api versions also. We want to go ahead with the release so are on a tight schedule. |
lirenhe
approved these changes
Mar 30, 2022
The JS SDK should be fine and here is the PR for JS SDK AzureSDKAutomation/azure-sdk-for-js#8263 |
This was referenced Mar 30, 2022
[ReleasePR track2_azure-mgmt-databoxedge] Databoxedge march release
Azure/azure-sdk-for-python#19754
Closed
25 tasks
FredericHeem
pushed a commit
to grucloud/azure-rest-api-specs
that referenced
this pull request
May 16, 2022
* Initial Commit * 2022-03-01 * Fix Breaking Changes * Revert Readonly properties * Add capacity Name * Run Prettier Fix * Address ARM review comments * Reorder Swagger * Fix Delete call * Restore long running op * Enrich example Co-authored-by: Abhishek Mishra <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Add a changelog entry for this PR by answering the following questions:
-March End.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
-[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.