Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yuliu2/add purview configuration #18858

Merged
merged 12 commits into from
May 11, 2022
Merged

Yuliu2/add purview configuration #18858

Show file tree
Hide file tree
Changes from 11 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
f6fe18b
Merge pull request #3 from Azure/master
harics24 Mar 19, 2021
67c4abd
Merge branch 'Azure:master' into master
harics24 May 13, 2021
87a694d
Defining the APIs for the new NSP resource
May 17, 2021
f5dcf02
Merge branch 'Azure:master' into master
harics24 May 17, 2021
204f5f9
Merge branch 'Azure:master' into master
harics24 Jul 15, 2021
248d5e9
Merge branch 'Azure:master' into master
harics24 Aug 5, 2021
a18974f
Merge branch 'master' into master
harics24 Feb 27, 2022
64ce79a
Add PurviewConfiguration property in ADF
liuyu1981831m Apr 29, 2022
2567734
Fix discriminator
liuyu1981831m Apr 29, 2022
b8c2489
Remove discriminator
liuyu1981831m Apr 29, 2022
abe3a80
Update datafactory.json
liuyu1981831m May 6, 2022
53f906a
Rename PurviewConfiguration
liuyu1981831m May 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions ...ion/datafactory/resource-manager/Microsoft.DataFactory/stable/2018-06-01/datafactory.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4983,6 +4983,16 @@
"type": "object"
}
},
"FactoryPurviewConfiguration": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please keep this property name the same as in Synapse as well: "PurviewConfiguration".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

"description": "Factory's Purview configuration.",
"type": "object",
"properties": {
"purviewResourceId": {
"description": "Purview resource id.",
"type": "string"
}
}
},
"FactoryRepoConfiguration": {
"description": "Factory's git repo information.",
"type": "object",
Expand Down Expand Up @@ -5190,6 +5200,10 @@
"type": "string",
"readOnly": true
},
"purviewConfiguration": {
"$ref": "#/definitions/FactoryPurviewConfiguration",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep the same as in Synapse

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

"description": "Purview information of the factory."
},
"repoConfiguration": {
"$ref": "#/definitions/FactoryRepoConfiguration",
"description": "Git repo information of the factory."
Expand Down
3 changes: 3 additions & 0 deletions ...tory/resource-manager/Microsoft.DataFactory/stable/2018-06-01/examples/Factories_Get.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,9 @@
"provisioningState": "Succeeded",
"createTime": "2018-06-19T05:41:50.0041314Z",
"version": "2018-06-01",
"purviewConfiguration": {
"purviewResourceId": "/subscriptions/12345678-1234-1234-1234-12345678abc/resourceGroups/exampleResourceGroup/providers/Microsoft.Purview/accounts/examplePurview"
},
"repoConfiguration": {
"type": "FactoryVSTSConfiguration",
"projectName": "project",
Expand Down
6 changes: 6 additions & 0 deletions ...ory/resource-manager/Microsoft.DataFactory/stable/2018-06-01/examples/Factories_List.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,9 @@
"provisioningState": "Succeeded",
"createTime": "2018-06-19T05:41:50.0041314Z",
"version": "2018-06-01",
"purviewConfiguration": {
"purviewResourceId": "/subscriptions/12345678-1234-1234-1234-12345678abc/resourceGroups/exampleResourceGroup/providers/Microsoft.Purview/accounts/examplePurview"
},
"repoConfiguration": {
"type": "FactoryVSTSConfiguration",
"projectName": "project",
Expand Down Expand Up @@ -181,6 +184,9 @@
"provisioningState": "Succeeded",
"createTime": "2018-06-19T05:41:50.0041314Z",
"version": "2018-06-01",
"purviewConfiguration": {
"purviewResourceId": "/subscriptions/12345678-1234-1234-1234-12345678abc/resourceGroups/exampleResourceGroup/providers/Microsoft.Purview/accounts/examplePurview"
},
"repoConfiguration": {
"type": "FactoryVSTSConfiguration",
"projectName": "project",
Expand Down