Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding support for Auto LD #19108

Merged
merged 1 commit into from
May 24, 2022
Merged

Adding support for Auto LD #19108

merged 1 commit into from
May 24, 2022

Conversation

kayousef-zz
Copy link

@kayousef-zz kayousef-zz commented May 17, 2022 •
edited by wangyuantao
Loading

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. If updating an existing version, please select the specific language SDKs and CLIs that must be refreshed after the swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No refresh required for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following appy to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.

  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in a stable version
  • Removing properties in a stable version
  • Removing API version(s) in a stable version
  • Updating API in a stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@kayousef-zz kayousef-zz requested review from assafi, ChongTang, annatisch, heaths and a team as code owners May 17, 2022 16:33
@kayousef-zz kayousef-zz requested review from scgbear and weidongxu-microsoft and removed request for a team May 17, 2022 16:33
@openapi-workflow-bot
Copy link

Hi, @kayousef Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

    • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented May 17, 2022 •
    edited
    Loading

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️️✔️LintDiff succeeded [Detail] [Expand] 
    Validation passes for LintDiff.
    ️️✔️Avocado succeeded [Detail] [Expand] 
    Validation passes for Avocado.
    ️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand] 
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand] 
    Validation passes for SemanticValidation.
    ️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand] 
    There is no credential detected.
    ️️✔️PoliCheck succeeded [Detail] [Expand] 
    Validation passed for PoliCheck.
    ️️✔️SDK Track2 Validation succeeded [Detail] [Expand] 
    Validation passes for SDKTrack2Validation
    ️️✔️PrettierCheck succeeded [Detail] [Expand] 
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand] 
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand] 
    Validation passes for Lint(RPaaS).
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented May 17, 2022 •
    edited
    Loading

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
    ️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

    Breaking Changes Tracking

    ️❌ azure-sdk-for-net failed [Detail]
    • ❌Failed [Logs]Release - Generate from f0b25f5. SDK Automation 14.0.0 
      warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-6.0
command	autorest --version=2.0.4421 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --csharp-sdks-folder=/mnt/vss/_work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/dev/cognitiveservices/data-plane/Language/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] FATAL: System.InvalidOperationException: Swagger document contains two or more x-ms-enum extensions with the same name 'StringIndexType' and different values: TextElements_v8,UnicodeCodePoint,Utf16CodeUnit vs. Utf16CodeUnit
cmderr	[Autorest]    at AutoRest.Modeler.ObjectBuilder.BuildServiceType(String serviceTypeName, Boolean required) in /opt/vsts/work/1/s/src/ObjectBuilder.cs:line 150
cmderr	[Autorest]    at AutoRest.Modeler.SchemaBuilder.ParentBuildServiceType(String serviceTypeName, Boolean required) in /opt/vsts/work/1/s/src/SchemaBuilder.cs:line 217
cmderr	[Autorest]    at AutoRest.Modeler.SchemaBuilder.BuildServiceType(String serviceTypeName, Boolean required) in /opt/vsts/work/1/s/src/SchemaBuilder.cs:line 48
cmderr	[Autorest]    at AutoRest.Modeler.SwaggerModeler.BuildCompositeTypes() in /opt/vsts/work/1/s/src/SwaggerModeler.cs:line 348
cmderr	[Autorest]    at AutoRest.Modeler.SwaggerModeler.Build(ServiceDefinition serviceDefinition) in /opt/vsts/work/1/s/src/SwaggerModeler.cs:line 66
cmderr	[Autorest]    at AutoRest.Modeler.Program.<ProcessInternal>d__2.MoveNext() in /opt/vsts/work/1/s/src/Program.cs:line 60
cmderr	[Autorest] --- End of stack trace from previous location where exception was thrown ---
cmderr	[Autorest]    at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
cmderr	[Autorest]    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
cmderr	[Autorest]    at NewPlugin.<Process>d__15.MoveNext()
cmderr	[Autorest] FATAL: csharp/imodeler1 - FAILED
cmderr	[Autorest] FATAL: Error: Plugin imodeler1 reported failure.
cmderr	[Autorest]   Error: Plugin imodeler1 reported failure.
error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-net]: autorest
warn	Skip package processing as generation is failed
    ️❌ azure-sdk-for-python failed [Detail]
    • ❌Failed [Logs]Release - Generate from f0b25f5. SDK Automation 14.0.0 
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh]
cmderr	[automation_generate.sh] npm notice New minor version of npm available! 8.5.5 -> 8.10.0
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v8.10.0>
cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
cmderr	[automation_generate.sh] npm notice
cmdout	[automation_generate.sh] [Autorest] There is a new version of AutoRest available (3.6.1).
cmdout	[automation_generate.sh] [Autorest]  > You can install the newer version with with npm install -g autorest@latest
cmdout	[automation_generate.sh] [Autorest]
cmdout	[automation_generate.sh] [Autorest] SourceMapConsumer.initialize is a no-op when running in node.js
cmdout	[automation_generate.sh] [Autorest] info    |    Loading AutoRest core      '/home/cloudtest/.autorest/@[email protected]/nodemodules/@autorest/core/dist' (3.7.2)
cmdout	[automation_generate.sh] [Autorest] warning | DeprecatedConfig | Using directive.0.suppress which is deprecated and will be removed in the future.
cmdout	[automation_generate.sh] [Autorest] warning | DeprecatedConfig | Using directive.0.suppress which is deprecated and will be removed in the future.
cmdout	[automation_generate.sh] [Autorest] warning | PreNamer/DeduplicateName | Deduplicating schema name: 'ConfusionMatrixCell' -> 'ConfusionMatrixCellAutoGenerated'
cmdout	[automation_generate.sh] [Autorest] warning | PreNamer/DeduplicateName | Deduplicating schema name: 'EntityEvaluationSummary' -> 'EntityEvaluationSummaryAutoGenerated'
cmdout	[automation_generate.sh] [Autorest] error   | Duplicate object schemas with 'JobState' name  detected.
cmdout	[automation_generate.sh] [Autorest] error   | Duplicate object schemas with 'TaskState' name  detected.
cmdout	[automation_generate.sh] [Autorest] fatal   | Error: 2 errors occured -- cannot continue.
cmdout	[automation_generate.sh] [Autorest] fatal   | Process() cancelled due to failure
cmdout	[automation_generate.sh] [Autorest] error   |   Error: Plugin checker reported failure.
cmdout	[automation_generate.sh] [Autorest]/mnt/vss/_work/1/s/azure-sdk-for-python_tmp/venv-sdk/auto_temp.json does not exist!!!Error happened during codegen
error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-python]: sh scripts/automation_generate.sh
warn	Skip package processing as generation is failed
    Posted by Swagger Pipeline | How to fix these errors?

    heaths
    heaths reviewed May 17, 2022
    View reviewed changes
    Copy link
    Member

    @heaths heaths left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    One open question, but otherwise LGTM.

    @heaths
    Copy link
    Member

    heaths commented May 24, 2022

    @lmazuel the only checks failures are the duplicate symbol issue. Can you or @weshaggard force-merge this?

    @lmazuel lmazuel merged commit f0b25f5 into main May 24, 2022
    @lmazuel lmazuel deleted the kayousef/language/july/AutoLD branch May 24, 2022 00:09
    @czubair czubair added the API Review Scoping This is an issue that will track work on a specific set of API changes. label May 25, 2022
    @czubair czubair linked an issue May 25, 2022 that may be closed by this pull request
    [Language - AutoLD Feature] #19212
    Closed
    @czubair czubair added the APIStewardshipBoard-SignedOff The Azure API Stewardship team has reviewed and approved the changes. label May 25, 2022
    gargankit-microsoft pushed a commit that referenced this pull request May 26, 2022
    @kayousef @gargankit-microsoft
    Adding support for Auto LD (#19108)
    5921378
    @deyaaeldeen
    Copy link
    Member

    Is there a reason why auto LD is not added for healthcare tasks?

    @kayousef-zz
    Copy link
    Author

    Is there a reason why auto LD is not added for healthcare tasks?

    TA4H only supported English until very recent time

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @deyaaeldeen deyaaeldeen deyaaeldeen left review comments

    @heaths heaths heaths approved these changes

    @assafi assafi Awaiting requested review from assafi

    @ChongTang ChongTang Awaiting requested review from ChongTang

    @annatisch annatisch Awaiting requested review from annatisch annatisch is a code owner

    @scgbear scgbear Awaiting requested review from scgbear scgbear is a code owner automatically assigned from Azure/api-stewardship-board

    @weidongxu-microsoft weidongxu-microsoft Awaiting requested review from weidongxu-microsoft weidongxu-microsoft is a code owner automatically assigned from Azure/api-stewardship-board

    Assignees

    @akning-ms akning-ms

    Labels
    API Review Scoping This is an issue that will track work on a specific set of API changes. APIStewardshipBoard-SignedOff The Azure API Stewardship team has reviewed and approved the changes. Cognitive - Language
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.

    [Language - AutoLD Feature]
    8 participants
    @kayousef-zz @heaths @deyaaeldeen @lmazuel @akning-ms @czubair @mikekistler @kayousef