Dev sqlvirtualmachine microsoft.sql virtual machine 2022 02 01 #19471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ew/2021-11-01-preview to version 2022-02-01
|
Hi, @shiva08 Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
Swagger Validation Report
|
| Rule | Message |
|---|---|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isLpimEnabled Location: Microsoft.SqlVirtualMachine/stable/2022-02-01/sqlvm.json#L2126 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isIfiEnabled Location: Microsoft.SqlVirtualMachine/stable/2022-02-01/sqlvm.json#L2130 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: persistFolder Location: Microsoft.SqlVirtualMachine/stable/2022-02-01/sqlvm.json#L2182 |
The following errors/warnings exist before current PR submission:
| Rule | Message |
|---|---|
|
The response schema of operations API '/providers/Microsoft.SqlVirtualMachine/operations' does not match the ARM specification. Please standardize the schema. Location: Microsoft.SqlVirtualMachine/stable/2022-02-01/sqlvm.json#L241 |
|
Missing identifier id in array item property Location: Microsoft.SqlVirtualMachine/stable/2022-02-01/sqlvm.json#L987 |
|
Missing identifier id in array item property Location: Microsoft.SqlVirtualMachine/stable/2022-02-01/sqlvm.json#L1227 |
| The child tracked resource, 'availabilityGroupListeners' with immediate parent 'SqlVirtualMachineGroup', must have a list by immediate parent operation. Location: Microsoft.SqlVirtualMachine/stable/2022-02-01/sqlvm.json#L1184 |
|
| Guid used in model definition 'ResourceIdentity' for property 'principalId'. Usage of Guid is not recommanded. If GUIDs are absolutely required in your service, please get sign off from the Azure API review board. Location: Microsoft.SqlVirtualMachine/stable/2022-02-01/sqlvm.json#L1577 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: createDefaultAvailabilityGroupIfNotExist Location: Microsoft.SqlVirtualMachine/stable/2022-02-01/sqlvm.json#L1002 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: enable Location: Microsoft.SqlVirtualMachine/stable/2022-02-01/sqlvm.json#L1733 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: enable Location: Microsoft.SqlVirtualMachine/stable/2022-02-01/sqlvm.json#L1771 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: enableEncryption Location: Microsoft.SqlVirtualMachine/stable/2022-02-01/sqlvm.json#L1775 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: backupSystemDbs Location: Microsoft.SqlVirtualMachine/stable/2022-02-01/sqlvm.json#L1808 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: enable Location: Microsoft.SqlVirtualMachine/stable/2022-02-01/sqlvm.json#L1877 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: sqlSystemDbOnDataDisk Location: Microsoft.SqlVirtualMachine/stable/2022-02-01/sqlvm.json#L1945 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: enable Location: Microsoft.SqlVirtualMachine/stable/2022-02-01/sqlvm.json#L1985 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: runImmediately Location: Microsoft.SqlVirtualMachine/stable/2022-02-01/sqlvm.json#L1989 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isRServicesEnabled Location: Microsoft.SqlVirtualMachine/stable/2022-02-01/sqlvm.json#L2093 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isOptimizeForAdHocWorkloadsEnabled Location: Microsoft.SqlVirtualMachine/stable/2022-02-01/sqlvm.json#L2112 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: enable Location: Microsoft.SqlVirtualMachine/stable/2022-02-01/sqlvm.json#L2207 |
|
| 'SQLTempDbSettings' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: Microsoft.SqlVirtualMachine/stable/2022-02-01/sqlvm.json#L2154 |
|
| 'Schedule' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: Microsoft.SqlVirtualMachine/stable/2022-02-01/sqlvm.json#L2204 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️⚠️Cross-Version Breaking Changes: 1 Warnings warning [Detail]
- Compared Swaggers (Based on Oad v0.9.5)
- current:stable/2022-02-01/sqlvm.json compared with base:preview/2021-11-01-preview/sqlvm.json
| Rule | Message |
|---|---|
| The read only property has changed from 'true' to 'false'. New: Microsoft.SqlVirtualMachine/stable/2022-02-01/sqlvm.json#L1069:9 Old: Microsoft.SqlVirtualMachine/preview/2021-11-01-preview/sqlvm.json#L1040:9 |
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️SDK Track2 Validation succeeded [Detail] [Expand]
Validation passes for SDKTrack2Validation
- The following tags are being changed in this PR
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
Swagger Generation Artifacts
|
|
Hi @shiva08, Your PR has some issues. Please fix the CI sequentially by following the order of
|
This was referenced Jun 15, 2022
This was referenced Jun 15, 2022
rchlkm
reviewed
Jun 15, 2022
|
@tianxchen-ms |
openapi-workflow-bot
bot
added
ARMReview
WaitForARMFeedback
|
Hi, @shiva08 your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board([email protected]). |
zizw123
added
the
ARMSignedOff
openapi-workflow-bot
bot
removed
the
WaitForARMFeedback
tianxchen-ms
approved these changes
Jun 20, 2022
This was referenced Jun 20, 2022
ghost
pushed a commit
to Azure/azure-resource-manager-schemas
that referenced
this pull request
Jun 20, 2022
…tual machine 2022 02 01 (#2433) Create to sync Azure/azure-rest-api-specs#19471 [ReCreate this PR](https://github.com/azure-resource-manager-schemas/compare/main...azure-sdk:sdkAuto/sqlvirtualmachine?expand=1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following appy to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
-[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.