-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Hub Generated] Review request for Microsoft.CostManagement to add version stable/2021-10-01 #20218
[Hub Generated] Review request for Microsoft.CostManagement to add version stable/2021-10-01 #20218
Conversation
Hi, @bvishali Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
Swagger Validation Report
|
compared swaggers (via Oad v0.9.7)] | new version | base version |
---|---|---|
costmanagement.exports.json | 2021-10-01(3951c2b) | 2021-10-01(main) |
️️✔️
Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️
CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️
LintDiff: 0 Warnings warning [Detail]
compared tags (via openapi-validator v1.13.0) | new version | base version |
---|---|---|
package-preview-2022-06 | package-preview-2022-06(3951c2b) | package-preview-2022-06(main) |
package-preview-2022-04 | package-preview-2022-04(3951c2b) | package-preview-2022-04(main) |
package-2022-05 | package-2022-05(3951c2b) | package-2022-05(main) |
The following errors/warnings exist before current PR submission:
Rule | Message |
---|---|
Since operation 'ExportsGetExecutionHistory' response has model definition 'array', it should be of the form 'list'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.CostManagement/stable/2021-10-01/costmanagement.exports.json#L342 |
|
Since operation 'ExportsGetExecutionHistory' response has model definition 'array', it should be of the form 'list'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.CostManagement/stable/2021-10-01/costmanagement.exports.json#L342 |
|
Since operation 'ExportsGetExecutionHistory' response has model definition 'array', it should be of the form 'list'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.CostManagement/stable/2021-10-01/costmanagement.exports.json#L342 |
|
Based on the response model schema, operation 'Exports_List' might be pageable. Consider adding the x-ms-pageable extension. Location: Microsoft.CostManagement/stable/2021-10-01/costmanagement.exports.json#L37 |
|
Based on the response model schema, operation 'Exports_List' might be pageable. Consider adding the x-ms-pageable extension. Location: Microsoft.CostManagement/stable/2021-10-01/costmanagement.exports.json#L37 |
|
Based on the response model schema, operation 'Exports_List' might be pageable. Consider adding the x-ms-pageable extension. Location: Microsoft.CostManagement/stable/2021-10-01/costmanagement.exports.json#L37 |
|
Based on the response model schema, operation 'Exports_GetExecutionHistory' might be pageable. Consider adding the x-ms-pageable extension. Location: Microsoft.CostManagement/stable/2021-10-01/costmanagement.exports.json#L338 |
|
Based on the response model schema, operation 'Exports_GetExecutionHistory' might be pageable. Consider adding the x-ms-pageable extension. Location: Microsoft.CostManagement/stable/2021-10-01/costmanagement.exports.json#L338 |
|
Based on the response model schema, operation 'Exports_GetExecutionHistory' might be pageable. Consider adding the x-ms-pageable extension. Location: Microsoft.CostManagement/stable/2021-10-01/costmanagement.exports.json#L338 |
|
OperationId should contain the verb: 'run' in:'Exports_Execute'. Consider updating the operationId Location: Microsoft.CostManagement/stable/2021-10-01/costmanagement.exports.json#L288 |
|
OperationId should contain the verb: 'run' in:'Exports_Execute'. Consider updating the operationId Location: Microsoft.CostManagement/stable/2021-10-01/costmanagement.exports.json#L288 |
|
OperationId should contain the verb: 'run' in:'Exports_Execute'. Consider updating the operationId Location: Microsoft.CostManagement/stable/2021-10-01/costmanagement.exports.json#L288 |
|
The resource 'ExportExecution' does not have get operation, please add it. Location: Microsoft.CostManagement/stable/2021-10-01/costmanagement.exports.json#L697 |
|
The resource 'ExportExecution' does not have get operation, please add it. Location: Microsoft.CostManagement/stable/2021-10-01/costmanagement.exports.json#L697 |
|
The resource 'ExportExecution' does not have get operation, please add it. Location: Microsoft.CostManagement/stable/2021-10-01/costmanagement.exports.json#L697 |
️️✔️
Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️
ApiReadinessCheck succeeded [Detail] [Expand]
️❌
~[Staging] ServiceAPIReadinessTest: 0 Errors, 0 Warnings failed [Detail]
Tag package-2022-05; Prod region: Not deployed; Canary region: Not deployed
️❌
~[Staging] TrafficValidation: 0 Errors, 0 Warnings failed [Detail]
️️✔️
ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️
PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️⚠️
SDK Track2 Validation: 20 Warnings warning [Detail]
- The following tags are being changed in this PR
- "https://github.com/Azure/azure-rest-api-specs/blob/3951c2b58d1ad03c38d43934db2616ac54440e81/specification/cost-management/resource-manager/readme.md#tag-package-2022-05">cost-management/resource-manager/readme.md#package-2022-05
- "https://github.com/Azure/azure-rest-api-specs/blob/3951c2b58d1ad03c38d43934db2616ac54440e81/specification/cost-management/resource-manager/readme.md#tag-package-preview-2022-06">cost-management/resource-manager/readme.md#package-preview-2022-06
- "https://github.com/Azure/azure-rest-api-specs/blob/3951c2b58d1ad03c38d43934db2616ac54440e81/specification/cost-management/resource-manager/readme.md#tag-package-preview-2022-04">cost-management/resource-manager/readme.md#package-preview-2022-04
- "https://github.com/Azure/azure-rest-api-specs/blob/3951c2b58d1ad03c38d43934db2616ac54440e81/specification/cost-management/resource-manager/readme.md#tag-package-2021-10">cost-management/resource-manager/readme.md#package-2021-10
Rule | Message |
---|---|
"readme":"cost-management/resource-manager/readme.md", "tag":"package-2022-05", "details":"The schema 'AlertProperties-details-resourceGroupFilterItem' has no type or format information whatsoever. Location:\n file:///mnt/vss/_work/1/azure-rest-api-specs/specification/cost-management/resource-manager/Microsoft.CostManagement/stable/2021-10-01/costmanagement.json#/components/schemas/AlertProperties-details-resourceGroupFilterItem" |
|
"readme":"cost-management/resource-manager/readme.md", "tag":"package-2022-05", "details":"The schema 'AlertProperties-details-resourceFilterItem' has no type or format information whatsoever. Location:\n file:///mnt/vss/_work/1/azure-rest-api-specs/specification/cost-management/resource-manager/Microsoft.CostManagement/stable/2021-10-01/costmanagement.json#/components/schemas/AlertProperties-details-resourceFilterItem" |
|
"readme":"cost-management/resource-manager/readme.md", "tag":"package-2022-05", "details":"The schema 'AlertProperties-details-meterFilterItem' has no type or format information whatsoever. Location:\n file:///mnt/vss/_work/1/azure-rest-api-specs/specification/cost-management/resource-manager/Microsoft.CostManagement/stable/2021-10-01/costmanagement.json#/components/schemas/AlertProperties-details-meterFilterItem" |
|
"readme":"cost-management/resource-manager/readme.md", "tag":"package-2022-05", "details":"The schema 'ForecastProperties-rows-itemsItem' has no type or format information whatsoever. Location:\n file:///mnt/vss/_work/1/azure-rest-api-specs/specification/cost-management/resource-manager/Microsoft.CostManagement/stable/2021-10-01/costmanagement.json#/components/schemas/ForecastProperties-rows-itemsItem" |
|
"readme":"cost-management/resource-manager/readme.md", "tag":"package-2022-05", "details":"The schema 'QueryProperties-rows-itemsItem' has no type or format information whatsoever. Location:\n file:///mnt/vss/_work/1/azure-rest-api-specs/specification/cost-management/resource-manager/Microsoft.CostManagement/stable/2021-10-01/costmanagement.json#/components/schemas/QueryProperties-rows-itemsItem" |
|
"readme":"cost-management/resource-manager/readme.md", "tag":"package-preview-2022-06", "details":"The schema 'AlertProperties-details-resourceGroupFilterItem' has no type or format information whatsoever. Location:\n file:///mnt/vss/_work/1/azure-rest-api-specs/specification/cost-management/resource-manager/Microsoft.CostManagement/stable/2021-10-01/costmanagement.json#/components/schemas/AlertProperties-details-resourceGroupFilterItem" |
|
"readme":"cost-management/resource-manager/readme.md", "tag":"package-preview-2022-06", "details":"The schema 'AlertProperties-details-resourceFilterItem' has no type or format information whatsoever. Location:\n file:///mnt/vss/_work/1/azure-rest-api-specs/specification/cost-management/resource-manager/Microsoft.CostManagement/stable/2021-10-01/costmanagement.json#/components/schemas/AlertProperties-details-resourceFilterItem" |
|
"readme":"cost-management/resource-manager/readme.md", "tag":"package-preview-2022-06", "details":"The schema 'AlertProperties-details-meterFilterItem' has no type or format information whatsoever. Location:\n file:///mnt/vss/_work/1/azure-rest-api-specs/specification/cost-management/resource-manager/Microsoft.CostManagement/stable/2021-10-01/costmanagement.json#/components/schemas/AlertProperties-details-meterFilterItem" |
|
"readme":"cost-management/resource-manager/readme.md", "tag":"package-preview-2022-06", "details":"The schema 'ForecastProperties-rows-itemsItem' has no type or format information whatsoever. Location:\n file:///mnt/vss/_work/1/azure-rest-api-specs/specification/cost-management/resource-manager/Microsoft.CostManagement/stable/2021-10-01/costmanagement.json#/components/schemas/ForecastProperties-rows-itemsItem" |
|
"readme":"cost-management/resource-manager/readme.md", "tag":"package-preview-2022-06", "details":"The schema 'QueryProperties-rows-itemsItem' has no type or format information whatsoever. Location:\n file:///mnt/vss/_work/1/azure-rest-api-specs/specification/cost-management/resource-manager/Microsoft.CostManagement/stable/2021-10-01/costmanagement.json#/components/schemas/QueryProperties-rows-itemsItem" |
|
"readme":"cost-management/resource-manager/readme.md", "tag":"package-preview-2022-04", "details":"The schema 'AlertProperties-details-resourceGroupFilterItem' has no type or format information whatsoever. Location:\n file:///mnt/vss/_work/1/azure-rest-api-specs/specification/cost-management/resource-manager/Microsoft.CostManagement/stable/2021-10-01/costmanagement.json#/components/schemas/AlertProperties-details-resourceGroupFilterItem" |
|
"readme":"cost-management/resource-manager/readme.md", "tag":"package-preview-2022-04", "details":"The schema 'AlertProperties-details-resourceFilterItem' has no type or format information whatsoever. Location:\n file:///mnt/vss/_work/1/azure-rest-api-specs/specification/cost-management/resource-manager/Microsoft.CostManagement/stable/2021-10-01/costmanagement.json#/components/schemas/AlertProperties-details-resourceFilterItem" |
|
"readme":"cost-management/resource-manager/readme.md", "tag":"package-preview-2022-04", "details":"The schema 'AlertProperties-details-meterFilterItem' has no type or format information whatsoever. Location:\n file:///mnt/vss/_work/1/azure-rest-api-specs/specification/cost-management/resource-manager/Microsoft.CostManagement/stable/2021-10-01/costmanagement.json#/components/schemas/AlertProperties-details-meterFilterItem" |
|
"readme":"cost-management/resource-manager/readme.md", "tag":"package-preview-2022-04", "details":"The schema 'ForecastProperties-rows-itemsItem' has no type or format information whatsoever. Location:\n file:///mnt/vss/_work/1/azure-rest-api-specs/specification/cost-management/resource-manager/Microsoft.CostManagement/stable/2021-10-01/costmanagement.json#/components/schemas/ForecastProperties-rows-itemsItem" |
|
"readme":"cost-management/resource-manager/readme.md", "tag":"package-preview-2022-04", "details":"The schema 'QueryProperties-rows-itemsItem' has no type or format information whatsoever. Location:\n file:///mnt/vss/_work/1/azure-rest-api-specs/specification/cost-management/resource-manager/Microsoft.CostManagement/stable/2021-10-01/costmanagement.json#/components/schemas/QueryProperties-rows-itemsItem" |
|
"readme":"cost-management/resource-manager/readme.md", "tag":"package-2021-10", "details":"The schema 'AlertProperties-details-resourceGroupFilterItem' has no type or format information whatsoever. Location:\n file:///mnt/vss/_work/1/azure-rest-api-specs/specification/cost-management/resource-manager/Microsoft.CostManagement/stable/2021-10-01/costmanagement.json#/components/schemas/AlertProperties-details-resourceGroupFilterItem" |
|
"readme":"cost-management/resource-manager/readme.md", "tag":"package-2021-10", "details":"The schema 'AlertProperties-details-resourceFilterItem' has no type or format information whatsoever. Location:\n file:///mnt/vss/_work/1/azure-rest-api-specs/specification/cost-management/resource-manager/Microsoft.CostManagement/stable/2021-10-01/costmanagement.json#/components/schemas/AlertProperties-details-resourceFilterItem" |
|
"readme":"cost-management/resource-manager/readme.md", "tag":"package-2021-10", "details":"The schema 'AlertProperties-details-meterFilterItem' has no type or format information whatsoever. Location:\n file:///mnt/vss/_work/1/azure-rest-api-specs/specification/cost-management/resource-manager/Microsoft.CostManagement/stable/2021-10-01/costmanagement.json#/components/schemas/AlertProperties-details-meterFilterItem" |
|
"readme":"cost-management/resource-manager/readme.md", "tag":"package-2021-10", "details":"The schema 'ForecastProperties-rows-itemsItem' has no type or format information whatsoever. Location:\n file:///mnt/vss/_work/1/azure-rest-api-specs/specification/cost-management/resource-manager/Microsoft.CostManagement/stable/2021-10-01/costmanagement.json#/components/schemas/ForecastProperties-rows-itemsItem" |
|
"readme":"cost-management/resource-manager/readme.md", "tag":"package-2021-10", "details":"The schema 'QueryProperties-rows-itemsItem' has no type or format information whatsoever. Location:\n file:///mnt/vss/_work/1/azure-rest-api-specs/specification/cost-management/resource-manager/Microsoft.CostManagement/stable/2021-10-01/costmanagement.json#/components/schemas/QueryProperties-rows-itemsItem" |
The following errors/warnings exist before current PR submission:
Rule | Message |
---|---|
"readme":"cost-management/resource-manager/readme.md", "tag":"package-2022-05", "details":"Security scheme azure_auth is unknown and will not be processed. Only supported types are AADToken, AzureKey, Anonymous" |
|
"readme":"cost-management/resource-manager/readme.md", "tag":"package-preview-2022-06", "details":"Security scheme azure_auth is unknown and will not be processed. Only supported types are AADToken, AzureKey, Anonymous" |
|
"readme":"cost-management/resource-manager/readme.md", "tag":"package-preview-2022-04", "details":"Security scheme azure_auth is unknown and will not be processed. Only supported types are AADToken, AzureKey, Anonymous" |
|
"readme":"cost-management/resource-manager/readme.md", "tag":"package-2021-10", "details":"Security scheme azure_auth is unknown and will not be processed. Only supported types are AADToken, AzureKey, Anonymous" |
️️✔️
PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️
SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️
Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️
CadlValidation succeeded [Detail] [Expand]
Validation passes for CadlValidation.
️️✔️
PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
Swagger Generation Artifacts
|
/azp run unifiedPipeline |
No pipelines are associated with this pull request. |
Hi, @bvishali. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove |
/azp run unifiedPipeline |
No pipelines are associated with this pull request. |
Hi, @bvishali your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board([email protected]). |
/azp run unifiedPipeline |
No pipelines are associated with this pull request. |
/azp run unifiedPipeline |
No pipelines are associated with this pull request. |
…gement-2021-10-01-export-etag-optional
/azp run unifiedPipeline |
No pipelines are associated with this pull request. |
This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
ARM API Information (Control Plane)
Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist (MS Employees Only):
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.