Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maulik/mfe stable changes #20373

Closed
wants to merge 110 commits into from
Closed

Maulik/mfe stable changes #20373

wants to merge 110 commits into from

Conversation

Maulik003
Copy link
Contributor

@Maulik003 Maulik003 commented Aug 24, 2022 •
edited
Loading

ARM API Information (Control Plane)

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.

  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

rejoron and others added 30 commits August 8, 2022 10:50
@rejoron
Updating Microsoft.Security\Pricing API Documentation (Azure#19439)
63312d0 
* Updating Microsoft.Security\Pricing API Documentation

* Adding items property to replacedBy
@tombuildsstuff
deviceprovisioningservices: updating the Swagger Tags to match the Op…
f840c84 
…eration ID Prefix (Azure#20106)

This means that when grouped these are grouped by Type (Certificate, IotDpsResource) rather than by GET/PUT/PATCH etc which is less useful.
@j-zhong-ms
update x-ms-identifiers (Azure#19929)
1b30184
@Wzb123456789
Update connectedvmware readme.python.md (Azure#20143)
73adb85 
Co-authored-by: Zhenbiao Wei (WICRESOFT NORTH AMERICA LTD) <[email protected]>
@feiyushi @AzureRestAPISpecReview
[AutoSync] a35dd0d71 Merged PR 6495219: Release swagger changes throu…
a64043a 
…gh shift left (Azure#20122)

Co-authored-by: swagger-automation <[email protected]>
@bruceWangMS
[Hub Generated] Review request for Microsoft.DBforMySQL to fix wrong …
8659813 
…properties in data encryption (Azure#19910)

* fix name error

* fix example

* fix example

* fix properties error
@leniatgh
Add support for more scopes and update documentation (Azure#20124)
352507b 
* Add more scopes

* update documentation

* fix some wording

* wording

* fix artifact name

* fix comment

* fix title

* rename files
@j-zhong-ms
add x-ms-identifiers for iotsecurity (Azure#19981)
7473936
@ericshape
Release microsoft.sql 2021-11-01 Stable API version (Azure#19863)
2548fe4 
* Adds base for updating Microsoft.Sql from version preview/2021-11-01-preview to version 2021-11-01

* Updates readme

* Updates API version in new specs and examples

* add the latest generated stable 2021-11-01

* update readme.md with latest stable api list

* update swaggers

* update swagger format

* address lintdiff pipeline

* address lint error

* add           "x-ms-identifiers": []
@thatChang @xieofxie @Danieladu
Dev botservice microsoft.bot service 2022 06 15 preview (Azure#19687)
827a487 
* Adds base for updating Microsoft.BotService from version preview/2021-05-01-preview to version 2022-06-15-preview

* Updates readme

* Updates API version in new specs and examples

* add email related and outlook

* Update readme

* Correct some elements

* fix model issue

* Fix prettier issues.

* add QnAMakerEndpointKeys api

* fix the prettierCheck

Co-authored-by: hualxie <[email protected]>
Co-authored-by: Chang Liu <[email protected]>
Co-authored-by: Hongyang Du <[email protected]>
@xwang971
change response code (Azure#20081)
680eab4
@ruslany
Fixerrorresponseschema (Azure#20002)
d62bf7a 
* Fix error response schema for the ListCustomHostNameAnalysis API

* Wrong place
@MaximeKjaer @msyyc
[SRP] 2022-05-01 Swagger Api (Azure#19357)
4e80dd0 
* Full copy from 2021-09-01 to 2022-05-01 without any changes

* Updating API version for Service types, Updating readme files

* Feature: add directoryServiceOptions AADKERB

* Add AADKERB to list of custom words

* Fix default version tag in readme.md

* Make encryption keySource optional

* Fix lint: add missing x-ms-enum

* Fix x-ms-enum at wrong level

* Make some activeDirectoryProperties optional

* Update readme.python.md

Co-authored-by: Yuchao Yan <[email protected]>
@BigCat20196
Update readme.python.md (Azure#20151)
dfeece1
@JonathanSaraco @JonathanSaracoMS
Dev peering microsoft.peering 2022 06 01 (Azure#19815)
1b3b9c1 
* Adds base for updating Microsoft.Peering from version stable/2022-01-01 to version 2022-06-01

* Updates readme

* Updates API version in new specs and examples

* Updated Peering API version 2022-06-01

* Fixed slight issue with Peering readme

* Updated resource path for POST ValidateRegisteredPrefix

Co-authored-by: jsaraco <[email protected]>
@zhugexubin
[Hub Generated] Review request for Creator to add version preview/202…
6555955 
…2-09-01-preview (Azure#19889)

* Adds base for updating Creator from version preview/2.0 to version 2022-09-01-preview

* Updates readme

* Updates API version in new specs and examples

* Add swagger doc with version '2022-09-01-preview' for styling service

* update sharedKey description

* resolve some comments and couple validation errors

* Fix more model issues

* Fix more model validations

* Fix LintDiff

* Fix validation errors

* Fix lintDiff
@StephanieHan
[Hub Generated] Review request for Microsoft.Media to add version sta…
429ced7 
…ble/2022-08-01 (Azure#19891)

* Adds base for updating Microsoft.Media from version stable/2021-11-01 to version 2022-08-01

* Updates readme

* Updates API version in new specs and examples

* remove unrelated changes

* delete unrelated examples

* make changes to 2022-08-01 streamingservice

* fix comments

Co-authored-by: Stephanie Han <[email protected]>
@ArcturusZhang @tadelesh
change the name of a new enumeration in storage's latest api-version (A…
a98a48c 
…zure#20157)

* change the name of a new enumeration

* revert changes in python readme

* add directive to mitigate go sdk breaking change

Co-authored-by: Chenjie Shi <[email protected]>
@didact2401 @firstaye-zz
[Hub Generated] Review request for Microsoft.Devices to add version p…
1f75c8b 
…review/2022-04-30-preview (Azure#18743)

* Adds base for updating Microsoft.Devices from version preview/2021-07-02-preview to version 2022-04-30-preview

* Updates readme

* Updates API version in new specs and examples

* Add RoutingCosmosDBCollectionProperties to iothub.json.

* Update naming.

* Fix enum.

* Unique x-ms-enum names.

* Use same name for same enum def.

* Revert "Use same name for same enum def."

This reverts commit 6279e70.

* Use same name for enum.

* Revert "Use same name for enum."

This reverts commit 366c4b3.

* Adds suppression to readme

* Revert "Revert "Use same name for enum.""

This reverts commit 15b8dc9.

* Update reason on UniqueXmsEnumName suppression.

* Ensure camel casing on partitionKeyName and partitionKeyTemplate.

* Add 'deviceid' to custom-words.txt.

* Add x-ms-secret.

* Remove secret tag for storage endpoint connection string.

* Adding the change for rootCertificateV2

* typo

* fixing validation error

* Update error response schema

* fixing tag

* adding Azure-AsyncOperation as header

* fix: adding Azure-AsyncOperation as header

* Fix semantic error

* header fix

* adding x-ms-identifiers

* fix

* fix

* prettier fix

* Azure-Async header position testing

* re-trigger stuck queue validation jobs

* revert change

* testing Azure AsyncOperation header

* Adding Azure-AsyncOperation to other possible place to mitigate the error

* make small change to retrigger the check queue

* Adding Async Operation header to the examples.

* fix format

* Typo fix

* revert the change of error details schema

* Revert unwanted changes

Co-authored-by: Jared Wilson <[email protected]>
Co-authored-by: Chris Huang <[email protected]>
@ronniegeraghty
[CODEOWNERS] Update on request (Azure#20007)
c34f343 
Updating the CODEOWNERS for Cosmos related PRs on request of Cosmos team.
@msyyc
Update readme.python.md (Azure#20163)
124789a
@anat-gilenson @moranraz
dev-Sentinel-2022-08-01-preview (Azure#19925)
2ce16bd 
* Adds base for updating Microsoft.SecurityInsights from version preview/2022-07-01-preview to version 2022-08-01-preview

* Updates readme

* Updates API version in new specs and examples

* Added file imports (Azure#19678)

* added file imports

* .

* .

* version

* fix delete response (Azure#20154)

* fix delete response

* example fix

Co-authored-by: Moran Raz Mizrahi <[email protected]>

Co-authored-by: moranraz <[email protected]>
Co-authored-by: Moran Raz Mizrahi <[email protected]>
@raych1
Update pull_request_assignment.yml (Azure#20153)
fd07605 
Customize secretmanagementtestsvc pr assignment.
@j-zhong-ms
add x-ms-identifiers for healthbot (Azure#19959)
f964ff8
@HarshAulakhh
make required field changes (Azure#20128)
8006549
@Frey-Wang @AzureRestAPISpecReview
[AutoSync] b5d73c84f1 [Swagger] Update operation id to update mapping…
2421768 
… configuration (Azure#20187)

Co-authored-by: swagger-automation <[email protected]>
@msyyc
cosmosdb (Azure#20188)
4b5383a
@kamperiadis
Dev labservices microsoft.lab services 2022 08 01 (Azure#20121)
37c9b56 
* Adds base for updating Microsoft.LabServices from version preview/2021-11-15-preview to version 2022-08-01

* Updates readme

* Updates API version in new specs and examples

* refactor: update the v2022-08-01 specifications

* Fix prettier issues

* Add missing clouderror.json file

* Add missing xmsidentifier clouderror property

* Add x-ms-identifiers to Skus.json file

* Resolve code style issues in clouderror.json

* Add clouderror to custom-words.txt

* Use ErrorResponse instead of CloudError

* Fix duration format in examples

* Fix duration format in Users examples

* Fix duration format in LabPlans examples
@wangyuantao @yuantao-wang
Summarization API for 2022-10-01-preview (Azure#19523)
f3e0d43 
* patch now 3

* patch now 4

* patch now 5

* test encoding

* test encoding

* doc abs req

* text sum

* conv

* example

* BOM

* revert

* add timing

* add missing parent

* custom api

* more descriptions

* add more required fields

* add custom task and result

* add more description to summary controls

* fix base class bug, add lab features, ext phrase c

* add CustomAbstractiveSummarizationLROResults

* add examples

* auth example

* remove dup

* require storage

* remove invalid example, rename item id

* fix example

* add more description

* fix invalid char in example, unify enum value

* remove customization

* fix example

* revert ext sum, denorm conv

* fix typo

* 10

* spec

* revert

* remove lab features, rename timing, narrative

* fix examples

* merge upstream

* Revert "merge upstream"

This reverts commit 07fc9c6.

* fetch upstream

* common ver

* get 07-01 back to readme

* revert changes to extractive summarization

* prettier

* add word

Co-authored-by: Yuantao Wang <[email protected]>
@msyyc
Update readme.python.md (Azure#20213)
f842bc6
This was referenced Aug 31, 2022
Closed
Closed
Closed
Closed
Closed
Draft
Closed
Closed
Closed
Closed
Closed
Closed
@raosuhas
Copy link

Seems like this PR is created in correctly can you please abandon and recreate ?

@raosuhas raosuhas added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Aug 31, 2022
@azure-sdk azure-sdk mentioned this pull request Aug 31, 2022
Closed
@openapi-workflow-bot
Copy link

Please ensure to respond feedbacks from the ARM API reviewer. When you are ready to continue the ARM API review, please remove ARMChangesRequested

@openapi-workflow-bot openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Aug 31, 2022
@openapi-pipeline-app openapi-pipeline-app bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Aug 31, 2022
@openapi-workflow-bot openapi-workflow-bot bot removed the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Aug 31, 2022
This was referenced Aug 31, 2022
Closed
Closed
Closed
Closed
Closed
@Maulik003 Maulik003 closed this Aug 31, 2022
This was referenced Aug 31, 2022
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msyyc msyyc Awaiting requested review from msyyc

@BigCat20196 BigCat20196 Awaiting requested review from BigCat20196

@ArcturusZhang ArcturusZhang Awaiting requested review from ArcturusZhang

@jsntcy jsntcy Awaiting requested review from jsntcy

@qiaozha qiaozha Awaiting requested review from qiaozha

@wonner wonner Awaiting requested review from wonner

@JasonYang-MSFT JasonYang-MSFT Awaiting requested review from JasonYang-MSFT

@jamestao jamestao Awaiting requested review from jamestao

@ericshape ericshape Awaiting requested review from ericshape

@MikhailTryakhov MikhailTryakhov Awaiting requested review from MikhailTryakhov

@giakas giakas Awaiting requested review from giakas

@rkmanda rkmanda Awaiting requested review from rkmanda

@Frey-Wang Frey-Wang Awaiting requested review from Frey-Wang

@zhangyd2015 zhangyd2015 Awaiting requested review from zhangyd2015

@davidzhaoyue davidzhaoyue Awaiting requested review from davidzhaoyue

@palma21 palma21 Awaiting requested review from palma21

@matthchr matthchr Awaiting requested review from matthchr

@circy9 circy9 Awaiting requested review from circy9

@jorinmejia jorinmejia Awaiting requested review from jorinmejia

@yunheMsft yunheMsft Awaiting requested review from yunheMsft

@t-bzhan t-bzhan Awaiting requested review from t-bzhan

@ofirmanor ofirmanor Awaiting requested review from ofirmanor

@orieldar orieldar Awaiting requested review from orieldar

@annatisch annatisch Awaiting requested review from annatisch

@heaths heaths Awaiting requested review from heaths

@deyaaeldeen deyaaeldeen Awaiting requested review from deyaaeldeen

@kristapratico kristapratico Awaiting requested review from kristapratico

@mssfang mssfang Awaiting requested review from mssfang

@tomkerkhove tomkerkhove Awaiting requested review from tomkerkhove tomkerkhove was automatically assigned from Azure/api-stewardship-board

@johanste johanste Awaiting requested review from johanste johanste was automatically assigned from Azure/api-stewardship-board

Assignees

@ArcturusZhang ArcturusZhang

Labels
ARMReview CI-BreakingChange-Go CI-BreakingChange-JavaScript CI-FixRequiredOnFailure data-plane resource-manager WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.