[Hub Generated] Review request for Microsoft.Maintenance to add version preview/2021-09-01-preview #20626

KalpeshChavan12 · 2022-09-07T17:15:21Z

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

ARM API Information (Control Plane)

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.

Changelog

Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

I commit to follow the Breaking Change Policy of "no breaking changes"
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs

Adding new properties

All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
- Adding a new service
- Adding new API(s)
- Adding a new API version
  -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

openapi-workflow-bot · 2022-09-07T17:15:24Z

Hi, @KalpeshChavan12 Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

KalpeshChavan12 · 2022-09-07T17:38:04Z

/azp run unifiedPipeline

openapi-pipeline-app · 2022-09-07T17:38:06Z

Swagger Validation Report

️🔄BreakingChange inProgress [Detail]

️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]

There are no breaking changes.

️⌛CredScan pending [Detail]

️🔄LintDiff inProgress [Detail]

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️🔄ApiReadinessCheck inProgress [Detail]

️🔄~[Staging] ServiceAPIReadinessTest inProgress [Detail]

️🔄~[Staging] TrafficValidation inProgress [Detail]

️⌛ModelValidation pending [Detail]

️⌛SemanticValidation pending [Detail]

️⌛PoliCheck pending [Detail]

️🔄SDK Track2 Validation inProgress [Detail]

️⌛PrettierCheck pending [Detail]

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️⌛Lint(RPaaS) pending [Detail]

️️✔️CadlValidation succeeded [Detail] [Expand]

Validation passes for CadlValidation.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2022-09-07T17:38:06Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

Breaking Changes Tracking

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs]Release - Generate from 95008e2. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh] npm notice
cmderr	[automation_generate.sh] npm notice New major version of npm available! 8.19.2 -> 9.1.2
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.1.2>
cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
cmderr	[automation_generate.sh] npm notice

️✔️track2_azure-mgmt-maintenance [View full logs] [Release SDK Changes]
- azure_mgmt_maintenance-1.0.0b1-py3-none-any.whl
- azure-mgmt-maintenance-1.0.0b1.zip
```
info	[Changelog]
```

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 95008e2. SDK Automation 14.0.0

command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️sdk/resourcemanager/maintenance/armmaintenance [View full logs] [Release SDK Changes]

info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New const `MaintenanceScopeResource`
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 1 additive change(s).

️⚠️ azure-resource-manager-schemas warning [Detail]

⚠️Warning [Logs]Release - Generate from 95008e2. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh]  WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json

️✔️maintenance [View full logs] [Release Schema Changes]

️️✔️ azure-powershell succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 95008e2. SDK Automation 14.0.0

command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json

️✔️Az.Maintenance [View full logs] [Release SDK Changes]
- Az.Maintenance.0.1.0.nupkg

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2022-09-07T17:38:07Z

Generated ApiView

Language	Package Name	ApiView Link
Go	sdk/resourcemanager/maintenance/armmaintenance	Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
Python	track2_azure-mgmt-maintenance	Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.

azure-pipelines · 2022-09-07T17:38:09Z

No pipelines are associated with this pull request.

openapi-pipeline-app · 2022-09-07T17:43:30Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

compared swaggers (via Oad v0.10.2)]	new version	base version
Maintenance.json	2021-09-01-preview(ff5e292)	2021-09-01-preview(main)
Maintenance.json	2022-07-01-preview(ff5e292)	2022-07-01-preview(main)

️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️⚠️LintDiff: 0 Warnings warning [Detail]

compared tags (via openapi-validator v2.0.0)	new version	base version
package-preview-2022-07	package-preview-2022-07(ff5e292)	package-preview-2022-07(main)
package-preview-2021-09	package-preview-2021-09(ff5e292)	package-preview-2021-09(main)

The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule	Message
`❌` ResourceNameRestriction	The resource name parameter 'resourceName' should be defined with a 'pattern' restriction. Location: Microsoft.Maintenance/preview/2021-09-01-preview/Maintenance.json#L62
`❌` TrackedResourcePatchOperation	Tracked resource 'MaintenanceConfiguration' must have patch operation that at least supports the update of tags. Location: Microsoft.Maintenance/preview/2021-09-01-preview/Maintenance.json#L62
`❌` ResourceNameRestriction	The resource name parameter 'providerName' should be defined with a 'pattern' restriction. Location: Microsoft.Maintenance/preview/2021-09-01-preview/Maintenance.json#L109
`❌` ResourceNameRestriction	The resource name parameter 'resourceParentName' should be defined with a 'pattern' restriction. Location: Microsoft.Maintenance/preview/2021-09-01-preview/Maintenance.json#L109
`❌` ResourceNameRestriction	The resource name parameter 'resourceName' should be defined with a 'pattern' restriction. Location: Microsoft.Maintenance/preview/2021-09-01-preview/Maintenance.json#L109
`❌` ResourceNameRestriction	The resource name parameter 'applyUpdateName' should be defined with a 'pattern' restriction. Location: Microsoft.Maintenance/preview/2021-09-01-preview/Maintenance.json#L109
`❌` SubscriptionsAndResourceGroupCasing	The path segment resourcegroups should be resourceGroups. Location: Microsoft.Maintenance/preview/2021-09-01-preview/Maintenance.json#L109
`❌` ParametersOrder	The parameters:resourceGroupName,resourceParentType,resourceParentName,providerName,resourceType,resourceName,applyUpdateName should be kept in the same order as they present in the path. Location: Microsoft.Maintenance/preview/2021-09-01-preview/Maintenance.json#L110
`❌` ResourceNameRestriction	The resource name parameter 'providerName' should be defined with a 'pattern' restriction. Location: Microsoft.Maintenance/preview/2021-09-01-preview/Maintenance.json#L199
`❌` ResourceNameRestriction	The resource name parameter 'resourceName' should be defined with a 'pattern' restriction. Location: Microsoft.Maintenance/preview/2021-09-01-preview/Maintenance.json#L199
`❌` ResourceNameRestriction	The resource name parameter 'applyUpdateName' should be defined with a 'pattern' restriction. Location: Microsoft.Maintenance/preview/2021-09-01-preview/Maintenance.json#L199
`❌` SubscriptionsAndResourceGroupCasing	The path segment resourcegroups should be resourceGroups. Location: Microsoft.Maintenance/preview/2021-09-01-preview/Maintenance.json#L199
`❌` ResourceNameRestriction	The resource name parameter 'providerName' should be defined with a 'pattern' restriction. Location: Microsoft.Maintenance/preview/2021-09-01-preview/Maintenance.json#L275
`❌` ResourceNameRestriction	The resource name parameter 'resourceParentName' should be defined with a 'pattern' restriction. Location: Microsoft.Maintenance/preview/2021-09-01-preview/Maintenance.json#L275
`❌` ResourceNameRestriction	The resource name parameter 'resourceName' should be defined with a 'pattern' restriction. Location: Microsoft.Maintenance/preview/2021-09-01-preview/Maintenance.json#L275
`❌` SubscriptionsAndResourceGroupCasing	The path segment resourcegroups should be resourceGroups. Location: Microsoft.Maintenance/preview/2021-09-01-preview/Maintenance.json#L275
`❌` ResourceNameRestriction	The resource name parameter 'providerName' should be defined with a 'pattern' restriction. Location: Microsoft.Maintenance/preview/2021-09-01-preview/Maintenance.json#L358
`❌` ResourceNameRestriction	The resource name parameter 'resourceName' should be defined with a 'pattern' restriction. Location: Microsoft.Maintenance/preview/2021-09-01-preview/Maintenance.json#L358
`❌` SubscriptionsAndResourceGroupCasing	The path segment resourcegroups should be resourceGroups. Location: Microsoft.Maintenance/preview/2021-09-01-preview/Maintenance.json#L358
`❌` ResourceNameRestriction	The resource name parameter 'providerName' should be defined with a 'pattern' restriction. Location: Microsoft.Maintenance/preview/2021-09-01-preview/Maintenance.json#L427
`❌` ResourceNameRestriction	The resource name parameter 'resourceParentName' should be defined with a 'pattern' restriction. Location: Microsoft.Maintenance/preview/2021-09-01-preview/Maintenance.json#L427
`❌` ResourceNameRestriction	The resource name parameter 'resourceName' should be defined with a 'pattern' restriction. Location: Microsoft.Maintenance/preview/2021-09-01-preview/Maintenance.json#L427
`❌` ResourceNameRestriction	The resource name parameter 'configurationAssignmentName' should be defined with a 'pattern' restriction. Location: Microsoft.Maintenance/preview/2021-09-01-preview/Maintenance.json#L427
`❌` SubscriptionsAndResourceGroupCasing	The path segment resourcegroups should be resourceGroups. Location: Microsoft.Maintenance/preview/2021-09-01-preview/Maintenance.json#L427
`❌` TrackedResourcePatchOperation	Tracked resource 'ConfigurationAssignment' must have patch operation that at least supports the update of tags. Location: Microsoft.Maintenance/preview/2021-09-01-preview/Maintenance.json#L427
`❌` DeleteResponseBodyEmpty	The delete response body must be empty. Location: Microsoft.Maintenance/preview/2021-09-01-preview/Maintenance.json#L688
`❌` ResourceNameRestriction	The resource name parameter 'providerName' should be defined with a 'pattern' restriction. Location: Microsoft.Maintenance/preview/2021-09-01-preview/Maintenance.json#L709
`❌` ResourceNameRestriction	The resource name parameter 'resourceName' should be defined with a 'pattern' restriction. Location: Microsoft.Maintenance/preview/2021-09-01-preview/Maintenance.json#L709
`❌` ResourceNameRestriction	The resource name parameter 'configurationAssignmentName' should be defined with a 'pattern' restriction. Location: Microsoft.Maintenance/preview/2021-09-01-preview/Maintenance.json#L709
`❌` SubscriptionsAndResourceGroupCasing	The path segment resourcegroups should be resourceGroups. Location: Microsoft.Maintenance/preview/2021-09-01-preview/Maintenance.json#L709

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️ApiReadinessCheck succeeded [Detail] [Expand]

️⚠️~[Staging] ServiceAPIReadinessTest: 0 Warnings warning [Detail]

API Test is not triggered due to precheck failure. Check pipeline log for details.

️️✔️~[Staging] SwaggerAPIView succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️PoliCheck succeeded [Detail] [Expand]

Validation passed for PoliCheck.

️️✔️PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

️️✔️CadlValidation succeeded [Detail] [Expand]

Validation passes for CadlValidation.

️️✔️PR Summary succeeded [Detail] [Expand]

Validation passes for Summary.

_{Posted by Swagger Pipeline | How to fix these errors?}

…Maintenance to add version preview/2021-09-01-preview (#2669) Create to sync Azure/azure-rest-api-specs#20626 [ReCreate this PR](https://github.com/azure-resource-manager-schemas/compare/main...azure-sdk:sdkAuto/maintenance?expand=1)

Co-authored-by: Kalpesh Chavan <[email protected]>

KalpeshChavan12 force-pushed the release-maintenance-Microsoft.Maintenance-2021-09-01-preview branch from 3442f91 to 8dce4f8 Compare September 7, 2022 17:18

openapi-pipeline-app bot added the resource-manager label Sep 7, 2022

KalpeshChavan12 force-pushed the release-maintenance-Microsoft.Maintenance-2021-09-01-preview branch 2 times, most recently from 9f3b926 to 2169075 Compare November 18, 2022 15:08

KalpeshChavan12 marked this pull request as ready for review November 22, 2022 06:13

openapi-assignment-bot bot assigned akning-ms Nov 22, 2022

Updated doc

ff5e292

KalpeshChavan12 force-pushed the release-maintenance-Microsoft.Maintenance-2021-09-01-preview branch from 2169075 to ff5e292 Compare November 22, 2022 06:24

akning-ms approved these changes Nov 22, 2022

View reviewed changes

akning-ms merged commit 95008e2 into Azure:main Nov 22, 2022

anandanthony pushed a commit to anandMicro/azure-rest-api-specs that referenced this pull request Dec 16, 2022

Updated doc (Azure#20626)

3216b5b

Co-authored-by: Kalpesh Chavan <[email protected]>

kayousef-zz pushed a commit to kayousef-zz/azure-rest-api-specs that referenced this pull request Dec 21, 2022

Updated doc (Azure#20626)

763a965

Co-authored-by: Kalpesh Chavan <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Hub Generated] Review request for Microsoft.Maintenance to add version preview/2021-09-01-preview #20626

[Hub Generated] Review request for Microsoft.Maintenance to add version preview/2021-09-01-preview #20626

KalpeshChavan12 commented Sep 7, 2022 •

edited

Loading

openapi-workflow-bot bot commented Sep 7, 2022

KalpeshChavan12 commented Sep 7, 2022

openapi-pipeline-app bot commented Sep 7, 2022 •

edited

Loading

openapi-pipeline-app bot commented Sep 7, 2022 •

edited

Loading

Breaking Changes Tracking

openapi-pipeline-app bot commented Sep 7, 2022 •

edited

Loading

azure-pipelines bot commented Sep 7, 2022

openapi-pipeline-app bot commented Sep 7, 2022 •

edited

Loading

[Hub Generated] Review request for Microsoft.Maintenance to add version preview/2021-09-01-preview #20626

[Hub Generated] Review request for Microsoft.Maintenance to add version preview/2021-09-01-preview #20626

Conversation

KalpeshChavan12 commented Sep 7, 2022 • edited Loading

ARM API Information (Control Plane)

Changelog

Contribution checklist (MS Employees Only):

ARM API Review Checklist

Breaking Change Review Checklist

openapi-workflow-bot bot commented Sep 7, 2022

KalpeshChavan12 commented Sep 7, 2022

openapi-pipeline-app bot commented Sep 7, 2022 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Sep 7, 2022 • edited Loading

Swagger Generation Artifacts

Breaking Changes Tracking

openapi-pipeline-app bot commented Sep 7, 2022 • edited Loading

Generated ApiView

azure-pipelines bot commented Sep 7, 2022

openapi-pipeline-app bot commented Sep 7, 2022 • edited Loading

Swagger Validation Report

KalpeshChavan12 commented Sep 7, 2022 •

edited

Loading

openapi-pipeline-app bot commented Sep 7, 2022 •

edited

Loading

openapi-pipeline-app bot commented Sep 7, 2022 •

edited

Loading

openapi-pipeline-app bot commented Sep 7, 2022 •

edited

Loading

openapi-pipeline-app bot commented Sep 7, 2022 •

edited

Loading