Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release appcomplianceautomation microsoft.app compliance automation 2022 11 16 preview resolve comments 2 #21152

Merged
merged 9 commits into from
Oct 18, 2022
Merged

Release appcomplianceautomation microsoft.app compliance automation 2022 11 16 preview resolve comments 2 #21152

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
4dac4b1
fix comments
Oct 17, 2022
cb49745
remove duplicate in body
Oct 17, 2022
9373a20
resolve comments
Oct 17, 2022
05e5572
edit examples to match schema
Oct 17, 2022
476945f
fix failure
Oct 17, 2022
988b4e6
fix model validation
Oct 17, 2022
be90f98
change passed to passedCount
Oct 17, 2022
db3ef37
add x-ms-enum to isPass
Oct 17, 2022
1a5daa9
change delete 200 description
Oct 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
136 changes: 70 additions & 66 deletions ...Microsoft.AppComplianceAutomation/preview/2022-11-16-preview/appcomplianceautomation.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,52 +34,6 @@
}
},
"paths": {
"/providers/Microsoft.AppComplianceAutomation/operationResults/{operationId}": {
"get": {
"tags": [
"AppComplianceAutomation"
],
"description": "Query the ongoing operation status.",
"operationId": "OperationResults_Get",
"produces": [
"application/json"
],
"parameters": [
{
"$ref": "../../../../../common-types/resource-management/v3/types.json#/parameters/ApiVersionParameter"
},
{
"$ref": "../../../../../common-types/resource-management/v3/types.json#/parameters/OperationIdParameter"
}
],
"responses": {
"200": {
"description": "OK. The request has succeeded."
},
"202": {
"description": "Accepted. The request is still running."
},
"204": {
"description": "No Content. For Delete operation results."
},
"default": {
"description": "Error response.",
"schema": {
"$ref": "../../../../../common-types/resource-management/v3/types.json#/definitions/ErrorResponse"
}
}
},
"x-ms-long-running-operation": true,
"x-ms-long-running-operation-options": {
"final-state-via": "azure-async-operation"
},
"x-ms-examples": {
"OperationResults_Get": {
"$ref": "./examples/OperationResults_Get.json"
}
}
}
},
"/providers/Microsoft.AppComplianceAutomation/operations": {
"get": {
"tags": [
Expand Down Expand Up @@ -124,7 +78,7 @@
"tags": [
"AppComplianceAutomation"
],
"description": "Get the AppComplianceAutomation report list.",
"description": "Get the AppComplianceAutomation report list for the tenant.",
"operationId": "Reports_List",
"parameters": [
{
Expand Down Expand Up @@ -288,11 +242,8 @@
"$ref": "#/definitions/ReportResource"
}
},
"201": {
"description": "Long running operation support.",
"schema": {
"$ref": "#/definitions/ReportResource"
}
"202": {
"description": "Long running operation support."
},
"default": {
"description": "Error response.",
Expand Down Expand Up @@ -327,7 +278,7 @@
],
"responses": {
"200": {
"description": "Success. The response indicates the resource is already deleted."
"description": "Success. The response indicates the resource has been deleted."
},
"202": {
"description": "Accepted. The response indicates the delete operation is performed in the background."
Expand Down Expand Up @@ -464,13 +415,13 @@
"$ref": "#/parameters/SnapshotNameParameter"
},
{
"$ref": "#/parameters/ReportCreatorTenantIdParameter"
},
{
"$ref": "#/parameters/DownloadTypeParameter"
},
{
"$ref": "#/parameters/OfferGuidParameter"
"name": "parameters",
"in": "body",
"description": "Parameters for the query operation",
"required": true,
"schema": {
"$ref": "#/definitions/SnapshotDownloadRequest"
}
}
],
"responses": {
Expand Down Expand Up @@ -516,17 +467,17 @@
"description": "The overview of the compliance result for one report.",
"type": "object",
"properties": {
"passed": {
"passedCount": {
"format": "int32",
"type": "integer",
"description": "The count of all passed full automation control."
},
"failed": {
"failedCount": {
"format": "int32",
"type": "integer",
"description": "The count of all failed full automation control."
},
"manual": {
"manualCount": {
"format": "int32",
"type": "integer",
"description": "The count of all manual control."
Expand Down Expand Up @@ -835,9 +786,17 @@
"readOnly": true
},
"isPass": {
"type": "boolean",
"type": "string",
"enum": [
"True",
"False"
],
"readOnly": true,
"description": "Indicates whether all the resource(s) are compliant."
"description": "Indicates whether all the resource(s) are compliant.",
"x-ms-enum": {
"name": "IsPass",
"modelAsString": true
}
},
"policyId": {
"description": "The policy id mapping to this assessment.",
Expand Down Expand Up @@ -1026,6 +985,50 @@
}
}
},
"SnapshotDownloadRequest": {
"type": "object",
"description": "Snapshot's download request.",
"properties": {
"properties": {
"description": "Snapshot's download properties",
"$ref": "#/definitions/SnapshotDownloadProperties"
}
}
},
"SnapshotDownloadProperties": {
"type": "object",
"description": "Snapshot's download query properties.",
"required": [
"downloadType"
],
"properties": {
"reportCreatorTenantId": {
"description": "Tenant id.",
"type": "string"
},
"downloadType": {
"description": "Indicates the download type.",
"x-ms-parameter-location": "method",
"enum": [
"ComplianceReport",
"CompliancePdfReport",
"ComplianceDetailedPdfReport",
"ResourceList"
],
"type": "string",
"x-ms-enum": {
"name": "DownloadType",
"modelAsString": true
}
},
"offerGuid": {
"type": "string",
"description": "The offerGuid which mapping to the reports.",
"x-ms-parameter-location": "method",
"minLength": 1
}
}
},
"SnapshotProperties": {
"type": "object",
"description": "Snapshot's properties.",
Expand Down Expand Up @@ -1180,7 +1183,8 @@
"sasUri": {
"description": "uri of compliance pdf report",
"type": "string",
"readOnly": true
"readOnly": true,
"x-ms-secret": false
}
}
},
Expand Down
16 changes: 0 additions & 16 deletions ...oft.AppComplianceAutomation/preview/2022-11-16-preview/examples/OperationResults_Get.json
View file
Open in desktop

This file was deleted.

12 changes: 6 additions & 6 deletions ...ft.AppComplianceAutomation/preview/2022-11-16-preview/examples/Report_CreateOrUpdate.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,9 +48,9 @@
"provisioningState": "Succeeded",
"complianceStatus": {
"m365": {
"passed": 0,
"failed": 0,
"manual": 0
"passedCount": 0,
"failedCount": 0,
"manualCount": 0
}
}
},
Expand Down Expand Up @@ -92,9 +92,9 @@
],
"complianceStatus": {
"m365": {
"passed": 0,
"failed": 0,
"manual": 0
"passedCount": 0,
"failedCount": 0,
"manualCount": 0
}
},
"provisioningState": "Succeeded"
Expand Down
6 changes: 3 additions & 3 deletions ...ger/Microsoft.AppComplianceAutomation/preview/2022-11-16-preview/examples/Report_Get.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,9 @@
],
"complianceStatus": {
"m365": {
"passed": 0,
"failed": 0,
"manual": 0
"passedCount": 0,
"failedCount": 0,
"manualCount": 0
}
},
"provisioningState": "Succeeded"
Expand Down
51 changes: 4 additions & 47 deletions .../Microsoft.AppComplianceAutomation/preview/2022-11-16-preview/examples/Report_Update.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,9 +47,9 @@
],
"complianceStatus": {
"m365": {
"passed": 0,
"failed": 0,
"manual": 0
"passedCount": 0,
"failedCount": 0,
"manualCount": 0
}
},
"provisioningState": "Succeeded"
Expand All @@ -64,50 +64,7 @@
}
}
},
"201": {
"body": {
"id": "/provider/Microsfot.AppComplianceAutomation/reports/testReportName",
"name": "testReportName",
"type": "Microsfot.AppComplianceAutomation/reports",
"properties": {
"id": "00000000-0000-0000-0000-000000000000",
"status": "Active",
"tenantId": "00000000-0000-0000-0000-000000000000",
"reportName": "testReportName",
"offerGuid": "00000000-0000-0000-0000-000000000000",
"timeZone": "GMT Standard Time",
"triggerTime": "2022-03-02T05:17:23.922Z",
"nextTriggerTime": "2022-03-02T05:17:23.922Z",
"lastTriggerTime": "2022-03-02T05:17:23.922Z",
"subscriptions": [
"00000000-0000-0000-0000-000000000000"
],
"resources": [
{
"resourceId": "/subscriptions/00000000-0000-0000-0000-000000000000/resourcegroups/myResourceGroup/providers/Microsoft.SignalRService/SignalR/mySignalRService",
"tags": {
"key1": "value1"
}
}
],
"complianceStatus": {
"m365": {
"passed": 0,
"failed": 0,
"manual": 0
}
},
"provisioningState": "Succeeded"
},
"systemData": {
"createdBy": "00000000-0000-0000-0000-000000000000",
"createdByType": "User",
"createdAt": "2021-05-14T22:34:55.4499903Z",
"lastModifiedBy": "00000000-0000-0000-0000-000000000000",
"lastModifiedByType": "User",
"lastModifiedAt": "2021-05-14T22:34:55.4499903Z"
}
},
"202": {
"headers": {
"Location": "https://management.azure.com/providers/Microsoft.AppComplianceAutomation/operationResults/{operationId}",
"Azure-AsyncOperation": "https://management.azure.com/providers/Microsoft.AppComplianceAutomation/operationStatuses/{operationId}"
Expand Down
6 changes: 3 additions & 3 deletions ...r/Microsoft.AppComplianceAutomation/preview/2022-11-16-preview/examples/Reports_List.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,9 @@
],
"complianceStatus": {
"m365": {
"passed": 0,
"failed": 0,
"manual": 0
"passedCount": 0,
"failedCount": 0,
"manualCount": 0
}
},
"provisioningState": "Succeeded"
Expand Down
10 changes: 7 additions & 3 deletions ...on/preview/2022-11-16-preview/examples/Snapshot_ComplianceDetailedPdfReport_Download.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,13 @@
"api-version": "2022-11-16-preview",
"reportName": "testReportName",
"snapshotName": "testSnapshotName",
"downloadType": "ComplianceDetailedPdfReport",
"reportCreatorTenantId": "00000000-0000-0000-0000-000000000000",
"offerGuid": "00000000-0000-0000-0000-000000000000"
"parameters": {
"properties": {
"downloadType": "ComplianceDetailedPdfReport",
"reportCreatorTenantId": "00000000-0000-0000-0000-000000000000",
"offerGuid": "00000000-0000-0000-0000-000000000000"
}
}
},
"responses": {
"200": {
Expand Down
10 changes: 7 additions & 3 deletions ...Automation/preview/2022-11-16-preview/examples/Snapshot_CompliancePdfReport_Download.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,13 @@
"api-version": "2022-11-16-preview",
"reportName": "testReportName",
"snapshotName": "testSnapshotName",
"downloadType": "CompliancePdfReport",
"reportCreatorTenantId": "00000000-0000-0000-0000-000000000000",
"offerGuid": "00000000-0000-0000-0000-000000000000"
"parameters": {
"properties": {
"downloadType": "CompliancePdfReport",
"reportCreatorTenantId": "00000000-0000-0000-0000-000000000000",
"offerGuid": "00000000-0000-0000-0000-000000000000"
}
}
},
"responses": {
"200": {
Expand Down
10 changes: 7 additions & 3 deletions ...nceAutomation/preview/2022-11-16-preview/examples/Snapshot_ComplianceReport_Download.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,13 @@
"api-version": "2022-11-16-preview",
"reportName": "testReportName",
"snapshotName": "testSnapshotName",
"downloadType": "ComplianceReport",
"reportCreatorTenantId": "00000000-0000-0000-0000-000000000000",
"offerGuid": "00000000-0000-0000-0000-000000000000"
"parameters": {
"properties": {
"downloadType": "ComplianceReport",
"reportCreatorTenantId": "00000000-0000-0000-0000-000000000000",
"offerGuid": "00000000-0000-0000-0000-000000000000"
}
}
},
"responses": {
"200": {
Expand Down
Loading