[Hub Generated] Review request for Microsoft.ContainerInstance to add version preview/2022-10-01-preview #21530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e/2022-09-01 to version 2022-10-01-preview
…10-01-preview' of https://github.com/fnuarnav/azure-rest-api-specs into dev-containerinstance-Microsoft.ContainerInstance-2022-10-01-preview
|
Hi, @fnuarnav Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
ghost
added
the
Swagger Validation Report
|
| compared swaggers (via Oad v0.10.2)] | new version | base version |
|---|---|---|
| containerInstance.json | 2022-10-01-preview(be0248e) | 2022-09-01(main) |
| containerInstance.json | 2022-10-01-preview(be0248e) | 2018-02-01-preview(main) |
The following breaking changes are detected by comparison with the latest preview version:
Only 30 items are listed, please refer to log for more details.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️LintDiff: 0 Warnings warning [Detail]
| compared tags (via openapi-validator v2.0.0) | new version | base version |
|---|---|---|
| package-preview-2022-10 | package-preview-2022-10(be0248e) | default(main) |
The following errors/warnings exist before current PR submission:
Only 30 items are listed, please refer to log for more details.
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
️❌~[Staging] ServiceAPIReadinessTest: 13 Errors, 0 Warnings failed [Detail]
Tag package-preview-2022-10; Prod region: Deployed
Test run on region: westcentralus; Operation coverage: total: 18, untested: 0, failed: 13, passed: 5
Service API Readiness Test failed. Check pipeline artifact for detail report.
| Rule | Message |
|---|---|
|
"statusCode: 403, errorCode: LinkedAuthorizationFailed, errorMessage: The client has permission to perform action 'Microsoft.ManagedIdentity/userAssignedIdentities/assign/action' on scope '/subscriptions/db5eb68e-73e2-4fa8-b18a-46cd1be4cce5/resourceGroups/apiTest-sGhTZH-21530/providers/Microsoft.ContainerInstance/containerGroups/containerg1clg8f', however the linked subscription '00000000-0000-0000-0000-000000000000' was not found. " |
|
"statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.ContainerInstance/containerGroups/containerg1clg8f' under resource group 'apiTest-sGhTZH-21530' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix" |
|
"statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.ContainerInstance/containerGroups/containerg1clg8f' under resource group 'apiTest-sGhTZH-21530' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix" |
|
"statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.ContainerInstance/containerGroups/containerg1clg8f' under resource group 'apiTest-sGhTZH-21530' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix" |
|
"statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.ContainerInstance/containerGroups/containerg1clg8f' under resource group 'apiTest-sGhTZH-21530' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix" |
|
"statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.ContainerInstance/containerGroups/containerg1clg8f' under resource group 'apiTest-sGhTZH-21530' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix" |
|
"statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.ContainerInstance/containerGroups/containerg1clg8f' under resource group 'apiTest-sGhTZH-21530' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix" |
|
"statusCode: 502, errorCode: MultipleErrorsOccurred, errorMessage: Multiple error occurred: BadGateway, BadGateway, BadGateway, BadGateway, BadGateway, BadGateway, BadGateway, BadGateway, BadGateway, BadGateway. Please see details." |
|
"statusCode: 502, errorCode: MultipleErrorsOccurred, errorMessage: Multiple error occurred: BadGateway, BadGateway. Please see details." |
|
"statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.ContainerInstance/containerGroups/containerg1clg8f' under resource group 'apiTest-sGhTZH-21530' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix" |
|
"statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.ContainerInstance/containerGroups/containerg1clg8f' under resource group 'apiTest-sGhTZH-21530' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix" |
|
"statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.ContainerInstance/containerGroups/containerg1clg8f' under resource group 'apiTest-sGhTZH-21530' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix" |
|
"statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.Network/virtualNetworks/virtualnet0u2lyh' under resource group 'apiTest-sGhTZH-21530' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix" |
️️✔️~[Staging] SwaggerAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️CadlValidation succeeded [Detail] [Expand]
Validation passes for CadlValidation.
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
Swagger Generation Artifacts
|
Generated ApiView
|
This was referenced Nov 11, 2022
This was referenced Nov 11, 2022
mlalic
reviewed
Nov 14, 2022
| }, | ||
| "priority": { | ||
| "type": "string", | ||
| "description": "The priority of containers in the container group.", |
There was a problem hiding this comment.
This isn't wrong or incorrect, but not sure there's a benefit in referring to the containers here at all. This is the priority of the container group as a whole.
…10-01-preview' of https://github.com/fnuarnav/azure-rest-api-specs into dev-containerinstance-Microsoft.ContainerInstance-2022-10-01-preview
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
AzureRestAPISpecReview
added
new-api-version
ReadyForApiTest
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
LGTM. |
visingla-ms
added
the
ARMSignedOff
openapi-workflow-bot
bot
removed
the
WaitForARMFeedback
|
@fengzhou-msft could you help with the track2 dotnet SDK failure ? |
The breaking change in .NET SDK which caused the failure was not caused by this PR. It can be ignored. |
This was referenced Dec 4, 2022
anandanthony
pushed a commit
to anandMicro/azure-rest-api-specs
that referenced
this pull request
Dec 16, 2022
… version preview/2022-10-01-preview (Azure#21530) * Adds base for updating Microsoft.ContainerInstance from version stable/2022-09-01 to version 2022-10-01-preview * Updates readme * Updates API version in new specs and examples * added ConfidentialComputeProperties, and Confidential ContainerGroupSku * added Untested confidential container example * Add priority property to ContainerGroup * Add examples with priority property * removed IsolationType from ConfidentialComputeProperties * fixed spellcheck issues * Change priority description Co-authored-by: Divya Bharadwaj Yellapragada <[email protected]>
kayousef-zz
pushed a commit
to kayousef-zz/azure-rest-api-specs
that referenced
this pull request
Dec 21, 2022
… version preview/2022-10-01-preview (Azure#21530) * Adds base for updating Microsoft.ContainerInstance from version stable/2022-09-01 to version 2022-10-01-preview * Updates readme * Updates API version in new specs and examples * added ConfidentialComputeProperties, and Confidential ContainerGroupSku * added Untested confidential container example * Add priority property to ContainerGroup * Add examples with priority property * removed IsolationType from ConfidentialComputeProperties * fixed spellcheck issues * Change priority description Co-authored-by: Divya Bharadwaj Yellapragada <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
ARM API Information (Control Plane)
Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist (MS Employees Only):
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.