-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review request for Microsoft.RecoveryServices to add version stable/2023-01-01 #22045
Review request for Microsoft.RecoveryServices to add version stable/2023-01-01 #22045
Conversation
Hi, @singhabh27 Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
Swagger Validation Report
|
compared swaggers (via Oad v0.10.4)] | new version | base version |
---|---|---|
registeredidentities.json | 2023-01-01(69ccec4) | 2022-10-01(main) |
registeredidentities.json | 2023-01-01(69ccec4) | 2022-09-30-preview(main) |
replicationusages.json | 2023-01-01(69ccec4) | 2022-10-01(main) |
replicationusages.json | 2023-01-01(69ccec4) | 2022-09-30-preview(main) |
vaults.json | 2023-01-01(69ccec4) | 2022-10-01(main) |
vaults.json | 2023-01-01(69ccec4) | 2022-09-30-preview(main) |
vaultusages.json | 2023-01-01(69ccec4) | 2022-10-01(main) |
vaultusages.json | 2023-01-01(69ccec4) | 2022-09-30-preview(main) |
️️✔️
CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️
LintDiff succeeded [Detail] [Expand]
Validation passes for LintDiff.
compared tags (via openapi-validator v2.0.0) | new version | base version |
---|---|---|
package-2023-01 | package-2023-01(69ccec4) | default(main) |
️️✔️
Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️
ApiReadinessCheck succeeded [Detail] [Expand]
️❌
~[Staging] ServiceAPIReadinessTest: 31 Errors, 0 Warnings failed [Detail]
Tag package-2023-01; Prod region: Deployed
Test run on region: westcentralus; Operation coverage: total: 20, untested: 0, failed: 13, passed: 7
Service API Readiness Test failed. Check pipeline artifact for detail report.
Only 30 items are listed, please refer to log for more details.
Rule | Message |
---|---|
CLIENT_ERROR |
statusCode: 404, errorCode: InvalidResourceType, errorMessage: The resource type 'locations/checkNameAvailability' could not be found in the namespace 'Microsoft.RecoveryServices' for api version '2023-01-01'. The supported api-versions are '2018-01-10'. Source: runtime OperationId: RecoveryServices_CheckNameAvailability |
OBJECT_ADDITIONAL_PROPERTIES |
Additional properties not allowed: identityUrl Source: response OperationId: Vaults_ListBySubscriptionId |
OBJECT_ADDITIONAL_PROPERTIES |
Additional properties not allowed: identityUrl Source: response OperationId: Vaults_ListByResourceGroup |
OBJECT_ADDITIONAL_PROPERTIES |
Additional properties not allowed: location Source: response OperationId: VaultExtendedInfo_CreateOrUpdate |
OBJECT_ADDITIONAL_PROPERTIES |
Additional properties not allowed: tags Source: response OperationId: VaultExtendedInfo_CreateOrUpdate |
OBJECT_ADDITIONAL_PROPERTIES |
Additional properties not allowed: identity Source: response OperationId: VaultExtendedInfo_CreateOrUpdate |
OBJECT_ADDITIONAL_PROPERTIES |
Additional properties not allowed: sku Source: response OperationId: VaultExtendedInfo_CreateOrUpdate |
OBJECT_ADDITIONAL_PROPERTIES |
Additional properties not allowed: location Source: response OperationId: VaultExtendedInfo_Get |
OBJECT_ADDITIONAL_PROPERTIES |
Additional properties not allowed: tags Source: response OperationId: VaultExtendedInfo_Get |
OBJECT_ADDITIONAL_PROPERTIES |
Additional properties not allowed: identity Source: response OperationId: VaultExtendedInfo_Get |
OBJECT_ADDITIONAL_PROPERTIES |
Additional properties not allowed: sku Source: response OperationId: VaultExtendedInfo_Get |
CLIENT_ERROR |
statusCode: 412, errorCode: undefined, errorMessage: undefined Source: runtime OperationId: VaultExtendedInfo_Update |
INVALID_RESPONSE_BODY |
Body is required in response but not provided Source: response OperationId: VaultExtendedInfo_Update |
CLIENT_ERROR |
statusCode: 400, errorCode: undefined, errorMessage: undefined Source: runtime OperationId: VaultCertificates_Create |
INVALID_RESPONSE_CODE |
The swagger file does not define '400' response code Source: response OperationId: VaultCertificates_Create |
CLIENT_ERROR |
statusCode: 404, errorCode: ResourceNotFound, errorMessage: Could not perform the operation as VM no longer exists. Stop protecting virtual machine without deleting backup data. More details at http://go.microsoft.com/fwlink/?LinkId=808124 Source: runtime OperationId: RegisteredIdentities_Delete |
INVALID_RESPONSE_CODE |
The swagger file does not define '404' response code Source: response OperationId: RegisteredIdentities_Delete |
OBJECT_ADDITIONAL_PROPERTIES |
Additional properties not allowed: monitoringSummary Source: response OperationId: ReplicationUsages_List |
OBJECT_ADDITIONAL_PROPERTIES |
Additional properties not allowed: jobsSummary Source: response OperationId: ReplicationUsages_List |
OBJECT_ADDITIONAL_PROPERTIES |
Additional properties not allowed: protectedItemsSummary Source: response OperationId: ReplicationUsages_List |
OBJECT_ADDITIONAL_PROPERTIES |
Additional properties not allowed: storageAccountsCountSummary Source: response OperationId: ReplicationUsages_List |
OBJECT_ADDITIONAL_PROPERTIES |
Additional properties not allowed: protectedItemCount Source: response OperationId: ReplicationUsages_List |
OBJECT_ADDITIONAL_PROPERTIES |
Additional properties not allowed: registeredServersCount Source: response OperationId: ReplicationUsages_List |
OBJECT_ADDITIONAL_PROPERTIES |
Additional properties not allowed: recoveryPlanCount Source: response OperationId: ReplicationUsages_List |
CLIENT_ERROR |
statusCode: 403, errorCode: AuthorizationFailed, errorMessage: The client '7904a8be-825f-480e-a728-80a70579dba4' with object id '7904a8be-825f-480e-a728-80a70579dba4' does not have authorization to perform action 'Microsoft.RecoveryServices/locations/capabilities/action' over scope '/subscriptions/db5eb68e-73e2-4fa8-b18a-46cd1be4cce5' or the scope is invalid. If access was recently granted, please refresh your credentials. Source: runtime OperationId: RecoveryServices_Capabilities |
CLIENT_ERROR |
statusCode: 400, errorCode: CloudInvalidInputError, errorMessage: The current operation failed due to an internal service error "Invalid input error". Please retry the operation after some time. If the issue persists, please contact Microsoft support. Source: runtime OperationId: GetOperationResult |
OBJECT_ADDITIONAL_PROPERTIES |
Additional properties not allowed: innerError Source: response OperationId: GetOperationResult |
CLIENT_ERROR |
statusCode: 400, errorCode: CloudInvalidInputError, errorMessage: The current operation failed due to an internal service error "Invalid input error". Please retry the operation after some time. If the issue persists, please contact Microsoft support. Source: runtime OperationId: GetOperationStatus |
OBJECT_ADDITIONAL_PROPERTIES |
Additional properties not allowed: innerError Source: response OperationId: GetOperationStatus |
CLIENT_ERROR |
statusCode: 404, errorCode: undefined, errorMessage: undefined Source: runtime OperationId: PrivateLinkResources_Get |
️️✔️
~[Staging] SwaggerAPIView succeeded [Detail] [Expand]
️️✔️
~[Staging] CadlAPIView succeeded [Detail] [Expand]
️️✔️
ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️
PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️
PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️
SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️
Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️
CadlValidation succeeded [Detail] [Expand]
Validation passes for CadlValidation.
️️✔️
PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
Swagger Generation Artifacts
|
Generated ApiView
|
Hi, @singhabh27 your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board([email protected]). |
/azp run unifiedPipeline |
No pipelines are associated with this pull request. |
Hi, @singhabh27, For review efficiency consideration, when creating a new api version, it is required to place API specs of the base version in the first commit, and push new version updates into successive commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki. Or you could onboard API spec pipeline |
New API version with no API changes, so no ARM feedback needed. |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
@singhabh27 The PR looks good, but the Service APIs seem not deployed yet (see ServiceApiReadinessTest pipeline result). Please deploy your service APIs then we'll merge this PR to main. |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
@leni-msft , please merge the PR. |
…vices to add version stable/2023-01-01 (#2752) Create to sync Azure/azure-rest-api-specs#22045 [ReCreate this PR](https://github.com/azure-resource-manager-schemas/compare/main...azure-sdk:sdkAuto/recoveryservices?expand=1)
ARM API Information (Control Plane)
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist (MS Employees Only):
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.