Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review request for Microsoft.RecoveryServices to add version stable/2023-01-01 #22045

Conversation

singhabh27
Copy link
Contributor

@singhabh27 singhabh27 commented Jan 4, 2023

ARM API Information (Control Plane)

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @singhabh27 Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jan 4, 2023

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
    There are no breaking changes.
    compared swaggers (via Oad v0.10.4)] new version base version
    registeredidentities.json 2023-01-01(69ccec4) 2022-10-01(main)
    registeredidentities.json 2023-01-01(69ccec4) 2022-09-30-preview(main)
    replicationusages.json 2023-01-01(69ccec4) 2022-10-01(main)
    replicationusages.json 2023-01-01(69ccec4) 2022-09-30-preview(main)
    vaults.json 2023-01-01(69ccec4) 2022-10-01(main)
    vaults.json 2023-01-01(69ccec4) 2022-09-30-preview(main)
    vaultusages.json 2023-01-01(69ccec4) 2022-10-01(main)
    vaultusages.json 2023-01-01(69ccec4) 2022-09-30-preview(main)
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️️✔️LintDiff succeeded [Detail] [Expand]
    Validation passes for LintDiff.
    compared tags (via openapi-validator v2.0.0) new version base version
    package-2023-01 package-2023-01(69ccec4) default(main)
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
    ️❌~[Staging] ServiceAPIReadinessTest: 31 Errors, 0 Warnings failed [Detail]

    Tag package-2023-01; Prod region: Deployed

    Test run on region: westcentralus; Operation coverage: total: 20, untested: 0, failed: 13, passed: 7

    Service API Readiness Test failed. Check pipeline artifact for detail report.

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    CLIENT_ERROR statusCode: 404,
    errorCode: InvalidResourceType,
    errorMessage: The resource type 'locations/checkNameAvailability' could not be found in the namespace 'Microsoft.RecoveryServices' for api version '2023-01-01'. The supported api-versions are '2018-01-10'.
    Source: runtime
    OperationId: RecoveryServices_CheckNameAvailability
    OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: identityUrl
    Source: response
    OperationId: Vaults_ListBySubscriptionId
    OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: identityUrl
    Source: response
    OperationId: Vaults_ListByResourceGroup
    OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: location
    Source: response
    OperationId: VaultExtendedInfo_CreateOrUpdate
    OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: tags
    Source: response
    OperationId: VaultExtendedInfo_CreateOrUpdate
    OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: identity
    Source: response
    OperationId: VaultExtendedInfo_CreateOrUpdate
    OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: sku
    Source: response
    OperationId: VaultExtendedInfo_CreateOrUpdate
    OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: location
    Source: response
    OperationId: VaultExtendedInfo_Get
    OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: tags
    Source: response
    OperationId: VaultExtendedInfo_Get
    OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: identity
    Source: response
    OperationId: VaultExtendedInfo_Get
    OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: sku
    Source: response
    OperationId: VaultExtendedInfo_Get
    CLIENT_ERROR statusCode: 412,
    errorCode: undefined,
    errorMessage: undefined
    Source: runtime
    OperationId: VaultExtendedInfo_Update
    INVALID_RESPONSE_BODY Body is required in response but not provided
    Source: response
    OperationId: VaultExtendedInfo_Update
    CLIENT_ERROR statusCode: 400,
    errorCode: undefined,
    errorMessage: undefined
    Source: runtime
    OperationId: VaultCertificates_Create
    INVALID_RESPONSE_CODE The swagger file does not define '400' response code
    Source: response
    OperationId: VaultCertificates_Create
    CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: Could not perform the operation as VM no longer exists. Stop protecting virtual machine without deleting backup data. More details at http://go.microsoft.com/fwlink/?LinkId=808124
    Source: runtime
    OperationId: RegisteredIdentities_Delete
    INVALID_RESPONSE_CODE The swagger file does not define '404' response code
    Source: response
    OperationId: RegisteredIdentities_Delete
    OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: monitoringSummary
    Source: response
    OperationId: ReplicationUsages_List
    OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: jobsSummary
    Source: response
    OperationId: ReplicationUsages_List
    OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: protectedItemsSummary
    Source: response
    OperationId: ReplicationUsages_List
    OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: storageAccountsCountSummary
    Source: response
    OperationId: ReplicationUsages_List
    OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: protectedItemCount
    Source: response
    OperationId: ReplicationUsages_List
    OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: registeredServersCount
    Source: response
    OperationId: ReplicationUsages_List
    OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: recoveryPlanCount
    Source: response
    OperationId: ReplicationUsages_List
    CLIENT_ERROR statusCode: 403,
    errorCode: AuthorizationFailed,
    errorMessage: The client '7904a8be-825f-480e-a728-80a70579dba4' with object id '7904a8be-825f-480e-a728-80a70579dba4' does not have authorization to perform action 'Microsoft.RecoveryServices/locations/capabilities/action' over scope '/subscriptions/db5eb68e-73e2-4fa8-b18a-46cd1be4cce5' or the scope is invalid. If access was recently granted, please refresh your credentials.
    Source: runtime
    OperationId: RecoveryServices_Capabilities
    CLIENT_ERROR statusCode: 400,
    errorCode: CloudInvalidInputError,
    errorMessage: The current operation failed due to an internal service error "Invalid input error". Please retry the operation after some time. If the issue persists, please contact Microsoft support.
    Source: runtime
    OperationId: GetOperationResult
    OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: innerError
    Source: response
    OperationId: GetOperationResult
    CLIENT_ERROR statusCode: 400,
    errorCode: CloudInvalidInputError,
    errorMessage: The current operation failed due to an internal service error "Invalid input error". Please retry the operation after some time. If the issue persists, please contact Microsoft support.
    Source: runtime
    OperationId: GetOperationStatus
    OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: innerError
    Source: response
    OperationId: GetOperationStatus
    CLIENT_ERROR statusCode: 404,
    errorCode: undefined,
    errorMessage: undefined
    Source: runtime
    OperationId: PrivateLinkResources_Get
    ️️✔️~[Staging] SwaggerAPIView succeeded [Detail] [Expand]
    ️️✔️~[Staging] CadlAPIView succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️PoliCheck succeeded [Detail] [Expand]
    Validation passed for PoliCheck.
    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    ️️✔️CadlValidation succeeded [Detail] [Expand]
    Validation passes for CadlValidation.
    ️️✔️PR Summary succeeded [Detail] [Expand]
    Validation passes for Summary.
    Posted by Swagger Pipeline | How to fix these errors?

    @ghost ghost added the RecoveryServices label Jan 4, 2023
    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jan 4, 2023

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️❌SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking

    azure-sdk-for-go - sdk/resourcemanager/recoveryservices/armrecoveryservices - 2.0.0
    +	Struct `CloudError` has been removed
    +	Type of `ErrorAdditionalInfo.Info` has been changed from `interface{}` to `any`


    ️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 15045fe. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
      cmderr	[automation_generate.sh]
      cmderr	[automation_generate.sh] npm notice New major version of npm available! 8.19.3 -> 9.3.1
      cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.3.1>
      cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
      cmderr	[automation_generate.sh] npm notice
    • ️✔️track2_azure-mgmt-recoveryservices [View full logs]  [Release SDK Changes]
      info	[Changelog]
    ️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 15045fe. SDK Automation 14.0.0
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️sdk/resourcemanager/recoveryservices/armrecoveryservices [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] ### Breaking Changes
      info	[Changelog]
      info	[Changelog] - Type of `ErrorAdditionalInfo.Info` has been changed from `interface{}` to `any`
      info	[Changelog] - Struct `CloudError` has been removed
      info	[Changelog]
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog] - New type alias `ImmutabilityState` with values `ImmutabilityStateDisabled`, `ImmutabilityStateLocked`, `ImmutabilityStateUnlocked`
      info	[Changelog] - New type alias `PublicNetworkAccess` with values `PublicNetworkAccessDisabled`, `PublicNetworkAccessEnabled`
      info	[Changelog] - New type alias `VaultSubResourceType` with values `VaultSubResourceTypeAzureBackup`, `VaultSubResourceTypeAzureBackupSecondary`, `VaultSubResourceTypeAzureSiteRecovery`
      info	[Changelog] - New function `*Client.Capabilities(context.Context, string, ResourceCapabilities, *ClientCapabilitiesOptions) (ClientCapabilitiesResponse, error)`
      info	[Changelog] - New struct `CapabilitiesProperties`
      info	[Changelog] - New struct `CapabilitiesResponse`
      info	[Changelog] - New struct `CapabilitiesResponseProperties`
      info	[Changelog] - New struct `DNSZone`
      info	[Changelog] - New struct `DNSZoneResponse`
      info	[Changelog] - New struct `ImmutabilitySettings`
      info	[Changelog] - New struct `ResourceCapabilities`
      info	[Changelog] - New struct `ResourceCapabilitiesBase`
      info	[Changelog] - New struct `SecuritySettings`
      info	[Changelog] - New field `GroupIDs` in struct `PrivateEndpointConnection`
      info	[Changelog] - New field `PublicNetworkAccess` in struct `VaultProperties`
      info	[Changelog] - New field `SecuritySettings` in struct `VaultProperties`
      info	[Changelog]
      info	[Changelog] Total 3 breaking change(s), 32 additive change(s).
    ️❌ azure-sdk-for-js failed [Detail]
    • Code Generator Failed [Logs]Release - Generate from 15045fe. SDK Automation 14.0.0
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
      warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
      command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
      cmderr	[automation_generate.sh] [ERROR] An error occurred while generating codes for readme file: "specification/recoveryservices/resource-manager/readme.md":
      cmderr	[automation_generate.sh] [ERROR] Err: Error: Command failed: autorest --version=3.9.3 --typescript --modelerfour.lenient-model-deduplication --azure-arm --head-as-boolean=true --license-header=MICROSOFT_MIT_NO_VERSION --generate-test --typescript-sdks-folder=/mnt/vss/_work/1/s/azure-sdk-for-js ../azure-rest-api-specs/specification/recoveryservices/resource-manager/readme.md --use=@autorest/[email protected]
      cmderr	[automation_generate.sh] [ERROR] Stderr: "null"
      cmderr	[automation_generate.sh] [ERROR] Stdout: "null"
      cmderr	[automation_generate.sh] [ERROR] ErrorStack: "Error: Command failed: autorest --version=3.9.3 --typescript --modelerfour.lenient-model-deduplication --azure-arm --head-as-boolean=true --license-header=MICROSOFT_MIT_NO_VERSION --generate-test --typescript-sdks-folder=/mnt/vss/_work/1/s/azure-sdk-for-js ../azure-rest-api-specs/specification/recoveryservices/resource-manager/readme.md --use=@autorest/[email protected]
      cmderr	[automation_generate.sh] [ERROR]     at checkExecSyncError (node:child_process:861:11)
      cmderr	[automation_generate.sh] [ERROR]     at Object.execSync (node:child_process:932:15)
      cmderr	[automation_generate.sh] [ERROR]     at Object.<anonymous> (/opt/hostedtoolcache/node/16.19.0/x64/lib/node_modules/@azure-tools/js-sdk-release-tools/dist/hlc/generateMgmt.js:39:33)
      cmderr	[automation_generate.sh] [ERROR]     at Generator.next (<anonymous>)
      cmderr	[automation_generate.sh] [ERROR]     at /opt/hostedtoolcache/node/16.19.0/x64/lib/node_modules/@azure-tools/js-sdk-release-tools/node_modules/tslib/tslib.js:115:75
      cmderr	[automation_generate.sh] [ERROR]     at new Promise (<anonymous>)
      cmderr	[automation_generate.sh] [ERROR]     at Object.__awaiter (/opt/hostedtoolcache/node/16.19.0/x64/lib/node_modules/@azure-tools/js-sdk-release-tools/node_modules/tslib/tslib.js:111:16)
      cmderr	[automation_generate.sh] [ERROR]     at Object.generateMgmt (/opt/hostedtoolcache/node/16.19.0/x64/lib/node_modules/@azure-tools/js-sdk-release-tools/dist/hlc/generateMgmt.js:20:20)
      cmderr	[automation_generate.sh] [ERROR]     at /opt/hostedtoolcache/node/16.19.0/x64/lib/node_modules/@azure-tools/js-sdk-release-tools/dist/autoGenerateInPipeline.js:43:34"
      error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-js]: sh .scripts/automation_generate.sh
      warn	Skip package processing as generation is failed
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 15045fe. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh]  WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh] npm WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] npm WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    • ️✔️recoveryservices [View full logs]  [Release Schema Changes]
    ️️✔️ azure-powershell succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 15045fe. SDK Automation 14.0.0
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
      command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
    • ️✔️Az.RecoveryServices [View full logs]  [Release SDK Changes]
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jan 4, 2023

    Generated ApiView

    Language Package Name ApiView Link
    Go sdk/resourcemanager/recoveryservices/armrecoveryservices https://apiview.dev/Assemblies/Review/c3dc30408a6445909f5b07daf61a8be9
    Java azure-resourcemanager-recoveryservices https://apiview.dev/Assemblies/Review/6a2fba124fd54840ad7357254a915416
    .Net Azure.ResourceManager.RecoveryServices https://apiview.dev/Assemblies/Review/2bda7a4fcc0b460f8b00f22668e0b8bb

    @singhabh27 singhabh27 added the DoNotMerge <valid label in PR review process> use to hold merge after approval label Jan 4, 2023
    @openapi-workflow-bot openapi-workflow-bot bot added ARMReview WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jan 4, 2023
    @openapi-workflow-bot
    Copy link

    Hi, @singhabh27 your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board([email protected]).

    @singhabh27 singhabh27 marked this pull request as ready for review January 4, 2023 10:01
    @Azure Azure deleted a comment from azure-pipelines bot Jan 4, 2023
    @singhabh27
    Copy link
    Contributor Author

    /azp run unifiedPipeline

    @azure-pipelines
    Copy link

    No pipelines are associated with this pull request.

    @openapi-workflow-bot
    Copy link

    Hi, @singhabh27, For review efficiency consideration, when creating a new api version, it is required to place API specs of the base version in the first commit, and push new version updates into successive commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki. Or you could onboard API spec pipeline

    @mentat9
    Copy link
    Member

    mentat9 commented Jan 6, 2023

    New API version with no API changes, so no ARM feedback needed.

    @mentat9 mentat9 added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Jan 6, 2023
    @openapi-workflow-bot openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jan 6, 2023
    @leniatgh
    Copy link
    Contributor

    leniatgh commented Jan 6, 2023

    /azp run

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @leniatgh
    Copy link
    Contributor

    leniatgh commented Jan 9, 2023

    @singhabh27 The PR looks good, but the Service APIs seem not deployed yet (see ServiceApiReadinessTest pipeline result). Please deploy your service APIs then we'll merge this PR to main.

    @leniatgh
    Copy link
    Contributor

    /azp run

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @singhabh27 singhabh27 removed the DoNotMerge <valid label in PR review process> use to hold merge after approval label Jan 16, 2023
    @singhabh27
    Copy link
    Contributor Author

    /azp run

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @openapi-pipeline-app openapi-pipeline-app bot added the DoNotMerge <valid label in PR review process> use to hold merge after approval label Jan 19, 2023
    @singhabh27
    Copy link
    Contributor Author

    /azp run

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @singhabh27
    Copy link
    Contributor Author

    @leni-msft , please merge the PR.

    @singhabh27 singhabh27 removed the DoNotMerge <valid label in PR review process> use to hold merge after approval label Jan 24, 2023
    @ruowan ruowan merged commit 15045fe into Azure:main Jan 24, 2023
    @openapi-pipeline-app openapi-pipeline-app bot added the DoNotMerge <valid label in PR review process> use to hold merge after approval label Jan 24, 2023
    ghost pushed a commit to Azure/azure-resource-manager-schemas that referenced this pull request Jan 24, 2023
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review CI-BreakingChange-Go CI-MissingBaseCommit DoNotMerge <valid label in PR review process> use to hold merge after approval new-api-version ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test RecoveryServices resource-manager
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    5 participants