Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new preview version 2022-09-30-preview for private link #23067

Merged
merged 22 commits into from
Apr 14, 2023

Conversation

xiaoxuqi-ms
Copy link
Member

@xiaoxuqi-ms xiaoxuqi-ms commented Mar 14, 2023

ARM API Information (Control Plane)

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @xiaoxuqi-ms Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    @ghost ghost added the MySQL label Mar 14, 2023
    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Mar 14, 2023

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.
    ️❌Breaking Change(Cross-Version): 32 Errors, 40 Warnings failed [Detail]
    compared swaggers (via Oad v0.10.4)] new version base version
    PrivateEndpointConnections.json 2022-09-30-preview(efd5cd2) 2018-06-01(main)
    PrivateEndpointConnections.json 2022-09-30-preview(efd5cd2) 2018-06-01-privatepreview(main)
    PrivateLinkResources.json 2022-09-30-preview(efd5cd2) 2018-06-01(main)
    PrivateLinkResources.json 2022-09-30-preview(efd5cd2) 2018-06-01-privatepreview(main)

    The following breaking changes are detected by comparison with the latest stable version:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DBforMySQL/servers/{serverName}/privateEndpointConnections/{privateEndpointConnectionName}' removed or restructured?
    Old: legacy/stable/2018-06-01/PrivateEndpointConnections.json#L37:5
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DBforMySQL/servers/{serverName}/privateEndpointConnections' removed or restructured?
    Old: legacy/stable/2018-06-01/PrivateEndpointConnections.json#L251:5
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DBforMySQL/servers/{serverName}/privateLinkResources' removed or restructured?
    Old: legacy/stable/2018-06-01/PrivateLinkResources.json#L37:5
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DBforMySQL/servers/{serverName}/privateLinkResources/{groupName}' removed or restructured?
    Old: legacy/stable/2018-06-01/PrivateLinkResources.json#L82:5
    1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'PrivateEndpointProperty' removed or renamed?
    New: PrivateLink/preview/2022-09-30-preview/PrivateEndpointConnections.json#L260:3
    Old: legacy/stable/2018-06-01/PrivateEndpointConnections.json#L297:3
    1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'PrivateLinkServiceConnectionStateProperty' removed or renamed?
    New: PrivateLink/preview/2022-09-30-preview/PrivateEndpointConnections.json#L260:3
    Old: legacy/stable/2018-06-01/PrivateEndpointConnections.json#L297:3
    1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: common-types/resource-management/v4/types.json#L625:5
    Old: common-types/resource-management/v1/types.json#L551:5
    1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: common-types/resource-management/v4/types.json#L625:5
    Old: common-types/resource-management/v1/types.json#L551:5
    1025 - RequiredStatusChange The 'required' status changed from the old version('False') to the new version('True').
    New: common-types/resource-management/v4/privatelinks.json#L38:7
    Old: legacy/stable/2018-06-01/PrivateEndpointConnections.json#L301:7
    1025 - RequiredStatusChange The 'required' status changed from the old version('True') to the new version('False').
    New: common-types/resource-management/v4/privatelinks.json#L67:7
    Old: legacy/stable/2018-06-01/PrivateEndpointConnections.json#L333:7
    1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.
    New: common-types/resource-management/v4/privatelinks.json#L12:9
    Old: legacy/stable/2018-06-01/PrivateEndpointConnections.json#L320:9
    1029 - ReadonlyPropertyChanged The read only property has changed from 'true' to 'false'.
    New: common-types/resource-management/v4/privatelinks.json#L76:9
    Old: legacy/stable/2018-06-01/PrivateEndpointConnections.json#L342:9
    1029 - ReadonlyPropertyChanged The read only property has changed from 'true' to 'false'.
    New: common-types/resource-management/v4/privatelinks.json#L156:9
    Old: legacy/stable/2018-06-01/PrivateEndpointConnections.json#L369:9
    1029 - ReadonlyPropertyChanged The read only property has changed from 'true' to 'false'.
    New: common-types/resource-management/v4/privatelinks.json#L169:9
    Old: legacy/stable/2018-06-01/PrivateLinkResources.json#L137:9
    1033 - RemovedProperty The new version is missing a property found in the old version. Was 'nextLink' renamed or removed?
    New: common-types/resource-management/v4/privatelinks.json#L155:7
    Old: legacy/stable/2018-06-01/PrivateEndpointConnections.json#L368:7
    1033 - RemovedProperty The new version is missing a property found in the old version. Was 'code' renamed or removed?
    New: common-types/resource-management/v4/types.json#L306:7
    Old: common-types/resource-management/v1/types.json#L289:7
    1033 - RemovedProperty The new version is missing a property found in the old version. Was 'message' renamed or removed?
    New: common-types/resource-management/v4/types.json#L306:7
    Old: common-types/resource-management/v1/types.json#L289:7
    1033 - RemovedProperty The new version is missing a property found in the old version. Was 'target' renamed or removed?
    New: common-types/resource-management/v4/types.json#L306:7
    Old: common-types/resource-management/v1/types.json#L289:7
    1033 - RemovedProperty The new version is missing a property found in the old version. Was 'details' renamed or removed?
    New: common-types/resource-management/v4/types.json#L306:7
    Old: common-types/resource-management/v1/types.json#L289:7
    1033 - RemovedProperty The new version is missing a property found in the old version. Was 'additionalInfo' renamed or removed?
    New: common-types/resource-management/v4/types.json#L306:7
    Old: common-types/resource-management/v1/types.json#L289:7
    1033 - RemovedProperty The new version is missing a property found in the old version. Was 'nextLink' renamed or removed?
    New: common-types/resource-management/v4/privatelinks.json#L168:7
    Old: legacy/stable/2018-06-01/PrivateLinkResources.json#L136:7
    1033 - RemovedProperty The new version is missing a property found in the old version. Was 'code' renamed or removed?
    New: common-types/resource-management/v4/types.json#L306:7
    Old: common-types/resource-management/v1/types.json#L289:7
    1033 - RemovedProperty The new version is missing a property found in the old version. Was 'message' renamed or removed?
    New: common-types/resource-management/v4/types.json#L306:7
    Old: common-types/resource-management/v1/types.json#L289:7
    1033 - RemovedProperty The new version is missing a property found in the old version. Was 'target' renamed or removed?
    New: common-types/resource-management/v4/types.json#L306:7
    Old: common-types/resource-management/v1/types.json#L289:7
    1033 - RemovedProperty The new version is missing a property found in the old version. Was 'details' renamed or removed?
    New: common-types/resource-management/v4/types.json#L306:7
    Old: common-types/resource-management/v1/types.json#L289:7
    1033 - RemovedProperty The new version is missing a property found in the old version. Was 'additionalInfo' renamed or removed?
    New: common-types/resource-management/v4/types.json#L306:7
    Old: common-types/resource-management/v1/types.json#L289:7
    1034 - AddedRequiredProperty The new version has new required property 'privateLinkServiceConnectionState' that was not found in the old version.
    New: common-types/resource-management/v4/privatelinks.json#L36:5
    Old: legacy/stable/2018-06-01/PrivateEndpointConnections.json#L298:5
    1034 - AddedRequiredProperty The new version has new required property 'privateLinkServiceConnectionState' that was not found in the old version.
    New: common-types/resource-management/v4/privatelinks.json#L23:9
    Old: legacy/stable/2018-06-01/PrivateEndpointConnections.json#L358:9
    1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.DBforMySQL/common-types/v1/common-types.json#L10:5
    Old: legacy/stable/2018-06-01/PrivateEndpointConnections.json#L407:5
    1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.DBforMySQL/common-types/v1/common-types.json#L10:5
    Old: legacy/stable/2018-06-01/PrivateLinkResources.json#L198:5


    The following breaking changes are detected by comparison with the latest preview version:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DBforMySQL/servers/{serverName}/privateEndpointConnections/{privateEndpointConnectionName}' removed or restructured?
    Old: legacy/preview/2018-06-01-privatepreview/PrivateEndpointConnections.json#L37:5
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DBforMySQL/servers/{serverName}/privateEndpointConnections' removed or restructured?
    Old: legacy/preview/2018-06-01-privatepreview/PrivateEndpointConnections.json#L251:5
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DBforMySQL/servers/{serverName}/privateLinkResources' removed or restructured?
    Old: legacy/preview/2018-06-01-privatepreview/PrivateLinkResources.json#L37:5
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DBforMySQL/servers/{serverName}/privateLinkResources/{groupName}' removed or restructured?
    Old: legacy/preview/2018-06-01-privatepreview/PrivateLinkResources.json#L82:5
    ⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'PrivateEndpointProperty' removed or renamed?
    New: PrivateLink/preview/2022-09-30-preview/PrivateEndpointConnections.json#L260:3
    Old: legacy/preview/2018-06-01-privatepreview/PrivateEndpointConnections.json#L297:3
    ⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'PrivateLinkServiceConnectionStateProperty' removed or renamed?
    New: PrivateLink/preview/2022-09-30-preview/PrivateEndpointConnections.json#L260:3
    Old: legacy/preview/2018-06-01-privatepreview/PrivateEndpointConnections.json#L297:3
    ⚠️ 1007 - RemovedClientParameter The new version is missing a client parameter that was found in the old version. Was 'ResourceGroupParameter' removed or renamed?
    New: azure-rest-api-specs/blob/efd5cd2c35cd9d9713ff934215e8eb07c3a4432f/revision#L908:2
    Old: legacy/preview/2018-06-01-privatepreview/PrivateEndpointConnections.json#L431:3
    ⚠️ 1007 - RemovedClientParameter The new version is missing a client parameter that was found in the old version. Was 'ResourceGroupParameter' removed or renamed?
    New: azure-rest-api-specs/blob/efd5cd2c35cd9d9713ff934215e8eb07c3a4432f/revision#L605:2
    Old: legacy/preview/2018-06-01-privatepreview/PrivateLinkResources.json#L222:3
    ⚠️ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
    New: common-types/resource-management/v4/privatelinks.json#L47:9
    Old: legacy/preview/2018-06-01-privatepreview/PrivateEndpointConnections.json#L302:9
    ⚠️ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
    New: common-types/resource-management/v4/privatelinks.json#L51:9
    Old: legacy/preview/2018-06-01-privatepreview/PrivateEndpointConnections.json#L306:9
    ⚠️ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
    New: common-types/resource-management/v4/privatelinks.json#L68:9
    Old: legacy/preview/2018-06-01-privatepreview/PrivateEndpointConnections.json#L334:9
    ⚠️ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
    New: common-types/resource-management/v4/privatelinks.json#L55:9
    Old: legacy/preview/2018-06-01-privatepreview/PrivateEndpointConnections.json#L310:9
    ⚠️ 1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: common-types/resource-management/v4/types.json#L625:5
    Old: legacy/preview/2018-06-01-privatepreview/PrivateEndpointConnections.json#L432:5
    ⚠️ 1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: common-types/resource-management/v4/types.json#L625:5
    Old: legacy/preview/2018-06-01-privatepreview/PrivateLinkResources.json#L223:5
    ⚠️ 1025 - RequiredStatusChange The 'required' status changed from the old version('False') to the new version('True').
    New: common-types/resource-management/v4/privatelinks.json#L38:7
    Old: legacy/preview/2018-06-01-privatepreview/PrivateEndpointConnections.json#L301:7
    ⚠️ 1025 - RequiredStatusChange The 'required' status changed from the old version('True') to the new version('False').
    New: common-types/resource-management/v4/privatelinks.json#L67:7
    Old: legacy/preview/2018-06-01-privatepreview/PrivateEndpointConnections.json#L333:7
    ⚠️ 1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.
    New: common-types/resource-management/v4/privatelinks.json#L12:9
    Old: legacy/preview/2018-06-01-privatepreview/PrivateEndpointConnections.json#L320:9
    ⚠️ 1029 - ReadonlyPropertyChanged The read only property has changed from 'true' to 'false'.
    New: common-types/resource-management/v4/privatelinks.json#L76:9
    Old: legacy/preview/2018-06-01-privatepreview/PrivateEndpointConnections.json#L342:9
    ⚠️ 1029 - ReadonlyPropertyChanged The read only property has changed from 'true' to 'false'.
    New: common-types/resource-management/v4/privatelinks.json#L156:9
    Old: legacy/preview/2018-06-01-privatepreview/PrivateEndpointConnections.json#L369:9
    ⚠️ 1029 - ReadonlyPropertyChanged The read only property has changed from 'true' to 'false'.
    New: common-types/resource-management/v4/privatelinks.json#L169:9
    Old: legacy/preview/2018-06-01-privatepreview/PrivateLinkResources.json#L137:9
    ⚠️ 1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
    New: common-types/resource-management/v4/privatelinks.json#L20:5
    Old: legacy/preview/2018-06-01-privatepreview/PrivateEndpointConnections.json#L349:5
    ⚠️ 1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
    New: common-types/resource-management/v4/privatelinks.json#L159:11
    Old: legacy/preview/2018-06-01-privatepreview/PrivateEndpointConnections.json#L372:11
    ⚠️ 1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
    New: common-types/resource-management/v4/privatelinks.json#L172:11
    Old: legacy/preview/2018-06-01-privatepreview/PrivateLinkResources.json#L140:11
    ⚠️ 1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
    New: common-types/resource-management/v4/privatelinks.json#L111:5
    Old: legacy/preview/2018-06-01-privatepreview/PrivateLinkResources.json#L171:5
    ⚠️ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'nextLink' renamed or removed?
    New: common-types/resource-management/v4/privatelinks.json#L155:7
    Old: legacy/preview/2018-06-01-privatepreview/PrivateEndpointConnections.json#L368:7
    ⚠️ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'nextLink' renamed or removed?
    New: common-types/resource-management/v4/privatelinks.json#L168:7
    Old: legacy/preview/2018-06-01-privatepreview/PrivateLinkResources.json#L136:7
    ⚠️ 1034 - AddedRequiredProperty The new version has new required property 'privateLinkServiceConnectionState' that was not found in the old version.
    New: common-types/resource-management/v4/privatelinks.json#L36:5
    Old: legacy/preview/2018-06-01-privatepreview/PrivateEndpointConnections.json#L298:5
    ⚠️ 1034 - AddedRequiredProperty The new version has new required property 'privateLinkServiceConnectionState' that was not found in the old version.
    New: common-types/resource-management/v4/privatelinks.json#L23:9
    Old: legacy/preview/2018-06-01-privatepreview/PrivateEndpointConnections.json#L358:9
    ⚠️ 1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.DBforMySQL/common-types/v1/common-types.json#L10:5
    Old: legacy/preview/2018-06-01-privatepreview/PrivateEndpointConnections.json#L456:5
    ⚠️ 1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.DBforMySQL/common-types/v1/common-types.json#L10:5
    Old: legacy/preview/2018-06-01-privatepreview/PrivateLinkResources.json#L247:5
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️❌LintDiff: 6 Errors, 11 Warnings failed [Detail]
    compared tags (via openapi-validator v2.0.0) new version base version
    package-flexibleserver-2022-09-30-preview-privatelink package-flexibleserver-2022-09-30-preview-privatelink(efd5cd2) default(main)

    [must fix]The following errors/warnings are introduced by current PR:

    Rule Message Related RPC [For API reviewers]
    ImplementPrivateEndpointAPIs The private endpoint API: /subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DBforMySQL/flexibleServers/{serverName}/privateLinkResources is missing.
    Location: PrivateLink/preview/2022-09-30-preview/PrivateEndpointConnections.json#L36
    CreateOperationAsyncResponseValidation Only 201 is the supported response code for PUT async response.
    Location: PrivateLink/preview/2022-09-30-preview/PrivateEndpointConnections.json#L133
    RPC-Async-V1-01
    GetCollectionResponseSchema The response in the GET collection operation 'PrivateEndpointConnections_ListByServer' does not match the response definition in the individual GET operation 'PrivateEndpointConnections_Get' .
    Location: PrivateLink/preview/2022-09-30-preview/PrivateEndpointConnections.json#L217
    ImplementPrivateEndpointAPIs The private endpoint API: /subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DBforMySQL/flexibleServers/{serverName}/privateEndpointConnections/{privateEndpointConnectionName} is missing.
    Location: PrivateLink/preview/2022-09-30-preview/PrivateLinkResources.json#L36
    ImplementPrivateEndpointAPIs The private endpoint API: /subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DBforMySQL/flexibleServers/{serverName}/privateEndpointConnections is missing.
    Location: PrivateLink/preview/2022-09-30-preview/PrivateLinkResources.json#L36
    GetCollectionResponseSchema The response in the GET collection operation 'PrivateLinkResources_ListByServer' does not match the response definition in the individual GET operation 'PrivateLinkResources_Get' .
    Location: PrivateLink/preview/2022-09-30-preview/PrivateLinkResources.json#L37
    ⚠️ ParameterNotDefinedInGlobalParameters Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition
    Location: PrivateLink/preview/2022-09-30-preview/PrivateEndpointConnections.json#L44
    ⚠️ ParameterNotDefinedInGlobalParameters Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition
    Location: PrivateLink/preview/2022-09-30-preview/PrivateEndpointConnections.json#L92
    ⚠️ ParameterDescription Parameter should have a description.
    Location: PrivateLink/preview/2022-09-30-preview/PrivateEndpointConnections.json#L99
    ⚠️ ParameterDescription Parameter should have a description.
    Location: PrivateLink/preview/2022-09-30-preview/PrivateEndpointConnections.json#L105
    ⚠️ ParameterNotDefinedInGlobalParameters Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition
    Location: PrivateLink/preview/2022-09-30-preview/PrivateEndpointConnections.json#L164
    ⚠️ ParameterDescription Parameter should have a description.
    Location: PrivateLink/preview/2022-09-30-preview/PrivateEndpointConnections.json#L171
    ⚠️ PageableOperation Based on the response model schema, operation 'PrivateEndpointConnections_ListByServer' might be pageable. Consider adding the x-ms-pageable extension.
    Location: PrivateLink/preview/2022-09-30-preview/PrivateEndpointConnections.json#L218
    ⚠️ ParameterNotDefinedInGlobalParameters Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition
    Location: PrivateLink/preview/2022-09-30-preview/PrivateEndpointConnections.json#L224
    ⚠️ PageableOperation Based on the response model schema, operation 'PrivateLinkResources_ListByServer' might be pageable. Consider adding the x-ms-pageable extension.
    Location: PrivateLink/preview/2022-09-30-preview/PrivateLinkResources.json#L38
    ⚠️ ParameterNotDefinedInGlobalParameters Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition
    Location: PrivateLink/preview/2022-09-30-preview/PrivateLinkResources.json#L44
    ⚠️ ParameterNotDefinedInGlobalParameters Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition
    Location: PrivateLink/preview/2022-09-30-preview/PrivateLinkResources.json#L86
    ️⚠️Avocado: 1 Warnings warning [Detail]
    Rule Message
    ⚠️ MULTIPLE_API_VERSION The default tag contains multiple API versions swaggers.
    readme: specification/mysql/resource-manager/readme.md
    tag: specification/mysql/resource-manager/readme.md#tag-package-2020-01-01
    ️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
    ️⚠️~[Staging] ServiceAPIReadinessTest: 0 Warnings warning [Detail]

    API Test is not triggered due to precheck failure. Check pipeline log for details.

    ️️✔️SwaggerAPIView succeeded [Detail] [Expand]
    ️️✔️CadlAPIView succeeded [Detail] [Expand]
    ️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️PoliCheck succeeded [Detail] [Expand]
    Validation passed for PoliCheck.
    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    ️️✔️CadlValidation succeeded [Detail] [Expand]
    Validation passes for CadlValidation.
    ️️✔️TypeSpec Validation succeeded [Detail] [Expand]
    Validation passes for TypeSpec Validation.
    ️️✔️PR Summary succeeded [Detail] [Expand]
    Validation passes for Summary.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Mar 14, 2023

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

    Breaking Changes Tracking




    ️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from c40f446. SDK Automation 14.0.0
      command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
      command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
    • ️✔️Azure.ResourceManager.MySql [View full logs]  [Release SDK Changes]
      info	[Changelog]
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from c40f446. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
      cmderr	[automation_generate.sh] npm notice
      cmderr	[automation_generate.sh] npm notice New minor version of npm available! 9.5.0 -> 9.6.4
      cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.6.4>
      cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
      cmderr	[automation_generate.sh] npm notice
    • ️✔️track2_azure-mgmt-rdbms [View full logs]  [Release SDK Changes]
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog]   - Added model ErrorResponseAutoGenerated
    ️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from c40f446. SDK Automation 14.0.0
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️sdk/resourcemanager/mysql/armmysql [View full logs]  [Release SDK Changes]
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️sdk/resourcemanager/mysql/armmysqlflexibleservers [View full logs]  [Release SDK Changes]
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog] - New enum type `AdministratorName` with values `AdministratorNameActiveDirectory`
      info	[Changelog] - New enum type `AdministratorType` with values `AdministratorTypeActiveDirectory`
      info	[Changelog] - New enum type `ResetAllToDefault` with values `ResetAllToDefaultFalse`, `ResetAllToDefaultTrue`
      info	[Changelog] - New function `NewAzureADAdministratorsClient(string, azcore.TokenCredential, *arm.ClientOptions) (*AzureADAdministratorsClient, error)`
      info	[Changelog] - New function `*AzureADAdministratorsClient.BeginCreateOrUpdate(context.Context, string, string, AdministratorName, AzureADAdministrator, *AzureADAdministratorsClientBeginCreateOrUpdateOptions) (*runtime.Poller[AzureADAdministratorsClientCreateOrUpdateResponse], error)`
      info	[Changelog] - New function `*AzureADAdministratorsClient.BeginDelete(context.Context, string, string, AdministratorName, *AzureADAdministratorsClientBeginDeleteOptions) (*runtime.Poller[AzureADAdministratorsClientDeleteResponse], error)`
      info	[Changelog] - New function `*AzureADAdministratorsClient.Get(context.Context, string, string, AdministratorName, *AzureADAdministratorsClientGetOptions) (AzureADAdministratorsClientGetResponse, error)`
      info	[Changelog] - New function `*AzureADAdministratorsClient.NewListByServerPager(string, string, *AzureADAdministratorsClientListByServerOptions) *runtime.Pager[AzureADAdministratorsClientListByServerResponse]`
      info	[Changelog] - New function `*BackupsClient.Put(context.Context, string, string, string, *BackupsClientPutOptions) (BackupsClientPutResponse, error)`
      info	[Changelog] - New function `NewCheckNameAvailabilityWithoutLocationClient(string, azcore.TokenCredential, *arm.ClientOptions) (*CheckNameAvailabilityWithoutLocationClient, error)`
      info	[Changelog] - New function `*CheckNameAvailabilityWithoutLocationClient.Execute(context.Context, NameAvailabilityRequest, *CheckNameAvailabilityWithoutLocationClientExecuteOptions) (CheckNameAvailabilityWithoutLocationClientExecuteResponse, error)`
      info	[Changelog] - New function `*ClientFactory.NewAzureADAdministratorsClient() *AzureADAdministratorsClient`
      info	[Changelog] - New function `*ClientFactory.NewCheckNameAvailabilityWithoutLocationClient() *CheckNameAvailabilityWithoutLocationClient`
      info	[Changelog] - New function `*ClientFactory.NewLogFilesClient() *LogFilesClient`
      info	[Changelog] - New function `*ConfigurationsClient.BeginCreateOrUpdate(context.Context, string, string, string, Configuration, *ConfigurationsClientBeginCreateOrUpdateOptions) (*runtime.Poller[ConfigurationsClientCreateOrUpdateResponse], error)`
      info	[Changelog] - New function `NewLogFilesClient(string, azcore.TokenCredential, *arm.ClientOptions) (*LogFilesClient, error)`
      info	[Changelog] - New function `*LogFilesClient.NewListByServerPager(string, string, *LogFilesClientListByServerOptions) *runtime.Pager[LogFilesClientListByServerResponse]`
      info	[Changelog] - New struct `AdministratorListResult`
      info	[Changelog] - New struct `AdministratorProperties`
      info	[Changelog] - New struct `AzureADAdministrator`
      info	[Changelog] - New struct `LogFile`
      info	[Changelog] - New struct `LogFileListResult`
      info	[Changelog] - New struct `LogFileProperties`
      info	[Changelog] - New field `ResetAllToDefault` in struct `ConfigurationListForBatchUpdate`
      info	[Changelog] - New field `CurrentValue` in struct `ConfigurationProperties`
      info	[Changelog] - New field `DocumentationLink` in struct `ConfigurationProperties`
      info	[Changelog] - New field `Keyword` in struct `ConfigurationsClientListByServerOptions`
      info	[Changelog] - New field `Page` in struct `ConfigurationsClientListByServerOptions`
      info	[Changelog] - New field `PageSize` in struct `ConfigurationsClientListByServerOptions`
      info	[Changelog] - New field `Tags` in struct `ConfigurationsClientListByServerOptions`
      info	[Changelog] - New field `Version` in struct `ServerPropertiesForUpdate`
      info	[Changelog] - New field `AutoIoScaling` in struct `Storage`
      info	[Changelog] - New field `Location` in struct `VirtualNetworkSubnetUsageResult`
      info	[Changelog] - New field `SubscriptionID` in struct `VirtualNetworkSubnetUsageResult`
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 39 additive change(s).
    ️⚠️ azure-sdk-for-js warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from c40f446. SDK Automation 14.0.0
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
      warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
      command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
      warn	No file changes detected after generation
      warn	No package detected after generation
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from c40f446. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh]  WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh] npm WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] npm WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    ️❌ azure-powershell failed [Detail]
    • Failed [Logs]Release - Generate from c40f446. SDK Automation 14.0.0
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
      command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
    • Az.mysql.DefaultTag [View full logs]  [Release SDK Changes]
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Mar 14, 2023

    Generated ApiView

    Language Package Name ApiView Link
    Go sdk/resourcemanager/mysql/armmysql There is no API change compared with the previous version
    Go sdk/resourcemanager/mysql/armmysqlflexibleservers https://apiview.dev/Assemblies/Review/2503423e3ff944fe88256ac1bee210cd
    Java azure-resourcemanager-mysqlflexibleserver https://apiview.dev/Assemblies/Review/0cf859b6c204479f8d4f6572d479b91c
    .Net Azure.ResourceManager.MySql https://apiview.dev/Assemblies/Review/66b4eae26d654fa784342e558c305595

    @xiaoxuqi-ms xiaoxuqi-ms requested a review from Suna-MS March 14, 2023 07:25
    @openapi-workflow-bot openapi-workflow-bot bot added ARMReview WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Mar 14, 2023
    @openapi-workflow-bot
    Copy link

    Hi, @xiaoxuqi-ms your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board([email protected]).

    @openapi-workflow-bot
    Copy link

    Hi @xiaoxuqi-ms, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
    Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
    If you want to know the production traffic statistic, please see ARM Traffic statistic.
    If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.
    Note: To avoid breaking change, you can refer to Shift Left Solution for detecting breaking change in early phase at your service code repository.

    @openapi-workflow-bot
    Copy link

    Hi @xiaoxuqi-ms, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

    TaskHow to fixPriority
    AvocadoFix-AvocadoHigh
    Semantic validationFix-SemanticValidation-ErrorHigh
    Model validationFix-ModelValidation-ErrorHigh
    LintDiffFix-LintDiffhigh
    If you need further help, please feedback via swagger feedback.

    @openapi-workflow-bot
    Copy link

    Hi, @xiaoxuqi-ms, For review efficiency consideration, when creating a new api version, it is required to place API specs of the base version in the first commit, and push new version updates into successive commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki. Or you could onboard API spec pipeline

    @raosuhas raosuhas added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Mar 22, 2023
    @openapi-workflow-bot openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Mar 22, 2023
    @AzureRestAPISpecReview AzureRestAPISpecReview removed the BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required label Apr 7, 2023
    @weshaggard
    Copy link
    Member

    /azp run

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @AzureRestAPISpecReview AzureRestAPISpecReview added the BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required label Apr 7, 2023
    @akning-ms
    Copy link
    Contributor

    approved linter diff as it is green in Linter (staging) and linter error for privatelink is false alarm according to Jianye

    @akning-ms akning-ms merged commit c40f446 into main Apr 14, 2023
    @akning-ms akning-ms deleted the mysql/20220901stable branch April 14, 2023 10:53
    JoshLove-msft pushed a commit to JoshLove-msft/azure-rest-api-specs that referenced this pull request Apr 25, 2023
    )
    
    * add new version 20220901 based on 20211201preview
    
    * change api version, examples and readme
    
    * fix linter errors
    
    * fix api version
    
    * add privatelink
    
    * fix private link validation
    
    * fix private link
    
    * fix private link model
    
    * fix
    
    * use 2022-09-30-preview as version
    
    * fix readme
    
    * add private link only
    
    * revert readme.com
    
    * add readme
    
    * add priviate link in readme to fix avocado
    
    * fix 202 for LRO
    
    * fix avocado: remove inner common-tyoe
    
    * fix
    
    * fix
    
    * fix conflict
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 Approved-LintDiff ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required CI-BreakingChange-Go CI-FixRequiredOnFailure CI-MissingBaseCommit MySQL new-api-version resource-manager
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    5 participants