Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cosmos DB] Fix CosmosDBMongo Source Sink #23191

Merged

Conversation

ashwinisingh01
Copy link
Contributor

@ashwinisingh01 ashwinisingh01 commented Mar 21, 2023

ARM API Information (Control Plane)

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @ashwinisingh01 Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Mar 21, 2023

    Swagger Validation Report

    ️❌BreakingChange: 4 Errors, 0 Warnings failed [Detail]
    compared swaggers (via Oad v0.10.4)] new version base version
    dataTransferService.json 2023-03-01-preview(104bb8a) 2023-03-01-preview(main)
    Rule Message
    1020 - AddedEnumValue The new version is adding enum value(s) 'CosmosDBMongo' from the old version.
    New: Microsoft.DocumentDB/preview/2023-03-01-preview/dataTransferService.json#L301:9
    Old: Microsoft.DocumentDB/preview/2023-03-01-preview/dataTransferService.json#L301:9
    1020 - AddedEnumValue The new version is adding enum value(s) 'CosmosDBMongo' from the old version.
    New: Microsoft.DocumentDB/preview/2023-03-01-preview/dataTransferService.json#L301:9
    Old: Microsoft.DocumentDB/preview/2023-03-01-preview/dataTransferService.json#L301:9
    1020 - AddedEnumValue The new version is adding enum value(s) 'CosmosDBMongo' from the old version.
    New: Microsoft.DocumentDB/preview/2023-03-01-preview/dataTransferService.json#L301:9
    Old: Microsoft.DocumentDB/preview/2023-03-01-preview/dataTransferService.json#L301:9
    1020 - AddedEnumValue The new version is adding enum value(s) 'CosmosDBMongo' from the old version.
    New: Microsoft.DocumentDB/preview/2023-03-01-preview/dataTransferService.json#L301:9
    Old: Microsoft.DocumentDB/preview/2023-03-01-preview/dataTransferService.json#L301:9
    ️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️⚠️LintDiff: 0 Warnings warning [Detail]
    compared tags (via openapi-validator v2.0.0) new version base version
    package-preview-2023-03 package-preview-2023-03(104bb8a) package-preview-2023-03(main)

    The following errors/warnings exist before current PR submission:

    Rule Message
    ⚠️ PutRequestResponseScheme A PUT operation request body schema should be the same as its 200 response schema, to allow reusing the same entity between GET and PUT. If the schema of the PUT request body is a superset of the GET response body, make sure you have a PATCH operation to make the resource updatable. Operation: 'DataTransferJobs_Create' Request Model: 'parameters[5].schema' Response Model: 'responses[200].schema'
    Location: Microsoft.DocumentDB/preview/2023-03-01-preview/dataTransferService.json#L38
    ⚠️ ParameterDescription Parameter should have a description.
    Location: Microsoft.DocumentDB/preview/2023-03-01-preview/dataTransferService.json#L62
    ⚠️ UniqueXmsExample Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: CosmosDBDataTransferJobCreate
    Location: Microsoft.DocumentDB/preview/2023-03-01-preview/dataTransferService.json#L173
    ⚠️ UniqueXmsExample Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: CosmosDBDataTransferJobCreate
    Location: Microsoft.DocumentDB/preview/2023-03-01-preview/dataTransferService.json#L215
    ⚠️ AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
    Location: Microsoft.DocumentDB/preview/2023-03-01-preview/dataTransferService.json#L469
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
    ️⚠️~[Staging] ServiceAPIReadinessTest: 0 Warnings warning [Detail]

    API Test is not triggered due to precheck failure. Check pipeline log for details.

    ️️✔️SwaggerAPIView succeeded [Detail] [Expand]
    ️️✔️CadlAPIView succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️PoliCheck succeeded [Detail] [Expand]
    Validation passed for PoliCheck.
    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    ️️✔️CadlValidation succeeded [Detail] [Expand]
    Validation passes for CadlValidation.
    ️️✔️PR Summary succeeded [Detail] [Expand]
    Validation passes for Summary.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Mar 21, 2023

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

    Breaking Changes Tracking




    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 65c3e5c. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
      cmderr	[automation_generate.sh] npm notice
      cmderr	[automation_generate.sh] npm notice New minor version of npm available! 9.5.0 -> 9.6.2
      cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.6.2>
      cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
      cmderr	[automation_generate.sh] npm notice
    • ️✔️track2_azure-mgmt-cosmosdb [View full logs]  [Release SDK Changes]
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog]   - Added operation group MongoClustersOperations
    ️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]
    ️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]
    ️❌ azure-sdk-for-go failed [Detail]
    • Code Generator Failed [Logs]Release - Generate from 65c3e5c. SDK Automation 14.0.0
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
      cmderr	[generator automation-v2] [ERROR] total 1 error(s):
      cmderr	[generator automation-v2] [ERROR] json: cannot unmarshal object into Go value of type []map[string]interface {}
      error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-go/src/github.com/Azure/azure-sdk-for-go]: generator automation-v2
      warn	Skip package processing as generation is failed
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 65c3e5c. SDK Automation 14.0.0
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
      warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
      command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️@azure/arm-cosmosdb [View full logs]  [Release SDK Changes]
      Only show 120 items here, please refer to log for details.
      info	[Changelog]   - Added Interface NodeGroupProperties
      info	[Changelog]   - Added Interface NodeGroupSpec
      info	[Changelog]   - Added Interface PhysicalPartitionId
      info	[Changelog]   - Added Interface PhysicalPartitionStorageInfo
      info	[Changelog]   - Added Interface PhysicalPartitionStorageInfoCollection
      info	[Changelog]   - Added Interface PhysicalPartitionThroughputInfoProperties
      info	[Changelog]   - Added Interface PhysicalPartitionThroughputInfoResource
      info	[Changelog]   - Added Interface PhysicalPartitionThroughputInfoResult
      info	[Changelog]   - Added Interface PhysicalPartitionThroughputInfoResultPropertiesResource
      info	[Changelog]   - Added Interface ProxyResourceAutoGenerated
      info	[Changelog]   - Added Interface RedistributeThroughputParameters
      info	[Changelog]   - Added Interface RedistributeThroughputPropertiesResource
      info	[Changelog]   - Added Interface ResourceAutoGenerated
      info	[Changelog]   - Added Interface ResourceRestoreParameters
      info	[Changelog]   - Added Interface RestoreParametersBase
      info	[Changelog]   - Added Interface RetrieveThroughputParameters
      info	[Changelog]   - Added Interface RetrieveThroughputPropertiesResource
      info	[Changelog]   - Added Interface SqlResourcesListSqlContainerPartitionMergeHeaders
      info	[Changelog]   - Added Interface SqlResourcesListSqlContainerPartitionMergeOptionalParams
      info	[Changelog]   - Added Interface SqlResourcesSqlContainerRedistributeThroughputHeaders
      info	[Changelog]   - Added Interface SqlResourcesSqlContainerRedistributeThroughputOptionalParams
      info	[Changelog]   - Added Interface SqlResourcesSqlContainerRetrieveThroughputDistributionHeaders
      info	[Changelog]   - Added Interface SqlResourcesSqlContainerRetrieveThroughputDistributionOptionalParams
      info	[Changelog]   - Added Interface SqlResourcesSqlDatabaseRedistributeThroughputHeaders
      info	[Changelog]   - Added Interface SqlResourcesSqlDatabaseRedistributeThroughputOptionalParams
      info	[Changelog]   - Added Interface SqlResourcesSqlDatabaseRetrieveThroughputDistributionHeaders
      info	[Changelog]   - Added Interface SqlResourcesSqlDatabaseRetrieveThroughputDistributionOptionalParams
      info	[Changelog]   - Added Interface TrackedResource
      info	[Changelog]   - Added Type Alias CassandraClustersGetBackupResponse
      info	[Changelog]   - Added Type Alias CassandraClustersListBackupsResponse
      info	[Changelog]   - Added Type Alias CassandraResourcesCreateUpdateCassandraViewResponse
      info	[Changelog]   - Added Type Alias CassandraResourcesGetCassandraViewResponse
      info	[Changelog]   - Added Type Alias CassandraResourcesGetCassandraViewThroughputResponse
      info	[Changelog]   - Added Type Alias CassandraResourcesListCassandraViewsResponse
      info	[Changelog]   - Added Type Alias CassandraResourcesMigrateCassandraViewToAutoscaleResponse
      info	[Changelog]   - Added Type Alias CassandraResourcesMigrateCassandraViewToManualThroughputResponse
      info	[Changelog]   - Added Type Alias CassandraResourcesUpdateCassandraViewThroughputResponse
      info	[Changelog]   - Added Type Alias CheckNameAvailabilityReason
      info	[Changelog]   - Added Type Alias ContinuousTier
      info	[Changelog]   - Added Type Alias DataTransferComponent
      info	[Changelog]   - Added Type Alias DataTransferDataSourceSinkUnion
      info	[Changelog]   - Added Type Alias DataTransferJobsCancelResponse
      info	[Changelog]   - Added Type Alias DataTransferJobsCreateResponse
      info	[Changelog]   - Added Type Alias DataTransferJobsGetResponse
      info	[Changelog]   - Added Type Alias DataTransferJobsListByDatabaseAccountNextResponse
      info	[Changelog]   - Added Type Alias DataTransferJobsListByDatabaseAccountResponse
      info	[Changelog]   - Added Type Alias DataTransferJobsPauseResponse
      info	[Changelog]   - Added Type Alias DataTransferJobsResumeResponse
      info	[Changelog]   - Added Type Alias EnableFullTextQuery
      info	[Changelog]   - Added Type Alias GraphResourcesCreateUpdateGraphResponse
      info	[Changelog]   - Added Type Alias GraphResourcesGetGraphResponse
      info	[Changelog]   - Added Type Alias GraphResourcesListGraphsResponse
      info	[Changelog]   - Added Type Alias MongoClustersCheckNameAvailabilityResponse
      info	[Changelog]   - Added Type Alias MongoClustersCreateOrUpdateFirewallRuleResponse
      info	[Changelog]   - Added Type Alias MongoClustersCreateOrUpdateResponse
      info	[Changelog]   - Added Type Alias MongoClustersDeleteFirewallRuleResponse
      info	[Changelog]   - Added Type Alias MongoClustersDeleteResponse
      info	[Changelog]   - Added Type Alias MongoClustersGetFirewallRuleResponse
      info	[Changelog]   - Added Type Alias MongoClustersGetResponse
      info	[Changelog]   - Added Type Alias MongoClustersListByResourceGroupNextResponse
      info	[Changelog]   - Added Type Alias MongoClustersListByResourceGroupResponse
      info	[Changelog]   - Added Type Alias MongoClustersListConnectionStringsResponse
      info	[Changelog]   - Added Type Alias MongoClustersListFirewallRulesNextResponse
      info	[Changelog]   - Added Type Alias MongoClustersListFirewallRulesResponse
      info	[Changelog]   - Added Type Alias MongoClustersListNextResponse
      info	[Changelog]   - Added Type Alias MongoClustersListResponse
      info	[Changelog]   - Added Type Alias MongoClusterStatus
      info	[Changelog]   - Added Type Alias MongoClustersUpdateResponse
      info	[Changelog]   - Added Type Alias MongoDBResourcesListMongoDBCollectionPartitionMergeResponse
      info	[Changelog]   - Added Type Alias MongoDBResourcesMongoDBContainerRedistributeThroughputResponse
      info	[Changelog]   - Added Type Alias MongoDBResourcesMongoDBContainerRetrieveThroughputDistributionResponse
      info	[Changelog]   - Added Type Alias MongoDBResourcesMongoDBDatabaseRedistributeThroughputResponse
      info	[Changelog]   - Added Type Alias MongoDBResourcesMongoDBDatabaseRetrieveThroughputDistributionResponse
      info	[Changelog]   - Added Type Alias NodeKind
      info	[Changelog]   - Added Type Alias ProvisioningState
      info	[Changelog]   - Added Type Alias SqlResourcesListSqlContainerPartitionMergeResponse
      info	[Changelog]   - Added Type Alias SqlResourcesSqlContainerRedistributeThroughputResponse
      info	[Changelog]   - Added Type Alias SqlResourcesSqlContainerRetrieveThroughputDistributionResponse
      info	[Changelog]   - Added Type Alias SqlResourcesSqlDatabaseRedistributeThroughputResponse
      info	[Changelog]   - Added Type Alias SqlResourcesSqlDatabaseRetrieveThroughputDistributionResponse
      info	[Changelog]   - Added Type Alias ThroughputPolicyType
      info	[Changelog]   - Interface ARMResourceProperties has a new optional parameter identity
      info	[Changelog]   - Interface ContinuousModeBackupPolicy has a new optional parameter continuousModeProperties
      info	[Changelog]   - Interface DatabaseAccountCreateUpdateParameters has a new optional parameter diagnosticLogSettings
      info	[Changelog]   - Interface DatabaseAccountCreateUpdateParameters has a new optional parameter enableBurstCapacity
      info	[Changelog]   - Interface DatabaseAccountCreateUpdateParameters has a new optional parameter enableMaterializedViews
      info	[Changelog]   - Interface DatabaseAccountGetResults has a new optional parameter diagnosticLogSettings
      info	[Changelog]   - Interface DatabaseAccountGetResults has a new optional parameter enableBurstCapacity
      info	[Changelog]   - Interface DatabaseAccountGetResults has a new optional parameter enableMaterializedViews
      info	[Changelog]   - Interface DatabaseAccountUpdateParameters has a new optional parameter diagnosticLogSettings
      info	[Changelog]   - Interface DatabaseAccountUpdateParameters has a new optional parameter enableBurstCapacity
      info	[Changelog]   - Interface DatabaseAccountUpdateParameters has a new optional parameter enableMaterializedViews
      info	[Changelog]   - Interface DataCenterResourceProperties has a new optional parameter authenticationMethodLdapProperties
      info	[Changelog]   - Interface GremlinDatabaseResource has a new optional parameter createMode
      info	[Changelog]   - Interface GremlinDatabaseResource has a new optional parameter restoreParameters
      info	[Changelog]   - Interface GremlinGraphResource has a new optional parameter createMode
      info	[Changelog]   - Interface GremlinGraphResource has a new optional parameter restoreParameters
      info	[Changelog]   - Interface LocationProperties has a new optional parameter status
      info	[Changelog]   - Interface MongoDBCollectionResource has a new optional parameter createMode
      info	[Changelog]   - Interface MongoDBCollectionResource has a new optional parameter restoreParameters
      info	[Changelog]   - Interface MongoDBDatabaseResource has a new optional parameter createMode
      info	[Changelog]   - Interface MongoDBDatabaseResource has a new optional parameter restoreParameters
      info	[Changelog]   - Interface RestorableDatabaseAccountGetResult has a new optional parameter oldestRestorableTime
      info	[Changelog]   - Interface RestoreParameters has a new optional parameter sourceBackupLocation
      info	[Changelog]   - Interface SqlContainerResource has a new optional parameter createMode
      info	[Changelog]   - Interface SqlContainerResource has a new optional parameter restoreParameters
      info	[Changelog]   - Interface SqlDatabaseResource has a new optional parameter createMode
      info	[Changelog]   - Interface SqlDatabaseResource has a new optional parameter restoreParameters
      info	[Changelog]   - Interface TableResource has a new optional parameter createMode
      info	[Changelog]   - Interface TableResource has a new optional parameter restoreParameters
      info	[Changelog]   - Added Enum KnownCheckNameAvailabilityReason
      info	[Changelog]   - Added Enum KnownContinuousTier
      info	[Changelog]   - Added Enum KnownDataTransferComponent
      info	[Changelog]   - Added Enum KnownMongoClusterStatus
      info	[Changelog]   - Added Enum KnownNodeKind
      info	[Changelog]   - Added Enum KnownProvisioningState
      info	[Changelog]   - Added Enum KnownThroughputPolicyType
      info	[Changelog]   - Enum KnownAuthenticationMethod has a new value Ldap
      info	[Changelog]   - Enum KnownCreateMode has a new value PointInTimeRestore
      info	[Changelog]   - Enum KnownOperationType has a new value Recreate
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 65c3e5c. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh] WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh] npm WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] npm WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    • ️✔️cosmos-db [View full logs]  [Release Schema Changes]
    ️❌ azure-powershell failed [Detail]
    • Failed [Logs]Release - Generate from 65c3e5c. SDK Automation 14.0.0
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
      command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
    • Az.cosmos-db.DefaultTag [View full logs]  [Release SDK Changes]
    Posted by Swagger Pipeline | How to fix these errors?

    @ghost ghost added the Cosmos label Mar 21, 2023
    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Mar 21, 2023

    Generated ApiView

    Language Package Name ApiView Link
    Java azure-resourcemanager-cosmos-generated https://apiview.dev/Assemblies/Review/fa2f354e6ef245f3aa6f77bfd2207bd5
    .Net Azure.ResourceManager.CosmosDB There is no API change compared with the previous version
    JavaScript @azure/arm-cosmosdb https://apiview.dev/Assemblies/Review/ec3ac272bf63407bb40b31c09502223e

    @openapi-workflow-bot
    Copy link

    Hi @ashwinisingh01, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

    TaskHow to fixPriority
    AvocadoFix-AvocadoHigh
    Semantic validationFix-SemanticValidation-ErrorHigh
    Model validationFix-ModelValidation-ErrorHigh
    LintDiffFix-LintDiffhigh
    If you need further help, please feedback via swagger feedback.

    @raych1
    Copy link
    Member

    raych1 commented Mar 22, 2023

    /azp run

    @ashwinisingh01
    Copy link
    Contributor Author

    ashwinisingh01 commented Mar 22, 2023

    @XiaofeiCao , can you please merge this PR. Let me know if we need something else. Can you please help resolve the failing gates check

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @raych1
    Copy link
    Member

    raych1 commented Mar 22, 2023

    @mikekistler , can you confirm if adding a new enum value to existed version is breaking change? I don't see the breakingchangereviewrequired label was added automatically. I'm not sure if it's due to the enum is used as discriminator.

    @mikekistler
    Copy link
    Member

    Adding a new value to an enum (even an extensible enum) is not a breaking change but must be done in a new api-version. Similar to adding an optional property or parameter or adding a new operation.

    @pjohari-ms
    Copy link
    Member

    pjohari-ms commented Mar 22, 2023

    @mikekistler This is also a preview version, and was just very recently merged. While developing CLI/PS we noticed that this change is not present in this newly updated version and immediately updated it. There hasn't been any development on it, and this API version is also not publically released as well. So considering the circumstances, we think it'll be better to merge this in current API version itself.

    @mikekistler
    Copy link
    Member

    I see that the base version was merged just a week ago, so I suppose we can make an exception in this case. Please be more careful with PRs to main going forward.

    @mikekistler mikekistler added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Mar 22, 2023
    @ashwini-mnnit
    Copy link

    @XiaofeiCao, can you please help merge this PR

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 Cosmos resource-manager
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    9 participants