-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Hub Generated] Review request for Microsoft.Devices to add version stable/2023-06-30 #23791
Merged
rkmanda
merged 10 commits into
main
from
MikalaiSavenka-iothub-Microsoft.Devices-2023-06-30
Aug 17, 2023
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
7349c68
Adds base for updating Microsoft.Devices from version stable/2021-07-…
MikalaiSavenka 2b83ff3
Updates readme
MikalaiSavenka 17667df
Updates API version in new specs and examples
MikalaiSavenka 4a8aba7
add cosmosdb endpoint routing feature
MikalaiSavenka 09336e3
validation errors fixes
MikalaiSavenka cd75263
example added
MikalaiSavenka 13514e2
add format
MikalaiSavenka 63fe3d1
add example reference
MikalaiSavenka 882ceda
examples fix
MikalaiSavenka 9c60f45
merge main and resolve conflicts
MikalaiSavenka File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
20 changes: 20 additions & 0 deletions
20
.../resource-manager/Microsoft.Devices/stable/2023-06-30/examples/IotHub_ManualFailover.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| { | ||
| "parameters": { | ||
| "iotHubName": "testHub", | ||
| "resourceGroupName": "myResourceGroup", | ||
| "api-version": "2023-06-30", | ||
| "subscriptionId": "91d12660-3dec-467a-be2a-213b5544ddc0", | ||
| "failoverInput": { | ||
| "failoverRegion": "testHub" | ||
| } | ||
| }, | ||
| "responses": { | ||
| "200": {}, | ||
| "202": { | ||
| "headers": { | ||
| "Azure-AsyncOperation": "https://management.azure.com/subscriptions/91d12660-3dec-467a-be2a-213b5544ddc0/providers/Microsoft.Devices/operationResults/b3NfaWhfYmJhZmM4OWItNzQ3My00OWExLTg0NWUtNzQ3NWU2ODBkNDA3?api-version=2023-06-30-preview&operationSource=os_ih&asyncinfo", | ||
| "Location": "https://management.azure.com/subscriptions/91d12660-3dec-467a-be2a-213b5544ddc0/providers/Microsoft.Devices/operationResults/b3NfaWhfYmJhZmM4OWItNzQ3My00OWExLTg0NWUtNzQ3NWU2ODBkNDA3?api-version=2022-11-01-preview&operationSource=os_ih" | ||
| } | ||
| } | ||
| } | ||
| } |
20 changes: 20 additions & 0 deletions
20
.../resource-manager/Microsoft.Devices/stable/2023-06-30/examples/checkNameAvailability.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| { | ||
| "parameters": { | ||
| "resourceName": "testHub", | ||
| "resourceGroupName": "myResourceGroup", | ||
| "api-version": "2023-06-30", | ||
| "subscriptionId": "91d12660-3dec-467a-be2a-213b5544ddc0", | ||
| "operationInputs": { | ||
| "name": "test-request" | ||
| } | ||
| }, | ||
| "responses": { | ||
| "200": { | ||
| "body": { | ||
| "nameAvailable": true, | ||
| "reason": "Invalid", | ||
| "message": "" | ||
| } | ||
| } | ||
| } | ||
| } |
348 changes: 348 additions & 0 deletions
348
...nager/Microsoft.Devices/stable/2023-06-30/examples/iothub_addRoutingCosmosDBEndpoint.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,348 @@ | ||
| { | ||
| "parameters": { | ||
| "resourceName": "testHub", | ||
| "resourceGroupName": "myResourceGroup", | ||
| "api-version": "2023-06-30", | ||
| "subscriptionId": "91d12660-3dec-467a-be2a-213b5544ddc0", | ||
| "iotHubDescription": { | ||
| "location": "centraluseuap", | ||
| "tags": {}, | ||
| "etag": "AAAAAAFD6M4=", | ||
| "properties": { | ||
| "ipFilterRules": [], | ||
| "networkRuleSets": { | ||
| "defaultAction": "Deny", | ||
| "applyToBuiltInEventHubEndpoint": true, | ||
| "ipRules": [ | ||
| { | ||
| "filterName": "rule1", | ||
| "action": "Allow", | ||
| "ipMask": "131.117.159.53" | ||
| }, | ||
| { | ||
| "filterName": "rule2", | ||
| "action": "Allow", | ||
| "ipMask": "157.55.59.128/25" | ||
| } | ||
| ] | ||
| }, | ||
| "eventHubEndpoints": { | ||
| "events": { | ||
| "retentionTimeInDays": 1, | ||
| "partitionCount": 2 | ||
| } | ||
| }, | ||
| "routing": { | ||
| "endpoints": { | ||
| "serviceBusQueues": [], | ||
| "serviceBusTopics": [], | ||
| "eventHubs": [], | ||
| "storageContainers": [], | ||
| "cosmosDBSqlContainers": [ | ||
| { | ||
| "primaryKey": "<primary-key>", | ||
| "secondaryKey": "<secondary-key>", | ||
| "authenticationType": "keyBased", | ||
| "containerName": "test", | ||
| "databaseName": "systemstore", | ||
| "endpointUri": "https://test-systemstore-test2.documents.azure.com", | ||
| "name": "endpointcosmos", | ||
| "partitionKeyName": "keystamped", | ||
| "partitionKeyTemplate": "{deviceid}-{YYYY}-{MM}", | ||
| "resourceGroup": "rg-test", | ||
| "subscriptionId": "<subscription-id>" | ||
| } | ||
| ] | ||
| }, | ||
| "routes": [], | ||
| "fallbackRoute": { | ||
| "name": "$fallback", | ||
| "source": "DeviceMessages", | ||
| "condition": "true", | ||
| "endpointNames": [ | ||
| "events" | ||
| ], | ||
| "isEnabled": true | ||
| } | ||
| }, | ||
| "storageEndpoints": { | ||
| "$default": { | ||
| "sasTtlAsIso8601": "PT1H", | ||
| "connectionString": "", | ||
| "containerName": "" | ||
| } | ||
| }, | ||
| "messagingEndpoints": { | ||
| "fileNotifications": { | ||
| "lockDurationAsIso8601": "PT1M", | ||
| "ttlAsIso8601": "PT1H", | ||
| "maxDeliveryCount": 10 | ||
| } | ||
| }, | ||
| "enableFileUploadNotifications": false, | ||
| "cloudToDevice": { | ||
| "maxDeliveryCount": 10, | ||
| "defaultTtlAsIso8601": "PT1H", | ||
| "feedback": { | ||
| "lockDurationAsIso8601": "PT1M", | ||
| "ttlAsIso8601": "PT1H", | ||
| "maxDeliveryCount": 10 | ||
| } | ||
| }, | ||
| "features": "None", | ||
| "minTlsVersion": "1.2", | ||
| "enableDataResidency": false | ||
| }, | ||
| "sku": { | ||
| "name": "S1", | ||
| "capacity": 1 | ||
| } | ||
| } | ||
| }, | ||
| "responses": { | ||
| "200": { | ||
| "body": { | ||
| "id": "/subscriptions/ae24ff83-d2ca-4fc8-9717-05dae4bba489/resourceGroups/myResourceGroup/providers/Microsoft.Devices/IotHubs/testHub", | ||
| "name": "testHub", | ||
| "type": "Microsoft.Devices/IotHubs", | ||
| "location": "centraluseuap", | ||
| "tags": {}, | ||
| "etag": "AAAAAAFD6M4=", | ||
| "properties": { | ||
| "state": "Active", | ||
| "provisioningState": "Succeeded", | ||
| "ipFilterRules": [ | ||
| { | ||
| "filterName": "rule1", | ||
| "action": "Accept", | ||
| "ipMask": "131.117.159.53" | ||
| }, | ||
| { | ||
| "filterName": "rule2", | ||
| "action": "Accept", | ||
| "ipMask": "157.55.59.128/25" | ||
| } | ||
| ], | ||
| "networkRuleSets": { | ||
| "defaultAction": "Deny", | ||
| "applyToBuiltInEventHubEndpoint": true, | ||
| "ipRules": [ | ||
| { | ||
| "filterName": "rule1", | ||
| "action": "Allow", | ||
| "ipMask": "131.117.159.53" | ||
| }, | ||
| { | ||
| "filterName": "rule2", | ||
| "action": "Allow", | ||
| "ipMask": "157.55.59.128/25" | ||
| } | ||
| ] | ||
| }, | ||
| "hostName": "iot-dps-cit-hub-1.azure-devices.net", | ||
| "eventHubEndpoints": { | ||
| "events": { | ||
| "retentionTimeInDays": 1, | ||
| "partitionCount": 2, | ||
| "partitionIds": [ | ||
| "0", | ||
| "1" | ||
| ], | ||
| "path": "iot-dps-cit-hub-1", | ||
| "endpoint": "sb://iothub-ns-iot-dps-ci-245306-76aca8e13b.servicebus.windows.net/" | ||
| } | ||
| }, | ||
| "routing": { | ||
| "endpoints": { | ||
| "serviceBusQueues": [], | ||
| "serviceBusTopics": [], | ||
| "eventHubs": [], | ||
| "storageContainers": [], | ||
| "cosmosDBSqlContainers": [ | ||
| { | ||
| "id": "009208fa-9cb7-4b90-bfbd-f40086e766c9", | ||
| "authenticationType": "keyBased", | ||
| "containerName": "test", | ||
| "databaseName": "systemstore", | ||
| "endpointUri": "https://test-systemstore-test2.documents.azure.com", | ||
| "name": "endpointcosmos", | ||
| "partitionKeyName": "keystamped", | ||
| "partitionKeyTemplate": "{deviceid}-{YYYY}-{MM}", | ||
| "resourceGroup": "rg-test", | ||
| "subscriptionId": "<subscription-id>" | ||
| } | ||
| ] | ||
| }, | ||
| "routes": [], | ||
| "fallbackRoute": { | ||
| "name": "$fallback", | ||
| "source": "DeviceMessages", | ||
| "condition": "true", | ||
| "endpointNames": [ | ||
| "events" | ||
| ], | ||
| "isEnabled": true | ||
| } | ||
| }, | ||
| "storageEndpoints": { | ||
| "$default": { | ||
| "sasTtlAsIso8601": "PT1H", | ||
| "connectionString": "", | ||
| "containerName": "" | ||
| } | ||
| }, | ||
| "messagingEndpoints": { | ||
| "fileNotifications": { | ||
| "lockDurationAsIso8601": "PT1M", | ||
| "ttlAsIso8601": "PT1H", | ||
| "maxDeliveryCount": 10 | ||
| } | ||
| }, | ||
| "enableFileUploadNotifications": false, | ||
| "cloudToDevice": { | ||
| "maxDeliveryCount": 10, | ||
| "defaultTtlAsIso8601": "PT1H", | ||
| "feedback": { | ||
| "lockDurationAsIso8601": "PT1M", | ||
| "ttlAsIso8601": "PT1H", | ||
| "maxDeliveryCount": 10 | ||
| } | ||
| }, | ||
| "features": "None", | ||
| "minTlsVersion": "1.2", | ||
| "enableDataResidency": false | ||
| }, | ||
| "sku": { | ||
| "name": "S1", | ||
| "tier": "Standard", | ||
| "capacity": 1 | ||
| }, | ||
| "systemData": { | ||
| "createdAt": "2021-01-30T00:28:38.963Z" | ||
| } | ||
| } | ||
| }, | ||
| "201": { | ||
| "body": { | ||
| "id": "/subscriptions/ae24ff83-d2ca-4fc8-9717-05dae4bba489/resourceGroups/myResourceGroup/providers/Microsoft.Devices/IotHubs/testHub", | ||
| "name": "testHub", | ||
| "type": "Microsoft.Devices/IotHubs", | ||
| "location": "centraluseuap", | ||
| "tags": {}, | ||
| "etag": "AAAAAAFD6M4=", | ||
| "properties": { | ||
| "state": "Active", | ||
| "provisioningState": "Succeeded", | ||
| "ipFilterRules": [ | ||
| { | ||
| "filterName": "rule1", | ||
| "action": "Accept", | ||
| "ipMask": "131.117.159.53" | ||
| }, | ||
| { | ||
| "filterName": "rule2", | ||
| "action": "Accept", | ||
| "ipMask": "157.55.59.128/25" | ||
| } | ||
| ], | ||
| "networkRuleSets": { | ||
| "defaultAction": "Deny", | ||
| "applyToBuiltInEventHubEndpoint": true, | ||
| "ipRules": [ | ||
| { | ||
| "filterName": "rule1", | ||
| "action": "Allow", | ||
| "ipMask": "131.117.159.53" | ||
| }, | ||
| { | ||
| "filterName": "rule2", | ||
| "action": "Allow", | ||
| "ipMask": "157.55.59.128/25" | ||
| } | ||
| ] | ||
| }, | ||
| "hostName": "iot-dps-cit-hub-1.azure-devices.net", | ||
| "eventHubEndpoints": { | ||
| "events": { | ||
| "retentionTimeInDays": 1, | ||
| "partitionCount": 2, | ||
| "partitionIds": [ | ||
| "0", | ||
| "1" | ||
| ], | ||
| "path": "iot-dps-cit-hub-1", | ||
| "endpoint": "sb://iothub-ns-iot-dps-ci-245306-76aca8e13b.servicebus.windows.net/" | ||
| } | ||
| }, | ||
| "routing": { | ||
| "endpoints": { | ||
| "serviceBusQueues": [], | ||
| "serviceBusTopics": [], | ||
| "eventHubs": [], | ||
| "storageContainers": [], | ||
| "cosmosDBSqlContainers": [ | ||
| { | ||
| "id": "009208fa-9cb7-4b90-bfbd-f40086e766c9", | ||
| "authenticationType": "keyBased", | ||
| "containerName": "test", | ||
| "databaseName": "systemstore", | ||
| "endpointUri": "https://test-systemstore-test2.documents.azure.com", | ||
| "name": "endpointcosmos", | ||
| "partitionKeyName": "keystamped", | ||
| "partitionKeyTemplate": "{deviceid}-{YYYY}-{MM}", | ||
| "resourceGroup": "rg-test", | ||
| "subscriptionId": "<subscription-id>" | ||
| } | ||
| ] | ||
| }, | ||
| "routes": [], | ||
| "fallbackRoute": { | ||
| "name": "$fallback", | ||
| "source": "DeviceMessages", | ||
| "condition": "true", | ||
| "endpointNames": [ | ||
| "events" | ||
| ], | ||
| "isEnabled": true | ||
| } | ||
| }, | ||
| "storageEndpoints": { | ||
| "$default": { | ||
| "sasTtlAsIso8601": "PT1H", | ||
| "connectionString": "", | ||
| "containerName": "" | ||
| } | ||
| }, | ||
| "messagingEndpoints": { | ||
| "fileNotifications": { | ||
| "lockDurationAsIso8601": "PT1M", | ||
| "ttlAsIso8601": "PT1H", | ||
| "maxDeliveryCount": 10 | ||
| } | ||
| }, | ||
| "enableFileUploadNotifications": false, | ||
| "cloudToDevice": { | ||
| "maxDeliveryCount": 10, | ||
| "defaultTtlAsIso8601": "PT1H", | ||
| "feedback": { | ||
| "lockDurationAsIso8601": "PT1M", | ||
| "ttlAsIso8601": "PT1H", | ||
| "maxDeliveryCount": 10 | ||
| } | ||
| }, | ||
| "features": "None", | ||
| "minTlsVersion": "1.2", | ||
| "enableDataResidency": false | ||
| }, | ||
| "sku": { | ||
| "name": "S1", | ||
| "tier": "Standard", | ||
| "capacity": 1 | ||
| }, | ||
| "systemData": { | ||
| "createdAt": "2021-01-30T00:28:38.963Z" | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In ARM APIs 'id' often means the resource id. I suppose you have to do it this way for consistency, but if not, I would have wondered if we could find a better name, maybe uuid or uniqueId, or if it is even really needed. Is there any way the customer will consume this by passing it to other parts of the API? #ByDesign
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
id is inherited name as in all other endpoints