Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 2022-09-30-preview for service operations in MySQL #23900

Merged
merged 4 commits into from
May 19, 2023

Conversation

xiaoxuqi-ms
Copy link
Member

@xiaoxuqi-ms xiaoxuqi-ms commented May 10, 2023

ARM API Information (Control Plane)

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @xiaoxuqi-ms Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented May 10, 2023

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.
    ️❌Breaking Change(Cross-Version): 4 Errors, 4 Warnings failed [Detail]
    compared swaggers (via Oad v0.10.4)] new version base version
    ServiceOperations.json 2022-09-30-preview(d60f356) 2022-01-01(main)
    ServiceOperations.json 2022-09-30-preview(d60f356) 2021-12-01-preview(main)

    The following breaking changes are detected by comparison with the latest stable version:

    Rule Message
    1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: ServiceOperations/preview/2022-09-30-preview/ServiceOperations.json#L49:9
    Old: ServiceOperations/stable/2022-01-01/ServiceOperations.json#L49:9
    1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: ServiceOperations/preview/2022-09-30-preview/ServiceOperations.json#L91:9
    Old: ServiceOperations/stable/2022-01-01/ServiceOperations.json#L91:9
    1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: ServiceOperations/preview/2022-09-30-preview/ServiceOperations.json#L139:9
    Old: ServiceOperations/stable/2022-01-01/ServiceOperations.json#L139:9
    1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.DBforMySQL/common-types/v1/common-types.json#L25:5
    Old: ServiceOperations/stable/2022-01-01/ServiceOperations.json#L637:5


    The following breaking changes are detected by comparison with the latest preview version:

    Rule Message
    ⚠️ 1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: ServiceOperations/preview/2022-09-30-preview/ServiceOperations.json#L49:9
    Old: ServiceOperations/preview/2021-12-01-preview/ServiceOperations.json#L49:9
    ⚠️ 1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: ServiceOperations/preview/2022-09-30-preview/ServiceOperations.json#L91:9
    Old: ServiceOperations/preview/2021-12-01-preview/ServiceOperations.json#L91:9
    ⚠️ 1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: ServiceOperations/preview/2022-09-30-preview/ServiceOperations.json#L139:9
    Old: ServiceOperations/preview/2021-12-01-preview/ServiceOperations.json#L139:9
    ⚠️ 1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.DBforMySQL/common-types/v1/common-types.json#L25:5
    Old: ServiceOperations/preview/2021-12-01-preview/ServiceOperations.json#L637:5
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️⚠️LintDiff: 0 Warnings warning [Detail]
    compared tags (via openapi-validator v2.1.1) new version base version
    package-flexibleserver-2022-09-30-preview-privatelink package-flexibleserver-2022-09-30-preview-privatelink(d60f356) package-flexibleserver-2022-09-30-preview-privatelink(main)

    The following errors/warnings exist before current PR submission:

    Rule Message
    OperationsApiResponseSchema The response schema of operations API '/providers/Microsoft.DBforMySQL/operations' does not match the ARM specification. Please standardize the schema.
    Location: ServiceOperations/preview/2022-09-30-preview/ServiceOperations.json#L273
    OperationsApiSchemaUsesCommonTypes Operations API path must follow the schema provided in the common types.
    Location: ServiceOperations/preview/2022-09-30-preview/ServiceOperations.json#L274
    ⚠️ PostOperationIdContainsUrlVerb OperationId should contain the verb: 'checkvirtualnetworksubnetusage' in:'CheckVirtualNetworkSubnetUsage_Execute'. Consider updating the operationId
    Location: ServiceOperations/preview/2022-09-30-preview/ServiceOperations.json#L84
    ⚠️ PostOperationIdContainsUrlVerb OperationId should contain the verb: 'checknameavailability' in:'CheckNameAvailability_Execute'. Consider updating the operationId
    Location: ServiceOperations/preview/2022-09-30-preview/ServiceOperations.json#L132
    ⚠️ PostOperationIdContainsUrlVerb OperationId should contain the verb: 'checknameavailability' in:'CheckNameAvailabilityWithoutLocation_Execute'. Consider updating the operationId
    Location: ServiceOperations/preview/2022-09-30-preview/ServiceOperations.json#L180
    ⚠️ UniqueXmsExample Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: Check name availability
    Location: ServiceOperations/preview/2022-09-30-preview/ServiceOperations.json#L181
    ⚠️ PostOperationIdContainsUrlVerb OperationId should contain the verb: 'getprivatednszonesuffix' in:'GetPrivateDnsZoneSuffix_Execute'. Consider updating the operationId
    Location: ServiceOperations/preview/2022-09-30-preview/ServiceOperations.json#L225
    ⚠️ LocationMustHaveXmsMutability Property location must have 'x-ms-mutability':['read', 'create'] extension defined.
    Location: ServiceOperations/preview/2022-09-30-preview/ServiceOperations.json#L321
    ⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
    Location: ServiceOperations/preview/2022-09-30-preview/ServiceOperations.json#L546
    ️⚠️Avocado: 1 Warnings warning [Detail]
    Rule Message
    ⚠️ MULTIPLE_API_VERSION The default tag contains multiple API versions swaggers.
    readme: specification/mysql/resource-manager/readme.md
    tag: specification/mysql/resource-manager/readme.md#tag-package-2020-01-01
    ️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
    ️❌~[Staging] ServiceAPIReadinessTest: 34 Errors, 0 Warnings failed [Detail]

    Tag package-flexibleserver-2022-09-30-preview-privatelink; Prod region: Deployed

    Test run on region: westcentralus; Operation coverage: total: 44, untested: 0, failed: 32, passed: 12

    Service API Readiness Test failed. Check pipeline artifact for detail report.

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    CLIENT_ERROR statusCode: 403,
    errorCode: AuthorizationFailed,
    errorMessage: The client '7904a8be-825f-480e-a728-80a70579dba4' with object id '7904a8be-825f-480e-a728-80a70579dba4' does not have authorization to perform action 'Microsoft.DBforMySQL/locations/checkNameAvailability/action' over scope '/subscriptions/db5eb68e-73e2-4fa8-b18a-46cd1be4cce5' or the scope is invalid. If access was recently granted, please refresh your credentials.
    Source: runtime
    OperationId: CheckNameAvailability_Execute
    CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The requested resource of type 'Microsoft.DBforMySQL/flexibleServers' with name 'servernah9rrns' was not found.
    Source: runtime
    OperationId: Servers_Get
    CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The requested resource of type 'Microsoft.DBforMySQL/flexibleServers' with name 'servernah9rrns' was not found.
    Source: runtime
    OperationId: Servers_Update
    CLIENT_ERROR statusCode: 404,
    errorCode: ServerNotFound,
    errorMessage: Subscription 'db5eb68e-73e2-4fa8-b18a-46cd1be4cce5' does not have the server 'servernah9rrns'.
    Source: runtime
    OperationId: Servers_Restart
    CLIENT_ERROR statusCode: 404,
    errorCode: ServerNotFound,
    errorMessage: Subscription 'db5eb68e-73e2-4fa8-b18a-46cd1be4cce5' does not have the server 'servernah9rrns'.
    Source: runtime
    OperationId: Servers_Failover
    SERVER_ERROR statusCode: 500,
    errorCode: InternalServerError,
    errorMessage: An unexpected error occured while processing the request. Tracking ID: '2459cd4f-b7cd-4342-934e-dc5a2e0ea1fc'
    Source: runtime
    OperationId: PrivateEndpointConnections_CreateOrUpdate
    SERVER_ERROR statusCode: 500,
    errorCode: InternalServerError,
    errorMessage: An unexpected error occured while processing the request. Tracking ID: '414e2637-21f9-4079-8683-d4ddf1035e2d'
    Source: runtime
    OperationId: PrivateEndpointConnections_ListByServer
    SERVER_ERROR statusCode: 500,
    errorCode: InternalServerError,
    errorMessage: An unexpected error occured while processing the request. Tracking ID: 'bcbfeb17-6d50-4b0c-8436-d4300307041c'
    Source: runtime
    OperationId: PrivateEndpointConnections_Get
    CLIENT_ERROR statusCode: 404,
    errorCode: ServerNotExist,
    errorMessage: The server 'servernah9rrns' does not exist or in unexpected status.
    Source: runtime
    OperationId: Configurations_CreateOrUpdate
    CLIENT_ERROR statusCode: 404,
    errorCode: ServerNotExist,
    errorMessage: The server 'servernah9rrns' does not exist or in unexpected status.
    Source: runtime
    OperationId: Configurations_ListByServer
    CLIENT_ERROR statusCode: 404,
    errorCode: ServerNotExist,
    errorMessage: The server 'servernah9rrns' does not exist or in unexpected status.
    Source: runtime
    OperationId: Configurations_Get
    CLIENT_ERROR statusCode: 404,
    errorCode: ServerNotExist,
    errorMessage: The server 'servernah9rrns' does not exist or in unexpected status.
    Source: runtime
    OperationId: Configurations_Update
    CLIENT_ERROR statusCode: 404,
    errorCode: ServerNotExist,
    errorMessage: The server 'servernah9rrns' does not exist or in unexpected status.
    Source: runtime
    OperationId: Configurations_BatchUpdate
    CLIENT_ERROR statusCode: 404,
    errorCode: ServerNotExist,
    errorMessage: The server 'servernah9rrns' does not exist or in unexpected status.
    Source: runtime
    OperationId: Databases_CreateOrUpdate
    CLIENT_ERROR statusCode: 404,
    errorCode: ServerNotExist,
    errorMessage: The server 'servernah9rrns' does not exist or in unexpected status.
    Source: runtime
    OperationId: Databases_ListByServer
    CLIENT_ERROR statusCode: 404,
    errorCode: ServerNotExist,
    errorMessage: The server 'servernah9rrns' does not exist or in unexpected status.
    Source: runtime
    OperationId: Databases_Get
    SERVER_ERROR statusCode: 500,
    errorCode: InternalServerError,
    errorMessage: An unexpected error occured while processing the request. Tracking ID: 'd0901607-3032-4bf6-89db-e49477794a56'
    Source: runtime
    OperationId: FirewallRules_CreateOrUpdate
    CLIENT_ERROR statusCode: 404,
    errorCode: ServerNotExist,
    errorMessage: The server 'servernah9rrns' does not exist or in unexpected status.
    Source: runtime
    OperationId: FirewallRules_ListByServer
    CLIENT_ERROR statusCode: 404,
    errorCode: ServerNotExist,
    errorMessage: The server 'servernah9rrns' does not exist or in unexpected status.
    Source: runtime
    OperationId: FirewallRules_Get
    CLIENT_ERROR statusCode: 400,
    errorCode: InvalidParameterValue,
    errorMessage: Invalid value given for parameter administratorName. Specify a valid parameter value.
    Source: runtime
    OperationId: AzureADAdministrators_CreateOrUpdate
    CLIENT_ERROR statusCode: 404,
    errorCode: ServerNotExist,
    errorMessage: The server 'servernah9rrns' does not exist or in unexpected status.
    Source: runtime
    OperationId: AzureADAdministrators_ListByServer
    CLIENT_ERROR statusCode: 400,
    errorCode: InvalidParameterValue,
    errorMessage: Invalid value given for parameter administratorName. Specify a valid parameter value.
    Source: runtime
    OperationId: AzureADAdministrators_Get
    CLIENT_ERROR statusCode: 404,
    errorCode: ServerNotExist,
    errorMessage: The server 'servernah9rrns' does not exist or in unexpected status.
    Source: runtime
    OperationId: Backups_Put
    CLIENT_ERROR statusCode: 404,
    errorCode: ServerNotExist,
    errorMessage: The server 'servernah9rrns' does not exist or in unexpected status.
    Source: runtime
    OperationId: Backups_ListByServer
    CLIENT_ERROR statusCode: 404,
    errorCode: ServerNotExist,
    errorMessage: The server 'servernah9rrns' does not exist or in unexpected status.
    Source: runtime
    OperationId: Backups_Get
    CLIENT_ERROR statusCode: 400,
    errorCode: NoRegisteredProviderFound,
    errorMessage: No registered resource provider found for location 'locationas2iuq' and API version '2022-09-30-preview' for type 'locations/capabilities'. The supported api-versions are '2020-07-01-privatepreview, 2020-07-01-preview, 2021-05-01-preview, 2021-05-01, 2021-12-01-preview, 2022-06-01-privatepreview, 2022-06-01-preview, 2022-09-30-privatepreview, 2022-09-30-preview'. The supported locations are 'australiacentral, australiasoutheast, canadaeast, eastasia, eastus2, germanynorth, germanywestcentral, centralindia, southindia, japanwest, koreasouth, northcentralus, norwayeast, norwaywest, swedencentral, uaenorth, ukwest, westcentralus, westus, westus2, westus3, brazilsouth, brazilsoutheast, francecentral, francesouth, southafricanorth, southafricawest, southeastasia, northeurope, australiaeast, japaneast, koreacentral, uksouth, westeurope, canadacentral, centralus, eastus, switzerlandnorth, switzerlandwest, southcentralus, qatarcentral, eastus2euap, centraluseuap'.
    Source: runtime
    OperationId: LocationBasedCapabilities_List
    CLIENT_ERROR statusCode: 403,
    errorCode: AuthorizationFailed,
    errorMessage: The client '7904a8be-825f-480e-a728-80a70579dba4' with object id '7904a8be-825f-480e-a728-80a70579dba4' does not have authorization to perform action 'Microsoft.DBforMySQL/locations/checkVirtualNetworkSubnetUsage/action' over scope '/subscriptions/db5eb68e-73e2-4fa8-b18a-46cd1be4cce5' or the scope is invalid. If access was recently granted, please refresh your credentials.
    Source: runtime
    OperationId: CheckVirtualNetworkSubnetUsage_Execute
    CLIENT_ERROR statusCode: 404,
    errorCode: ServerNotExist,
    errorMessage: The server 'servernah9rrns' does not exist or in unexpected status.
    Source: runtime
    OperationId: LogFiles_ListByServer
    CLIENT_ERROR statusCode: 404,
    errorCode: undefined,
    errorMessage: undefined
    Source: runtime
    OperationId: PrivateLinkResources_Get
    INVALID_CONTENT_TYPE Invalid Content-Type (application/octet-stream). These are supported: application/json
    Source: response
    OperationId: PrivateLinkResources_Get
    ️❌SwaggerAPIView: 0 Errors, 0 Warnings failed [Detail]
    ️️✔️CadlAPIView succeeded [Detail] [Expand]
    ️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️PoliCheck succeeded [Detail] [Expand]
    Validation passed for PoliCheck.
    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    ️️✔️CadlValidation succeeded [Detail] [Expand]
    Validation passes for CadlValidation.
    ️️✔️TypeSpec Validation succeeded [Detail] [Expand]
    Validation passes for TypeSpec Validation.
    ️️✔️PR Summary succeeded [Detail] [Expand]
    Validation passes for Summary.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented May 10, 2023

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️❌SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking


    azure-sdk-for-go - sdk/resourcemanager/mysql/armmysqlflexibleservers - Approved - 2.0.0-beta.1
    +	Type of `Identity.Type` has been changed from `*string` to `*ManagedServiceIdentityType`

    ️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from ec1dd63. SDK Automation 14.0.0
      command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
      command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
    • ️✔️Azure.ResourceManager.MySql [View full logs]  [Release SDK Changes]
      info	[Changelog]
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from ec1dd63. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
      cmderr	[automation_generate.sh] notice
      cmderr	[automation_generate.sh] npm notice New minor version of npm available! 9.5.1 -> 9.6.7
      cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.6.7>
      cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
      cmderr	[automation_generate.sh] npm notice
    • ️✔️track2_azure-mgmt-rdbms [View full logs]  [Release SDK Changes]
      info	[Changelog] change log generation failed!!!
    ️⚠️ azure-sdk-for-java warning [Detail]
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from ec1dd63. SDK Automation 14.0.0
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️sdk/resourcemanager/mysql/armmysql [View full logs]  [Release SDK Changes]
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️sdk/resourcemanager/mysql/armmysqlflexibleservers [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] ### Breaking Changes
      info	[Changelog]
      info	[Changelog] - Type of `Identity.Type` has been changed from `*string` to `*ManagedServiceIdentityType`
      info	[Changelog]
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog] - New enum type `AdministratorName` with values `AdministratorNameActiveDirectory`
      info	[Changelog] - New enum type `AdministratorType` with values `AdministratorTypeActiveDirectory`
      info	[Changelog] - New enum type `BackupFormat` with values `BackupFormatCollatedFormat`, `BackupFormatNone`
      info	[Changelog] - New enum type `ManagedServiceIdentityType` with values `ManagedServiceIdentityTypeUserAssigned`
      info	[Changelog] - New enum type `OperationStatus` with values `OperationStatusCancelInProgress`, `OperationStatusCanceled`, `OperationStatusFailed`, `OperationStatusInProgress`, `OperationStatusPending`, `OperationStatusSucceeded`
      info	[Changelog] - New enum type `ResetAllToDefault` with values `ResetAllToDefaultFalse`, `ResetAllToDefaultTrue`
      info	[Changelog] - New function `NewAzureADAdministratorsClient(string, azcore.TokenCredential, *arm.ClientOptions) (*AzureADAdministratorsClient, error)`
      info	[Changelog] - New function `*AzureADAdministratorsClient.BeginCreateOrUpdate(context.Context, string, string, AdministratorName, AzureADAdministrator, *AzureADAdministratorsClientBeginCreateOrUpdateOptions) (*runtime.Poller[AzureADAdministratorsClientCreateOrUpdateResponse], error)`
      info	[Changelog] - New function `*AzureADAdministratorsClient.BeginDelete(context.Context, string, string, AdministratorName, *AzureADAdministratorsClientBeginDeleteOptions) (*runtime.Poller[AzureADAdministratorsClientDeleteResponse], error)`
      info	[Changelog] - New function `*AzureADAdministratorsClient.Get(context.Context, string, string, AdministratorName, *AzureADAdministratorsClientGetOptions) (AzureADAdministratorsClientGetResponse, error)`
      info	[Changelog] - New function `*AzureADAdministratorsClient.NewListByServerPager(string, string, *AzureADAdministratorsClientListByServerOptions) *runtime.Pager[AzureADAdministratorsClientListByServerResponse]`
      info	[Changelog] - New function `NewBackupAndExportClient(string, azcore.TokenCredential, *arm.ClientOptions) (*BackupAndExportClient, error)`
      info	[Changelog] - New function `*BackupAndExportClient.BeginCreate(context.Context, string, string, BackupAndExportRequest, *BackupAndExportClientBeginCreateOptions) (*runtime.Poller[BackupAndExportClientCreateResponse], error)`
      info	[Changelog] - New function `*BackupAndExportClient.ValidateBackup(context.Context, string, string, *BackupAndExportClientValidateBackupOptions) (BackupAndExportClientValidateBackupResponse, error)`
      info	[Changelog] - New function `*BackupStoreDetails.GetBackupStoreDetails() *BackupStoreDetails`
      info	[Changelog] - New function `*BackupsClient.Put(context.Context, string, string, string, *BackupsClientPutOptions) (BackupsClientPutResponse, error)`
      info	[Changelog] - New function `NewCheckNameAvailabilityWithoutLocationClient(string, azcore.TokenCredential, *arm.ClientOptions) (*CheckNameAvailabilityWithoutLocationClient, error)`
      info	[Changelog] - New function `*CheckNameAvailabilityWithoutLocationClient.Execute(context.Context, NameAvailabilityRequest, *CheckNameAvailabilityWithoutLocationClientExecuteOptions) (CheckNameAvailabilityWithoutLocationClientExecuteResponse, error)`
      info	[Changelog] - New function `*ClientFactory.NewAzureADAdministratorsClient() *AzureADAdministratorsClient`
      info	[Changelog] - New function `*ClientFactory.NewBackupAndExportClient() *BackupAndExportClient`
      info	[Changelog] - New function `*ClientFactory.NewCheckNameAvailabilityWithoutLocationClient() *CheckNameAvailabilityWithoutLocationClient`
      info	[Changelog] - New function `*ClientFactory.NewLogFilesClient() *LogFilesClient`
      info	[Changelog] - New function `*ConfigurationsClient.BeginCreateOrUpdate(context.Context, string, string, string, Configuration, *ConfigurationsClientBeginCreateOrUpdateOptions) (*runtime.Poller[ConfigurationsClientCreateOrUpdateResponse], error)`
      info	[Changelog] - New function `*FullBackupStoreDetails.GetBackupStoreDetails() *BackupStoreDetails`
      info	[Changelog] - New function `NewLogFilesClient(string, azcore.TokenCredential, *arm.ClientOptions) (*LogFilesClient, error)`
      info	[Changelog] - New function `*LogFilesClient.NewListByServerPager(string, string, *LogFilesClientListByServerOptions) *runtime.Pager[LogFilesClientListByServerResponse]`
      info	[Changelog] - New function `*ServersClient.BeginResetGtid(context.Context, string, string, ServerGtidSetParameter, *ServersClientBeginResetGtidOptions) (*runtime.Poller[ServersClientResetGtidResponse], error)`
      info	[Changelog] - New struct `AdministratorListResult`
      info	[Changelog] - New struct `AdministratorProperties`
      info	[Changelog] - New struct `AzureADAdministrator`
      info	[Changelog] - New struct `BackupAndExportRequest`
      info	[Changelog] - New struct `BackupAndExportResponse`
      info	[Changelog] - New struct `BackupAndExportResponseProperties`
      info	[Changelog] - New struct `BackupRequestBase`
      info	[Changelog] - New struct `BackupSettings`
      info	[Changelog] - New struct `FullBackupStoreDetails`
      info	[Changelog] - New struct `LogFile`
      info	[Changelog] - New struct `LogFileListResult`
      info	[Changelog] - New struct `LogFileProperties`
      info	[Changelog] - New struct `ServerGtidSetParameter`
      info	[Changelog] - New struct `ValidateBackupResponse`
      info	[Changelog] - New struct `ValidateBackupResponseProperties`
      info	[Changelog] - New field `ResetAllToDefault` in struct `ConfigurationListForBatchUpdate`
      info	[Changelog] - New field `CurrentValue`, `DocumentationLink` in struct `ConfigurationProperties`
      info	[Changelog] - New field `Keyword`, `Page`, `PageSize`, `Tags` in struct `ConfigurationsClientListByServerOptions`
      info	[Changelog] - New field `Network`, `Version` in struct `ServerPropertiesForUpdate`
      info	[Changelog] - New field `AutoIoScaling`, `LogOnDisk` in struct `Storage`
      info	[Changelog] - New field `Location`, `SubscriptionID` in struct `VirtualNetworkSubnetUsageResult`
      info	[Changelog]
      info	[Changelog] Total 1 breaking change(s), 77 additive change(s).
    ️⚠️ azure-sdk-for-js warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from ec1dd63. SDK Automation 14.0.0
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
      warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
      command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
      warn	No file changes detected after generation
      warn	No package detected after generation
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from ec1dd63. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh]  old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh] npm WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] npm WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
      warn	No file changes detected after generation
    • ️✔️mysql [View full logs
    ️❌ azure-powershell failed [Detail]
    • Pipeline Framework Failed [Logs]Release - Generate from ec1dd63. SDK Automation 14.0.0
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
      command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
      SSL error: syscall failure: Broken pipe
      Error: SSL error: syscall failure: Broken pipe
    • ️✔️Az.mysql.DefaultTag [View full logs
      error	Fatal error: SSL error: syscall failure: Broken pipe
      error	The following packages are still pending:
      error		Az.mysql.DefaultTag
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented May 10, 2023

    Generated ApiView

    Language Package Name ApiView Link
    Go sdk/resourcemanager/mysql/armmysql There is no API change compared with the previous version
    Go sdk/resourcemanager/mysql/armmysqlflexibleservers https://apiview.dev/Assemblies/Review/ae200ff9f3e0472bbfebfc4e09ecd52e
    Java azure-resourcemanager-mysqlflexibleserver https://apiview.dev/Assemblies/Review/17bcf9334f434c52bc5b27189062b987
    .Net Azure.ResourceManager.MySql https://apiview.dev/Assemblies/Review/55ed1844acef4112920eff54dd88796c

    @xiaoxuqi-ms xiaoxuqi-ms changed the title Mysql/20220930serviceoperation Add 2022-09-30-preview for service operations in MySQL May 10, 2023
    @AzureRestAPISpecReview AzureRestAPISpecReview added ARMReview BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test resource-manager labels May 10, 2023
    @openapi-workflow-bot
    Copy link

    Hi @xiaoxuqi-ms, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
    Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
    If you want to know the production traffic statistic, please see ARM Traffic statistic.
    If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.
    Note: To avoid breaking change, you can refer to Shift Left Solution for detecting breaking change in early phase at your service code repository.

    @xiaoxuqi-ms
    Copy link
    Member Author

    Hi Reviewers,
    This pr is to add a new api version for service operations. There is no change of API, just copy from the previous version.

    @v-jiaodi
    Copy link
    Member

    @xiaoxuqi-ms Please fill in the correct checkboxes in the first comment so we can get a quick overview of what's going on with this PR and make sure you've understood the relevant linked docs.

    @TimLovellSmith
    Copy link
    Member

    TimLovellSmith commented May 10, 2023

    Hi Reviewers, This pr is to add a new api version for service operations. There is no change of API, just copy from the previous version.

    That's fine to have no changes. Please fill in the PR description, changelog, etc, anyway.
    I wonder why your PR got flagged as breakingchange review required.

    Edit: looks like you just have to do the BreakingChange review for the regex pattern change. ARM Review isn't really required for that, so I'll remove the ARMReview label!

    @JeffreyRichter JeffreyRichter added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label May 12, 2023
    @v-jiaodi
    Copy link
    Member

    /azp run

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @AzureRestAPISpecReview AzureRestAPISpecReview added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label May 12, 2023
    @v-jiaodi
    Copy link
    Member

    @raych1 could you help to take a look at the SDK breaking change in this PR? Thanks

    @raych1
    Copy link
    Member

    raych1 commented May 12, 2023

    @tadelesh , can you help me understand the breaking change detected?

    @mikekistler mikekistler self-requested a review May 12, 2023 15:36
    Copy link
    Member

    @mikekistler mikekistler left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    The LiveValidation site shows a number of missing operations in this API version. Could you please address these issues in this PR as well?

    @tadelesh
    Copy link
    Member

    @tadelesh , can you help me understand the breaking change detected?

    The breaking change is not from this PR's change. You may ignore it.

    @tadelesh tadelesh added the Approved-SdkBreakingChange-Go Approve the breaking change tracking for azure-sdk-for-go label May 15, 2023
    @raosuhas raosuhas added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label May 15, 2023
    @openapi-workflow-bot openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label May 15, 2023
    @xiaoxuqi-ms
    Copy link
    Member Author

    The LiveValidation site shows a number of missing operations in this API version. Could you please address these issues in this PR as well?

    Hi @mikekistler, by looking up ARM logs for these missing operations, we find some incoming calls are from portal. We will fix portal template to solve this. And a majority calls are from PolicyScan, we are working with Azure policy team to resolve this issues without unnecessary update of swagger.

    Copy link
    Member

    @mikekistler mikekistler left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Looks good. 👍

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 Approved-OkToMerge <valid label in PR review process>add this label when assignee approve to merge the updates Approved-SdkBreakingChange-Go Approve the breaking change tracking for azure-sdk-for-go ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required CI-BreakingChange-Go MySQL ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test resource-manager
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    10 participants