Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename operation #24036

Merged
merged 2 commits into from
Jun 1, 2023
Merged

Rename operation #24036

merged 2 commits into from
Jun 1, 2023

Conversation

MattEberhart-MSFTE
Copy link
Contributor

@MattEberhart-MSFTE MattEberhart-MSFTE commented May 17, 2023

Choose a PR Template

Switch to "Preview" on this description then select one of the choices below.

Click here to open a PR for a Data Plane API.

Click here to open a PR for a Control Plane (ARM) API.

Selecting template is not working.

The issue is with operation ids as is, each scope appears in our documentation with the API as a drop down rather than a single API with multiple scopes in a drop down.

Screenshot below marks an existing API acting as expected in green and the new API to be changed in this PR in orange
image

@openapi-workflow-bot
Copy link

Hi, @MattEberhart-MSFTE Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented May 17, 2023

    Swagger Validation Report

    ️❌BreakingChange: 6 Errors, 0 Warnings failed [Detail]
    compared swaggers (via Oad v0.10.4)] new version base version
    costmanagement.benefits.json 2023-03-01(036701d) 2023-03-01(main)
    Rule Message
    1008 - ModifiedOperationId The operation id has been changed from 'BillingAccountScope_GenerateBenefitUtilizationSummariesReport' to 'GenerateBenefitUtilizationSummariesReport_GenerateByBillingAccount'. This will impact generated code.
    New: Microsoft.CostManagement/stable/2023-03-01/costmanagement.benefits.json#L319:7
    Old: Microsoft.CostManagement/stable/2023-03-01/costmanagement.benefits.json#L319:7
    1008 - ModifiedOperationId The operation id has been changed from 'BillingProfileScope_GenerateBenefitUtilizationSummariesReport' to 'GenerateBenefitUtilizationSummariesReport_GenerateByBillingProfile'. This will impact generated code.
    New: Microsoft.CostManagement/stable/2023-03-01/costmanagement.benefits.json#L385:7
    Old: Microsoft.CostManagement/stable/2023-03-01/costmanagement.benefits.json#L385:7
    1008 - ModifiedOperationId The operation id has been changed from 'ReservationOrderScope_GenerateBenefitUtilizationSummariesReport' to 'GenerateBenefitUtilizationSummariesReport_GenerateByReservationOrderId'. This will impact generated code.
    New: Microsoft.CostManagement/stable/2023-03-01/costmanagement.benefits.json#L454:7
    Old: Microsoft.CostManagement/stable/2023-03-01/costmanagement.benefits.json#L454:7
    1008 - ModifiedOperationId The operation id has been changed from 'ReservationScope_GenerateBenefitUtilizationSummariesReport' to 'GenerateBenefitUtilizationSummariesReport_GenerateByReservationId'. This will impact generated code.
    New: Microsoft.CostManagement/stable/2023-03-01/costmanagement.benefits.json#L520:7
    Old: Microsoft.CostManagement/stable/2023-03-01/costmanagement.benefits.json#L520:7
    1008 - ModifiedOperationId The operation id has been changed from 'SavingsPlanOrderScope_GenerateBenefitUtilizationSummariesReport' to 'GenerateBenefitUtilizationSummariesReport_GenerateBySavingsPlanOrderId'. This will impact generated code.
    New: Microsoft.CostManagement/stable/2023-03-01/costmanagement.benefits.json#L589:7
    Old: Microsoft.CostManagement/stable/2023-03-01/costmanagement.benefits.json#L589:7
    1008 - ModifiedOperationId The operation id has been changed from 'SavingsPlanScope_GenerateBenefitUtilizationSummariesReportAsync' to 'GenerateBenefitUtilizationSummariesReportAsync_GenerateBySavingsPlanId'. This will impact generated code.
    New: Microsoft.CostManagement/stable/2023-03-01/costmanagement.benefits.json#L655:7
    Old: Microsoft.CostManagement/stable/2023-03-01/costmanagement.benefits.json#L655:7
    ️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️⚠️LintDiff: 6 Warnings warning [Detail]
    compared tags (via openapi-validator v2.1.2) new version base version
    package-2023-03 package-2023-03(036701d) package-2023-03(main)

    [must fix]The following errors/warnings are introduced by current PR:

    Rule Message Related RPC [For API reviewers]
    ⚠️ PostOperationIdContainsUrlVerb OperationId should contain the verb: 'generatebenefitutilizationsummariesreport' in:'GenerateBenefitUtilizationSummariesReport_GenerateByBillingAccount'. Consider updating the operationId
    Location: Microsoft.CostManagement/stable/2023-03-01/costmanagement.benefits.json#L323
    ⚠️ PostOperationIdContainsUrlVerb OperationId should contain the verb: 'generatebenefitutilizationsummariesreport' in:'GenerateBenefitUtilizationSummariesReport_GenerateByBillingProfile'. Consider updating the operationId
    Location: Microsoft.CostManagement/stable/2023-03-01/costmanagement.benefits.json#L389
    ⚠️ PostOperationIdContainsUrlVerb OperationId should contain the verb: 'generatebenefitutilizationsummariesreport' in:'GenerateBenefitUtilizationSummariesReport_GenerateByReservationOrderId'. Consider updating the operationId
    Location: Microsoft.CostManagement/stable/2023-03-01/costmanagement.benefits.json#L458
    ⚠️ PostOperationIdContainsUrlVerb OperationId should contain the verb: 'generatebenefitutilizationsummariesreport' in:'GenerateBenefitUtilizationSummariesReport_GenerateByReservationId'. Consider updating the operationId
    Location: Microsoft.CostManagement/stable/2023-03-01/costmanagement.benefits.json#L524
    ⚠️ PostOperationIdContainsUrlVerb OperationId should contain the verb: 'generatebenefitutilizationsummariesreport' in:'GenerateBenefitUtilizationSummariesReport_GenerateBySavingsPlanOrderId'. Consider updating the operationId
    Location: Microsoft.CostManagement/stable/2023-03-01/costmanagement.benefits.json#L593
    ⚠️ PostOperationIdContainsUrlVerb OperationId should contain the verb: 'generatebenefitutilizationsummariesreport' in:'GenerateBenefitUtilizationSummariesReportAsync_GenerateBySavingsPlanId'. Consider updating the operationId
    Location: Microsoft.CostManagement/stable/2023-03-01/costmanagement.benefits.json#L659


    The following errors/warnings exist before current PR submission:

    Rule Message
    ValidFormats 'decimal' is not a known format.
    Location: Microsoft.CostManagement/stable/2023-03-01/costmanagement.benefits.json#L812
    ValidFormats 'decimal' is not a known format.
    Location: Microsoft.CostManagement/stable/2023-03-01/costmanagement.benefits.json#L882
    ValidFormats 'decimal' is not a known format.
    Location: Microsoft.CostManagement/stable/2023-03-01/costmanagement.benefits.json#L914
    ValidFormats 'decimal' is not a known format.
    Location: Microsoft.CostManagement/stable/2023-03-01/costmanagement.benefits.json#L920
    ValidFormats 'decimal' is not a known format.
    Location: Microsoft.CostManagement/stable/2023-03-01/costmanagement.benefits.json#L926
    ValidFormats 'decimal' is not a known format.
    Location: Microsoft.CostManagement/stable/2023-03-01/costmanagement.benefits.json#L932
    ValidFormats 'decimal' is not a known format.
    Location: Microsoft.CostManagement/stable/2023-03-01/costmanagement.benefits.json#L938
    ValidFormats 'decimal' is not a known format.
    Location: Microsoft.CostManagement/stable/2023-03-01/costmanagement.benefits.json#L945
    ValidFormats 'decimal' is not a known format.
    Location: Microsoft.CostManagement/stable/2023-03-01/costmanagement.benefits.json#L951
    ValidFormats 'decimal' is not a known format.
    Location: Microsoft.CostManagement/stable/2023-03-01/costmanagement.benefits.json#L957
    ValidFormats 'decimal' is not a known format.
    Location: Microsoft.CostManagement/stable/2023-03-01/costmanagement.benefits.json#L963
    ValidFormats 'decimal' is not a known format.
    Location: Microsoft.CostManagement/stable/2023-03-01/costmanagement.benefits.json#L1221
    ValidFormats 'decimal' is not a known format.
    Location: Microsoft.CostManagement/stable/2023-03-01/costmanagement.benefits.json#L1255
    ValidFormats 'decimal' is not a known format.
    Location: Microsoft.CostManagement/stable/2023-03-01/costmanagement.benefits.json#L1261
    ValidFormats 'decimal' is not a known format.
    Location: Microsoft.CostManagement/stable/2023-03-01/costmanagement.benefits.json#L1267
    ⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'operationId'.
    Location: Microsoft.CostManagement/stable/2023-03-01/costmanagement.benefits.json#L58
    ⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'operationId'.
    Location: Microsoft.CostManagement/stable/2023-03-01/costmanagement.benefits.json#L112
    ⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'operationId'.
    Location: Microsoft.CostManagement/stable/2023-03-01/costmanagement.benefits.json#L165
    ⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'operationId'.
    Location: Microsoft.CostManagement/stable/2023-03-01/costmanagement.benefits.json#L226
    ⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'operationId'.
    Location: Microsoft.CostManagement/stable/2023-03-01/costmanagement.benefits.json#L278
    ⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'operationId'.
    Location: Microsoft.CostManagement/stable/2023-03-01/costmanagement.benefits.json#L337
    ⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'operationId'.
    Location: Microsoft.CostManagement/stable/2023-03-01/costmanagement.benefits.json#L403
    ⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'operationId'.
    Location: Microsoft.CostManagement/stable/2023-03-01/costmanagement.benefits.json#L472
    ⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'operationId'.
    Location: Microsoft.CostManagement/stable/2023-03-01/costmanagement.benefits.json#L538
    ⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'operationId'.
    Location: Microsoft.CostManagement/stable/2023-03-01/costmanagement.benefits.json#L607
    ⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'operationId'.
    Location: Microsoft.CostManagement/stable/2023-03-01/costmanagement.benefits.json#L673
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
    ️⚠️~[Staging] ServiceAPIReadinessTest: 0 Warnings warning [Detail]

    API Test is not triggered due to precheck failure. Check pipeline log for details.

    ️️✔️SwaggerAPIView succeeded [Detail] [Expand]
    ️️✔️CadlAPIView succeeded [Detail] [Expand]
    ️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️PoliCheck succeeded [Detail] [Expand]
    Validation passed for PoliCheck.
    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    ️️✔️CadlValidation succeeded [Detail] [Expand]
    Validation passes for CadlValidation.
    ️️✔️TypeSpec Validation succeeded [Detail] [Expand]
    Validation passes for TypeSpec Validation.
    ️️✔️PR Summary succeeded [Detail] [Expand]
    Validation passes for Summary.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented May 17, 2023

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️❌SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking

    azure-sdk-for-go - sdk/resourcemanager/costmanagement/armcostmanagement - Approved - 2.0.0
    +	Enum `ForecastTimeframeType` has been removed
    +	Enum `ReportConfigColumnType` has been removed
    +	Field `ETag` of struct `ProxyResource` has been removed
    +	Field `ETag`, `Location`, `SKU`, `Tags` of struct `Resource` has been removed
    +	Field `ID` of struct `Operation` has been removed
    +	Field `QueryResult` of struct `ForecastClientExternalCloudProviderUsageResponse` has been removed
    +	Field `QueryResult` of struct `ForecastClientUsageResponse` has been removed
    +	Operation `*GenerateDetailedCostReportOperationResultsClient.Get` has been changed to LRO, use `*GenerateDetailedCostReportOperationResultsClient.BeginGet` instead.
    +	Struct `ExportExecutionProperties` has been removed
    +	Struct `ExportExecution` has been removed
    +	Type of `ExportExecutionListResult.Value` has been changed from `[]*ExportExecution` to `[]*ExportRun`
    +	Type of `ForecastDataset.Aggregation` has been changed from `map[string]*QueryAggregation` to `map[string]*ForecastAggregation`
    +	Type of `ForecastDataset.Configuration` has been changed from `*QueryDatasetConfiguration` to `*ForecastDatasetConfiguration`
    +	Type of `ForecastDataset.Filter` has been changed from `*QueryFilter` to `*ForecastFilter`
    +	Type of `ForecastDefinition.TimePeriod` has been changed from `*QueryTimePeriod` to `*ForecastTimePeriod`
    +	Type of `ForecastDefinition.Timeframe` has been changed from `*ForecastTimeframeType` to `*ForecastTimeframe`
    +	Type of `OperationListResult.Value` has been changed from `[]*Operation` to `[]*OperationForCostManagement`
    +	Type of `ReportConfigGrouping.Type` has been changed from `*ReportConfigColumnType` to `*QueryColumnType`
    +	`QueryColumnTypeTag` from enum `QueryColumnType` has been removed
    azure-sdk-for-python-track2 - track2_azure-mgmt-costmanagement - Approved - 3.0.0
    +	Model Alert no longer has parameter tags
    +	Model ProxyResource no longer has parameter e_tag
    +	Model ReportConfigFilter no longer has parameter tag_key
    +	Model ReportConfigFilter no longer has parameter tag_value
    +	Model Resource no longer has parameter tags
    +	Removed operation group SettingsOperations
    ️❌ azure-sdk-for-net-track2 failed [Detail]
    • Failed [Logs]Release - Generate from 0724e72. SDK Automation 14.0.0
      command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
      command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:712
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 712 | �[0m         �[36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s�[0m …
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mFailed to generate sdk. exit code: False
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGet-ChildItem: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:800
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 800 | �[0m … rtifacts += �[36;1mGet-ChildItem $artifactsPath -Filter *.nupkg -exclude *.s�[0m …
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mCannot find path
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m'/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/packages/Debug/' because
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1mit does not exist.
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:712
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 712 | �[0m         �[36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s�[0m …
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mFailed to generate sdk artifact
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
    • Azure.ResourceManager.Cost-Management [View full logs]  [Release SDK Changes]
      info	[Changelog]
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 0724e72. SDK Automation 14.0.0
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️sdk/resourcemanager/costmanagement/armcostmanagement [View full logs]  [Release SDK Changes]
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog] - New value `OperationStatusTypeComplete` added to enum type `OperationStatusType`
      info	[Changelog] - New enum type `BenefitUtilizationSummaryReportSchema` with values `BenefitUtilizationSummaryReportSchemaAvgUtilizationPercentage`, `BenefitUtilizationSummaryReportSchemaBenefitID`, `BenefitUtilizationSummaryReportSchemaBenefitOrderID`, `BenefitUtilizationSummaryReportSchemaBenefitType`, `BenefitUtilizationSummaryReportSchemaKind`, `BenefitUtilizationSummaryReportSchemaMaxUtilizationPercentage`, `BenefitUtilizationSummaryReportSchemaMinUtilizationPercentage`, `BenefitUtilizationSummaryReportSchemaUsageDate`, `BenefitUtilizationSummaryReportSchemaUtilizedPercentage`
      info	[Changelog] - New function `*ClientFactory.NewGenerateBenefitUtilizationSummariesReportAsyncClient() *GenerateBenefitUtilizationSummariesReportAsyncClient`
      info	[Changelog] - New function `*ClientFactory.NewGenerateBenefitUtilizationSummariesReportClient() *GenerateBenefitUtilizationSummariesReportClient`
      info	[Changelog] - New function `NewGenerateBenefitUtilizationSummariesReportAsyncClient(azcore.TokenCredential, *arm.ClientOptions) (*GenerateBenefitUtilizationSummariesReportAsyncClient, error)`
      info	[Changelog] - New function `*GenerateBenefitUtilizationSummariesReportAsyncClient.BeginGenerateBySavingsPlanID(context.Context, string, string, BenefitUtilizationSummariesRequest, *GenerateBenefitUtilizationSummariesReportAsyncClientBeginGenerateBySavingsPlanIDOptions) (*runtime.Poller[GenerateBenefitUtilizationSummariesReportAsyncClientGenerateBySavingsPlanIDResponse], error)`
      info	[Changelog] - New function `NewGenerateBenefitUtilizationSummariesReportClient(azcore.TokenCredential, *arm.ClientOptions) (*GenerateBenefitUtilizationSummariesReportClient, error)`
      info	[Changelog] - New function `*GenerateBenefitUtilizationSummariesReportClient.BeginGenerateByBillingAccount(context.Context, string, BenefitUtilizationSummariesRequest, *GenerateBenefitUtilizationSummariesReportClientBeginGenerateByBillingAccountOptions) (*runtime.Poller[GenerateBenefitUtilizationSummariesReportClientGenerateByBillingAccountResponse], error)`
      info	[Changelog] - New function `*GenerateBenefitUtilizationSummariesReportClient.BeginGenerateByBillingProfile(context.Context, string, string, BenefitUtilizationSummariesRequest, *GenerateBenefitUtilizationSummariesReportClientBeginGenerateByBillingProfileOptions) (*runtime.Poller[GenerateBenefitUtilizationSummariesReportClientGenerateByBillingProfileResponse], error)`
      info	[Changelog] - New function `*GenerateBenefitUtilizationSummariesReportClient.BeginGenerateByReservationID(context.Context, string, string, BenefitUtilizationSummariesRequest, *GenerateBenefitUtilizationSummariesReportClientBeginGenerateByReservationIDOptions) (*runtime.Poller[GenerateBenefitUtilizationSummariesReportClientGenerateByReservationIDResponse], error)`
      info	[Changelog] - New function `*GenerateBenefitUtilizationSummariesReportClient.BeginGenerateByReservationOrderID(context.Context, string, BenefitUtilizationSummariesRequest, *GenerateBenefitUtilizationSummariesReportClientBeginGenerateByReservationOrderIDOptions) (*runtime.Poller[GenerateBenefitUtilizationSummariesReportClientGenerateByReservationOrderIDResponse], error)`
      info	[Changelog] - New function `*GenerateBenefitUtilizationSummariesReportClient.BeginGenerateBySavingsPlanOrderID(context.Context, string, BenefitUtilizationSummariesRequest, *GenerateBenefitUtilizationSummariesReportClientBeginGenerateBySavingsPlanOrderIDOptions) (*runtime.Poller[GenerateBenefitUtilizationSummariesReportClientGenerateBySavingsPlanOrderIDResponse], error)`
      info	[Changelog] - New struct `AsyncOperationStatusProperties`
      info	[Changelog] - New struct `BenefitUtilizationSummariesOperationStatus`
      info	[Changelog] - New struct `BenefitUtilizationSummariesRequest`
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 27 additive change(s).
    ️❌ azure-sdk-for-python-track2 failed [Detail]
    • Code Generator Failed [Logs]Release - Generate from 0724e72. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] E: Unable to locate package python3.10-venv
      cmderr	[automation_init.sh] E: Couldn't find any package by glob 'python3.10-venv'
      cmderr	[automation_init.sh] E: Couldn't find any package by regex 'python3.10-venv'
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
      cmderr	[automation_generate.sh]
      cmderr	[automation_generate.sh] npm notice New minor version of npm available! 9.5.1 -> 9.6.7
      cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.6.7>
      cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
      cmderr	[automation_generate.sh] npm notice
      cmderr	[automation_generate.sh] curl: (18) transfer closed with 8048244 bytes remaining to read
      cmderr	[automation_generate.sh] xz: (stdin): Unexpected end of input
      cmderr	[automation_generate.sh] tar: Unexpected EOF in archive
      cmderr	[automation_generate.sh] tar: Unexpected EOF in archive
      cmderr	[automation_generate.sh] tar: Error is not recoverable: exiting now
      cmderr	[automation_generate.sh]   Error: failed to download archive for 16.15.0
      cmdout	[automation_generate.sh] [Autorest]/mnt/vss/_work/1/s/azure-sdk-for-python_tmp/venv-sdk/auto_temp.json does not exist!!!Error happened during codegen
      error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-python]: sh scripts/automation_generate.sh
      warn	Skip package processing as generation is failed
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 0724e72. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh]
      cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh] npm WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] npm WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    • ️✔️cost-management [View full logs]  [Release Schema Changes]
    ️❌ azure-powershell failed [Detail]
    • Pipeline Framework Failed [Logs]Release - Generate from 0724e72. SDK Automation 14.0.0
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
      command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
      SSL error: syscall failure: Broken pipe
      Error: SSL error: syscall failure: Broken pipe
    • Az.cost-management.DefaultTag [View full logs
      error	Fatal error: SSL error: syscall failure: Broken pipe
      error	The following packages are still pending:
      error		Az.cost-management.DefaultTag
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented May 17, 2023

    Generated ApiView

    Language Package Name ApiView Link
    Go sdk/resourcemanager/costmanagement/armcostmanagement https://apiview.dev/Assemblies/Review/7997cf1c4a3a4420a0a2ede46a4da860

    @openapi-workflow-bot
    Copy link

    Hi @MattEberhart-MSFTE, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
    Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
    If you want to know the production traffic statistic, please see ARM Traffic statistic.
    If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.
    Note: To avoid breaking change, you can refer to Shift Left Solution for detecting breaking change in early phase at your service code repository.

    @ankhyk ankhyk added the Approved-OkToMerge <valid label in PR review process>add this label when assignee approve to merge the updates label May 23, 2023
    @ankhyk ankhyk removed the Approved-OkToMerge <valid label in PR review process>add this label when assignee approve to merge the updates label May 23, 2023
    @ankhyk
    Copy link
    Contributor

    ankhyk commented May 23, 2023

    @raych1 @msyyc please help take a look at GO and Python SDK breaking change

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 Approved-OkToMerge <valid label in PR review process>add this label when assignee approve to merge the updates Approved-SdkBreakingChange-Go Approve the breaking change tracking for azure-sdk-for-go Approved-SdkBreakingChange-Python BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required CI-BreakingChange-Go resource-manager
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    7 participants