Added Azure API Center resource manager. #24130
Conversation
azaslonov
requested review from
msyyc,
Wzb123456789,
ArcturusZhang,
jsntcy and
qiaozha
as code owners
|
Hi, @azaslonov Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
Swagger Validation Report
|
| compared tags (via openapi-validator v2.1.2) | new version | base version |
|---|---|---|
| package-2023-07-01-preview | package-2023-07-01-preview(aecc5d4) | default(main) |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
️❌~[Staging] ServiceAPIReadinessTest: 0 Errors, 0 Warnings failed [Detail]
Tag package-2023-07-01-preview; Prod region: Not deployed; Canary region: Not deployed
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️CadlAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️CadlValidation succeeded [Detail] [Expand]
Validation passes for CadlValidation.
️️✔️TypeSpec Validation succeeded [Detail] [Expand]
Validation passes for TypeSpec Validation.
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
Swagger Generation Artifacts
|
openapi-workflow-bot
bot
added
ARMReview
WaitForARMFeedback
Generated ApiView
|
|
Hi, @azaslonov your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board([email protected]). |
AzureRestAPISpecReview
added
CI-MissingBaseCommit
new-api-version
new-rp-namespace
ReadyForApiTest
|
Hi, @azaslonov, For review efficiency consideration, when creating a new api version, it is required to place API specs of the base version in the first commit, and push new version updates into successive commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki. Or you could onboard API spec pipeline |
|
Hi, @azaslonov, our workflow has detected that there is no management SDK ever released for your RP, to further process SDK onboard for your RP, you should have the SDK client library name of your RP reviewed and approved. Impact: SDK release owner will take the approved management client library name to release SDK. No client library name approval will leads to SDK release delayed. |
|
SignedOff based on Private Repo PR ARM SignOff: https://github.com/Azure/azure-rest-api-specs-pr/pull/12365. |
visingla-ms
added
the
ARMSignedOff
openapi-workflow-bot
bot
removed
the
WaitForARMFeedback
|
@azaslonov do you need to merge this pr now ? |
If possible, yes please. I see this check fails by some reason despite we have Canary deployment: I suspect it's because of feature flag: 
|
@Wzb123456789, could you please help with this: |
Here's the link: https://github.com/Azure/azure-sdk-pr/issues/1183 |
|
/azp run |
@azaslonov here is the result #24130 (comment) |
@JackTn are we good to merge? |
@msyyc take a look on this pr and help to merge it, Thanks |
JackTn
added
the
Approved-OkToMerge
azaslonov
deleted the
alzaslon-apicenter-Microsoft.ApiCenter-2023-07-01-preview
branch
* Added Azure API Center resource manager. * Added managed identity properties. Changed top-level resource type. --------- Co-authored-by: Alexander Zaslonov <[email protected]>
| } | ||
| }, | ||
| "parameters": { | ||
| "ServiceName": { |
There was a problem hiding this comment.
@azaslonov The serviceName parameter defined here would result in a client-level parameter in SDK side(JS, Python, Go etc), could you confirm that this is a client-level parameter or this is a method-level parameter shared by most operations?
If this is the latter one, please add the x-ms-parameter-location as method.
"x-ms-parameter-location": "method" <<<<<<<<<<<<<<<<<<<<<<<<<<<This issue is found in JS SDK release request.
ARM API Information (Control Plane)
Changelog
Add a changelog entry for this PR by answering the following questions:
Moving it from RPSaaSMaster branch of private repo. See corresponding signed-off pull request:
https://github.com/Azure/azure-rest-api-specs-pr/pull/12365
Contribution checklist (MS Employees Only):
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
-[x] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki. Note that this doesn't apply if you are trying to merge a PR that was previously in the private repository.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.