[Fleet] API 2023-06-15-preview #25027

zman-ms · 2023-07-28T00:15:34Z

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

Purpose of this PR

What's the purpose of this PR? Check all that apply. This is mandatory!

New API version. (Such PR should have been generated with OpenAPI Hub, per this wiki doc.)
Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
Update existing version to fix swagger quality issues in S360.
Other, please clarify:
- edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

I have reviewed the general guidance on the spec PR review process: https://aka.ms/specprreview.
I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data-plane related specifications.
I commit to follow the Breaking Change Policy.
I have reviewed following Resource Provider guidelines, including
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can request review from an ARM API Review board.

ARM API changes review

If you want for the ARM team to review this PR, you must add the ARMReview label.
The automation may automatically add the ARMReview label, if appropriate.
If this happens, proceed according to guidance given in GitHub comments also added by the automation.

Breaking change review

If you have any breaking changes as defined in the Breaking Change Policy,
follow the process outlined in the High-level Breaking Change Process doc.

Getting help

For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
and https://aka.ms/ci-fix.
For additional help, see https://aka.ms/azsdk/support/spectools.

…preview/2023-03-15-preview to version 2023-06-15-preview

* Adds base for updating Microsoft.ContainerService/fleet from version preview/2023-03-15-preview to version 2023-06-15-preview * Updates readme * Updates API version in new specs and examples * sync with ADO repo * exclude unneeded file changes * revert tsp config * revert helpers.tsp * remove package files * remove package files * add known word containerd * format * remove .npmrc * revert custom word * revert package-lock.json * re-generate json * add example * add example * fix read-only fields * fix read-only fields * re-generate json with latest compiler * add custom word back * re-generate json * restore config * add examples * add examples * add examples * add examples * add examples * add examples * prettier * fix examples * git ignore * review commoents * fix examples * make node image selection optional * fix warnings * fix warnings * fix warnings * fix docs * revert package changes * compile

openapi-pipeline-app · 2023-07-28T00:15:39Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

compared swaggers (via Oad v0.10.4)]	new version	base version
fleets.json	2022-09-02-preview(44f2bc2)	2022-09-02-preview(main)
fleets.json	2023-03-15-preview(44f2bc2)	2023-03-15-preview(main)

️⚠️Breaking Change(Cross-Version): 4 Warnings warning [Detail]

compared swaggers (via Oad v0.10.4)]	new version	base version
fleets.json	2023-06-15-preview(44f2bc2)	2023-03-15-preview(main)

The following breaking changes are detected by comparison with the latest preview version:

Rule	Message
⚠️ 1011 - AddingResponseCode	The new version adds a response code '202'. New: fleet/preview/2023-06-15-preview/fleets.json#L361:11
⚠️ 1011 - AddingResponseCode	The new version adds a response code '202'. New: fleet/preview/2023-06-15-preview/fleets.json#L785:11
⚠️ 1044 - XmsLongRunningOperationChanged	The new version has a different 'x-ms-longrunning-operation' value than the previous one. New: fleet/preview/2023-06-15-preview/fleets.json#L310:7 Old: fleet/preview/2023-03-15-preview/fleets.json#L310:7
⚠️ 1044 - XmsLongRunningOperationChanged	The new version has a different 'x-ms-longrunning-operation' value than the previous one. New: fleet/preview/2023-06-15-preview/fleets.json#L724:7 Old: fleet/preview/2023-03-15-preview/fleets.json#L706:7

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️️✔️LintDiff succeeded [Detail] [Expand]

Validation passes for LintDiff.

compared tags (via openapi-validator v2.1.4)	new version	base version
package-2023-03-preview	package-2023-03-preview(44f2bc2)	package-2023-03-preview(main)
package-2022-09-preview	package-2022-09-preview(44f2bc2)	package-2022-09-preview(main)
package-2023-06-preview	package-2023-06-preview(44f2bc2)	default(main)

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️SwaggerAPIView succeeded [Detail] [Expand]

️️✔️TypeSpecAPIView succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️PoliCheck succeeded [Detail] [Expand]

Validation passed for PoliCheck.

️️✔️PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

️️✔️PR Summary succeeded [Detail] [Expand]

Validation passes for Summary.

️️✔️Automated merging requirements met succeeded [Detail] [Expand]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-07-28T00:15:40Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️❌SDK Breaking Change Tracking failed [Detail]

Breaking Changes Tracking

❌azure-sdk-for-go - sdk/resourcemanager/containerservicefleet/armcontainerservicefleet - Approved - 0.2.0

+	Operation `*FleetMembersClient.Update` has been changed to LRO, use `*FleetMembersClient.BeginUpdate` instead.
+	Operation `*FleetsClient.Update` has been changed to LRO, use `*FleetsClient.BeginUpdate` instead.

❌azure-sdk-for-python-track2 - track2_azure-mgmt-containerservicefleet - Approved - 1.0.0b1

+	Renamed operation FleetMembersOperations.update to FleetMembersOperations.begin_update
+	Renamed operation FleetsOperations.update to FleetsOperations.begin_update

❌azure-sdk-for-js - @azure/arm-containerservicefleet - Approved - 1.0.0-beta.2

+	Removed operation FleetMembers.update
+	Removed operation Fleets.update

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs]Release - Generate from 802fc0a. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
warn		specification/containerservice/Fleet.Management/tspconfig.yaml skipped due to azure-sdk-for-python-track2 not found in tspconfig.yaml
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh]
cmderr	[automation_generate.sh] npm notice New minor version of npm available! 9.6.7 -> 9.8.1
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.8.1>
cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
cmderr	[automation_generate.sh] npm notice

️✔️track2_azure-mgmt-containerservicefleet [View full logs] [Release SDK Changes] Breaking Change Detected

info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog]   - Model Fleet has a new parameter identity
info	[Changelog]   - Model FleetHubProfile has a new parameter agent_profile
info	[Changelog]   - Model FleetHubProfile has a new parameter api_server_access_profile
info	[Changelog]   - Model FleetPatch has a new parameter identity
info	[Changelog]   - Model ManagedClusterUpdate has a new parameter node_image_selection
info	[Changelog]   - Model MemberUpdateStatus has a new parameter message
info	[Changelog]   - Model UpdateRunStatus has a new parameter node_image_selection
info	[Changelog]
info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog]   - Renamed operation FleetMembersOperations.update to FleetMembersOperations.begin_update
info	[Changelog]   - Renamed operation FleetsOperations.update to FleetsOperations.begin_update

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs]Release - Generate from 802fc0a. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.2.1
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.2.1
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json

️✔️azure-resourcemanager-containerservicefleet [View full logs] [Release SDK Changes]

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 802fc0a. SDK Automation 14.0.0

command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
warn		specification/containerservice/Fleet.Management/tspconfig.yaml skipped due to azure-sdk-for-go not found in tspconfig.yaml
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️sdk/resourcemanager/containerservicefleet/armcontainerservicefleet [View full logs] [Release SDK Changes] Breaking Change Detected

info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] - Operation `*FleetMembersClient.Update` has been changed to LRO, use `*FleetMembersClient.BeginUpdate` instead.
info	[Changelog] - Operation `*FleetsClient.Update` has been changed to LRO, use `*FleetsClient.BeginUpdate` instead.
info	[Changelog]
info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New value `UpdateStateSkipped` added to enum type `UpdateState`
info	[Changelog] - New enum type `ManagedServiceIdentityType` with values `ManagedServiceIdentityTypeNone`, `ManagedServiceIdentityTypeSystemAssigned`, `ManagedServiceIdentityTypeSystemAssignedUserAssigned`, `ManagedServiceIdentityTypeUserAssigned`
info	[Changelog] - New enum type `NodeImageSelectionType` with values `NodeImageSelectionTypeConsistent`, `NodeImageSelectionTypeLatest`
info	[Changelog] - New struct `APIServerAccessProfile`
info	[Changelog] - New struct `AgentProfile`
info	[Changelog] - New struct `ManagedServiceIdentity`
info	[Changelog] - New struct `NodeImageSelection`
info	[Changelog] - New struct `NodeImageSelectionStatus`
info	[Changelog] - New struct `NodeImageVersion`
info	[Changelog] - New struct `UserAssignedIdentity`
info	[Changelog] - New field `Identity` in struct `Fleet`
info	[Changelog] - New field `APIServerAccessProfile`, `AgentProfile` in struct `FleetHubProfile`
info	[Changelog] - New field `Identity` in struct `FleetPatch`
info	[Changelog] - New field `NodeImageSelection` in struct `ManagedClusterUpdate`
info	[Changelog] - New field `Message` in struct `MemberUpdateStatus`
info	[Changelog] - New field `NodeImageSelection` in struct `UpdateRunStatus`
info	[Changelog]
info	[Changelog] Total 2 breaking change(s), 29 additive change(s).

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 802fc0a. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json

️✔️@azure/arm-containerservicefleet [View full logs] [Release SDK Changes] Breaking Change Detected

azure-arm-containerservicefleet-1.0.0-beta.2.tgz

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Added operation FleetMembers.beginUpdate
info	[Changelog]   - Added operation FleetMembers.beginUpdateAndWait
info	[Changelog]   - Added operation Fleets.beginUpdate
info	[Changelog]   - Added operation Fleets.beginUpdateAndWait
info	[Changelog]   - Added Interface AgentProfile
info	[Changelog]   - Added Interface APIServerAccessProfile
info	[Changelog]   - Added Interface FleetMembersUpdateHeaders
info	[Changelog]   - Added Interface FleetsUpdateHeaders
info	[Changelog]   - Added Interface ManagedServiceIdentity
info	[Changelog]   - Added Interface NodeImageSelection
info	[Changelog]   - Added Interface NodeImageSelectionStatus
info	[Changelog]   - Added Interface NodeImageVersion
info	[Changelog]   - Added Interface UserAssignedIdentity
info	[Changelog]   - Added Type Alias ManagedServiceIdentityType
info	[Changelog]   - Added Type Alias NodeImageSelectionType
info	[Changelog]   - Interface Fleet has a new optional parameter identity
info	[Changelog]   - Interface FleetHubProfile has a new optional parameter agentProfile
info	[Changelog]   - Interface FleetHubProfile has a new optional parameter apiServerAccessProfile
info	[Changelog]   - Interface FleetMembersUpdateOptionalParams has a new optional parameter resumeFrom
info	[Changelog]   - Interface FleetMembersUpdateOptionalParams has a new optional parameter updateIntervalInMs
info	[Changelog]   - Interface FleetPatch has a new optional parameter identity
info	[Changelog]   - Interface FleetsUpdateOptionalParams has a new optional parameter resumeFrom
info	[Changelog]   - Interface FleetsUpdateOptionalParams has a new optional parameter updateIntervalInMs
info	[Changelog]   - Interface ManagedClusterUpdate has a new optional parameter nodeImageSelection
info	[Changelog]   - Interface MemberUpdateStatus has a new optional parameter message
info	[Changelog]   - Interface UpdateRunStatus has a new optional parameter nodeImageSelection
info	[Changelog]   - Added Enum KnownManagedServiceIdentityType
info	[Changelog]   - Added Enum KnownNodeImageSelectionType
info	[Changelog]   - Enum KnownUpdateState has a new value Skipped
info	[Changelog]
info	[Changelog] **Breaking Changes**
info	[Changelog]
info	[Changelog]   - Removed operation FleetMembers.update
info	[Changelog]   - Removed operation Fleets.update

️❌ azure-sdk-for-net-track2 failed [Detail]

❌Failed [Logs]Release - Generate from 802fc0a. SDK Automation 14.0.0

command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
warn		specification/containerservice/Fleet.Management/tspconfig.yaml skipped due to azure-sdk-for-net-track2 not found in tspconfig.yaml
command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:712
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 712 | �[0m         �[36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s�[0m …
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mFailed to generate sdk. exit code: False
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGet-ChildItem: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:805
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 805 | �[0m … rtifacts += �[36;1mGet-ChildItem $artifactsPath -Filter *.nupkg -exclude *.s�[0m …
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mCannot find path
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m'/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/packages/Debug/' because
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1mit does not exist.
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:712
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 712 | �[0m         �[36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s�[0m …
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mFailed to generate sdk artifact
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m

❌Azure.ResourceManager.ContainerService [View full logs] [Release SDK Changes]
```
info	[Changelog]
```

️⚠️ azure-resource-manager-schemas warning [Detail]

⚠️Warning [Logs]Release - Generate from 802fc0a. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
warn	No file changes detected after generation

️✔️containerservice [View full logs]

️❌ azure-powershell failed [Detail]

❌Pipeline Framework Failed [Logs]Release - Generate from 802fc0a. SDK Automation 14.0.0

command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
warn		specification/containerservice/Fleet.Management/tspconfig.yaml skipped due to azure-powershell not found in tspconfig.yaml
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
SSL error: syscall failure: Broken pipe
Error: SSL error: syscall failure: Broken pipe

️✔️Az.containerservice.DefaultTag [View full logs]

Az.ContainerServiceFleet.0.1.0.nupkg

error	Fatal error: SSL error: syscall failure: Broken pipe
error	The following packages are still pending:
error		Az.containerservice.DefaultTag

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-07-28T00:15:40Z

Generated ApiView

Language	Package Name	ApiView Link
Go	sdk/resourcemanager/containerservicefleet/armcontainerservicefleet	https://apiview.dev/Assemblies/Review/7167c9898f7748e8a5843a14dbabbad7
Java	azure-resourcemanager-containerservicefleet	https://apiview.dev/Assemblies/Review/c7fc276d26044faa90f7141ebffce2de
JavaScript	@azure/arm-containerservicefleet	https://apiview.dev/Assemblies/Review/2757e67a774a4d4a831e85fc666a8239

openapi-workflow-bot · 2023-07-28T00:15:41Z

Hi @zman-ms, this service has enabled Service API Toolset. All spec updates MUST be initiated from service ADO project repo, so that to guarantee it to be the source of truth., please review this pull request if it's intentional or reject it if it's not expected. Normally, all the specification or example changes should start with PR created in ADO.

You can refer to Service API Toolset Introduction for details.

Please contact service focal contacts or Service API Toolset Support Channel if need further help.

openapi-workflow-bot · 2023-07-28T00:15:43Z

Hi, @zman-ms! Thank you for your pull request. To help get your PR merged:

Ensure you reviewed the checklists in the PR description.

Know that PR assignee is the person auto-assigned and responsible for your current PR review and approval.

For convenient view of the API changes made by this PR, refer to the URLs provided in the table in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

openapi-workflow-bot · 2023-07-28T00:22:25Z

Hi @zman-ms! The automation detected breaking changes in this pull request. As a result, it added the BreakingChangeReviewRequired label.

You cannot proceed with merging this PR until you complete one of the following action items:

ACTION ITEM ALTERNATIVE A: Fix the breaking change.
Please consult the documentation provided in the relevant validation failures.

ACTION ITEM ALTERNATIVE B: Request approval.
Alternatively, if you cannot fix the breaking changes, then you can request an approval for them. Please follow the process described in the High-level Breaking Change Process doc.

ACTION ITEM ALTERNATIVE C: Report false positive.
If you think there are no breaking changes, i.e. the validation should pass yet it fails, then proceed as explained in ACTION ITEM ALTERNATIVE B.
This applies even if the breaking change tool fails with internal runtime error. In such case a manual breaking change review is necessary.

openapi-workflow-bot · 2023-07-28T00:22:25Z

Please address or respond to feedback from the ARM API reviewer.
When you are ready to continue the ARM API review, please remove the ARMChangesRequested label.
This will notify the reviewer to have another look.
If the feedback provided needs further discussion, please use this Teams channel to post your questions - aka.ms/azsdk/support/specreview-channel.
Please include [ARM Query] in the title of your question to indicate that it is ARM-related.

...ice/resource-manager/Microsoft.ContainerService/fleet/preview/2023-06-15-preview/fleets.json

...ice/resource-manager/Microsoft.ContainerService/fleet/preview/2023-03-15-preview/fleets.json

serbrech · 2023-08-04T23:08:06Z

specification/containerservice/Fleet.Management/updaterun.tsp

@@ -255,12 +319,6 @@ interface UpdateRuns {
      IfNoneMatchParameters<UpdateRun>
  >;

-  @extension(


thought typespec had fixed this bug, and we could remove our override?

openapi-pipeline-app · 2023-08-25T01:54:23Z

Next Steps to Merge

⚠️ This is an experimental comment. It may not always be up-to-date. ⚠️

✔️ All automated merging requirements have been met! Refer to step 4 in the PR workflow diagram (even if your PR is for data plane, not ARM).

openapi-pipeline-app · 2023-08-25T06:54:34Z

Swagger pipeline restarted successfully, please wait for status update in this comment.

zman-ms added 4 commits July 27, 2023 13:06

Adds base for updating Microsoft.ContainerService/fleet from version …

d6f2d79

…preview/2023-03-15-preview to version 2023-06-15-preview

Updates readme

dc22537

Updates API version in new specs and examples

48ca510

zman-ms requested review from palma21, weinong, alvinli222, matthchr and circy9 as code owners July 28, 2023 00:15

openapi-assignment-bot bot assigned rkmanda Jul 28, 2023

openapi-workflow-bot bot added ShiftLeftViolation DoNotMerge <valid label in PR review process> use to hold merge after approval labels Jul 28, 2023

zman-ms changed the title ~~Dev aks fleet 2023 06 15 preview~~ [Fleet] API 2023 06 15 preview Jul 28, 2023

zman-ms changed the title ~~[Fleet] API 2023 06 15 preview~~ [Fleet] API 2023-06-15-preview Jul 28, 2023

azure-sdk mentioned this pull request Jul 28, 2023

[AutoPR sdk/resourcemanager/containerservicefleet/armcontainerservicefleet] [Fleet] API 2023-06-15-preview azure-sdk/azure-sdk-for-go#6583

Closed

openapi-pipeline-app bot added the CI-BreakingChange-Go label Jul 28, 2023

zizw123 reviewed Aug 4, 2023

View reviewed changes

...ice/resource-manager/Microsoft.ContainerService/fleet/preview/2023-06-15-preview/fleets.json Show resolved Hide resolved

zizw123 reviewed Aug 4, 2023

View reviewed changes

...ice/resource-manager/Microsoft.ContainerService/fleet/preview/2023-03-15-preview/fleets.json Outdated Show resolved Hide resolved

zizw123 added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Aug 4, 2023

openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Aug 4, 2023

serbrech added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required and removed ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review labels Aug 4, 2023

serbrech reviewed Aug 4, 2023

View reviewed changes

revert extension removal (#25189)

9f1d104

openapi-pipeline-app bot added the ShiftLeftViolation label Aug 4, 2023

ms-zhenhua added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Aug 7, 2023

serbrech added DoNotMerge <valid label in PR review process> use to hold merge after approval and removed DoNotMerge <valid label in PR review process> use to hold merge after approval labels Aug 7, 2023

generate with type spec v0.47.0 (#25484)

44f2bc2

serbrech removed the DoNotMerge <valid label in PR review process> use to hold merge after approval label Aug 25, 2023

openapi-pipeline-app bot added the DoNotMerge <valid label in PR review process> use to hold merge after approval label Aug 25, 2023

serbrech removed the DoNotMerge <valid label in PR review process> use to hold merge after approval label Aug 25, 2023

qiaozha added the MergeRequested label Aug 25, 2023

ms-henglu approved these changes Aug 25, 2023

View reviewed changes

ms-henglu merged commit 802fc0a into main Aug 25, 2023

ms-henglu deleted the dev-aks-fleet-2023-06-15-preview branch August 25, 2023 06:54

openapi-pipeline-app bot added the DoNotMerge <valid label in PR review process> use to hold merge after approval label Aug 25, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Fleet] API 2023-06-15-preview #25027

[Fleet] API 2023-06-15-preview #25027

zman-ms commented Jul 28, 2023

openapi-pipeline-app bot commented Jul 28, 2023 •

edited

Loading

openapi-pipeline-app bot commented Jul 28, 2023 •

edited

Loading

Breaking Changes Tracking

openapi-pipeline-app bot commented Jul 28, 2023 •

edited

Loading

openapi-workflow-bot bot commented Jul 28, 2023

openapi-workflow-bot bot commented Jul 28, 2023

openapi-workflow-bot bot commented Jul 28, 2023

openapi-workflow-bot bot commented Jul 28, 2023

serbrech Aug 4, 2023

openapi-pipeline-app bot commented Aug 25, 2023 •

edited

Loading

openapi-pipeline-app bot commented Aug 25, 2023

[Fleet] API 2023-06-15-preview #25027

[Fleet] API 2023-06-15-preview #25027

Conversation

zman-ms commented Jul 28, 2023

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Purpose of this PR

Due diligence checklist

ARM API changes review

Breaking change review

Getting help

openapi-pipeline-app bot commented Jul 28, 2023 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Jul 28, 2023 • edited Loading

Swagger Generation Artifacts

Breaking Changes Tracking

openapi-pipeline-app bot commented Jul 28, 2023 • edited Loading

Generated ApiView

openapi-workflow-bot bot commented Jul 28, 2023

openapi-workflow-bot bot commented Jul 28, 2023

openapi-workflow-bot bot commented Jul 28, 2023

openapi-workflow-bot bot commented Jul 28, 2023

serbrech Aug 4, 2023

Choose a reason for hiding this comment

openapi-pipeline-app bot commented Aug 25, 2023 • edited Loading

Next Steps to Merge

openapi-pipeline-app bot commented Aug 25, 2023

openapi-pipeline-app bot commented Jul 28, 2023 •

edited

Loading

openapi-pipeline-app bot commented Jul 28, 2023 •

edited

Loading

openapi-pipeline-app bot commented Jul 28, 2023 •

edited

Loading

openapi-pipeline-app bot commented Aug 25, 2023 •

edited

Loading