Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ServiceBus]: Api version 2023-01-01-preview to support data disaster recovery #25268

Closed
wants to merge 10 commits into from

Conversation

damodaravadhani
Copy link
Member

@damodaravadhani damodaravadhani commented Aug 10, 2023

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

diagram

[1] public repo review queue, private repo review queue
The PRs are processed by time opened, ascending. Your PR may show up on 2nd or later page.
If you addressed Step 1 from the diagram and your PR is not showing up in the queue, ensure the label ARMChangesRequested
is removed from your PR. This should cause the label WaitForARMFeedback to be added.
[2] https://aka.ms/azsdk/support/specreview-channel
[3] List of SDK breaking changes approvers in pinned Teams announcement
[4] public repo merge queue, private repo merge queue

If you need further help with anything, see Getting help section below.

Purpose of this PR

What's the purpose of this PR? Check all that apply. This is mandatory!

  • New API version. (Such PR should have been generated with OpenAPI Hub, per this wiki doc.)
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix swagger quality issues in S360.
  • Other, please clarify:
    • edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

Breaking changes review (Step 1)

  • If the automation determines you have breaking changes, i.e. Step 1 from the diagram applies to you,
    you must follow the breaking changes process.
    IMPORTANT This applies even if:
    • The tool fails while it shouldn't, e.g. due to runtime exception, or incorrect detection of breaking changes.
    • You believe there is no need for you to request breaking change approval, for any reason.
      Such claims must be reviewed, and the process is the same.

ARM API changes review (Step 2)

  • If this PR is in purview of ARM review then automation will add the ARMReview label.
  • If you want to force ARM review, add the label yourself.
  • Proceed according to the diagram at the top of this comment.

Getting help

@openapi-workflow-bot
Copy link

Hi, @damodaravadhani! Thank you for your pull request. To help get your PR merged:

  • Ensure you reviewed the checklists in the PR description.
  • Know that PR assignee is the person auto-assigned and responsible for your current PR review and approval.
  • For convenient view of the API changes made by this PR, refer to the URLs provided in the table in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.
  • @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Aug 10, 2023

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.
    ️❌Breaking Change(Cross-Version): 2 Errors, 0 Warnings failed [Detail]
    compared swaggers (via Oad v0.10.4)] new version base version
    AuthorizationRules.json 2023-01-01-preview(dc1e97c) 2021-11-01(main)
    AuthorizationRules.json 2023-01-01-preview(dc1e97c) 2022-10-01-preview(main)
    CheckNameAvailability.json 2023-01-01-preview(dc1e97c) 2021-11-01(main)
    CheckNameAvailability.json 2023-01-01-preview(dc1e97c) 2022-10-01-preview(main)
    DisasterRecoveryConfig.json 2023-01-01-preview(dc1e97c) 2021-11-01(main)
    DisasterRecoveryConfig.json 2023-01-01-preview(dc1e97c) 2022-10-01-preview(main)
    Queue.json 2023-01-01-preview(dc1e97c) 2021-11-01(main)
    Queue.json 2023-01-01-preview(dc1e97c) 2022-10-01-preview(main)
    Rules.json 2023-01-01-preview(dc1e97c) 2021-11-01(main)
    Rules.json 2023-01-01-preview(dc1e97c) 2022-10-01-preview(main)
    migrationconfigs.json 2023-01-01-preview(dc1e97c) 2021-11-01(main)
    migrationconfigs.json 2023-01-01-preview(dc1e97c) 2022-10-01-preview(main)
    networksets.json 2023-01-01-preview(dc1e97c) 2021-11-01(main)
    networksets.json 2023-01-01-preview(dc1e97c) 2022-10-01-preview(main)
    operations.json 2023-01-01-preview(dc1e97c) 2021-11-01(main)
    operations.json 2023-01-01-preview(dc1e97c) 2022-10-01-preview(main)
    subscriptions.json 2023-01-01-preview(dc1e97c) 2021-11-01(main)
    subscriptions.json 2023-01-01-preview(dc1e97c) 2022-10-01-preview(main)
    topics.json 2023-01-01-preview(dc1e97c) 2021-11-01(main)
    topics.json 2023-01-01-preview(dc1e97c) 2022-10-01-preview(main)

    The following breaking changes are detected by comparison with the latest stable version:

    Rule Message
    Runtime Exception "new":"https://github.com/Azure/azure-rest-api-specs/blob/dc1e97c2937cac048f46fbb3e0477ae35a3a7e97/specification/servicebus/resource-manager/Microsoft.ServiceBus/preview/2023-01-01-preview/namespace-preview.json",
    "old":"https://github.com/Azure/azure-rest-api-specs/blob/main/specification/servicebus/resource-manager/Microsoft.ServiceBus/stable/2021-11-01/namespace-preview.json",
    "details":"Breaking change detector (OAD) invoked AutoRest. AutoRest threw a runtime error. First 6 lines of stack trace follow,
    indexed. First line should contain AutoRest command line invocation details. Second line should contain the main message reported by AutoRest.
    ====================
    1: Command failed: node "/mnt/vss/_work/_tasks/AzureApiValidation_5654d05d-82c1-48da-ad8f-161b817f6d41/0.0.72/common/temp/node_modules/.pnpm/@Azure[email protected]/node_modules/autorest/dist/app.js" --v2 --input-file=specification/servicebus/resource-manager/Microsoft.ServiceBus/preview/2023-01-01-preview/namespace-preview.json --output-artifact=swagger-document.json --output-artifact=swagger-document.map --output-file=new --output-folder=/tmp
    --------------------
    2: ERROR: Schema violation: Data does not match any schemas from 'oneOf'
    --------------------
    3: - file:///mnt/vss/_work/1/azure-rest-api-specs/specification/servicebus/resource-manager/Microsoft.ServiceBus/preview/2023-01-01-preview/namespace-preview.json:347:10 ($.paths["/subscriptions/subscriptionId/resourceGroups/resourceGroupName/providers/Microsoft.ServiceBus/namespaces/namespaceName/failover"].post["x-ms-examples"].NameSpaceFailover)
    --------------------
    4: FATAL: swagger-document/individual/schema-validator - FAILED
    --------------------
    5: FATAL: Error: [OperationAbortedException] Error occurred. Exiting.
    --------------------
    6: Process() cancelled due to exception : [OperationAbortedException] Error occurred. Exiting.
    --------------------"


    The following breaking changes are detected by comparison with the latest preview version:

    Rule Message
    Runtime Exception "new":"https://github.com/Azure/azure-rest-api-specs/blob/dc1e97c2937cac048f46fbb3e0477ae35a3a7e97/specification/servicebus/resource-manager/Microsoft.ServiceBus/preview/2023-01-01-preview/namespace-preview.json",
    "old":"https://github.com/Azure/azure-rest-api-specs/blob/main/specification/servicebus/resource-manager/Microsoft.ServiceBus/preview/2022-10-01-preview/namespace-preview.json",
    "details":"Breaking change detector (OAD) invoked AutoRest. AutoRest threw a runtime error. First 6 lines of stack trace follow,
    indexed. First line should contain AutoRest command line invocation details. Second line should contain the main message reported by AutoRest.
    ====================
    1: Command failed: node "/mnt/vss/_work/_tasks/AzureApiValidation_5654d05d-82c1-48da-ad8f-161b817f6d41/0.0.72/common/temp/node_modules/.pnpm/@Azure[email protected]/node_modules/autorest/dist/app.js" --v2 --input-file=specification/servicebus/resource-manager/Microsoft.ServiceBus/preview/2023-01-01-preview/namespace-preview.json --output-artifact=swagger-document.json --output-artifact=swagger-document.map --output-file=new --output-folder=/tmp
    --------------------
    2: ERROR: Schema violation: Data does not match any schemas from 'oneOf'
    --------------------
    3: - file:///mnt/vss/_work/1/azure-rest-api-specs/specification/servicebus/resource-manager/Microsoft.ServiceBus/preview/2023-01-01-preview/namespace-preview.json:347:10 ($.paths["/subscriptions/subscriptionId/resourceGroups/resourceGroupName/providers/Microsoft.ServiceBus/namespaces/namespaceName/failover"].post["x-ms-examples"].NameSpaceFailover)
    --------------------
    4: FATAL: swagger-document/individual/schema-validator - FAILED
    --------------------
    5: FATAL: Error: [OperationAbortedException] Error occurred. Exiting.
    --------------------
    6: Process() cancelled due to exception : [OperationAbortedException] Error occurred. Exiting.
    --------------------"
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️️✔️LintDiff succeeded [Detail] [Expand]
    Validation passes for LintDiff.
    compared tags (via openapi-validator v2.1.6) new version base version
    default default(dc1e97c) default(main)
    ️❌Avocado: 92 Errors, 0 Warnings failed [Detail]

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    UNREFERENCED_JSON_FILE The swagger JSON file is not referenced from the readme file.
    readme: specification/servicebus/resource-manager/readme.md
    json: Microsoft.ServiceBus/preview/2023-01-01-preview/AuthorizationRules.json
    UNREFERENCED_JSON_FILE The swagger JSON file is not referenced from the readme file.
    readme: specification/servicebus/resource-manager/readme.md
    json: Microsoft.ServiceBus/preview/2023-01-01-preview/CheckNameAvailability.json
    UNREFERENCED_JSON_FILE The swagger JSON file is not referenced from the readme file.
    readme: specification/servicebus/resource-manager/readme.md
    json: Microsoft.ServiceBus/preview/2023-01-01-preview/DisasterRecoveryConfig.json
    UNREFERENCED_JSON_FILE The swagger JSON file is not referenced from the readme file.
    readme: specification/servicebus/resource-manager/readme.md
    json: Microsoft.ServiceBus/preview/2023-01-01-preview/Queue.json
    UNREFERENCED_JSON_FILE The swagger JSON file is not referenced from the readme file.
    readme: specification/servicebus/resource-manager/readme.md
    json: Microsoft.ServiceBus/preview/2023-01-01-preview/Rules.json
    UNREFERENCED_JSON_FILE The example JSON file is not referenced from the swagger file.
    readme: specification/servicebus/resource-manager/readme.md
    json: 2023-01-01-preview/examples/Migrationconfigurations/SBMigrationconfigurationCompleteMigration.json
    UNREFERENCED_JSON_FILE The example JSON file is not referenced from the swagger file.
    readme: specification/servicebus/resource-manager/readme.md
    json: 2023-01-01-preview/examples/Migrationconfigurations/SBMigrationconfigurationCreateAndStartMigration.json
    UNREFERENCED_JSON_FILE The example JSON file is not referenced from the swagger file.
    readme: specification/servicebus/resource-manager/readme.md
    json: 2023-01-01-preview/examples/Migrationconfigurations/SBMigrationconfigurationDelete.json
    UNREFERENCED_JSON_FILE The example JSON file is not referenced from the swagger file.
    readme: specification/servicebus/resource-manager/readme.md
    json: 2023-01-01-preview/examples/Migrationconfigurations/SBMigrationconfigurationGet.json
    UNREFERENCED_JSON_FILE The example JSON file is not referenced from the swagger file.
    readme: specification/servicebus/resource-manager/readme.md
    json: 2023-01-01-preview/examples/Migrationconfigurations/SBMigrationconfigurationList.json
    UNREFERENCED_JSON_FILE The example JSON file is not referenced from the swagger file.
    readme: specification/servicebus/resource-manager/readme.md
    json: 2023-01-01-preview/examples/Migrationconfigurations/SBMigrationconfigurationRevert.json
    UNREFERENCED_JSON_FILE The example JSON file is not referenced from the swagger file.
    readme: specification/servicebus/resource-manager/readme.md
    json: 2023-01-01-preview/examples/NameSpaces/PrivateEndPointConnectionCreate.json
    UNREFERENCED_JSON_FILE The example JSON file is not referenced from the swagger file.
    readme: specification/servicebus/resource-manager/readme.md
    json: 2023-01-01-preview/examples/NameSpaces/PrivateEndPointConnectionDelete.json
    UNREFERENCED_JSON_FILE The example JSON file is not referenced from the swagger file.
    readme: specification/servicebus/resource-manager/readme.md
    json: 2023-01-01-preview/examples/NameSpaces/PrivateEndPointConnectionGet.json
    UNREFERENCED_JSON_FILE The example JSON file is not referenced from the swagger file.
    readme: specification/servicebus/resource-manager/readme.md
    json: 2023-01-01-preview/examples/NameSpaces/PrivateEndPointConnectionList.json
    UNREFERENCED_JSON_FILE The example JSON file is not referenced from the swagger file.
    readme: specification/servicebus/resource-manager/readme.md
    json: 2023-01-01-preview/examples/NameSpaces/PrivateLinkResourcesGet.json
    UNREFERENCED_JSON_FILE The example JSON file is not referenced from the swagger file.
    readme: specification/servicebus/resource-manager/readme.md
    json: 2023-01-01-preview/examples/NameSpaces/SBNameSpaceAuthorizationRuleCreate.json
    UNREFERENCED_JSON_FILE The example JSON file is not referenced from the swagger file.
    readme: specification/servicebus/resource-manager/readme.md
    json: 2023-01-01-preview/examples/NameSpaces/SBNameSpaceAuthorizationRuleDelete.json
    UNREFERENCED_JSON_FILE The example JSON file is not referenced from the swagger file.
    readme: specification/servicebus/resource-manager/readme.md
    json: 2023-01-01-preview/examples/NameSpaces/SBNameSpaceAuthorizationRuleGet.json
    UNREFERENCED_JSON_FILE The example JSON file is not referenced from the swagger file.
    readme: specification/servicebus/resource-manager/readme.md
    json: 2023-01-01-preview/examples/NameSpaces/SBNameSpaceAuthorizationRuleListAll.json
    UNREFERENCED_JSON_FILE The example JSON file is not referenced from the swagger file.
    readme: specification/servicebus/resource-manager/readme.md
    json: 2023-01-01-preview/examples/NameSpaces/SBNameSpaceAuthorizationRuleListKey.json
    UNREFERENCED_JSON_FILE The example JSON file is not referenced from the swagger file.
    readme: specification/servicebus/resource-manager/readme.md
    json: 2023-01-01-preview/examples/NameSpaces/SBNameSpaceAuthorizationRuleRegenerateKey.json
    UNREFERENCED_JSON_FILE The example JSON file is not referenced from the swagger file.
    readme: specification/servicebus/resource-manager/readme.md
    json: 2023-01-01-preview/examples/NameSpaces/SBNameSpaceCheckNameAvailability.json
    UNREFERENCED_JSON_FILE The example JSON file is not referenced from the swagger file.
    readme: specification/servicebus/resource-manager/readme.md
    json: 2023-01-01-preview/examples/NameSpaces/SBNameSpaceCreate.json
    UNREFERENCED_JSON_FILE The example JSON file is not referenced from the swagger file.
    readme: specification/servicebus/resource-manager/readme.md
    json: 2023-01-01-preview/examples/NameSpaces/SBNameSpaceDelete.json
    UNREFERENCED_JSON_FILE The example JSON file is not referenced from the swagger file.
    readme: specification/servicebus/resource-manager/readme.md
    json: 2023-01-01-preview/examples/NameSpaces/SBNameSpaceFailover.json
    UNREFERENCED_JSON_FILE The example JSON file is not referenced from the swagger file.
    readme: specification/servicebus/resource-manager/readme.md
    json: 2023-01-01-preview/examples/NameSpaces/SBNameSpaceGet.json
    UNREFERENCED_JSON_FILE The example JSON file is not referenced from the swagger file.
    readme: specification/servicebus/resource-manager/readme.md
    json: 2023-01-01-preview/examples/NameSpaces/SBNameSpaceList.json
    UNREFERENCED_JSON_FILE The example JSON file is not referenced from the swagger file.
    readme: specification/servicebus/resource-manager/readme.md
    json: 2023-01-01-preview/examples/NameSpaces/SBNameSpaceListByResourceGroup.json
    UNREFERENCED_JSON_FILE The example JSON file is not referenced from the swagger file.
    readme: specification/servicebus/resource-manager/readme.md
    json: 2023-01-01-preview/examples/NameSpaces/SBNameSpaceUpdate.json
    ️️✔️SwaggerAPIView succeeded [Detail] [Expand]
    ️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️PoliCheck succeeded [Detail] [Expand]
    Validation passed for PoliCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    ️️✔️PR Summary succeeded [Detail] [Expand]
    Validation passes for Summary.
    ️️✔️Automated merging requirements met succeeded [Detail] [Expand]
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Aug 10, 2023

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

    Breaking Changes Tracking




    ️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from 6bde6ac262f8173de69e489b77bf57dbf4375787. SDK Automation 14.0.0
      command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
      command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
    • ️✔️Azure.ResourceManager.ServiceBus [View full logs]  [Preview SDK Changes]
      info	[Changelog]
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs] Generate from 6bde6ac262f8173de69e489b77bf57dbf4375787. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: azure-devtools 1.2.1 does not provide the extra 'ci-tools'
      cmderr	[automation_init.sh] WARNING: azure-devtools 1.2.1 does not provide the extra 'ci-tools'
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    • ️✔️track2_azure-mgmt-servicebus [View full logs]  [Preview SDK Changes]
      info	[Changelog]
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs] Generate from 6bde6ac262f8173de69e489b77bf57dbf4375787. SDK Automation 14.0.0
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
      cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.3.2
      cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
      cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.3.2
      cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
      cmderr	[init.sh] rrent
      cmderr	[init.sh]                                  Dload  Upload   Total   Spent    Left  Speed
      cmderr	[init.sh] 
        0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0- --:--:--  106k
      cmderr	[init.sh]  notice
      cmderr	[init.sh] npm notice New minor version of npm available! 10.2.3 -> 10.3.0
      cmderr	[init.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.3.0>
      cmderr	[init.sh] npm notice Run `npm install -g [email protected]` to update!
      cmderr	[init.sh] npm notice
      cmderr	[init.sh] Downloading https://nodejs.org/dist/v18.15.0/node-v18.15.0-linux-x64.tar.xz...
      cmderr	[init.sh] ######################## 100.0%
      cmderr	[init.sh] Computing checksum with sha256sum
      cmderr	[init.sh] Checksums matched!
      command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
    • ️✔️azure-resourcemanager-servicebus-generated [View full logs]  [Preview SDK Changes]
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from 6bde6ac262f8173de69e489b77bf57dbf4375787. SDK Automation 14.0.0
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️sdk/resourcemanager/servicebus/armservicebus [View full logs]  [Preview SDK Changes]
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from 6bde6ac262f8173de69e489b77bf57dbf4375787. SDK Automation 14.0.0
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
      warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
      command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️@azure/arm-servicebus [View full logs]  [Preview SDK Changes]
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Added Type Alias PublicNetworkAccess
      info	[Changelog]   - Added Type Alias TlsVersion
      info	[Changelog]   - Interface SBNamespace has a new optional parameter minimumTlsVersion
      info	[Changelog]   - Interface SBNamespace has a new optional parameter premiumMessagingPartitions
      info	[Changelog]   - Interface SBNamespace has a new optional parameter publicNetworkAccess
      info	[Changelog]   - Added Enum KnownPublicNetworkAccess
      info	[Changelog]   - Added Enum KnownTlsVersion
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs] Generate from 6bde6ac262f8173de69e489b77bf57dbf4375787. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh]  notice
      cmderr	[initScript.sh] npm notice New minor version of npm available! 10.2.3 -> 10.3.0
      cmderr	[initScript.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.3.0>
      cmderr	[initScript.sh] npm notice Run `npm install -g [email protected]` to update!
      cmderr	[initScript.sh] npm notice
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
      warn	No file changes detected after generation
    • ️✔️servicebus [View full logs
    ️️✔️ azure-powershell succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from 6bde6ac262f8173de69e489b77bf57dbf4375787. SDK Automation 14.0.0
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
      command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
    • ️✔️Az.servicebus.DefaultTag [View full logs]  [Preview SDK Changes]
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Aug 10, 2023

    Generated ApiView

    Language Package Name ApiView Link
    Go sdk/resourcemanager/servicebus/armservicebus https://apiview.dev/Assemblies/Review/002d4025b23b4299a8d5ac660d16826d?revisionId=99b67f533e6042dabd98012e46f83871
    .Net Azure.ResourceManager.ServiceBus There is no API change compared with the previous version
    Java azure-resourcemanager-servicebus-generated https://apiview.dev/Assemblies/Review/a9e035e938664dd3a6d2b828cc5a6f7b?revisionId=6bb111164ece437b9f86f90048275954
    JavaScript @azure/arm-servicebus https://apiview.dev/Assemblies/Review/659c12466b03440b92bbae1ce12714d0?revisionId=f10a5ee79b6142df96feea6323faead0

    @openapi-workflow-bot
    Copy link

    Hi @damodaravadhani! Your PR has some issues. Please fix the CI issues, if present, in following order: Avocado, SemanticValidation, ModelValidation, Breaking Change, LintDiff.

    TaskHow to fixPriority
    AvocadoFix-AvocadoHigh
    Semantic ValidationFix-SemanticValidation-ErrorHigh
    Model ValidationFix-ModelValidation-ErrorHigh
    LintDiffFix-LintDiffHigh

    If you need further help, please reach out on the Teams channel aka.ms/azsdk/support/specreview-channel.

    @openapi-workflow-bot
    Copy link

    Hi @damodaravadhani! For review efficiency consideration, when creating a new API version, it is required to place API specs of the base version in the first commit, and push new version updates into successive commits. You can use OpenAPIHub to initialize the PR for adding a new version.
    For more details refer to the wiki.

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Aug 17, 2023

    Next Steps to Merge

    Next steps that must be taken to merge this PR:
    • ❌ Your PR is in purview of ARM review (label: ARMReview). Please ensure your PR is on the ARM PR review queue - see instructions in steps 1 and 2 in the PR description diagram.
    • ❌ The required check named Breaking Change(Cross-Version) has failed. Refer to the check in the PR's 'Checks' tab for details on how to fix it. In addition, refer to step 1 in the PR workflow diagram (even if your PR is for data plane, not ARM).

    @TimLovellSmith
    Copy link
    Member

    Please fix avocado errors and then remove ARMChangesRequested.

    @TimLovellSmith TimLovellSmith added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Aug 19, 2023
    Copy link
    Contributor

    Hi, @damodaravadhani. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    1 similar comment
    Copy link
    Contributor

    Hi, @damodaravadhani. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    Copy link
    Contributor

    Hi, @damodaravadhani. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    7 similar comments
    Copy link
    Contributor

    Hi, @damodaravadhani. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    Copy link
    Contributor

    Hi, @damodaravadhani. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    Copy link
    Contributor

    Hi, @damodaravadhani. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    Copy link
    Contributor

    Hi, @damodaravadhani. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    Copy link
    Contributor

    Hi, @damodaravadhani. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    Copy link
    Contributor

    Hi, @damodaravadhani. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    Copy link
    Contributor

    Hi, @damodaravadhani. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    @konrad-jamrozik
    Copy link

    /azp run

    Copy link

    Azure Pipelines successfully started running 4 pipeline(s).

    Copy link
    Contributor

    Hi, @damodaravadhani. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    @microsoft-github-policy-service microsoft-github-policy-service bot added the no-recent-activity There has been no recent activity on this issue. label Feb 5, 2024
    Copy link
    Contributor

    Hi, @damodaravadhani. The PR will be closed since the PR has no update for 28 days. If you still need the PR review to proceed, please reopen it and @ mention PR assignee.

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review ARMReview CI-FixRequiredOnFailure CI-MissingBaseCommit new-api-version no-recent-activity There has been no recent activity on this issue. resource-manager
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    7 participants