[Fleet] Move VMSize into AgentProfile #25805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zman-ms
requested review from
palma21,
weinong,
alvinli222,
matthchr and
circy9
as code owners
Next Steps to Merge✔️ All automated merging requirements have been met! Refer to step 4 in the PR workflow diagram (even if your PR is for data plane, not ARM). |
Swagger Validation Report
|
| compared swaggers (via Oad v0.10.4)] | new version | base version |
|---|---|---|
| fleets.json | 2023-08-15-preview(f778e47) | 2023-06-15-preview(main) |
️️✔️LintDiff succeeded [Detail] [Expand]
Validation passes for LintDiff.
| compared tags (via openapi-validator v2.1.4) | new version | base version |
|---|---|---|
| package-preview-2023-08 | package-preview-2023-08(f778e47) | package-preview-2023-08(dev-aks-fleet-2023-08-15-preview) |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Swagger Generation Artifacts
|
Generated ApiView
|
This was referenced Sep 15, 2023
serbrech
approved these changes
Sep 15, 2023
raosuhas
pushed a commit
that referenced
this pull request
Sep 26, 2023
* Adds base for updating Microsoft.ContainerService/fleet from version preview/2023-06-15-preview to version 2023-08-15-preview * Updates readme * Updates API version in new specs and examples * [Fleet][Dev] Strategy resource API (#25582) * Adds base for updating Microsoft.ContainerService/fleet from version preview/2023-06-15-preview to version 2023-07-15-preview * rebase * Updates API version in new specs and examples * new tsp files * new tsp files * readme files * copy example files * new example files * fix example files * compile * compile to add new example files * improve comments * format tsp files * re-compile * improve comments * visibility concistency * [Fleet] Add VMSize to hub profile (#25709) * add VMSize to hub profile * add VMSize examples * improve description * format * Add portal FQDN to fleet hub profile (#25766) Co-authored-by: nguyenmin <[email protected]> * [Fleet] Move VMSize into AgentProfile (#25805) * move vm size into agent profile * re-generate * [Fleet] Fix readme.md for 0815 (#25822) * fix readme * format --------- Co-authored-by: Minh Nguyen <[email protected]> Co-authored-by: nguyenmin <[email protected]>
jnlycklama
pushed a commit
that referenced
this pull request
Nov 8, 2023
* Adds base for updating Microsoft.ContainerService/fleet from version preview/2023-06-15-preview to version 2023-08-15-preview * Updates readme * Updates API version in new specs and examples * [Fleet][Dev] Strategy resource API (#25582) * Adds base for updating Microsoft.ContainerService/fleet from version preview/2023-06-15-preview to version 2023-07-15-preview * rebase * Updates API version in new specs and examples * new tsp files * new tsp files * readme files * copy example files * new example files * fix example files * compile * compile to add new example files * improve comments * format tsp files * re-compile * improve comments * visibility concistency * [Fleet] Add VMSize to hub profile (#25709) * add VMSize to hub profile * add VMSize examples * improve description * format * Add portal FQDN to fleet hub profile (#25766) Co-authored-by: nguyenmin <[email protected]> * [Fleet] Move VMSize into AgentProfile (#25805) * move vm size into agent profile * re-generate * [Fleet] Fix readme.md for 0815 (#25822) * fix readme * format --------- Co-authored-by: Minh Nguyen <[email protected]> Co-authored-by: nguyenmin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ARM (Control Plane) API Specification Update Pull Request
PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
[1] ARM review queue (for merge queues, see [4])
The PRs are processed by time opened, ascending. Your PR may show up on 2nd or later page.
If you addressed Step 1 from the diagram and your PR is not showing up in the queue, ensure the label
ARMChangesRequestedis removed from your PR. This should cause the label
WaitForARMFeedbackto be added.[2] https://aka.ms/azsdk/support/specreview-channel
[3] List of SDK breaking changes approvers in pinned Teams announcement
[4] public repo merge queue, private repo merge queue (for ARM review queue, [1])
If you need further help with anything, see
Getting helpsection below.Purpose of this PR
What's the purpose of this PR? Check all that apply. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to Step 2, "ARM Review", for this PR.
Breaking changes review (Step 1)
you must follow the breaking changes process.
IMPORTANT This applies even if:
Such claims must be reviewed, and the process is the same.
ARM API changes review (Step 2)
ARMReviewlabel.Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiViewcomment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.
Getting help
and https://aka.ms/ci-fix.