Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Microsoft.StorageTasks to Microsoft.StorageActions #25847

Merged
merged 4 commits into from
Sep 20, 2023
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"body": {
"value": [
{
"name": "Microsoft.StorageTasks/storageTasks/read",
"name": "Microsoft.StorageActions/storageTasks/read",
"isDataAction": false,
"display": {
"provider": "Microsoft StorageTask",
Expand All @@ -17,7 +17,7 @@
}
},
{
"name": "Microsoft.StorageTasks/storageTasks/write",
"name": "Microsoft.StorageActions/storageTasks/write",
"isDataAction": false,
"display": {
"provider": "Microsoft StorageTask",
Expand All @@ -27,7 +27,7 @@
}
},
{
"name": "Microsoft.StorageTasks/storageTasks/delete",
"name": "Microsoft.StorageActions/storageTasks/delete",
"isDataAction": false,
"display": {
"provider": "Microsoft StorageTask",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
"parameters": {
"subscriptionId": "1f31ba14-ce16-4281-b9b4-3e78da6e1616",
"api-version": "2023-01-01",
"location": "eastus",
"monitor": "true",
"parameters": {
"properties": {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"responses": {
"202": {
"headers": {
"location": "https://management.azure.com/subscriptions/{subscription-id}/resourceGroups/res9101/providers/Microsoft.StorageTasks/locations/westus/operationResults/00000000-0000-0000-0000-000000000000?api-version=2023-01-01"
"location": "https://management.azure.com/subscriptions/{subscription-id}/resourceGroups/res9101/providers/Microsoft.StorageActions/locations/westus/operationResults/00000000-0000-0000-0000-000000000000?api-version=2023-01-01"
}
},
"204": {}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,9 @@
"responses": {
"200": {
"body": {
"id": "/subscriptions/1f31ba14-ce16-4281-b9b4-3e78da6e1616/resourceGroups/res4228/providers/Microsoft.StorageTasks/storageTasks/mytask1",
"id": "/subscriptions/1f31ba14-ce16-4281-b9b4-3e78da6e1616/resourceGroups/res4228/providers/Microsoft.StorageActions/storageTasks/mytask1",
"name": "mytask1",
"type": "Microsoft.StorageTasks/storageTasks",
"type": "Microsoft.StorageActions/storageTasks",
"location": "westus",
"properties": {
"enabled": true,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -39,12 +39,12 @@
"responses": {
"200": {
"headers": {
"location": "https://management.azure.com/subscriptions/{subscription-id}/resourceGroups/res9101/providers/Microsoft.StorageTasks/locations/eastus/operationResults/00000000-0000-0000-0000-000000000000?api-version=2023-01-01"
"location": "https://management.azure.com/subscriptions/{subscription-id}/resourceGroups/res9101/providers/Microsoft.StorageActions/locations/eastus/operationResults/00000000-0000-0000-0000-000000000000?api-version=2023-01-01"
},
"body": {
"id": "/subscriptions/c86a9c18-8373-41fa-92d4-1d7bdc16977b/resourceGroups/res4228/providers/Microsoft.StorageTasks/storageTasks/mytask1",
"id": "/subscriptions/c86a9c18-8373-41fa-92d4-1d7bdc16977b/resourceGroups/res4228/providers/Microsoft.StorageActions/storageTasks/mytask1",
"name": "mytask1",
"type": "Microsoft.StorageTasks/storageTasks",
"type": "Microsoft.StorageActions/storageTasks",
"location": "westus",
"properties": {
"enabled": true,
Expand Down Expand Up @@ -81,7 +81,7 @@
},
"202": {
"headers": {
"location": "https://management.azure.com/subscriptions/{subscription-id}/resourceGroups/res9101/providers/Microsoft.StorageTasks/locations/eastus/operationResults/00000000-0000-0000-0000-000000000000?api-version=2023-01-01"
"location": "https://management.azure.com/subscriptions/{subscription-id}/resourceGroups/res9101/providers/Microsoft.StorageActions/locations/eastus/operationResults/00000000-0000-0000-0000-000000000000?api-version=2023-01-01"
}
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -40,12 +40,12 @@
"responses": {
"200": {
"headers": {
"location": "https://management.azure.com/subscriptions/{subscription-id}/resourceGroups/res9101/providers/Microsoft.StorageTasks/locations/eastus/operationResults/00000000-0000-0000-0000-000000000000?api-version=2023-01-01"
"location": "https://management.azure.com/subscriptions/{subscription-id}/resourceGroups/res9101/providers/Microsoft.StorageActions/locations/eastus/operationResults/00000000-0000-0000-0000-000000000000?api-version=2023-01-01"
},
"body": {
"id": "/subscriptions/c86a9c18-8373-41fa-92d4-1d7bdc16977b/resourceGroups/res4228/providers/Microsoft.StorageTasks/storageTasks/mytask1",
"id": "/subscriptions/c86a9c18-8373-41fa-92d4-1d7bdc16977b/resourceGroups/res4228/providers/Microsoft.StorageActions/storageTasks/mytask1",
"name": "mytask1",
"type": "Microsoft.StorageTasks/storageTasks",
"type": "Microsoft.StorageActions/storageTasks",
"location": "westus",
"properties": {
"enabled": true,
Expand Down Expand Up @@ -82,12 +82,12 @@
},
"201": {
"headers": {
"location": "https://management.azure.com/subscriptions/{subscription-id}/resourceGroups/res9101/providers/Microsoft.StorageTasks/locations/eastus/operationResults/00000000-0000-0000-0000-000000000000?api-version=2023-01-01"
"location": "https://management.azure.com/subscriptions/{subscription-id}/resourceGroups/res9101/providers/Microsoft.StorageActions/locations/eastus/operationResults/00000000-0000-0000-0000-000000000000?api-version=2023-01-01"
},
"body": {
"id": "/subscriptions/c86a9c18-8373-41fa-92d4-1d7bdc16977b/resourceGroups/res4228/providers/Microsoft.StorageTasks/storageTasks/mytask1",
"id": "/subscriptions/c86a9c18-8373-41fa-92d4-1d7bdc16977b/resourceGroups/res4228/providers/Microsoft.StorageActions/storageTasks/mytask1",
"name": "mytask1",
"type": "Microsoft.StorageTasks/storageTasks",
"type": "Microsoft.StorageActions/storageTasks",
"location": "westus",
"properties": {
"enabled": true,
Expand Down Expand Up @@ -124,7 +124,7 @@
},
"202": {
"headers": {
"location": "https://management.azure.com/subscriptions/{subscription-id}/resourceGroups/res9101/providers/Microsoft.StorageTasks/locations/eastus/operationResults/00000000-0000-0000-0000-000000000000?api-version=2023-01-01"
"location": "https://management.azure.com/subscriptions/{subscription-id}/resourceGroups/res9101/providers/Microsoft.StorageActions/locations/eastus/operationResults/00000000-0000-0000-0000-000000000000?api-version=2023-01-01"
}
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,9 @@
"body": {
"value": [
{
"id": "/subscriptions/c86a9c18-8373-41fa-92d4-1d7bdc16977b/resourceGroups/res6117/providers/Microsoft.StorageTasks/storageTasks/mytask1",
"id": "/subscriptions/c86a9c18-8373-41fa-92d4-1d7bdc16977b/resourceGroups/res6117/providers/Microsoft.StorageActions/storageTasks/mytask1",
"name": "mytask1",
"type": "Microsoft.StorageTasks/storageTasks",
"type": "Microsoft.StorageActions/storageTasks",
"location": "eastus",
"identity": {
"principalId": "2fd475e8-8923-4597-842f-7ce1adfc6c4a",
Expand Down Expand Up @@ -39,9 +39,9 @@
}
},
{
"id": "/subscriptions/c86a9c18-8373-41fa-92d4-1d7bdc16977b/resourceGroups/res6117/providers/Microsoft.StorageTasks/storageTasks/mytask2",
"id": "/subscriptions/c86a9c18-8373-41fa-92d4-1d7bdc16977b/resourceGroups/res6117/providers/Microsoft.StorageActions/storageTasks/mytask2",
"name": "mytask2",
"type": "Microsoft.StorageTasks/storageTasks",
"type": "Microsoft.StorageActions/storageTasks",
"location": "westus",
"properties": {
"enabled": true,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,9 @@
"body": {
"value": [
{
"id": "/subscriptions/c86a9c18-8373-41fa-92d4-1d7bdc16977b/resourceGroups/res6117/providers/Microsoft.StorageTasks/storageTasks/mytask1",
"id": "/subscriptions/c86a9c18-8373-41fa-92d4-1d7bdc16977b/resourceGroups/res6117/providers/Microsoft.StorageActions/storageTasks/mytask1",
"name": "mytask1",
"type": "Microsoft.StorageTasks/storageTasks",
"type": "Microsoft.StorageActions/storageTasks",
"location": "eastus",
"identity": {
"principalId": "2fd475e8-8923-4597-842f-7ce1adfc6c4a",
Expand Down Expand Up @@ -38,9 +38,9 @@
}
},
{
"id": "/subscriptions/c86a9c18-8373-41fa-92d4-1d7bdc16977b/resourceGroups/res6117/providers/Microsoft.StorageTasks/storageTasks/mytask2",
"id": "/subscriptions/c86a9c18-8373-41fa-92d4-1d7bdc16977b/resourceGroups/res6117/providers/Microsoft.StorageActions/storageTasks/mytask2",
"name": "mytask2",
"type": "Microsoft.StorageTasks/storageTasks",
"type": "Microsoft.StorageActions/storageTasks",
"location": "westus",
"properties": {
"enabled": true,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,9 @@
"body": {
"value": [
{
"id": "/subscriptions/9d6baee9-681f-44d8-99f7-d06d180af6bb/resourcegroups/rgroup1/providers/Microsoft.StorageTasks/storageTasks/myTaskName/reports/instance1",
"id": "/subscriptions/9d6baee9-681f-44d8-99f7-d06d180af6bb/resourcegroups/rgroup1/providers/Microsoft.StorageActions/storageTasks/myTaskName/reports/instance1",
"name": "instance1",
"type": "Microsoft.StorageTasks/storageTasks/reports",
"type": "Microsoft.StorageActions/storageTasks/reports",
"properties": {
"taskAssignmentId": "/subscriptions/9d6baee9-681f-44d8-99f7-d06d180af6bb/resourcegroups/rgroup1/providers/Microsoft.Storage/storageAccounts/acc123/storageTaskAssignments/assign1",
"storageAccountId": "/subscriptions/9d6baee9-681f-44d8-99f7-d06d180af6bb/resourcegroups/rgroup1/providers/Microsoft.Storage/storageAccounts/acc123",
Expand All @@ -26,15 +26,15 @@
"runStatusError": "0",
"runStatusEnum": "Finished",
"summaryReportPath": "https://acc123.blob.core.windows.net/result-container/{folderpath}/SummaryReport.json",
"taskId": "/subscriptions/9d6baee9-681f-44d8-99f7-d06d180af6bb/resourcegroups/rgroup1/providers/Microsoft.StorageTasks/storageTasks/mytask1",
"taskId": "/subscriptions/9d6baee9-681f-44d8-99f7-d06d180af6bb/resourcegroups/rgroup1/providers/Microsoft.StorageActions/storageTasks/mytask1",
"taskVersion": "1",
"runResult": "Succeeded"
}
},
{
"id": "/subscriptions/9d6baee9-681f-44d8-99f7-d06d180af6bb/resourcegroups/rgroup1/providers/Microsoft.StorageTasks/storageTasks/myTaskName/reports/instance2",
"id": "/subscriptions/9d6baee9-681f-44d8-99f7-d06d180af6bb/resourcegroups/rgroup1/providers/Microsoft.StorageActions/storageTasks/myTaskName/reports/instance2",
"name": "instance2",
"type": "Microsoft.StorageTasks/storageTasks/reports",
"type": "Microsoft.StorageActions/storageTasks/reports",
"properties": {
"taskAssignmentId": "/subscriptions/9d6baee9-681f-44d8-99f7-d06d180af6bb/resourcegroups/rgroup1/providers/Microsoft.Storage/storageAccounts/acc123/storageTaskAssignments/assign1",
"storageAccountId": "/subscriptions/9d6baee9-681f-44d8-99f7-d06d180af6bb/resourcegroups/rgroup1/providers/Microsoft.Storage/storageAccounts/acc123",
Expand All @@ -47,7 +47,7 @@
"runStatusError": "0",
"runStatusEnum": "Finished",
"summaryReportPath": "https://acc123.blob.core.windows.net/result-container/{folderpath}/SummaryReport.json",
"taskId": "/subscriptions/9d6baee9-681f-44d8-99f7-d06d180af6bb/resourcegroups/rgroup1/providers/Microsoft.StorageTasks/storageTasks/mytask1",
"taskId": "/subscriptions/9d6baee9-681f-44d8-99f7-d06d180af6bb/resourcegroups/rgroup1/providers/Microsoft.StorageActions/storageTasks/mytask1",
"taskVersion": "1",
"runResult": "Succeeded"
}
Expand Down
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
{
Copy link
Contributor

@visingla-ms visingla-ms Sep 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this change is in stable API version, please get a breaking changes review done from Breaking Changes Review Board [email protected]. #Resolved

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change is not released. However I will drop an email to the board and get back,

"swagger": "2.0",
"info": {
"title": "StorageTasksManagementClient",
"description": "The Azure Storage Tasks Management API.",
"title": "StorageActionsManagementClient",
"description": "The Azure Storage Actions Management API.",
"version": "2023-01-01"
},
"host": "management.azure.com",
Expand All @@ -16,12 +16,12 @@
"application/json"
],
"paths": {
"/providers/Microsoft.StorageTasks/operations": {
"/providers/Microsoft.StorageActions/operations": {
"get": {
"tags": [
"Storage Tasks Operations"
"Storage Actions Operations"
],
"description": "Lists all of the available Storage Tasks Rest API operations.",
"description": "Lists all of the available Storage Actions Rest API operations.",
"operationId": "Operations_List",
"x-ms-examples": {
"OperationsList": {
Expand Down Expand Up @@ -52,7 +52,7 @@
}
}
},
"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.StorageTasks/storageTasks/{storageTaskName}": {
"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.StorageActions/storageTasks/{storageTaskName}": {
"put": {
"tags": [
"StorageTasks"
Expand Down Expand Up @@ -271,7 +271,7 @@
}
}
},
"/subscriptions/{subscriptionId}/providers/Microsoft.StorageTasks/storageTasks": {
"/subscriptions/{subscriptionId}/providers/Microsoft.StorageActions/storageTasks": {
"get": {
"tags": [
"StorageTasks"
Expand Down Expand Up @@ -310,7 +310,7 @@
}
}
},
"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.StorageTasks/storageTasks": {
"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.StorageActions/storageTasks": {
"get": {
"tags": [
"StorageTasks"
Expand Down Expand Up @@ -352,7 +352,7 @@
}
}
},
"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.StorageTasks/storageTasks/{storageTaskName}/storageTaskAssignments": {
"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.StorageActions/storageTasks/{storageTaskName}/storageTaskAssignments": {
"get": {
"tags": [
"StorageTasks"
Expand Down Expand Up @@ -403,7 +403,7 @@
}
}
},
"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.StorageTasks/storageTasks/{storageTaskName}/reports": {
"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.StorageActions/storageTasks/{storageTaskName}/reports": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

storageTasks

Is only RP namespace changing? Not the underlying resource types?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is correct only the RP namespace is changing

"get": {
"tags": [
"StorageTasks"
Expand Down Expand Up @@ -460,7 +460,7 @@
}
}
},
"/subscriptions/{subscriptionId}/providers/Microsoft.StorageTasks/previewActions": {
"/subscriptions/{subscriptionId}/providers/Microsoft.StorageActions/locations/{location}/previewActions": {
"post": {
"tags": [
"StorageTasks"
Expand All @@ -479,6 +479,13 @@
{
"$ref": "../../../../../common-types/resource-management/v5/types.json#/parameters/SubscriptionIdParameter"
},
{
"name": "location",
"in": "path",
"required": true,
"type": "string",
"description": "The location to perform preview of the actions."
},
{
"name": "parameters",
"in": "body",
Expand Down Expand Up @@ -890,7 +897,7 @@
"x-ms-arm-id-details": {
"allowedResources": [
{
"type": "Microsoft.StorageTasks/storageTasks"
"type": "Microsoft.StorageActions/storageTasks"
}
]
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,11 @@ For new Resource Provider. It is highly recommended to onboard Azure CLI extensi

``` yaml $(az) && $(target-mode) != 'core'
az:
extensions: storagetasks
namespace: azure.mgmt.storagetasks
package-name: azure-mgmt-storagetasks
az-output-folder: $(azure-cli-extension-folder)/src/storagetasks
python-sdk-output-folder: "$(az-output-folder)/azext_storagetasks/vendored_sdks/storagetasks"
extensions: storageactions
namespace: azure.mgmt.storageactions
package-name: azure-mgmt-storageactions
az-output-folder: $(azure-cli-extension-folder)/src/storageactions
python-sdk-output-folder: "$(az-output-folder)/azext_storageactions/vendored_sdks/storageactions"
# add additional configuration here specific for Azure CLI
# refer to the faq.md for more details
```
Expand All @@ -20,9 +20,9 @@ python-sdk-output-folder: "$(az-output-folder)/azext_storagetasks/vendored_sdks/
This is for command modules that already in azure cli main repo.
``` yaml $(az) && $(target-mode) == 'core'
az:
extensions: storagetasks
namespace: azure.mgmt.storagetasks
package-name: azure-mgmt-storagetasks
az-output-folder: $(azure-cli-folder)/src/azure-cli/azure/cli/command_modules/storagetasks
python-sdk-output-folder: "$(az-output-folder)/vendored_sdks/storagetasks"
extensions: storageactions
namespace: azure.mgmt.storageactions
package-name: azure-mgmt-storageactions
az-output-folder: $(azure-cli-folder)/src/azure-cli/azure/cli/command_modules/storageactions
python-sdk-output-folder: "$(az-output-folder)/vendored_sdks/storageactions"
```
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,6 @@ csharp:
payload-flattening-threshold: 2
clear-output-folder: true
client-side-validation: false
namespace: Microsoft.Azure.Management.StorageTasks
output-folder: $(csharp-sdks-folder)/StorageTasks/Microsoft.Azure.Management.StorageTasks/src/Generated
namespace: Microsoft.Azure.Management.StorageActions
output-folder: $(csharp-sdks-folder)/StorageActions/Microsoft.Azure.Management.StorageActions/src/Generated
```
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ These settings apply only when `--go` is specified on the command line.
```yaml $(go) && $(track2)
azure-arm: true
license-header: MICROSOFT_MIT_NO_VERSION
module-name: sdk/resourcemanager/storagetasks/armstoragetasks
module-name: sdk/resourcemanager/storageactions/armstorageactions
module: github.com/Azure/azure-sdk-for-go/$(module-name)
output-folder: $(go-sdk-folder)/$(module-name)
```
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ These settings apply only when `--tag=package-2023-01-01` is specified on the co

```yaml $(tag) == 'package-2023-01-01'
input-file:
- Microsoft.StorageTasks/stable/2023-01-01/storagetasks.json
- Microsoft.StorageActions/stable/2023-01-01/storageactions.json
```

---
Expand All @@ -55,7 +55,7 @@ swagger-to-sdk:
- repo: azure-sdk-for-go
- repo: azure-sdk-for-js
after_scripts:
- bundle install && rake arm:regen_all_profiles['azure_mgmt_storagetasks']
- bundle install && rake arm:regen_all_profiles['azure_mgmt_storageactions']
```

## Go
Expand Down
Loading