[Hub Generated] Review request for Microsoft.Communication to add version preview/2023-06-01-preview #25952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…023-04-01-preview to version 2023-06-01-preview
Next Steps to Merge✔️ All automated merging requirements have been met! Refer to step 4 in the PR workflow diagram (even if your PR is for data plane, not ARM). |
Swagger Validation Report
|
| compared swaggers (via Oad v0.10.4)] | new version | base version |
|---|---|---|
| CommunicationServices.json | 2023-06-01-preview(ba1ffb3) | 2023-03-31(main) |
| CommunicationServices.json | 2023-06-01-preview(ba1ffb3) | 2023-04-01-preview(main) |
| Domains.json | 2023-06-01-preview(ba1ffb3) | 2023-03-31(main) |
| Domains.json | 2023-06-01-preview(ba1ffb3) | 2023-04-01-preview(main) |
| EmailServices.json | 2023-06-01-preview(ba1ffb3) | 2023-03-31(main) |
| EmailServices.json | 2023-06-01-preview(ba1ffb3) | 2023-04-01-preview(main) |
| SenderUsernames.json | 2023-06-01-preview(ba1ffb3) | 2023-03-31(main) |
| SenderUsernames.json | 2023-06-01-preview(ba1ffb3) | 2023-04-01-preview(main) |
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️LintDiff: 0 Warnings warning [Detail]
| compared tags (via openapi-validator v2.1.6) | new version | base version |
|---|---|---|
| package-preview-2023-06 | package-preview-2023-06(ba1ffb3) | default(main) |
The following errors/warnings exist before current PR submission:
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Swagger Generation Artifacts
|
Generated ApiView
|
This was referenced Sep 25, 2023
AzureRestAPISpecReview
added
ARMReview
ReadyForApiTest
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
raosuhas
reviewed
Sep 28, 2023
...on/resource-manager/Microsoft.Communication/preview/2023-06-01-preview/SuppressionLists.json
Outdated
Show resolved
Hide resolved
raosuhas
reviewed
Sep 28, 2023
...on/resource-manager/Microsoft.Communication/preview/2023-06-01-preview/SuppressionLists.json
Outdated
Show resolved
Hide resolved
raosuhas
added
the
ARMChangesRequested
AzureRestAPISpecReview
removed
the
BreakingChangeReviewRequired
matthohn-msft
removed
the
ARMChangesRequested
openapi-workflow-bot
bot
added
the
WaitForARMFeedback
|
@raosuhas can I get an exception for the lindiff failures related to the domainName pattern? This introduces a breaking change that will impact all ACS email resources. |
sjanamma
reviewed
Oct 6, 2023
| } | ||
| }, | ||
| "paths": { | ||
| "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Communication/emailServices/{emailServiceName}/domains/{domainName}/suppressionLists": { |
sjanamma
added
ARMChangesRequested
openapi-workflow-bot
bot
removed
the
WaitForARMFeedback
|
@sjanamma I added a local domainName parameter with an extremely basic pattern. How specific should this be? This domainName value will be used to query a resource from our storage. Another regex that may work : ^[a-zA-Z0-9][a-zA-Z0-9-]{1,61}a-zA-Z0-9+$ |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
matthohn-msft
removed
the
ARMChangesRequested
openapi-workflow-bot
bot
added
the
WaitForARMFeedback
ms-zhenhua
added
ARMSignedOff
ms-zhenhua
approved these changes
Oct 9, 2023
ms-zhenhua
deleted the
matthohn-msft-communication-Microsoft.Communication-2023-06-01-preview-public-merge
branch
|
Swagger pipeline restarted successfully, please wait for status update in this comment. |
This was referenced Oct 9, 2023
jnlycklama
pushed a commit
that referenced
this pull request
Nov 8, 2023
…sion preview/2023-06-01-preview (#25952) * Adds base for updating Microsoft.Communication from version preview/2023-04-01-preview to version 2023-06-01-preview * Updates readme * Updates API version in new specs and examples * Adding SuppressionList support. * Updating readme file * Fixing model validation error * Prettier fixes * Fixing endpoint description * remove dataLocation and make datetime props readonly * Fixing model validation error * Remove datalocation from examples * update to v5 * Addressing lintdiff failures * Fix model validation errors * Revert pattern change which introduced the breaking change * add local domainName parameter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
ARM (Control Plane) API Specification Update Pull Request
PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
[1] ARM review queue (for merge queues, see [4])
The PRs are processed by time opened, ascending. Your PR may show up on 2nd or later page.
If you addressed Step 1 from the diagram and your PR is not showing up in the queue, ensure the label
ARMChangesRequestedis removed from your PR. This should cause the label
WaitForARMFeedbackto be added.[2] https://aka.ms/azsdk/support/specreview-channel
[3] List of SDK breaking changes approvers in pinned Teams announcement
[4] public repo merge queue, private repo merge queue (for ARM review queue, [1])
If you need further help with anything, see
Getting helpsection below.Purpose of this PR
What's the purpose of this PR? Check all that apply. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to Step 2, "ARM Review", for this PR.
Breaking changes review (Step 1)
you must follow the breaking changes process.
IMPORTANT This applies even if:
Such claims must be reviewed, and the process is the same.
ARM API changes review (Step 2)
ARMReviewlabel.Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiViewcomment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.
Getting help
and https://aka.ms/ci-fix.