-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add additional OData query parameters + mark some properties as Expandable
#25958
Conversation
Next Steps to Merge✔️ All automated merging requirements have been met! Refer to step 4 in the PR workflow diagram (even if your PR is for data plane, not ARM). |
Swagger Generation Artifacts
|
Generated ApiView
|
/pr RequestMerge |
please check step3 in the flowchart above. You need to get the breaking change signoff before requesting merge |
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
Hi @oformaniuk , I updated the readme.md configuration on the main branch, please sync it to make sure the 'SDK azure-sdk-for-go' CI works properly |
@Alancere, I'm not sure what change you're referring to. Can you please elaborate more? I do not want to just sync the main as I'm not merging to the main directly but to another protected branch that I do not have permissions to sync. |
Please address or respond to feedback from the ARM API reviewer. |
Hi @oformaniuk , Please get a breaking changes approval from Azure Breaking Changes Reviewers [email protected]. Once you have the approval, we can merge this PR. |
@ms-henglu, can you please elaborate what changes requires new version assuming that I'm trying to introduce new version - target branch is our new version branch. |
925d54f
into
Azure:release-release-Sentinel-securityinsights-Microsoft.SecurityInsights-2023-10-01-preview
ARM (Control Plane) API Specification Update Pull Request
PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
[1] ARM review queue (for merge queues, see [4])
The PRs are processed by time opened, ascending. Your PR may show up on 2nd or later page.
If you addressed Step 1 from the diagram and your PR is not showing up in the queue, ensure the label
ARMChangesRequested
is removed from your PR. This should cause the label
WaitForARMFeedback
to be added.[2] https://aka.ms/azsdk/support/specreview-channel
[3] List of SDK breaking changes approvers in pinned Teams announcement
[4] public repo merge queue, private repo merge queue (for ARM review queue, [1])
If you need further help with anything, see
Getting help
section below.Purpose of this PR
What's the purpose of this PR? Check all that apply. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to Step 2, "ARM Review", for this PR.
Breaking changes review (Step 1)
you must follow the breaking changes process.
IMPORTANT This applies even if:
Such claims must be reviewed, and the process is the same.
ARM API changes review (Step 2)
ARMReview
label.Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiView
comment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.
Getting help
and https://aka.ms/ci-fix.