Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added x-ms-file-request-intent to File PutRangeFromUrl #26221

Merged

Conversation

seanmcc-msft
Copy link
Member

This is not a new feature or a breaking change

We missing adding the x-ms-file-request-intent request header when we implement Files OAuth

@seanmcc-msft seanmcc-msft requested a review from a team as a code owner October 13, 2023 21:24
@seanmcc-msft seanmcc-msft requested review from scgbear and MushMal and removed request for a team October 13, 2023 21:24
@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Oct 13, 2023

Next Steps to Merge

✔️ All automated merging requirements have been met! Refer to step 4 in the PR workflow diagram (even if your PR is for data plane, not ARM).

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Oct 13, 2023

Swagger Validation Report

️❌BreakingChange: 1 Errors, 0 Warnings failed [Detail]
compared swaggers (via Oad v0.10.4)] new version base version
file.json 2023-08-03(15f80f2) 2023-08-03(main)
Rule Message
1043 - AddingOptionalParameter The optional parameter 'x-ms-file-request-intent' was added in the new version.
New: Microsoft.FileStorage/preview/2023-08-03/file.json#L4821:9
️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️LintDiff: 0 Warnings warning [Detail]
compared tags (via openapi-validator v2.1.6) new version base version
package-2023-08 package-2023-08(15f80f2) package-2023-08(main)

The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule Message
HostParametersValidation The host parameter must be called 'endpoint'.
Location: Microsoft.FileStorage/preview/2023-08-03/file.json#L16
HostParametersValidation The host parameter must be typed 'type 'string', format 'url''.
Location: Microsoft.FileStorage/preview/2023-08-03/file.json#L16
XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
Location: Microsoft.FileStorage/preview/2023-08-03/file.json#L135
XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
Location: Microsoft.FileStorage/preview/2023-08-03/file.json#L145
XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
Location: Microsoft.FileStorage/preview/2023-08-03/file.json#L221
IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
Location: Microsoft.FileStorage/preview/2023-08-03/file.json#L361
IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
Location: Microsoft.FileStorage/preview/2023-08-03/file.json#L366
IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
Location: Microsoft.FileStorage/preview/2023-08-03/file.json#L371
IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
Location: Microsoft.FileStorage/preview/2023-08-03/file.json#L376
IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
Location: Microsoft.FileStorage/preview/2023-08-03/file.json#L387
XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
Location: Microsoft.FileStorage/preview/2023-08-03/file.json#L547
XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
Location: Microsoft.FileStorage/preview/2023-08-03/file.json#L644
XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
Location: Microsoft.FileStorage/preview/2023-08-03/file.json#L670
XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
Location: Microsoft.FileStorage/preview/2023-08-03/file.json#L759
XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
Location: Microsoft.FileStorage/preview/2023-08-03/file.json#L785
XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
Location: Microsoft.FileStorage/preview/2023-08-03/file.json#L882
XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
Location: Microsoft.FileStorage/preview/2023-08-03/file.json#L908
XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
Location: Microsoft.FileStorage/preview/2023-08-03/file.json#L1002
XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
Location: Microsoft.FileStorage/preview/2023-08-03/file.json#L1028
IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
Location: Microsoft.FileStorage/preview/2023-08-03/file.json#L1080
XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
Location: Microsoft.FileStorage/preview/2023-08-03/file.json#L1130
XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
Location: Microsoft.FileStorage/preview/2023-08-03/file.json#L1156
XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
Location: Microsoft.FileStorage/preview/2023-08-03/file.json#L1239
XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
Location: Microsoft.FileStorage/preview/2023-08-03/file.json#L1249
XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
Location: Microsoft.FileStorage/preview/2023-08-03/file.json#L1390
XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
Location: Microsoft.FileStorage/preview/2023-08-03/file.json#L1400
XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
Location: Microsoft.FileStorage/preview/2023-08-03/file.json#L1487
XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
Location: Microsoft.FileStorage/preview/2023-08-03/file.json#L1497
XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
Location: Microsoft.FileStorage/preview/2023-08-03/file.json#L1578
XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
Location: Microsoft.FileStorage/preview/2023-08-03/file.json#L1588
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Posted by Swagger Pipeline | How to fix these errors?

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Oct 13, 2023

Swagger pipeline restarted successfully, please wait for status update in this comment.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Oct 13, 2023

Generated ApiView

Language Package Name ApiView Link
Swagger Microsoft.FileStorage https://apiview.dev/Assemblies/Review/d207d8b1c9d243d59703509f49e514d2

@tg-msft tg-msft added Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 and removed NewApiVersionRequired labels Oct 16, 2023
@tg-msft
Copy link
Member

tg-msft commented Oct 16, 2023

Adding the Approved-BreakingChange as this was just an update to make the spec match the service

@tg-msft tg-msft merged commit 4bafbf3 into Azure:main Oct 16, 2023
@openapi-pipeline-app
Copy link

Swagger pipeline restarted successfully, please wait for status update in this comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 data-plane
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants