-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added x-ms-file-request-intent to File PutRangeFromUrl #26221
Merged
tg-msft
merged 1 commit into
Azure:main
from
seanmcc-msft:feature/storage/putRangeFromUrlOAuth
Oct 16, 2023
Merged
Added x-ms-file-request-intent to File PutRangeFromUrl #26221
tg-msft
merged 1 commit into
Azure:main
from
seanmcc-msft:feature/storage/putRangeFromUrlOAuth
Oct 16, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Next Steps to Merge✔️ All automated merging requirements have been met! Refer to step 4 in the PR workflow diagram (even if your PR is for data plane, not ARM). |
Swagger Validation Report
|
compared swaggers (via Oad v0.10.4)] | new version | base version |
---|---|---|
file.json | 2023-08-03(15f80f2) | 2023-08-03(main) |
Rule | Message |
---|---|
1043 - AddingOptionalParameter |
The optional parameter 'x-ms-file-request-intent' was added in the new version. New: Microsoft.FileStorage/preview/2023-08-03/file.json#L4821:9 |
️️✔️
Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️
CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️
LintDiff: 0 Warnings warning [Detail]
compared tags (via openapi-validator v2.1.6) | new version | base version |
---|---|---|
package-2023-08 | package-2023-08(15f80f2) | package-2023-08(main) |
The following errors/warnings exist before current PR submission:
Only 30 items are listed, please refer to log for more details.
Rule | Message |
---|---|
HostParametersValidation |
The host parameter must be called 'endpoint'. Location: Microsoft.FileStorage/preview/2023-08-03/file.json#L16 |
HostParametersValidation |
The host parameter must be typed 'type 'string', format 'url''. Location: Microsoft.FileStorage/preview/2023-08-03/file.json#L16 |
XmsEnumValidation |
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.FileStorage/preview/2023-08-03/file.json#L135 |
XmsEnumValidation |
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.FileStorage/preview/2023-08-03/file.json#L145 |
XmsEnumValidation |
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.FileStorage/preview/2023-08-03/file.json#L221 |
IntegerTypeMustHaveFormat |
The integer type does not have a format, please add it. Location: Microsoft.FileStorage/preview/2023-08-03/file.json#L361 |
IntegerTypeMustHaveFormat |
The integer type does not have a format, please add it. Location: Microsoft.FileStorage/preview/2023-08-03/file.json#L366 |
IntegerTypeMustHaveFormat |
The integer type does not have a format, please add it. Location: Microsoft.FileStorage/preview/2023-08-03/file.json#L371 |
IntegerTypeMustHaveFormat |
The integer type does not have a format, please add it. Location: Microsoft.FileStorage/preview/2023-08-03/file.json#L376 |
IntegerTypeMustHaveFormat |
The integer type does not have a format, please add it. Location: Microsoft.FileStorage/preview/2023-08-03/file.json#L387 |
XmsEnumValidation |
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.FileStorage/preview/2023-08-03/file.json#L547 |
XmsEnumValidation |
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.FileStorage/preview/2023-08-03/file.json#L644 |
XmsEnumValidation |
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.FileStorage/preview/2023-08-03/file.json#L670 |
XmsEnumValidation |
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.FileStorage/preview/2023-08-03/file.json#L759 |
XmsEnumValidation |
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.FileStorage/preview/2023-08-03/file.json#L785 |
XmsEnumValidation |
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.FileStorage/preview/2023-08-03/file.json#L882 |
XmsEnumValidation |
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.FileStorage/preview/2023-08-03/file.json#L908 |
XmsEnumValidation |
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.FileStorage/preview/2023-08-03/file.json#L1002 |
XmsEnumValidation |
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.FileStorage/preview/2023-08-03/file.json#L1028 |
IntegerTypeMustHaveFormat |
The integer type does not have a format, please add it. Location: Microsoft.FileStorage/preview/2023-08-03/file.json#L1080 |
XmsEnumValidation |
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.FileStorage/preview/2023-08-03/file.json#L1130 |
XmsEnumValidation |
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.FileStorage/preview/2023-08-03/file.json#L1156 |
XmsEnumValidation |
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.FileStorage/preview/2023-08-03/file.json#L1239 |
XmsEnumValidation |
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.FileStorage/preview/2023-08-03/file.json#L1249 |
XmsEnumValidation |
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.FileStorage/preview/2023-08-03/file.json#L1390 |
XmsEnumValidation |
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.FileStorage/preview/2023-08-03/file.json#L1400 |
XmsEnumValidation |
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.FileStorage/preview/2023-08-03/file.json#L1487 |
XmsEnumValidation |
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.FileStorage/preview/2023-08-03/file.json#L1497 |
XmsEnumValidation |
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.FileStorage/preview/2023-08-03/file.json#L1578 |
XmsEnumValidation |
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.FileStorage/preview/2023-08-03/file.json#L1588 |
️️✔️
Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️
SwaggerAPIView succeeded [Detail] [Expand]
️️✔️
TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️
ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️
PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️
PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️
SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️
Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️
PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️
Automated merging requirements met succeeded [Detail] [Expand]
Swagger pipeline restarted successfully, please wait for status update in this comment. |
Generated ApiView
|
jalauzon-msft
approved these changes
Oct 13, 2023
Adding the Approved-BreakingChange as this was just an update to make the spec match the service |
Swagger pipeline restarted successfully, please wait for status update in this comment. |
jnlycklama
pushed a commit
that referenced
this pull request
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Approved-BreakingChange
DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374
data-plane
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not a new feature or a breaking change
We missing adding the x-ms-file-request-intent request header when we implement Files OAuth