-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Metadata to chat thread and user level events #26347
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Next Steps to Merge✔️ All automated merging requirements have been met! Refer to step 4 in the PR workflow diagram (even if your PR is for data plane, not ARM). |
Swagger Validation Report
|
compared swaggers (via Oad v0.10.4)] | new version | base version |
---|---|---|
AzureCommunicationServices.json | 2018-01-01(a0ec4c2) | 2018-01-01(main) |
️️✔️
Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️
CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️
LintDiff: 0 Warnings warning [Detail]
compared tags (via openapi-validator v2.1.6) | new version | base version |
---|---|---|
package-2023-06-01-preview | package-2023-06-01-preview(a0ec4c2) | package-2023-06-01-preview(main) |
package-2018-01 | package-2018-01(a0ec4c2) | package-2018-01(main) |
The following errors/warnings exist before current PR submission:
️️✔️
Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️
SwaggerAPIView succeeded [Detail] [Expand]
️️✔️
TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️
ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️
PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️
PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️
SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️
Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️
PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️
Automated merging requirements met succeeded [Detail] [Expand]
Swagger Generation Artifacts
|
Generated ApiView
|
angiurgiu
approved these changes
Oct 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
angiurgiu
reviewed
Oct 25, 2023
...mmunication/stable/2018-01-01/examples/cloud-events-schema/chat_thread_created_withUser.json
Outdated
Show resolved
Hide resolved
...mmunication/stable/2018-01-01/examples/cloud-events-schema/chat_thread_created_withUser.json
Outdated
Show resolved
Hide resolved
angiurgiu
reviewed
Oct 25, 2023
...le/2018-01-01/examples/event-grid-schema/chat_participant_removed_from_thread_with_user.json
Outdated
Show resolved
Hide resolved
angiurgiu
reviewed
Oct 25, 2023
...on/stable/2018-01-01/examples/event-grid-schema/chat_thread_properties_updated_per_user.json
Outdated
Show resolved
Hide resolved
angiurgiu
reviewed
Oct 25, 2023
...mmunication/stable/2018-01-01/examples/event-grid-schema/chat_thread_properties_updated.json
Outdated
Show resolved
Hide resolved
...munication/stable/2018-01-01/examples/event-grid-schema/chat_thread_participant_removed.json
Outdated
Show resolved
Hide resolved
...entgrid/data-plane/Microsoft.Communication/stable/2018-01-01/AzureCommunicationServices.json
Outdated
Show resolved
Hide resolved
…for metadata dictionary to denote type string
...entgrid/data-plane/Microsoft.Communication/stable/2018-01-01/AzureCommunicationServices.json
Outdated
Show resolved
Hide resolved
JoshLove-msft
approved these changes
Nov 1, 2023
Swagger pipeline restarted successfully, please wait for status update in this comment. |
jnlycklama
pushed a commit
that referenced
this pull request
Nov 8, 2023
* Added Metadata to chat thread and user level events * Updated examples for each event which has new metadata fields * Apply suggestions for example user metadata * Update example metadata * Fix typo * Remove description from examples and add additional properties value for metadata dictionary to denote type string * Updated remaining examples in cloud-events-schema and event-grid-schema * Removed extra metadata properties
zman-ms
pushed a commit
that referenced
this pull request
Jan 10, 2024
* Added Metadata to chat thread and user level events * Updated examples for each event which has new metadata fields * Apply suggestions for example user metadata * Update example metadata * Fix typo * Remove description from examples and add additional properties value for metadata dictionary to denote type string * Updated remaining examples in cloud-events-schema and event-grid-schema * Removed extra metadata properties
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Data Plane API - Pull Request
This PR adds Metadata properties to chat events as follows:
ParticipantMetadata property:
ChatThreadCreatedWithUser.participants[n].metadata
ChatParticipantAddedToThreadWithUser.participantAdded.metadata
ChatParticipantRemovedFromThreadWithUser.participantRemoved.metadata
ChatThreadCreated.participants[n].metadata
ChatThreadParticipantAdded.participantAdded.metadata
ChatThreadParticipantRemoved.participantRemoved.metadata
ThreadMetadata property:
ChatThreadCreatedWithUser.properties.metadata
ChatThreadPropertiesUpdatedPerUser.properties.metadata
ChatThreadCreated.properties.metadata
ChatThreadPropertiesUpdated.properties.metadata
API Info: The Basics
Most of the information about your service should be captured in the issue that serves as your API Spec engagement record.
Is this review for (select one):
Change Scope
This section will help us focus on the specific parts of your API that are new or have been modified.
Please share a link to the design document for the new APIs, a link to the previous API Spec document (if applicable), and the root paths that have been updated.
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiView
comment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.
❔Got questions? Need additional info?? We are here to help!
Contact us!
The Azure API Review Board is dedicated to helping you create amazing APIs. You can read about our mission and learn more about our process on our wiki.
Click here for links to tools, specs, guidelines & other good stuff
Tooling
Guidelines & Specifications
Helpful Links