Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding ListKeys support for Automation Account #2654

Merged
merged 1 commit into from
Mar 26, 2018
Merged

Adding ListKeys support for Automation Account #2654

merged 1 commit into from
Mar 26, 2018

Conversation

vrdmr
Copy link
Member

@vrdmr vrdmr commented Mar 14, 2018 •
edited by azuresdkci
Loading

Adding new method which Lists Automation Keys.

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@AutorestCI
Copy link

AutorestCI commented Mar 14, 2018 •
edited
Loading

Automation for azure-libraries-for-java

Nothing to generate for azure-libraries-for-java

@AutorestCI
Copy link

AutorestCI commented Mar 14, 2018 •
edited
Loading

Automation for azure-sdk-for-go

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-go#1436

@AutorestCI AutorestCI mentioned this pull request Mar 14, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Mar 14, 2018 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#1959

subbukambala
subbukambala reviewed Mar 14, 2018
View reviewed changes
specification/automation/resource-manager/Microsoft.Automation/stable/2015-10-31/account.json Outdated
"ListKeys"
],
"operationId": "Keys_ListByAutomationAccount",
"description": "Retrieve the automation keys for the account id.",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you change the description to "Retrieve the automation keys for an account."

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay.

...ource-manager/Microsoft.Automation/stable/2015-10-31/examples/listAutomationAccountKeys.json Outdated
"subscriptionId": "subid",
"resourceGroupName": "rg",
"automationAccountName": "MyAutomationAccount",
"typeName": "MyCustomType",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is this typeName?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thats a mistake. I'll remove it

@AutorestCI
Copy link

AutorestCI commented Mar 14, 2018 •
edited
Loading

Automation for azure-sdk-for-node

Nothing to generate for azure-sdk-for-node

@sergey-shandar sergey-shandar added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Mar 15, 2018
@sergey-shandar
Copy link
Contributor

sergey-shandar commented Mar 15, 2018 •
edited
Loading

@ravbhatnagar new operations in Automation.

@vrdmr
Copy link
Member Author

vrdmr commented Mar 19, 2018

@ravbhatnagar Ping

@vrdmr
Copy link
Member Author

vrdmr commented Mar 21, 2018

@ravbhatnagar Ping. Could you please review this PR. Thanks.

@ravbhatnagar ravbhatnagar added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Mar 23, 2018
@ravbhatnagar
Copy link
Contributor

Done

sergey-shandar
sergey-shandar approved these changes Mar 26, 2018
View reviewed changes
Copy link
Contributor

@sergey-shandar sergey-shandar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sergey-shandar sergey-shandar merged commit 4773297 into Azure:master Mar 26, 2018
@AutorestCI AutorestCI mentioned this pull request Mar 26, 2018
Merged
@vrdmr vrdmr deleted the vameru-dsc-list-keys branch April 3, 2018 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@subbukambala subbukambala subbukambala approved these changes

@sergey-shandar sergey-shandar sergey-shandar approved these changes

Assignees

@sergey-shandar sergey-shandar

Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vrdmr @AutorestCI @sergey-shandar @ravbhatnagar @subbukambala