Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding patch API for Configurations #2688

Merged
merged 1 commit into from
Mar 23, 2018
Merged

Adding patch API for Configurations #2688

merged 1 commit into from
Mar 23, 2018

Conversation

vrdmr
Copy link
Member

@vrdmr vrdmr commented Mar 19, 2018

Adding spec for the new Patch operation for Automation/DscConfigurations.


This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@AutorestCI
Copy link

AutorestCI commented Mar 19, 2018

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#1959

@vrdmr
Copy link
Member Author

vrdmr commented Mar 20, 2018

Ping - @sarangan12, @fearthecowboy Could you please review this PR

@sarangan12
Copy link
Member

@sarangan12
Copy link
Member

@vrdmr I wanted to check in if you need any help in resolving the issues. Please let me know

@vrdmr
Copy link
Member Author

vrdmr commented Mar 21, 2018

Hi @sarangan12 - I have other PRs out to fix the same issues - #2690, #2687 and this is one in the series of PRs to get our Linting and Model Validation issues down to 0.

@vrdmr
Copy link
Member Author

vrdmr commented Mar 21, 2018

For the model issue, I'll add the example.

@AutorestCI
Copy link

AutorestCI commented Mar 22, 2018

Automation for azure-libraries-for-java

Nothing to generate for azure-libraries-for-java

@AutorestCI
Copy link

AutorestCI commented Mar 22, 2018

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#1411

@AutorestCI
Copy link

AutorestCI commented Mar 22, 2018

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#2483

@vrdmr
Copy link
Member Author

vrdmr commented Mar 22, 2018

@sarangan12 I fixed the model validation issue. The issue was with the spec I wrote. We dont have a 201 return code, but it was added. I fixed it.

@vrdmr
Copy link
Member Author

vrdmr commented Mar 22, 2018

@sarangan12 Could you please take a look at this PR.

@sarangan12 sarangan12 merged commit 2c4ddff into Azure:master Mar 23, 2018
@vrdmr
Copy link
Member Author

vrdmr commented Mar 23, 2018

Thanks @sarangan12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants