-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update server.json version to 2023-05-01 has tls 1.3 as valid input #27080
Merged
ms-henglu
merged 2 commits into
main
from
dev/jha1bhavna/update_version_for_server_json
Dec 18, 2023
Merged
Update server.json version to 2023-05-01 has tls 1.3 as valid input #27080
ms-henglu
merged 2 commits into
main
from
dev/jha1bhavna/update_version_for_server_json
Dec 18, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jha1bhavna
requested review from
jamestao,
ericshape and
jeremyfrosti
as code owners
December 14, 2023 09:27
Next Steps to Merge✔️ All automated merging requirements have been met! Refer to step 4 in the PR workflow diagram (even if your PR is for data plane, not ARM). |
Swagger Validation Report
|
compared tags (via openapi-validator v2.1.6) | new version | base version |
---|---|---|
default | default(fff3638) | default(main) |
️⚠️
Avocado: 1 Warnings warning [Detail]
Rule | Message |
---|---|
The default tag contains multiple API versions swaggers. readme: specification/sql/resource-manager/readme.md tag: specification/sql/resource-manager/readme.md#tag-package-composite-v5 |
️️✔️
SwaggerAPIView succeeded [Detail] [Expand]
️️✔️
TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️
ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️
PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️
SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️
Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️
PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️
Automated merging requirements met succeeded [Detail] [Expand]
Swagger Generation Artifacts
|
Generated ApiView
|
AzureRestAPISpecReview
added
ARMReview
ReadyForApiTest
<valid label in PR review process>add this label when swagger and service APIs are ready for test
resource-manager
WaitForARMFeedback
<valid label in PR review process> add this label when ARM review is required
labels
Dec 14, 2023
This was referenced Dec 14, 2023
This was referenced Dec 14, 2023
ericshape
reviewed
Dec 14, 2023
@@ -1289,7 +1289,7 @@ input-file: | |||
- ./Microsoft.Sql/preview/2022-11-01-preview/DatabaseSqlVulnerabilityAssessmentScanResult.json | |||
- ./Microsoft.Sql/preview/2022-11-01-preview/DatabaseSqlVulnerabilityAssessmentScans.json | |||
- ./Microsoft.Sql/preview/2022-11-01-preview/DatabaseSqlVulnerabilityAssessmentsSettings.json | |||
- ./Microsoft.Sql/preview/2023-02-01-preview/Servers.json | |||
- ./Microsoft.Sql/preview/2023-05-01-preview/Servers.json |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we move this line to the bottom of this section by alphabetical order?
ericshape
approved these changes
Dec 14, 2023
ms-zhenhua
added
ARMSignedOff
<valid label in PR review process>add this label when ARM approve updates after review
and removed
WaitForARMFeedback
<valid label in PR review process> add this label when ARM review is required
labels
Dec 15, 2023
@jha1bhavna this month we have sql release request https://github.com/Azure/sdk-release-request/projects/1931#card-91165085, Do you want this release contains your change? |
Alancere
added
the
Approved-SdkBreakingChange-Go
Approve the breaking change tracking for azure-sdk-for-go
label
Dec 18, 2023
Yes, please. I want this change to be in this release.
Thanks,
Bhavna
From: ZiWei Chen ***@***.***>
Sent: Monday, December 18, 2023 7:57 AM
To: Azure/azure-rest-api-specs ***@***.***>
Cc: Bhavna Jha ***@***.***>; Mention ***@***.***>
Subject: Re: [Azure/azure-rest-api-specs] Update server.json version to 2023-05-01 has tls 1.3 as valid input (PR #27080)
@jha1bhavna<https://github.com/jha1bhavna> this month we have sql release requesthttps://github.com/Azure/sdk-release-request/projects/1931#card-91165085, Do you want this release contains your change?
-
Reply to this email directly, view it on GitHub<#27080 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/A5EV4C3CWXE54D3PFJVOFGTYJ6SYBAVCNFSM6AAAAABAUQOZ42VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNJZGQ2DKMZSGM>.
You are receiving this because you were mentioned.Message ID: ***@***.******@***.***>>
|
/pr RequestMerge |
ms-henglu
approved these changes
Dec 18, 2023
arifibrahim4
pushed a commit
that referenced
this pull request
Feb 26, 2024
…27080) * Update server.json version to 2023-05-01 has tls 1.3 as valid input * Repositioning file according to alphabetical order
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Approved-SdkBreakingChange-Go
Approve the breaking change tracking for azure-sdk-for-go
Approved-SdkBreakingChange-JavaScript
ARMReview
ARMSignedOff
<valid label in PR review process>add this label when ARM approve updates after review
CI-BreakingChange-Go
CI-BreakingChange-JavaScript
ReadyForApiTest
<valid label in PR review process>add this label when swagger and service APIs are ready for test
resource-manager
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ARM (Control Plane) API Specification Update Pull Request
PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
Click here to see the details of Step 1
Breaking changes review (Diagram Step 1)
If the automation determines you have breaking changes, i.e. Step 1 from the diagram applies to you,
you must follow the breaking changes process.
IMPORTANT This applies even if:
Such claims must be reviewed, and the process is the same.
Click here to see the details of Step 2
ARM API changes review (Diagram Step 2)
ARMReview
label.Click here to see the diagram footnotes
Diagram footnotes
[1] ARM review queue (for merge queues, see [2])
The PRs are processed by time opened, ascending. Your PR may show up on 2nd or later page.
If you addressed Step 1 from the diagram and your PR is not showing up in the queue, ensure the label
ARMChangesRequested
is removed from your PR. This should cause the label
WaitForARMFeedback
to be added.[2] public repo merge queue, private repo merge queue (for ARM review queue, [1])
If you need further help with anything, see
Getting help
section below.Purpose of this PR
What's the purpose of this PR? Check all that apply. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the Diagram Step 2, "ARM API changes Review", for this PR.
Additional information
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiView
comment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.
Getting help
Purpose of this PR
andDue diligence checklist
.Next Steps to Merge
comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.and https://aka.ms/ci-fix.
queued
state, please add a comment with contents/azp run
.This should result in a new comment denoting a
PR validation pipeline
has started and the checks should be updated after few minutes.