[UpdateManagement] SoftwareUpdateConfiguration changes to support Inclusion #2911

ikanni · 2018-04-20T06:44:23Z

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

The title of the PR is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
If applicable, the PR references the bug/issue that it fixes.
Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

I have read the contribution guidelines.
My spec meets the review criteria:
- The spec conforms to the Swagger 2.0 specification.
- The spec follows the guidelines described in the Swagger checklist document.
- Validation tools were run on swagger spec(s) and have all been fixed in this PR.

AutorestCI · 2018-04-20T06:45:03Z

Automation for azure-libraries-for-java

Nothing to generate for azure-libraries-for-java

AutorestCI · 2018-04-20T06:46:29Z

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#1959

AutorestCI · 2018-04-20T06:49:20Z

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#2653

AutorestCI · 2018-04-20T06:50:04Z

Automation for azure-sdk-for-go

Encountered a Subprocess error: (azure-sdk-for-go)

Command: ['/usr/local/bin/autorest', '/tmp/tmpt0k0coa8/rest/specification/automation/resource-manager/readme.md', '--go', '--go-sdk-folder=/tmp/tmpt0k0coa8/src/github.com/Azure/azure-sdk-for-go', '--multiapi', '[email protected]/autorest.go@~2.1.95', '--use-onever', '--verbose']
Finished with return code 1
and output:

AutoRest code generation utility [version: 2.0.4262; node: v7.10.1]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      '/root/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4272)
   Loading AutoRest extension '@microsoft.azure/autorest.go' (~2.1.95->2.1.95)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.38->2.3.38)
Processing batch task - {"tag":"package-2015-10"} .
Processing batch task - {"tag":"package-2017-05-preview"} .
Processing batch task - {"tag":"package-2018-01-preview"} .
FATAL: System.ArgumentOutOfRangeException: Index was out of range. Must be non-negative and less than the size of the collection.
Parameter name: startIndex
   at System.String.LastIndexOf(Char value, Int32 startIndex, Int32 count)
   at AutoRest.Go.Model.CodeModelGo.PackageVerDir() in C:\Users\autorest-ci\AppData\Local\Temp\2\PUBLISH2qmje\111_20180319T191725\autorest.go\src\Model\CodeModelGo.cs:line 64
   at AutoRest.Go.Model.CodeModelGo.get_DefaultUserAgent() in C:\Users\autorest-ci\AppData\Local\Temp\2\PUBLISH2qmje\111_20180319T191725\autorest.go\src\Model\CodeModelGo.cs:line 83
   at AutoRest.Go.Model.CodeModelGo.get_UserAgent() in C:\Users\autorest-ci\AppData\Local\Temp\2\PUBLISH2qmje\111_20180319T191725\autorest.go\src\Model\CodeModelGo.cs:line 31
   at AutoRest.Go.Templates.VersionTemplate.<ExecuteAsync>d__1.MoveNext() in C:\Users\autorest-ci\AppData\Local\Temp\2\PUBLISH2qmje\111_20180319T191725\autorest.go\src\obj\Razor\Templates\VersionTemplate.cshtml:line 28
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at AutoRest.Core.CodeGenerator.<Write>d__12.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at AutoRest.Go.CodeGeneratorGo.<Generate>d__6.MoveNext() in C:\Users\autorest-ci\AppData\Local\Temp\2\PUBLISH2qmje\111_20180319T191725\autorest.go\src\CodeGeneratorGo.cs:line 91
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at AutoRest.Go.Program.<ProcessInternal>d__3.MoveNext() in C:\Users\autorest-ci\AppData\Local\Temp\2\PUBLISH2qmje\111_20180319T191725\autorest.go\src\Program.cs:line 107
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at NewPlugin.<Process>d__15.MoveNext()
FATAL: go/generate - FAILED
FATAL: Error: Plugin go reported failure.
Process() cancelled due to exception : Plugin go reported failure.
Failure during batch task - {"tag":"package-2018-01-preview"} -- Error: Plugin go reported failure..
  Error: Plugin go reported failure.

azuresdkciprbot · 2018-04-20T06:50:13Z

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/automation/resource-manager/readme.md
Before the PR: Warning(s): 219 Error(s): 0
After the PR: Warning(s): 219 Error(s): 0

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

azuresdkciprbot · 2018-04-21T13:52:31Z

AutoRest linter results for SDK Related Validation Errors/Warnings

These errors are reported by the SDK team's validation tools, reachout to ADX Swagger Reviewers directly for any questions or concerns.

File: specification/automation/resource-manager/readme.md

⚠️

0 new Warnings.(131 total)

❌0 new Errors.(0 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

azuresdkciprbot · 2018-04-21T13:52:32Z

AutoRest linter results for ARM Related Validation Errors/Warnings

These errors are reported by the ARM team's validation tools, reachout to ARM RP API Review directly for any questions or concerns.

File: specification/automation/resource-manager/readme.md

⚠️

0 new Warnings.(88 total)

❌0 new Errors.(0 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

ikanni · 2018-04-25T18:28:27Z

@ravbhatnagar , Could you please review ?

ravbhatnagar · 2018-04-25T22:38:50Z

Typically this should have gone in a new api-version. but since this is preview, it should be fine. Signing off.

marstr · 2018-04-25T23:34:19Z

Ready for me to merge, @ikanni?

ikanni · 2018-04-26T00:02:38Z

@marstr Please go head and merg

azuresdkciprbot · 2018-04-26T00:08:26Z

AutoRest linter results for ARM Related Validation Errors/Warnings

These errors are reported by the ARM team's validation tools, reachout to ARM RP API Review directly for any questions or concerns.

File: specification/automation/resource-manager/readme.md

⚠️

0 new Warnings.(88 total)

❌0 new Errors.(0 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

azuresdkciprbot · 2018-04-26T00:08:26Z

AutoRest linter results for SDK Related Validation Errors/Warnings

These errors are reported by the SDK team's validation tools, reachout to ADX Swagger Reviewers directly for any questions or concerns.

File: specification/automation/resource-manager/readme.md

⚠️

0 new Warnings.(131 total)

❌0 new Errors.(0 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

ikanni · 2018-04-26T06:38:55Z

@marstr @ravbhatnagar Thank you!

SoftwareUpdateConfiguration Changes to support Inclusion

09707ce

azuresdkci assigned marstr Apr 20, 2018

azuresdkci requested a review from marstr April 20, 2018 06:45

AutorestCI mentioned this pull request Apr 20, 2018

[AutoPR automation/resource-manager] [UpdateManagement] SoftwareUpdateConfiguration changes to support Inclusion Azure/azure-sdk-for-python#2438

Merged

AutorestCI mentioned this pull request Apr 20, 2018

[AutoPR automation/resource-manager] [UpdateManagement] SoftwareUpdateConfiguration changes to support Inclusion Azure/azure-sdk-for-node#2768

Closed

Removed NotSelected

f5aaeaf

marstr approved these changes Apr 23, 2018

View reviewed changes

marstr added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Apr 23, 2018

marstr requested a review from ravbhatnagar April 23, 2018 16:24

ravbhatnagar added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Apr 25, 2018

ikanni closed this Apr 26, 2018

ikanni reopened this Apr 26, 2018

AutorestCI mentioned this pull request Apr 26, 2018

[AutoPR automation/resource-manager] [UpdateManagement] SoftwareUpdateConfiguration changes to support Inclusion Azure/azure-sdk-for-node#2795

Merged

marstr merged commit 838bca8 into Azure:master Apr 26, 2018

ikanni deleted the ikanni/SoftwareUpdateConfiguration_Changes_for_Inclusion branch April 26, 2018 06:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[UpdateManagement] SoftwareUpdateConfiguration changes to support Inclusion #2911

[UpdateManagement] SoftwareUpdateConfiguration changes to support Inclusion #2911

ikanni commented Apr 20, 2018 •

edited by azuresdkci

Loading

AutorestCI commented Apr 20, 2018 •

edited

Loading

AutorestCI commented Apr 20, 2018 •

edited

Loading

AutorestCI commented Apr 20, 2018 •

edited

Loading

AutorestCI commented Apr 20, 2018 •

edited

Loading

azuresdkciprbot commented Apr 20, 2018

azuresdkciprbot commented Apr 21, 2018

azuresdkciprbot commented Apr 21, 2018

ikanni commented Apr 25, 2018

ravbhatnagar commented Apr 25, 2018

marstr commented Apr 25, 2018

ikanni commented Apr 26, 2018 •

edited

Loading

azuresdkciprbot commented Apr 26, 2018

azuresdkciprbot commented Apr 26, 2018

ikanni commented Apr 26, 2018

[UpdateManagement] SoftwareUpdateConfiguration changes to support Inclusion #2911

[UpdateManagement] SoftwareUpdateConfiguration changes to support Inclusion #2911

Conversation

ikanni commented Apr 20, 2018 • edited by azuresdkci Loading

PR information

Quality of Swagger

AutorestCI commented Apr 20, 2018 • edited Loading

Automation for azure-libraries-for-java

AutorestCI commented Apr 20, 2018 • edited Loading

Automation for azure-sdk-for-python

AutorestCI commented Apr 20, 2018 • edited Loading

Automation for azure-sdk-for-node

AutorestCI commented Apr 20, 2018 • edited Loading

Automation for azure-sdk-for-go

azuresdkciprbot commented Apr 20, 2018

azuresdkciprbot commented Apr 21, 2018

AutoRest linter results for SDK Related Validation Errors/Warnings

azuresdkciprbot commented Apr 21, 2018

AutoRest linter results for ARM Related Validation Errors/Warnings

ikanni commented Apr 25, 2018

ravbhatnagar commented Apr 25, 2018

marstr commented Apr 25, 2018

ikanni commented Apr 26, 2018 • edited Loading

azuresdkciprbot commented Apr 26, 2018

AutoRest linter results for ARM Related Validation Errors/Warnings

azuresdkciprbot commented Apr 26, 2018

AutoRest linter results for SDK Related Validation Errors/Warnings

ikanni commented Apr 26, 2018

ikanni commented Apr 20, 2018 •

edited by azuresdkci

Loading

AutorestCI commented Apr 20, 2018 •

edited

Loading

AutorestCI commented Apr 20, 2018 •

edited

Loading

AutorestCI commented Apr 20, 2018 •

edited

Loading

AutorestCI commented Apr 20, 2018 •

edited

Loading

ikanni commented Apr 26, 2018 •

edited

Loading