radiologyinsights, tspconfig, java on final-type of LRO #29273

weidongxu-microsoft · 2024-05-30T03:11:21Z

The reason of this tspconfig for Java is to workaround the bug in typespec-azure-core Azure/typespec-azure#787 (the finalResultPath and finalResult from LroMetadata is not correct -- hence here to override the finalResult)

It is otherwise very difficult for dev to customize the finalResult of an LRO in Java.

Data Plane API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

API Info: The Basics

Most of the information about your service should be captured in the issue that serves as your API Spec engagement record.

Link to API Spec engagement record issue:

Is this review for (select one):

a private preview
a public preview
GA release

Change Scope

^{This section will help us focus on the specific parts of your API that are new or have been modified.
Please share a link to the design document for the new APIs, a link to the previous API Spec document (if applicable), and the root paths that have been updated.}

Design Document:
Previous API Spec Doc:
Updated paths:

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.

❔Got questions? Need additional info?? We are here to help!

Contact us!

The Azure API Review Board is dedicated to helping you create amazing APIs. You can read about our mission and learn more about our process on our wiki.

💬 Teams Channel
💌 email

Click here for links to tools, specs, guidelines & other good stuff

Tooling

Open API validation tools were run on this PR. Go here to see how to fix errors
Spectral Linting

Guidelines & Specifications

Helpful Links

Schedule a data plane REST API spec review

Getting help

First, please carefully read through this PR description, from top to bottom.
If you don't have permissions to remove or add labels to the PR, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories
To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
and https://aka.ms/ci-fix.
If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

openapi-pipeline-app · 2024-05-30T03:11:26Z

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

openapi-pipeline-app · 2024-05-30T03:11:26Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️️✔️LintDiff succeeded [Detail] [Expand]

Validation passes for LintDiff.

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️SwaggerAPIView succeeded [Detail] [Expand]

️️✔️TypeSpecAPIView succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️PoliCheck succeeded [Detail] [Expand]

Validation passed for PoliCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

️️✔️PR Summary succeeded [Detail] [Expand]

Validation passes for Summary.

️️✔️Automated merging requirements met succeeded [Detail] [Expand]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2024-05-30T03:11:27Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

️⚠️ azure-sdk-for-python warning [Detail]

⚠️Warning in generating from c5b040a439f6114817eb33fa4116bafd39e164c5. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] W: Target Packages (main/binary-amd64/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target Packages (main/binary-all/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target Translations (main/i18n/Translation-en) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target CNF (main/cnf/Commands-amd64) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target CNF (main/cnf/Commands-all) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target Packages (main/binary-amd64/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target Packages (main/binary-all/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target Translations (main/i18n/Translation-en) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target CNF (main/cnf/Commands-amd64) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target CNF (main/cnf/Commands-all) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json

️✔️azure-healthinsights-radiologyinsights [Preview SDK Changes]
- azure_healthinsights_radiologyinsights-1.0.0-py3-none-any.whl
- azure-healthinsights-radiologyinsights-1.0.0.zip
```
info	[Changelog] data-plan skip changelog generation temporarily
```

️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]

️✔️Succeeded in generating from c5b040a439f6114817eb33fa4116bafd39e164c5. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json

️✔️azure-health-insights-radiologyinsights [Preview SDK Changes]
- pom.xml
- azure-health-insights-radiologyinsights-1.0.0-beta.2-sources.jar
- azure-health-insights-radiologyinsights-1.0.0-beta.2.jar

️❌ azure-sdk-for-net-track2 failed [Detail]

❌Failed in generating from c5b040a439f6114817eb33fa4116bafd39e164c5. SDK Automation 14.0.0

command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
cmderr	[Invoke-GenerateAndBuildV2.ps1] GeneratePackage: /mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/Invoke-GenerateAndBuildV2.ps1:131
cmderr	[Invoke-GenerateAndBuildV2.ps1] Line |
cmderr	[Invoke-GenerateAndBuildV2.ps1]  131 |                GeneratePackage `
cmderr	[Invoke-GenerateAndBuildV2.ps1]      |                ~~~~~~~~~~~~~~~~~
cmderr	[Invoke-GenerateAndBuildV2.ps1]      | Failed to generate sdk. exit code: False
cmderr	[Invoke-GenerateAndBuildV2.ps1] Get-ChildItem: /mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:807
cmderr	[Invoke-GenerateAndBuildV2.ps1] Line |
cmderr	[Invoke-GenerateAndBuildV2.ps1]  807 |  … rtifacts += Get-ChildItem $artifactsPath -Filter *.nupkg -exclude *.s …
cmderr	[Invoke-GenerateAndBuildV2.ps1]      |                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cmderr	[Invoke-GenerateAndBuildV2.ps1]      | Cannot find path
cmderr	[Invoke-GenerateAndBuildV2.ps1]      | '/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/packages/Debug/' because
cmderr	[Invoke-GenerateAndBuildV2.ps1]      | it does not exist.
cmderr	[Invoke-GenerateAndBuildV2.ps1] GeneratePackage: /mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/Invoke-GenerateAndBuildV2.ps1:131
cmderr	[Invoke-GenerateAndBuildV2.ps1] Line |
cmderr	[Invoke-GenerateAndBuildV2.ps1]  131 |                GeneratePackage `
cmderr	[Invoke-GenerateAndBuildV2.ps1]      |                ~~~~~~~~~~~~~~~~~
cmderr	[Invoke-GenerateAndBuildV2.ps1]      | Failed to generate sdk artifact

❌Azure.Health.Insights.RadiologyInsights [Preview SDK Changes]
```
info	[Changelog]
```

️❌ azure-sdk-for-js failed [Detail]

❌Code Generator Failed in generating from c5b040a439f6114817eb33fa4116bafd39e164c5. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
cmderr	[automation_generate.sh] [ERROR] Command failed: pwsh ./eng/common/scripts/TypeSpec-Project-Process.ps1 /mnt/vss/_work/1/s/azure-rest-api-specs/specification/ai/HealthInsights/HealthInsights.RadiologyInsights c5b040a439f6114817eb33fa4116bafd39e164c5 https://github.com/Azure/azure-rest-api-specs
cmderr	[automation_generate.sh] [ERROR] Command failed: pwsh ./eng/common/scripts/TypeSpec-Project-Process.ps1 /mnt/vss/_work/1/s/azure-rest-api-specs/specification/ai/HealthInsights/HealthInsights.RadiologyInsights c5b040a439f6114817eb33fa4116bafd39e164c5 https://github.com/Azure/azure-rest-api-specs
error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-js]: sh .scripts/automation_generate.sh
warn	Skip package processing as generation is failed

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2024-05-30T03:11:28Z

Generated ApiView

Language	Package Name	ApiView Link
Python	azure-healthinsights-radiologyinsights	https://apiview.dev/Assemblies/Review/20cfb136ef164184971be6154cc227df?revisionId=b2ae9ea9cfab4f59b124467340856d0f
Java	azure-health-insights-radiologyinsights	https://apiview.dev/Assemblies/Review/c48b47bd12a6493aa27b2cec58f9e54e?revisionId=cb05b2d8bd564db2a08c6c5587c039ca

weidongxu-microsoft · 2024-05-30T05:29:41Z

/azp run

azure-pipelines · 2024-05-30T05:29:58Z

Azure Pipelines successfully started running 4 pipeline(s).

catalinaperalta · 2024-05-30T18:06:38Z

Will merge per @koen-mertens request once CI passes.

catalinaperalta · 2024-05-30T18:18:09Z

/azp run

azure-pipelines · 2024-05-30T18:18:27Z

Azure Pipelines successfully started running 4 pipeline(s).

Co-authored-by: catalinaperalta <[email protected]>

weidongxu-microsoft changed the title ~~radiologyinsights, tsp-config, java on final-type of LRO~~ radiologyinsights, tspconfig, java on final-type of LRO May 30, 2024

radiologyinsights, tsp-config, java on final-type of LRO

5862460

weidongxu-microsoft force-pushed the tsp_java-radiologyinsights branch from 0cd6a2a to 5862460 Compare May 30, 2024 03:13

AzureRestAPISpecReview added the TypeSpec Authored with TypeSpec label May 30, 2024

weidongxu-microsoft added a commit to weidongxu-microsoft/azure-sdk-for-java that referenced this pull request May 30, 2024

regen with Azure/azure-rest-api-specs#29273

4d275d2

weidongxu-microsoft mentioned this pull request May 30, 2024

follow-up on azure-health-insights-radiologyinsights Azure/azure-sdk-for-java#40404

Closed

6 tasks

Merge branch 'main' into tsp_java-radiologyinsights

66111cd

catalinaperalta approved these changes May 30, 2024

View reviewed changes

catalinaperalta marked this pull request as ready for review May 30, 2024 18:05

catalinaperalta merged commit 9582151 into Azure:main May 30, 2024
29 of 32 checks passed

weidongxu-microsoft deleted the tsp_java-radiologyinsights branch May 30, 2024 23:12

Francisco-Gamino pushed a commit to Francisco-Gamino/azure-rest-api-specs that referenced this pull request Jun 5, 2024

radiologyinsights, tsp-config, java on final-type of LRO (Azure#29273)

e1d2819

Co-authored-by: catalinaperalta <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

radiologyinsights, tspconfig, java on final-type of LRO #29273

radiologyinsights, tspconfig, java on final-type of LRO #29273

weidongxu-microsoft commented May 30, 2024 •

edited

Loading

openapi-pipeline-app bot commented May 30, 2024 •

edited

Loading

openapi-pipeline-app bot commented May 30, 2024 •

edited

Loading

openapi-pipeline-app bot commented May 30, 2024 •

edited

Loading

openapi-pipeline-app bot commented May 30, 2024 •

edited

Loading

weidongxu-microsoft commented May 30, 2024

azure-pipelines bot commented May 30, 2024

catalinaperalta commented May 30, 2024

catalinaperalta commented May 30, 2024

azure-pipelines bot commented May 30, 2024

radiologyinsights, tspconfig, java on final-type of LRO #29273

radiologyinsights, tspconfig, java on final-type of LRO #29273

Conversation

weidongxu-microsoft commented May 30, 2024 • edited Loading

Data Plane API Specification Update Pull Request

PR review workflow diagram

API Info: The Basics

Change Scope

Viewing API changes

Suppressing failures

❔Got questions? Need additional info?? We are here to help!

Tooling

Guidelines & Specifications

Helpful Links

Getting help

openapi-pipeline-app bot commented May 30, 2024 • edited Loading

Next Steps to Merge

openapi-pipeline-app bot commented May 30, 2024 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented May 30, 2024 • edited Loading

Swagger Generation Artifacts

openapi-pipeline-app bot commented May 30, 2024 • edited Loading

Generated ApiView

weidongxu-microsoft commented May 30, 2024

azure-pipelines bot commented May 30, 2024

catalinaperalta commented May 30, 2024

catalinaperalta commented May 30, 2024

azure-pipelines bot commented May 30, 2024

weidongxu-microsoft commented May 30, 2024 •

edited

Loading

openapi-pipeline-app bot commented May 30, 2024 •

edited

Loading

openapi-pipeline-app bot commented May 30, 2024 •

edited

Loading

openapi-pipeline-app bot commented May 30, 2024 •

edited

Loading

openapi-pipeline-app bot commented May 30, 2024 •

edited

Loading