Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SnapToRoads/RouteRange/RouteMatrix 2024-07-01-preview #29919

Merged

Conversation

koyasu221b
Copy link
Member

@koyasu221b koyasu221b commented Jul 19, 2024

Data Plane API - Pull Request

  • Fix RouteRange and RouteMatrix Bug bash related issues and update descriptions.
  • Add RouteMatrix from 2024-06-01-preview to 2024-07-01-preview and remove coordinate from response
  • Remove asyncBatch APIs

API Info: The Basics

Most of the information about your service should be captured in the issue that serves as your API Spec engagement record.

  • Link to API Spec engagement record issue:

Is this review for (select one):

  • a private preview
  • a public preview
  • GA release

Change Scope

This section will help us focus on the specific parts of your API that are new or have been modified.
Please share a link to the design document for the new APIs, a link to the previous API Spec document (if applicable), and the root paths that have been updated.

  • Design Document:
  • Previous API Spec Doc:
  • Updated paths:

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.

❔Got questions? Need additional info?? We are here to help!

Contact us!

The Azure API Review Board is dedicated to helping you create amazing APIs. You can read about our mission and learn more about our process on our wiki.

Click here for links to tools, specs, guidelines & other good stuff

Tooling

Guidelines & Specifications

Helpful Links

Checks stuck in `queued` state? If the PR CI checks appear to be stuck in `queued` state, please add a comment with contents `/azp run`. This should result in a new comment denoting a `PR validation pipeline` has started and the checks should be updated after few minutes.

Copy link

openapi-pipeline-app bot commented Jul 19, 2024

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

Copy link

openapi-pipeline-app bot commented Jul 19, 2024

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]
 Please click here to preview with your @microsoft account. 
Posted by Swagger Pipeline | How to fix these errors?

Copy link

openapi-pipeline-app bot commented Jul 19, 2024

Generated ApiView

Language Package Name ApiView Link
Swagger Route https://apiview.dev/Assemblies/Review/46fc96bf83a8468da2623389b47566b4?revisionId=378f3ff301c443f294d032250075932d

@koyasu221b koyasu221b marked this pull request as ready for review July 19, 2024 05:34
@koyasu221b koyasu221b requested a review from a team as a code owner July 19, 2024 05:34
@koyasu221b koyasu221b requested review from JeffreyRichter, marclerwick, FarazGIS and mikekistler and removed request for a team July 19, 2024 05:34
Copy link
Member

@mikekistler mikekistler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found a couple small problems. Pls fix and then tag me to re-review.

Copy link
Member

@mikekistler mikekistler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@koyasu221b koyasu221b added the DoNotMerge <valid label in PR review process> use to hold merge after approval label Jul 23, 2024
@koyasu221b koyasu221b changed the title SnapToRoads and RouteRange 2024-07-01-preview SnapToRoads/RouteRange/RouteMatrix 2024-07-01-preview Aug 2, 2024
@AzureRestAPISpecReview AzureRestAPISpecReview added TypeSpec Authored with TypeSpec and removed TypeSpec Authored with TypeSpec labels Aug 12, 2024
@koyasu221b koyasu221b force-pushed the users/huangwill/koyasu221b-maps-Route-2024-07-01-preview branch 2 times, most recently from cbe9a94 to 1660766 Compare September 6, 2024 06:03
@koyasu221b koyasu221b force-pushed the users/huangwill/koyasu221b-maps-Route-2024-07-01-preview branch from 0298703 to 0acf91c Compare October 7, 2024 07:07
@microsoft-github-policy-service microsoft-github-policy-service bot added the no-recent-activity There has been no recent activity on this issue. label Oct 28, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot removed the no-recent-activity There has been no recent activity on this issue. label Oct 29, 2024
@koyasu221b koyasu221b removed the DoNotMerge <valid label in PR review process> use to hold merge after approval label Oct 29, 2024
@koyasu221b koyasu221b added PublishToCustomers Acknowledgement the changes will be published to Azure customers. APIStewardshipBoard-SignedOff The Azure API Stewardship team has reviewed and approved the changes. labels Oct 29, 2024
@jhendrixMSFT jhendrixMSFT merged commit 20b3f44 into main Oct 30, 2024
28 of 30 checks passed
@jhendrixMSFT jhendrixMSFT deleted the users/huangwill/koyasu221b-maps-Route-2024-07-01-preview branch October 30, 2024 13:07
haagha pushed a commit that referenced this pull request Nov 19, 2024
* first commit

* update to 2024-07-01-preview

* add type string

* Add RouteMatrix

* Remove axleCount for RouteMatrix

* Remove axleCount for RouteMatrix

* Remove axleCount for RouteMatrix

* update departAt/arriveAt

* Add statusCode

* Change success to Completed

* Apply limitation table for sync

* Apply limitation table for async

* Remove async route matrix request in async doc

* update examples

* Update description

* fix

* update departAt

* fix departAt

* Update example

* isInterpolated

* Update geometry

* fix spell

* Add GeoJsonGeometry

* Add GeoJsonObject

* update

* Add 404 example

* Update Resource not found

* Simplify example

* Added TypeSpecRequirement suppression for Route

---------

Co-authored-by: Will Huang <[email protected]>
digvijaymali94 pushed a commit to digvijaymali94/azure-rest-api-specs that referenced this pull request Dec 17, 2024
* first commit

* update to 2024-07-01-preview

* add type string

* Add RouteMatrix

* Remove axleCount for RouteMatrix

* Remove axleCount for RouteMatrix

* Remove axleCount for RouteMatrix

* update departAt/arriveAt

* Add statusCode

* Change success to Completed

* Apply limitation table for sync

* Apply limitation table for async

* Remove async route matrix request in async doc

* update examples

* Update description

* fix

* update departAt

* fix departAt

* Update example

* isInterpolated

* Update geometry

* fix spell

* Add GeoJsonGeometry

* Add GeoJsonObject

* update

* Add 404 example

* Update Resource not found

* Simplify example

* Added TypeSpecRequirement suppression for Route

---------

Co-authored-by: Will Huang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APIStewardshipBoard-SignedOff The Azure API Stewardship team has reviewed and approved the changes. data-plane Maps new-api-version PublishToCustomers Acknowledgement the changes will be published to Azure customers.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants