Set new baseline for cspell #32171
Merged
Set new baseline for cspell #32171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR validation pipeline restarted successfully. This comment will be populated with next steps to merge this PR once validation is completed. Please wait ⌛. |
|
PR validation pipeline restarted successfully. If there is ApiView generated, it will be updated in this comment. |
mikeharder
reviewed
Jan 15, 2025
mikeharder
reviewed
Jan 15, 2025
mikeharder
approved these changes
Jan 15, 2025
weshaggard
reviewed
Jan 15, 2025
weshaggard
reviewed
Jan 15, 2025
weshaggard
reviewed
Jan 15, 2025
weshaggard
reviewed
Jan 15, 2025
weshaggard
reviewed
Jan 15, 2025
weshaggard
approved these changes
Jan 15, 2025
weshaggard
reviewed
Jan 15, 2025
danieljurek
force-pushed
the
djurek/cspell-baseline-2
branch
from
5ca869f to
ab31fb4
Compare
danieljurek
requested review from
benbp,
raych1,
maririos,
dazilb,
tshoham,
omerhaimov,
bermanraz,
Einav94,
naveedaz,
wanyang7,
atpham256 and
ankushbindlish2
as code owners
danieljurek
requested review from
davidzhaoyue,
pjohari-ms,
palma21,
matthchr,
kjeur,
Sandido,
dkulkarni-ms,
haagha,
MS-syh2qs,
grizzlytheodore,
mabhard,
yangyuan,
rrahulms,
ChenglongLiu,
wilcobmsft,
wiboris,
dpwatrous,
skapur12,
cRui861,
wanghoppe,
stankovski,
jijohn14,
Juliehzl and
solankisamir
as code owners
3 tasks
This was referenced Jan 16, 2025
ZhidaLiu
pushed a commit
to ZhidaLiu/azure-rest-api-specs
that referenced
this pull request
Jan 22, 2025
* Set cspell baseilne * Update documentation/cspell.yaml to remove compound words * pwsh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed
cSpell.jsonto service-specificcspell.yamlfilescspell.yamlfilescspell.yamlwordsarraycspell.yamland a legacycspell.jsonfile points to thecspell.yaml. The legacycspell.jsonfile is required because of howcheck-spelling-in-changed-files.ps1generates the file list for spell checkingcspell.yamlfor checking spelling in the documentation folder) see preview hereTests
SpellCheck
No spelling errors (success): https://github.com/Azure/azure-rest-api-specs/actions/runs/12796679864/job/35676868333?pr=32171
With spelling errors (expected fail): https://github.com/danieljurek/azure-rest-api-specs/actions/runs/12797877686/job/35680746239?pr=6
Warning:
check-spelling-in-changed-files.ps1includes the first link (https://aka.ms/azsdk/engsys/spellcheck)... I have a PR out to add a Note section to the page to redirect folks to REST API specs. We can harmonize how the advice is documented or called out in CI later.SpellCheck - All
No spelling errors (success): https://github.com/danieljurek/azure-rest-api-specs/actions/runs/12798095199/job/35681400703
With spelling errors (expected fail): https://github.com/danieljurek/azure-rest-api-specs/actions/runs/12797885971