Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add execution name to execution start api #32644

Open
wants to merge 5 commits into
base: release-app-Microsoft.App-preview/2025-02-02-Preview
Choose a base branch
from

Conversation

brusniak
Copy link
Member

Choose a PR Template

Switch to "Preview" on this description then select one of the choices below.

Click here to open a PR for a Data Plane API.

Click here to open a PR for a Control Plane (ARM) API.

Click here to open a PR for only SDK configuration.

Copy link

PR validation pipeline started successfully. This comment will be populated with next steps to merge this PR once validation is completed. Please wait ⌛.

Copy link

PR validation pipeline started successfully. If there is ApiView generated, it will be updated in this comment.

@brusniak brusniak marked this pull request as ready for review February 14, 2025 19:14
Copy link

openapi-pipeline-app bot commented Feb 14, 2025

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ This PR is in purview of the ARM review (label: ARMReview). This PR must get ARMSignedOff label from an ARM reviewer.
    This PR has ARMChangesRequested label. Please address or respond to feedback from the ARM API reviewer.
    When you are ready to continue the ARM API review, please remove the ARMChangesRequested label.
    Automation should then add WaitForARMFeedback label.
    ❗If you don't have permissions to remove the label, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories.
    For details of the ARM review, see aka.ms/azsdk/pr-arm-review

@@ -1356,6 +1356,10 @@
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

executionName

please add examples on how where is this used

@ramoka178
Copy link
Contributor

Choose a PR Template

Switch to "Preview" on this description then select one of the choices below.

Click here to open a PR for a Data Plane API.

Click here to open a PR for a Control Plane (ARM) API.

Click here to open a PR for only SDK configuration.

Please fill in this too.

@ramoka178 ramoka178 added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Feb 14, 2025
@openapi-pipeline-app openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Feb 14, 2025
@jianingwang123
Copy link

The error 'Error: [Exception] No input files provided' might be due to a mismatch between the tags 'package-preview-2025-02-02' and 'package-preview-2025-02-02-preview' in the readme.md. The related issue can be found here: #31973. The workaround is to manually edit the tags.

@jianingwang123
Copy link

Hi @brusniak,
According to https://github.com/Azure/azure-rest-api-specs/actions/runs/13337486230/job/37255786982?pr=32644#step:4:72, your tspconfig.yaml is incorrectly configured. Kindly update your tspconfig.yaml as per the details provided below.
Please let us know if you need any further assistance.

 - The value of options.@azure-tools/typespec-java.package-dir "microsoft-app-dynamicsessions" does not match "/^azure(-\w+)+$/". Please update the value of "options.@azure-tools/typespec-java.package-dir" to match "/^azure(-\w+)+$/".
 - The value of options.@azure-tools/typespec-csharp.package-dir "Microsoft.App.DynamicSessions" does not match "/^Azure\./". Please update the value of "options.@azure-tools/typespec-csharp.package-dir" to match "/^Azure\./".

@github-actions github-actions bot added the brownfield Brownfield services will soon be required to convert to TypeSpec. See https://aka.ms/azsdk/typespec. label Feb 27, 2025
@brusniak
Copy link
Member Author

@microsoft-github-policy-service agree company="Microsoft"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review ARMReview BreakingChange-JavaScript-Sdk BreakingChange-Python-Sdk brownfield Brownfield services will soon be required to convert to TypeSpec. See https://aka.ms/azsdk/typespec. resource-manager TypeSpec Authored with TypeSpec
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants