Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publicipprefixaugust #3572

Closed
wants to merge 22 commits into from

Conversation

anilingle-ms
Copy link

@anilingle-ms anilingle-ms commented Aug 2, 2018

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

MikhailTryakhov and others added 22 commits July 26, 2018 11:00
* Created folder for 2018-07-01 api version

* fixed incorrect encoding symbol
Lint diff was failing on PRs with a base branch other than master. We
needed to fetch the base branch ref from the origin before trying to
resolve it to its commit hash.
@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI
Copy link

AutorestCI commented Aug 2, 2018

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@AutorestCI
Copy link

AutorestCI commented Aug 2, 2018

Automation for azure-sdk-for-python

A PR has been created for you:
Azure/azure-sdk-for-python#3071

@AutorestCI
Copy link

AutorestCI commented Aug 2, 2018

Automation for azure-sdk-for-node

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-node#3252

@AutorestCI
Copy link

AutorestCI commented Aug 2, 2018

Automation for azure-sdk-for-java

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-java#2135

@AutorestCI
Copy link

AutorestCI commented Aug 2, 2018

Automation for azure-sdk-for-go

A PR has been created for you:
Azure/azure-sdk-for-go#2387

mccleanp pushed a commit that referenced this pull request Mar 23, 2022
* added new endpoint for validation resourcetype

* added example file

* Fix model validation

* Fix Model validations

* removed  firstname and lastname required attributes

* update the name of api

* update cspell to fix swagger spell check
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants