-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating PUT operation requirements for SourceControls and SourceControlSyncJobs, updating streams’ value property, and updating examples. #3580
Changes from 4 commits
2f79128
9b116f2
0393994
ea69aa8
2afd6df
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -352,7 +352,8 @@ | |
}, | ||
"securityToken": { | ||
"type": "string", | ||
"description": "Gets or sets the authorization token for the repo of the source control." | ||
"description": "Gets or sets the authorization token for the repo of the source control.", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please avoid terminology like "Gets or sets" as this isn't idiomatic for all generated SDK languages. Just stick with the description: There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thank you for the suggestion. Fixed. |
||
"$ref": "#/definitions/SourceControlSecurityTokenProperties" | ||
}, | ||
"description": { | ||
"type": "string", | ||
|
@@ -493,8 +494,8 @@ | |
}, | ||
"securityToken": { | ||
"type": "string", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Now that this is a complex object - please remove the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I missed that, thanks. Fixed. |
||
"maxLength": 1024, | ||
"description": "Gets or sets the authorization token for the repo of the source control." | ||
"description": "Gets or sets the authorization token for the repo of the source control.", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please avoid terminology like "Gets or sets" as this isn't idiomatic for all generated SDK languages. Just stick with the description. This also applies to the other descriptions below. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fixed. |
||
"$ref": "#/definitions/SourceControlSecurityTokenProperties" | ||
}, | ||
"description": { | ||
"type": "string", | ||
|
@@ -503,6 +504,32 @@ | |
} | ||
}, | ||
"description": "The properties of the create source control operation." | ||
}, | ||
"SourceControlSecurityTokenProperties": { | ||
"properties":{ | ||
"accessToken":{ | ||
"type":"string", | ||
"maxLength":1024, | ||
"description":"Gets or sets the access token." | ||
}, | ||
"refreshToken":{ | ||
"type":"string", | ||
"maxLength":1024, | ||
"description":"Gets or sets the refresh token." | ||
}, | ||
"tokenType":{ | ||
"type": "string", | ||
"description": "The token type. Must be either PersonalAccessToken or Oauth.", | ||
"enum": [ | ||
"PersonalAccessToken", | ||
"Oauth" | ||
], | ||
"x-ms-enum": { | ||
"name": "tokenType", | ||
"modelAsString": true | ||
} | ||
} | ||
} | ||
} | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that this is a complex object - please remove the
"type":"string
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.