Microsot.Network/virtualnetworkgateways Reset VPN Client Shared Key #3649

henry416 · 2018-08-15T18:58:18Z

Added a reset VPN Client shared key operation (POST) on virtual network gateway resource.

PR information

The title of the PR is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
If applicable, the PR references the bug/issue that it fixes.
Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

I have read the contribution guidelines.
My spec meets the review criteria:
- The spec conforms to the Swagger 2.0 specification.
- The spec follows the guidelines described in the Swagger checklist document.
- Validation tools were run on swagger spec(s) and have all been fixed in this PR.

AutorestCI · 2018-08-15T19:04:30Z

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

AutorestCI · 2018-08-15T19:07:31Z

Automation for azure-sdk-for-python

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-python#3246

AutorestCI · 2018-08-15T19:14:50Z

Automation for azure-sdk-for-java

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-java#2135

azuresdkci · 2018-08-15T19:16:20Z

Can one of the admins verify this patch?

AutorestCI · 2018-08-15T19:32:07Z

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#3505

AutorestCI · 2018-08-15T19:40:01Z

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#2620

henry416 · 2018-08-16T22:58:09Z

@sergey-shandar Can you please review this PR?

sergey-shandar · 2018-08-17T18:48:58Z

...tion/network/resource-manager/Microsoft.Network/stable/2018-06-01/virtualNetworkGateway.json

@@ -362,6 +362,49 @@
        "x-ms-long-running-operation": true
      }
    },
+    "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/virtualNetworkGateways/{virtualNetworkGatewayName}/resetvpnclientsharedkey": {


Do we have this operations in other API versions as well? 2018-07-01?

This is from 2018-06-01 onwards

@henry416 in this case you might need to port the changes to 2018-07-01 as well. Also 2018-08-01 (working branch for that version is Network-September-Release)

@number213 If that is the case, I will open another PR for the 2018-08-01 version instead

henry416 · 2018-08-20T17:36:50Z

@sergey-shandar Are there any other pending items? Can we merge?

sergey-shandar · 2018-08-20T18:29:03Z

...tion/network/resource-manager/Microsoft.Network/stable/2018-06-01/virtualNetworkGateway.json

+        "tags": [
+          "VirtualNetworkGateways"
+        ],
+        "operationId": "VirtualNetworkGateways_Resetvpnclientsharedkey",


Could we have a better name? For example VirtualNetworkGateways_ResetVpnClientSharedKey

@sergey-shandar Done as requested

sergey-shandar · 2018-08-21T19:34:24Z

@henry416 we still need ARM (@ravbhatnagar) and codeowner (@MikhailTryakhov) approvals to merge.

henry416 · 2018-08-23T22:45:04Z

@ravbhatnagar and @MikhailTryakhov Can you please review this PR?

ravbhatnagar · 2018-08-28T00:05:50Z

looks good. signing off from ARM

henry416 · 2018-08-29T18:22:22Z

@MikhailTryakhov Can you please take a look and sign off?

anton-evseev · 2018-08-30T07:29:43Z

@henry416 Mikhail is on vacation, please contact NRP Swagger Admins <[email protected]>

henry416 · 2018-09-04T18:01:21Z

@sergey-shandar @ravbhatnagar @number213 , as suggested, retargeted this PR for outgoing 2018 version, could you please sign off on that one? #3800

Reset VPN Client shared key

be44f71

henry416 requested a review from MikhailTryakhov as a code owner August 15, 2018 18:58

azuresdkci assigned sergey-shandar Aug 15, 2018

azuresdkci requested a review from sergey-shandar August 15, 2018 19:19

typo

fb70fd5

sergey-shandar approved these changes Aug 17, 2018

View reviewed changes

sergey-shandar added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Aug 17, 2018

sergey-shandar reviewed Aug 17, 2018

View reviewed changes

sergey-shandar approved these changes Aug 20, 2018

View reviewed changes

sergey-shandar reviewed Aug 20, 2018

View reviewed changes

CR rename

aafca9c

ravbhatnagar added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Aug 28, 2018

henry416 mentioned this pull request Sep 4, 2018

Microsot.Network/virtualnetworkgateways Reset VPN Client Shared Key #3800

Merged

10 tasks

sergey-shandar merged commit f092b14 into Azure:master Sep 5, 2018

AutorestCI mentioned this pull request Sep 5, 2018

[AutoPR network/resource-manager] Microsot.Network/virtualnetworkgateways Reset VPN Client Shared Key Azure/azure-sdk-for-python#3273

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Microsot.Network/virtualnetworkgateways Reset VPN Client Shared Key #3649

Microsot.Network/virtualnetworkgateways Reset VPN Client Shared Key #3649

henry416 commented Aug 15, 2018 •

edited

Loading

AutorestCI commented Aug 15, 2018 •

edited

Loading

AutorestCI commented Aug 15, 2018 •

edited

Loading

AutorestCI commented Aug 15, 2018 •

edited

Loading

azuresdkci commented Aug 15, 2018

AutorestCI commented Aug 15, 2018 •

edited

Loading

AutorestCI commented Aug 15, 2018 •

edited

Loading

henry416 commented Aug 16, 2018

sergey-shandar Aug 17, 2018

henry416 Aug 17, 2018 •

edited

Loading

anton-evseev Aug 30, 2018

henry416 Aug 30, 2018

henry416 commented Aug 20, 2018

sergey-shandar Aug 20, 2018

henry416 Aug 20, 2018

sergey-shandar commented Aug 21, 2018 •

edited

Loading

henry416 commented Aug 23, 2018

ravbhatnagar commented Aug 28, 2018

henry416 commented Aug 29, 2018

anton-evseev commented Aug 30, 2018

henry416 commented Sep 4, 2018

Microsot.Network/virtualnetworkgateways Reset VPN Client Shared Key #3649

Microsot.Network/virtualnetworkgateways Reset VPN Client Shared Key #3649

Conversation

henry416 commented Aug 15, 2018 • edited Loading

PR information

Quality of Swagger

AutorestCI commented Aug 15, 2018 • edited Loading

Automation for azure-sdk-for-ruby

AutorestCI commented Aug 15, 2018 • edited Loading

Automation for azure-sdk-for-python

AutorestCI commented Aug 15, 2018 • edited Loading

Automation for azure-sdk-for-java

azuresdkci commented Aug 15, 2018

AutorestCI commented Aug 15, 2018 • edited Loading

Automation for azure-sdk-for-node

AutorestCI commented Aug 15, 2018 • edited Loading

Automation for azure-sdk-for-go

henry416 commented Aug 16, 2018

sergey-shandar Aug 17, 2018

Choose a reason for hiding this comment

henry416 Aug 17, 2018 • edited Loading

Choose a reason for hiding this comment

anton-evseev Aug 30, 2018

Choose a reason for hiding this comment

henry416 Aug 30, 2018

Choose a reason for hiding this comment

henry416 commented Aug 20, 2018

sergey-shandar Aug 20, 2018

Choose a reason for hiding this comment

henry416 Aug 20, 2018

Choose a reason for hiding this comment

sergey-shandar commented Aug 21, 2018 • edited Loading

henry416 commented Aug 23, 2018

ravbhatnagar commented Aug 28, 2018

henry416 commented Aug 29, 2018

anton-evseev commented Aug 30, 2018

henry416 commented Sep 4, 2018

henry416 commented Aug 15, 2018 •

edited

Loading

AutorestCI commented Aug 15, 2018 •

edited

Loading

AutorestCI commented Aug 15, 2018 •

edited

Loading

AutorestCI commented Aug 15, 2018 •

edited

Loading

AutorestCI commented Aug 15, 2018 •

edited

Loading

AutorestCI commented Aug 15, 2018 •

edited

Loading

henry416 Aug 17, 2018 •

edited

Loading

sergey-shandar commented Aug 21, 2018 •

edited

Loading