Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New tag for 2018-06 APIs for Automation #3906

Merged
merged 4 commits into from
Sep 14, 2018
Merged

Conversation

khughes66
Copy link

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@AutorestCI
Copy link

AutorestCI commented Sep 13, 2018

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#3125

@AutorestCI
Copy link

AutorestCI commented Sep 13, 2018

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@AutorestCI
Copy link

AutorestCI commented Sep 13, 2018

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI
Copy link

AutorestCI commented Sep 13, 2018

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

@AutorestCI
Copy link

AutorestCI commented Sep 13, 2018

Automation for azure-sdk-for-node

Nothing to generate for azure-sdk-for-node

Copy link
Member

@marstr marstr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding the tag was done correctly, but looking at CI it look like there are some duplicate models that need to be cleaned up before we can proceed.

@marstr marstr merged commit 7bc4150 into Azure:master Sep 14, 2018
mccleanp pushed a commit that referenced this pull request Mar 23, 2022
* Change the class from CloudError to ErrorResponse

* Try to fix js sdk

* Fix package name

* Fixing operation api spec

* Adding readonly for dataaction

* Fix operation api examples

* Revert "Fix operation api examples"

This reverts commit 16aa86c90105a19f81658724ff9dcf2c0a665d29.

* Revert "Adding readonly for dataaction"

This reverts commit 09b736a14aeccee74899967605ea184039f83001.

* Revert "Fixing operation api spec"

This reverts commit 58a1667426beea3ce856e226bc68bbaa1b195dc2.

* Try to fix opreation api spec

* Run prettier

* Fix spelling issue

* Remove readonly on operations apis

* Adding readonly to systemdata

Co-authored-by: Shuo Li <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants