Swagger change for adding status to BootDiagnosticsInstanceView #3983
Conversation
Automation for azure-sdk-for-jsNothing to generate for azure-sdk-for-js |
Automation for azure-sdk-for-pythonThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-rubyThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-nodeThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-javaA PR has been created for you based on this PR content. Once this PR will be merged, content will be added to your service PR: |
Automation for azure-sdk-for-goA PR has been created for you based on this PR content. Once this PR will be merged, content will be added to your service PR: |
|
Can one of the admins verify this patch? |
| }, | ||
| "status": { | ||
| "$ref": "#/definitions/InstanceViewStatus", | ||
| "description": "The boot diagnostics status information for the VM. <br><br> NOTE: It will be set only if there are errors encountered in enabling boot diagnostics." |
There was a problem hiding this comment.
Is this a readonly property ("readOnly": true)? Same comment for this model across all api-versions of compute.
There was a problem hiding this comment.
Also looking at the BootDiagnosticsInstanceView model it seems all properties can be readonly - right?
There was a problem hiding this comment.
Made all properties readOnly
This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information
api-versionin the path should match theapi-versionin the spec).Quality of Swagger