Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove readOnly attribute for ID field of Resource. #4002

Merged
merged 1 commit into from
Sep 25, 2018
Merged

Remove readOnly attribute for ID field of Resource. #4002

merged 1 commit into from
Sep 25, 2018

Conversation

ttlcgl
Copy link
Contributor

@ttlcgl ttlcgl commented Sep 25, 2018 •
edited
Loading

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@AutorestCI
Copy link

AutorestCI commented Sep 25, 2018 •
edited
Loading

Automation for azure-sdk-for-js

Nothing to generate for azure-sdk-for-js

@ttlcgl
Copy link
Contributor Author

ttlcgl commented Sep 25, 2018

This addresses the issue here: Azure/azure-powershell#7329

@AutorestCI AutorestCI mentioned this pull request Sep 25, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Sep 25, 2018 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#2899

@AutorestCI
Copy link

AutorestCI commented Sep 25, 2018 •
edited
Loading

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

@AutorestCI
Copy link

AutorestCI commented Sep 25, 2018 •
edited
Loading

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#3693

This was referenced Sep 25, 2018
Merged
Merged
@AutorestCI
Copy link

AutorestCI commented Sep 25, 2018 •
edited
Loading

Automation for azure-sdk-for-ruby

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-ruby#1581

@AutorestCI
Copy link

AutorestCI commented Sep 25, 2018 •
edited
Loading

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@dsgouda
Copy link
Contributor

dsgouda commented Sep 25, 2018

@MikhailTryakhov PTAL, I guess this needs to cascade into all subsequent API versions

dsgouda
dsgouda suggested changes Sep 25, 2018
View reviewed changes
Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsgouda
Copy link
Contributor

dsgouda commented Sep 25, 2018

Will merge once CIs are done

@lmazuel lmazuel merged commit 5999297 into Azure:master Sep 25, 2018
mccleanp pushed a commit that referenced this pull request Mar 23, 2022
@marjanmr
adding stable api version to hybridnetwork (#4002)
8de163e 
* adding base

* Update API version and fix the validation errors

* change readme file

* fix recent errors about typeobject

* fix readme go md file

* fix readme go md file

* fix readme go md file to remove preview
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsgouda dsgouda dsgouda approved these changes

@sergey-shandar sergey-shandar Awaiting requested review from sergey-shandar

Assignees

@sergey-shandar sergey-shandar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ttlcgl @AutorestCI @azuresdkci @dsgouda @sergey-shandar @lmazuel