Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update swagger documetation to mark Collation property as writable. #4314

Merged
merged 4 commits into from
Nov 8, 2018
Merged

Update swagger documetation to mark Collation property as writable. #4314

merged 4 commits into from
Nov 8, 2018

Conversation

NMijat1024
Copy link
Contributor

@NMijat1024 NMijat1024 commented Oct 24, 2018 •
edited
Loading

Change Managed Instance collation property from read only to read and create.
Add collation to properties section in ManagedInstanceCreateMax example.

VSTS task: 12336257

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

Update swagger documetation to mark Collation property as writable.
8a98e37 
Change Managed Instance collation property from read only to read and create.
Add collation to properties section in ManagedInstanceCreateMax example.

VSTS task: 12336257
@msftclas
Copy link

msftclas commented Oct 24, 2018 •
edited
Loading

CLA assistant check
All CLA requirements met.

@azuresdkci azuresdkci requested a review from marstr October 24, 2018 16:29
@AutorestCI AutorestCI mentioned this pull request Oct 24, 2018
Closed
@AutorestCI
Copy link

AutorestCI commented Oct 24, 2018 •
edited
Loading

Automation for azure-sdk-for-ruby

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-ruby#1871

@AutorestCI AutorestCI mentioned this pull request Oct 24, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Oct 24, 2018 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#3680

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI AutorestCI mentioned this pull request Oct 24, 2018
Closed
@AutorestCI
Copy link

AutorestCI commented Oct 24, 2018 •
edited
Loading

Automation for azure-sdk-for-js

A PR has been created for you:
Azure/azure-sdk-for-js#450

@AutorestCI AutorestCI mentioned this pull request Oct 24, 2018
Closed
@AutorestCI
Copy link

AutorestCI commented Oct 24, 2018 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#3255

@NMijat1024
Copy link
Contributor Author

@storak

@AutorestCI AutorestCI mentioned this pull request Oct 24, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Oct 24, 2018 •
edited
Loading

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#4057

marstr
marstr requested changes Oct 30, 2018
View reviewed changes
Copy link
Member

@marstr marstr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delayed review!

@NMijat1024 NMijat1024 changed the title Update swagger documetation to mark Collation property as writable. Update swagger documetation to mark Collation property as writable. [DO NOT MERGE] Oct 31, 2018
@AutorestCI
Copy link

AutorestCI commented Nov 5, 2018 •
edited
Loading

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

This was referenced Nov 5, 2018
Closed
Merged
@NMijat1024 NMijat1024 changed the title Update swagger documetation to mark Collation property as writable. [DO NOT MERGE] Update swagger documetation to mark Collation property as writable. Nov 5, 2018
@AutorestCI AutorestCI mentioned this pull request Nov 6, 2018
Closed
@marstr marstr added the Reassign label Nov 6, 2018
@marstr marstr removed their assignment Nov 6, 2018
@marstr
Copy link
Member

marstr commented Nov 6, 2018

I've been re-orged out of the Swagger review pool so I'm having this PR reassigned.

@azuresdkci azuresdkci requested a review from jianghaolu November 6, 2018 18:05
@lmazuel
Copy link
Member

lmazuel commented Nov 8, 2018

Merging, since @jianghaolu and @jaredmoo approved, but I think it's blocked by @marstr because he requested changes that are not needed anymore.

@lmazuel lmazuel merged commit 0307edd into Azure:master Nov 8, 2018
@AutorestCI AutorestCI mentioned this pull request Nov 8, 2018
Closed
@NMijat1024 NMijat1024 mentioned this pull request Nov 9, 2018
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marstr marstr marstr requested changes

@jianghaolu jianghaolu jianghaolu approved these changes

@jaredmoo jaredmoo jaredmoo approved these changes

Assignees

@jianghaolu jianghaolu

Labels
Reassign
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@NMijat1024 @msftclas @AutorestCI @azuresdkci @marstr @lmazuel @jianghaolu @jaredmoo