Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

graphrbac - updating folder structure to be more consistent #4776

Merged
merged 3 commits into from
Dec 5, 2018
Merged

graphrbac - updating folder structure to be more consistent #4776

merged 3 commits into from
Dec 5, 2018

Conversation

veronicagg
Copy link
Contributor

Adding a folder to graphrbac to be more consistent with the rest of the repo, this helps supporting the service in OpenAPIHub - https://portal.azure-devex-tools.com/app/branch/veronicagg/azure-rest-api-specs/graphrbac-fix-folder

@openapi-portal-comment
Copy link

If you're a MSFT employee, click this link
to view this PR's validation status on our new OpenAPI Hub spec management tool.

@AutorestCI AutorestCI mentioned this pull request Dec 5, 2018
Closed
@AutorestCI
Copy link

AutorestCI commented Dec 5, 2018 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#3971

@AutorestCI AutorestCI mentioned this pull request Dec 5, 2018
Closed
@AutorestCI
Copy link

AutorestCI commented Dec 5, 2018 •
edited
Loading

Automation for azure-sdk-for-js

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-js#589

@AutorestCI AutorestCI mentioned this pull request Dec 5, 2018
Closed
@AutorestCI
Copy link

AutorestCI commented Dec 5, 2018 •
edited
Loading

Automation for azure-sdk-for-ruby

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-ruby#1958

@AutorestCI
Copy link

AutorestCI commented Dec 5, 2018 •
edited
Loading

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

@AutorestCI AutorestCI mentioned this pull request Dec 5, 2018
Closed
@AutorestCI
Copy link

AutorestCI commented Dec 5, 2018 •
edited
Loading

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#4202

@AutorestCI AutorestCI mentioned this pull request Dec 5, 2018
Closed
@AutorestCI
Copy link

AutorestCI commented Dec 5, 2018 •
edited
Loading

Automation for azure-sdk-for-java

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-java#2338

@veronicagg veronicagg changed the title updating folder structure to be more consistent graphrbac - updating folder structure to be more consistent Dec 5, 2018
@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@azuresdkci azuresdkci requested a review from praries880 December 5, 2018 01:33
@nschonni
Copy link
Contributor

nschonni commented Dec 5, 2018

Should it be Microsoft.GraphRbac instead of the plain GraphRbac?

@veronicagg
Copy link
Contributor Author

@nschonni good question, since this is not the name of the resource provider, I thought of adding a folder that's just a plain name to make that more obvious.
@salameer @billytrend thoughts?

This was referenced Dec 5, 2018
Merged
Merged
Merged
@veronicagg
Copy link
Contributor Author

ok, decided to update it, thanks!

This was referenced Dec 5, 2018
Merged
Merged
@nschonni
Copy link
Contributor

nschonni commented Dec 5, 2018

Just to be even more confusing 😉 the C# has Graph.RBAC, so maybe even Microsoft.Graph.Rbac

@veronicagg
Copy link
Contributor Author

@nschonni thanks, but I'd prefer to leave it as is :)

@praries880 praries880 merged commit 478a692 into Azure:master Dec 5, 2018
TalluriAnusha pushed a commit to AsrOneSdk/azure-rest-api-specs that referenced this pull request Feb 6, 2019
@veronicagg @AnuTalluri
graphrbac - updating folder structure to be more consistent (Azure#4776)
d2e1a0e 
* updating folder structure to be more consistent with the rest of the services

* updating file due to not desired automatic formatting

* updating to Microsoft.GraphRbac
mccleanp pushed a commit that referenced this pull request Mar 23, 2022
@angogada
Create a new version for Microsoft.ObjectStore swagger (#4776)
1bf7720 
* Remove 202 response from Microsoft.ObjectStore swagger

* Add new API Version 2021-09-01-preview

Add new API Version 2021-09-01-preview

* Update the new version in the swagger spec and examples

* Update ListByResourceGroup.json

* Addressed ARM feedback

* Update objectstore.json

* Update objectstore.json

* Add required properties to Operation

* Minor Fix for example json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@praries880 praries880 praries880 approved these changes

@salameer salameer Awaiting requested review from salameer

@billytrend billytrend Awaiting requested review from billytrend

Assignees

@praries880 praries880

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@veronicagg @AutorestCI @azuresdkci @nschonni @praries880