Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enum updates to support Hourly reports #4827

Merged
merged 24 commits into from
Jan 18, 2019
Merged

Enum updates to support Hourly reports #4827

merged 24 commits into from
Jan 18, 2019

Conversation

shalinved
Copy link
Contributor

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@AutorestCI
Copy link

AutorestCI commented Dec 7, 2018

Automation for azure-sdk-for-js

Nothing to generate for azure-sdk-for-js

@AutorestCI
Copy link

AutorestCI commented Dec 7, 2018

Automation for azure-sdk-for-python

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-python#2924

@AutorestCI
Copy link

AutorestCI commented Dec 7, 2018

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

@AutorestCI
Copy link

AutorestCI commented Dec 7, 2018

Automation for azure-sdk-for-ruby

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-ruby#2160

@AutorestCI
Copy link

AutorestCI commented Dec 7, 2018

Automation for azure-sdk-for-node

Nothing to generate for azure-sdk-for-node

@AutorestCI
Copy link

AutorestCI commented Dec 7, 2018

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#3866

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@azuresdkci azuresdkci requested a review from sarangan12 December 7, 2018 19:32
@nschonni
Copy link
Contributor

nschonni commented Dec 7, 2018

Fixes #4666

@sarangan12
Copy link
Contributor

Since this is introducing a ne version, this needs ARM Approval. Adding appropriate label

@sarangan12 sarangan12 added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Dec 13, 2018
@ravbhatnagar ravbhatnagar added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Dec 17, 2018
@sarangan12 sarangan12 assigned veronicagg and unassigned sarangan12 Dec 17, 2018
@sarangan12 sarangan12 merged commit 17b8154 into Azure:master Jan 18, 2019
TalluriAnusha pushed a commit to AsrOneSdk/azure-rest-api-specs that referenced this pull request Feb 6, 2019
* Consumption specifications for cost insights and reporting operations

* Fixed $ref for ReportConfigDelete

* Silly me!! Fixed bad reference again

* Fixed schema validation issues

* Fixing validation errors around datetime and dynamic respones

* Fixed parameters in examples

* Fixed parameter name in example

* Removed x-ms-odata method for POST op

* Fixed ARM review comments

* Moved reports and usage analysis from microsoft.consumption to microsoft.costmanagament

* Merged with master again

* Updated reports api documentation

* Undo remove of API from stable version

* Enum updates supporing Hourly reports

* Fixing merge issues

* Added Open API documentation for Budgets GTM APIs

* Splitting up budgets changes in another PR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants