Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cogs Face] Align with latest released version of Face API with Snapshot features. #5074

Merged
merged 3 commits into from
Jan 22, 2019

Conversation

lebronJ
Copy link
Contributor

@lebronJ lebronJ commented Jan 22, 2019

(I am one of the main devs working on Face API and Face containers.)

This is to align Face API swaggers with latest published version with Snapshot features. (rollout started on Jan 21st and will last a week)

  • We have locally generated AutoRest SDK and written tests to ensure all functionalities work.
  • This should also generate the documentation for both Azure REST API Reference and Face .NET SDK documentation. Hopefully this can take short time and catch our rollout timeline, thanks!

Note: This PR only adds new API interfaces for Face API, without changing any existing interfaces.

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@lebronJ lebronJ requested a review from yangyuan as a code owner January 22, 2019 08:01
@openapi-portal-comment
Copy link

If you're a MSFT employee, click this link
to view this PR's validation status on our new OpenAPI Hub spec management tool.

@AutorestCI
Copy link

AutorestCI commented Jan 22, 2019

Automation for azure-sdk-for-js

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-js#796

@AutorestCI
Copy link

AutorestCI commented Jan 22, 2019

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#4220

@AutorestCI
Copy link

AutorestCI commented Jan 22, 2019

Automation for azure-sdk-for-ruby

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-ruby#2174

@AutorestCI
Copy link

AutorestCI commented Jan 22, 2019

Automation for azure-sdk-for-java

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-java#2270

@AutorestCI
Copy link

AutorestCI commented Jan 22, 2019

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#4413

@AutorestCI
Copy link

AutorestCI commented Jan 22, 2019

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#3927

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@dsgouda
Copy link
Contributor

dsgouda commented Jan 22, 2019

Working on some high-pri .NET deliverables, reasssigning

TalluriAnusha pushed a commit to AsrOneSdk/azure-rest-api-specs that referenced this pull request Feb 6, 2019
…hot features. (Azure#5074)

* Add newly released Snapshot API interfaces for Face API's swagger.

* Resolve comments.

* Resolve comments.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants